)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"36953944740cb384848c6dc2d34282f52752103b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e6adb824_7d522855","updated":"2025-05-27 21:27:31.000000000","message":"Hi @jlarriba@redhat.com, I\u0027ve added you as a reviewer for this change given your interest on the upstream change. Let me know if you have any feedback or other changes you\u0027d like to incorporate.","commit_id":"5fdeb4c6d3fae66a2f3fe14a0a03f05421ad5584"},{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"c656945bbe9c82e6faa1060582e49bb61a26e4f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c9a877e6_dd79451b","updated":"2025-05-27 21:29:16.000000000","message":"Needs the upstream change merged first.","commit_id":"5fdeb4c6d3fae66a2f3fe14a0a03f05421ad5584"},{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"ec629f4ca878078b6ba5da44d0aa8154a7fa6d10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3139e87b_9fec5177","updated":"2025-05-27 21:24:33.000000000","message":"The spec-less blueprint for the upstream Nova changes have been accepted, and the patches should be merged in the near future.\n\nI have rebased this patch so it can be reviewed and merged.","commit_id":"5fdeb4c6d3fae66a2f3fe14a0a03f05421ad5584"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"62bdd6f675bf16c7165791eca80507fcb4a35225","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3328e234_fb9896b4","updated":"2025-08-25 06:42:43.000000000","message":"Thank you very much for this great contribution!","commit_id":"a5478e927047fbc17dd7d75c3b1b71c0cf77dea5"},{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"111f8d25b750c1b746c0deca33a4580cd09d77ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"12e83f95_711d2ddf","updated":"2025-08-09 08:42:16.000000000","message":"The Nova change has now been merged.","commit_id":"a5478e927047fbc17dd7d75c3b1b71c0cf77dea5"}],"ceilometer/compute/discovery.py":[{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"85a176199c2b01e4ea5ac8617a6ae1fe4980c74f","unresolved":true,"context_lines":[{"line_number":156,"context_line":"            return {"},{"line_number":157,"context_line":"                extra_spec.attrib[\"name\"]: extra_spec.text"},{"line_number":158,"context_line":"                for extra_spec in extra_specs.findall(\"./extraSpec\")}"},{"line_number":159,"context_line":"        # If not found in libvirt metadata, return None to signify"},{"line_number":160,"context_line":"        # \"not fetched\", as we don\u0027t support performing additional"},{"line_number":161,"context_line":"        # API queries just for the extra specs."},{"line_number":162,"context_line":"        return None"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    @cachetools.cachedmethod(operator.attrgetter(\u0027_flavor_id_cache\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7efdc2b7_651819f4","line":161,"range":{"start_line":159,"start_character":0,"end_line":161,"end_character":47},"updated":"2025-08-07 10:56:42.000000000","message":"With hindsight, it would probably be fine to fall back to queries to get extra specs. In practice, if the extra specs are not available in the libvirt metadata, neither would be the flavour ID. We need to fetch the flavour to get the ID anyway, we might as well cache the whole flavour object and get extra specs out of it as well.","commit_id":"388a57d64713033003b5cc8fae9e2c0dc2ccf8de"},{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"6b6aef7d00eebd2ecc80b71755da5a4d9bf6d908","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            return {"},{"line_number":157,"context_line":"                extra_spec.attrib[\"name\"]: extra_spec.text"},{"line_number":158,"context_line":"                for extra_spec in extra_specs.findall(\"./extraSpec\")}"},{"line_number":159,"context_line":"        # If not found in libvirt metadata, return None to signify"},{"line_number":160,"context_line":"        # \"not fetched\", as we don\u0027t support performing additional"},{"line_number":161,"context_line":"        # API queries just for the extra specs."},{"line_number":162,"context_line":"        return None"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    @cachetools.cachedmethod(operator.attrgetter(\u0027_flavor_id_cache\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"e953dd6c_734e62c7","line":161,"range":{"start_line":159,"start_character":0,"end_line":161,"end_character":47},"in_reply_to":"7efdc2b7_651819f4","updated":"2025-08-07 11:13:03.000000000","message":"Actually, I forgot, it\u0027s actually a separate API request to get the extra specs. I don\u0027t think it\u0027s worth it in that case.","commit_id":"388a57d64713033003b5cc8fae9e2c0dc2ccf8de"}]}