)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b0a552ef1a7434d2adaedca739e445b20463c999","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"41da0c60_52e262f4","updated":"2025-06-10 11:54:39.000000000","message":"The code change looks almost good to me but I have a few suggestions.","commit_id":"79d85c6717fc720196d59c6b9f099387cd9bc919"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5f029e7217bc1a14b2a54ba5d2231705f367b207","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"61491d57_953a0e6d","updated":"2025-06-11 13:43:37.000000000","message":"I\u0027ve proposed a potential refactoring as https://review.opendev.org/c/openstack/ceilometer/+/952337 . Let\u0027s merge this now and see if we can also merge that as well.","commit_id":"0e16c1dd91b6affef63e153dfee75d54d775849d"}],"ceilometer/volume/cinder.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b0a552ef1a7434d2adaedca739e445b20463c999","unresolved":true,"context_lines":[{"line_number":31,"context_line":"            metadata[\"instance_id\"] \u003d None"},{"line_number":32,"context_line":"        if getattr(obj, \"pool_name\", None):"},{"line_number":33,"context_line":"            metadata[\"pool_name\"] \u003d getattr(obj, \u0027pool_name\u0027)"},{"line_number":34,"context_line":"        else:"},{"line_number":35,"context_line":"            metadata[\"pool_name\"] \u003d getattr(obj, \"volume_backend_name\", None)"},{"line_number":36,"context_line":"        return metadata"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7ca15164_db1e24df","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":77},"updated":"2025-06-10 11:54:39.000000000","message":"Can we rather not adding pool_name, if that does not exist in cinder ?","commit_id":"79d85c6717fc720196d59c6b9f099387cd9bc919"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"6480b59c454ad27f49ae0bcbf32b92ab9dee6e00","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            metadata[\"instance_id\"] \u003d None"},{"line_number":32,"context_line":"        if getattr(obj, \"pool_name\", None):"},{"line_number":33,"context_line":"            metadata[\"pool_name\"] \u003d getattr(obj, \u0027pool_name\u0027)"},{"line_number":34,"context_line":"        else:"},{"line_number":35,"context_line":"            metadata[\"pool_name\"] \u003d getattr(obj, \"volume_backend_name\", None)"},{"line_number":36,"context_line":"        return metadata"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dbd319bc_2e81c949","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":77},"in_reply_to":"7ca15164_db1e24df","updated":"2025-06-11 07:15:08.000000000","message":"The volume_backend_name seemed like a good alternative, but I guess not adding the pool_name makes more sense than trying to use a different property for this. Done","commit_id":"79d85c6717fc720196d59c6b9f099387cd9bc919"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1502d1e5f71bea403257f9353fbd931204b32876","unresolved":true,"context_lines":[{"line_number":29,"context_line":"            metadata[\"instance_id\"] \u003d obj.attachments[0][\"server_id\"]"},{"line_number":30,"context_line":"        else:"},{"line_number":31,"context_line":"            metadata[\"instance_id\"] \u003d None"},{"line_number":32,"context_line":"        if getattr(obj, \"pool_name\", None):"},{"line_number":33,"context_line":"            metadata[\"pool_name\"] \u003d getattr(obj, \u0027pool_name\u0027)"},{"line_number":34,"context_line":"        else:"},{"line_number":35,"context_line":"            metadata[\"pool_name\"] \u003d None"},{"line_number":36,"context_line":"        return metadata"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9c823b97_a83dd24a","line":35,"range":{"start_line":32,"start_character":0,"end_line":35,"end_character":40},"updated":"2025-06-11 02:14:30.000000000","message":"You can drop the if-else block and just do\n\n```\n    metadata[\"pool_name\"] \u003d getattr(obj, \u0027pool_name\u0027, None)\n```\n\n\nAlso I noticed that this affects all cinder resources. Is that expected or do you intend to add it only to `VolumeProviderPool*` ?","commit_id":"43898053c81e1c5e9bebd2238d8983894c2e79df"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"6480b59c454ad27f49ae0bcbf32b92ab9dee6e00","unresolved":true,"context_lines":[{"line_number":29,"context_line":"            metadata[\"instance_id\"] \u003d obj.attachments[0][\"server_id\"]"},{"line_number":30,"context_line":"        else:"},{"line_number":31,"context_line":"            metadata[\"instance_id\"] \u003d None"},{"line_number":32,"context_line":"        if getattr(obj, \"pool_name\", None):"},{"line_number":33,"context_line":"            metadata[\"pool_name\"] \u003d getattr(obj, \u0027pool_name\u0027)"},{"line_number":34,"context_line":"        else:"},{"line_number":35,"context_line":"            metadata[\"pool_name\"] \u003d None"},{"line_number":36,"context_line":"        return metadata"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"cd2ccf6b_4416a241","line":35,"range":{"start_line":32,"start_character":0,"end_line":35,"end_character":40},"in_reply_to":"9c823b97_a83dd24a","updated":"2025-06-11 07:15:08.000000000","message":"I was initially trying to follow the rest of the classes and use the extract_metadata method, which made some sense before this patch, but I guess with the changes in this patch it\u0027s just strange to try to use it. I modified the code, now the pool_name is extracted directly in each of the get_samples methods.","commit_id":"43898053c81e1c5e9bebd2238d8983894c2e79df"}],"releasenotes/notes/fix-volume-provider-pool-capacity-metrics-7b8b0de29a513cea.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b0a552ef1a7434d2adaedca739e445b20463c999","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix volume provider pool capacity metrics for ceph backend."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4ce09d0d_e0894e09","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":63},"updated":"2025-06-10 11:54:39.000000000","message":"It\u0027d be probably useful if you can report a bug and put a link for it so that users can understand what the issue was.","commit_id":"79d85c6717fc720196d59c6b9f099387cd9bc919"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"6480b59c454ad27f49ae0bcbf32b92ab9dee6e00","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix volume provider pool capacity metrics for ceph backend."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0a0bfbdc_8f9c795c","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":63},"in_reply_to":"4ce09d0d_e0894e09","updated":"2025-06-11 07:15:08.000000000","message":"Done","commit_id":"79d85c6717fc720196d59c6b9f099387cd9bc919"}]}