)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"2f4372a5d5ab9c32114bbdd38d8347a5a8051038","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Berendt \u003cberendt@b1-systems.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-03 08:32:21 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"use LOG instead of logger as name for the Logger object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2997a33b1039dd4ab4b28b16f87d200bec9bfad7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ae5cdf2_20b24094","line":7,"updated":"2014-06-03 15:25:56.000000000","message":"this could probably be changed to something more accurate but not a blocker... if you need to rebase, can you change this to \"define logger as global LOG so it\u0027s consistent with other Pollsters\"","commit_id":"22d1461721578c4756e6919cc190eaa4b4b46c61"}],"ceilometer/network/floatingip.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"89a09fefa4c4dbbcd4f4dfb458909a8ba05b0970","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class FloatingIPPollster(plugin.CentralPollster):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    logger \u003d log.getLogger(__name__ + \u0027.floatingip\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _get_floating_ips(self):"},{"line_number":35,"context_line":"        nv \u003d nova_client.Client()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ae8d1ca_4c135966","line":32,"updated":"2014-05-28 09:30:17.000000000","message":"I think there is no need to use floatingip specific log. we should just use\n\nLOG \u003d log.getLogger(__name__)\n\nas others","commit_id":"b6e4f16b2672110f421d870ddbca1f51e0630c74"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"a1e1c74ce04f7d0906c053ee54b50191a8c0468f","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class FloatingIPPollster(plugin.CentralPollster):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    logger \u003d log.getLogger(__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _get_floating_ips(self):"},{"line_number":35,"context_line":"        nv \u003d nova_client.Client()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ae8d1ca_81c5fc8f","line":32,"updated":"2014-05-29 10:26:28.000000000","message":"Sorry, I didn\u0027t make myself clear about the last comment. What I meant was to follow other pollsters, e.g. https://github.com/openstack/ceilometer/blob/master/ceilometer/compute/pollsters/cpu.py#L28","commit_id":"5942bd2de118983b6cc7350d1bf0cba824bc9451"},{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"9be81c5b120f0398283a3b7061a2a9aef13984c4","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class FloatingIPPollster(plugin.CentralPollster):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    logger \u003d log.getLogger(__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _get_floating_ips(self):"},{"line_number":35,"context_line":"        nv \u003d nova_client.Client()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_4d48db5b","line":32,"in_reply_to":"3ae8d1ca_81c5fc8f","updated":"2014-05-30 08:25:36.000000000","message":"It is better to use same style logger, if possible.","commit_id":"5942bd2de118983b6cc7350d1bf0cba824bc9451"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"0daa4750b4a13dda27211185241d4e8bcbfece5a","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def get_samples(self, manager, cache, resources\u003dNone):"},{"line_number":44,"context_line":"        for ip in self._iter_floating_ips(cache):"},{"line_number":45,"context_line":"            LOG.info(_(\"FLOATING IP USAGE: %s\") % ip.ip)"},{"line_number":46,"context_line":"            # FIXME (flwang) Now Nova API /os-floating-ips can\u0027t provide those"},{"line_number":47,"context_line":"            # attributes were used by Ceilometer, such as project id, host."},{"line_number":48,"context_line":"            # In this fix, those attributes usage will be removed temporarily."}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_38d28700","line":45,"updated":"2014-06-03 07:46:40.000000000","message":"nit: I\u0027m really don\u0027t like such upper case words in log message, but it is not this patch\u0027s problem","commit_id":"22d1461721578c4756e6919cc190eaa4b4b46c61"}]}