)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"40c0a18286df022ecf7bcc4d0bd6efa5a3e25118","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     liu-sheng \u003cliusheng@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-30 10:52:10 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check unsupported query filtes of listing evetns"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, CLI cannot recognise the unsupported query filtes of listing"},{"line_number":10,"context_line":"events, this is unlike others commands (listing alarm, etc.)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_da73c4e5","line":7,"updated":"2014-05-30 03:46:21.000000000","message":"nit: s/filtes/filters/ s/evetns/events/","commit_id":"27a379e772980c0cff949a344fc6a602bb35f713"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"40c0a18286df022ecf7bcc4d0bd6efa5a3e25118","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check unsupported query filtes of listing evetns"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, CLI cannot recognise the unsupported query filtes of listing"},{"line_number":10,"context_line":"events, this is unlike others commands (listing alarm, etc.)."},{"line_number":11,"context_line":"This patch provide a clear presentation for valid keys if we specify"},{"line_number":12,"context_line":"unsupported keys in query fileds."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_1a7e0caf","line":9,"updated":"2014-05-30 03:46:21.000000000","message":"nit: filtes","commit_id":"27a379e772980c0cff949a344fc6a602bb35f713"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"40c0a18286df022ecf7bcc4d0bd6efa5a3e25118","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, CLI cannot recognise the unsupported query filtes of listing"},{"line_number":10,"context_line":"events, this is unlike others commands (listing alarm, etc.)."},{"line_number":11,"context_line":"This patch provide a clear presentation for valid keys if we specify"},{"line_number":12,"context_line":"unsupported keys in query fileds."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9b8ef306b97b3102c7a1c8d8d451a7be427e37ae"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_3a4ae883","line":11,"updated":"2014-05-30 03:46:21.000000000","message":"nit: provide-\u003eprovides","commit_id":"27a379e772980c0cff949a344fc6a602bb35f713"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"40c0a18286df022ecf7bcc4d0bd6efa5a3e25118","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, CLI cannot recognise the unsupported query filtes of listing"},{"line_number":10,"context_line":"events, this is unlike others commands (listing alarm, etc.)."},{"line_number":11,"context_line":"This patch provide a clear presentation for valid keys if we specify"},{"line_number":12,"context_line":"unsupported keys in query fileds."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9b8ef306b97b3102c7a1c8d8d451a7be427e37ae"},{"line_number":15,"context_line":"Closes-Bug: #1291846"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_9a493c8e","line":12,"updated":"2014-05-30 03:46:21.000000000","message":"nit: fileds-\u003efields","commit_id":"27a379e772980c0cff949a344fc6a602bb35f713"}],"ceilometer/api/controllers/v2.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"40c0a18286df022ecf7bcc4d0bd6efa5a3e25118","unresolved":false,"context_lines":[{"line_number":2266,"context_line":"        \u0027end_time\u0027: None"},{"line_number":2267,"context_line":"    }"},{"line_number":2268,"context_line":"    traits_filter \u003d []"},{"line_number":2269,"context_line":""},{"line_number":2270,"context_line":"    for i in q:"},{"line_number":2271,"context_line":"        # FIXME(herndon): Support for operators other than"},{"line_number":2272,"context_line":"        # \u0027eq\u0027 will come later."}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_ba5d184b","side":"PARENT","line":2269,"updated":"2014-05-30 03:46:21.000000000","message":"nit: I think there is no need to remove this blank line","commit_id":"4ed4559f4722249645bd87b5b2abed47710dd068"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"40c0a18286df022ecf7bcc4d0bd6efa5a3e25118","unresolved":false,"context_lines":[{"line_number":2278,"context_line":"            traits_filter.append({\"key\": i.field[6:],"},{"line_number":2279,"context_line":"                                  i.type: i._get_value_as_type()})"},{"line_number":2280,"context_line":"        else:"},{"line_number":2281,"context_line":"            msg \u003d (\"Unrecognized field in query: %(query)s, \""},{"line_number":2282,"context_line":"                   \"valid keys: %(valid_keys)s or trait filters\" %"},{"line_number":2283,"context_line":"                   {\u0027query\u0027: i, \u0027valid_keys\u0027: evt_model_filter.keys()})"},{"line_number":2284,"context_line":"            raise wsme.exc.UnknownArgument(i.field, msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_3a31080c","line":2281,"updated":"2014-05-30 03:46:21.000000000","message":"-1: the msg will expose to end-users, which means need i18n support","commit_id":"27a379e772980c0cff949a344fc6a602bb35f713"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"75fa3139108b2e880561719ac60e951a4d4806b9","unresolved":false,"context_lines":[{"line_number":2280,"context_line":"                                  i.type: i._get_value_as_type()})"},{"line_number":2281,"context_line":"        else:"},{"line_number":2282,"context_line":"            msg \u003d (\"Unrecognized field in query: %(query)s, \""},{"line_number":2283,"context_line":"                   \"valid keys: %(valid_keys)s or trait filters\" %"},{"line_number":2284,"context_line":"                   {\u0027query\u0027: i, \u0027valid_keys\u0027: evt_model_filter.keys()})"},{"line_number":2285,"context_line":"            raise wsme.exc.UnknownArgument(i.field, msg)"},{"line_number":2286,"context_line":"    return storage.EventFilter(traits_filter\u003dtraits_filter, **evt_model_filter)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_6674b299","line":2283,"updated":"2014-05-31 08:45:57.000000000","message":"nit: trait filters is implicit for users, at least tell them should use trait.{key} format","commit_id":"db67cd5b6f1a35765e24ab772c240927b8fa8fb6"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"03a2424bda5ea5373cc8559dbb4b00eb14eb600b","unresolved":false,"context_lines":[{"line_number":2268,"context_line":"            raise ClientSideError(error)"},{"line_number":2269,"context_line":"        if i.field in evt_model_filter:"},{"line_number":2270,"context_line":"            evt_model_filter[i.field] \u003d i.value"},{"line_number":2271,"context_line":"        elif i.field.startswith(\u0027trait.\u0027):"},{"line_number":2272,"context_line":"            traits_filter.append({\"key\": i.field[6:],"},{"line_number":2273,"context_line":"                                  i.type: i._get_value_as_type()})"},{"line_number":2274,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_845dc74a","line":2271,"updated":"2014-07-19 20:39:00.000000000","message":"Is this change to require \"trait.\" prefix a non-backward compatible API modification?","commit_id":"8f416d5cfb2bcb3e40f52ea064e4ae9c8d13cf74"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"4492f2cabbf063599660dfbfae426daaf617ff4a","unresolved":false,"context_lines":[{"line_number":2268,"context_line":"            raise ClientSideError(error)"},{"line_number":2269,"context_line":"        if i.field in evt_model_filter:"},{"line_number":2270,"context_line":"            evt_model_filter[i.field] \u003d i.value"},{"line_number":2271,"context_line":"        elif i.field.startswith(\u0027trait.\u0027):"},{"line_number":2272,"context_line":"            traits_filter.append({\"key\": i.field[6:],"},{"line_number":2273,"context_line":"                                  i.type: i._get_value_as_type()})"},{"line_number":2274,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_cb134363","line":2271,"in_reply_to":"baada198_845dc74a","updated":"2014-07-21 01:57:12.000000000","message":"Yes, I have concerned about about that, but maybe the event-list should check unsupported query filters like others API of ceilometer, this change is refer to the metadata query fileter:\n\nhttps://github.com/openstack/ceilometer/blob/master/ceilometer/api/controllers/v2.py#L479","commit_id":"8f416d5cfb2bcb3e40f52ea064e4ae9c8d13cf74"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"03a2424bda5ea5373cc8559dbb4b00eb14eb600b","unresolved":false,"context_lines":[{"line_number":2272,"context_line":"            traits_filter.append({\"key\": i.field[6:],"},{"line_number":2273,"context_line":"                                  i.type: i._get_value_as_type()})"},{"line_number":2274,"context_line":"        else:"},{"line_number":2275,"context_line":"            msg \u003d (\"Unrecognized field in query: %(query)s, \""},{"line_number":2276,"context_line":"                   \"valid keys: %(valid_keys)s or trait filters, use \""},{"line_number":2277,"context_line":"                   \"trait.{field} format to specify trait filter\u0027s field.\" %"},{"line_number":2278,"context_line":"                   {\u0027query\u0027: i, \u0027valid_keys\u0027: evt_model_filter.keys()})"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_249a3b14","line":2275,"updated":"2014-07-19 20:39:00.000000000","message":"Would this error message be more specific if it included just the query field (i.e. i.field) as opposed to the entire query (i.e i)?","commit_id":"8f416d5cfb2bcb3e40f52ea064e4ae9c8d13cf74"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"4492f2cabbf063599660dfbfae426daaf617ff4a","unresolved":false,"context_lines":[{"line_number":2272,"context_line":"            traits_filter.append({\"key\": i.field[6:],"},{"line_number":2273,"context_line":"                                  i.type: i._get_value_as_type()})"},{"line_number":2274,"context_line":"        else:"},{"line_number":2275,"context_line":"            msg \u003d (\"Unrecognized field in query: %(query)s, \""},{"line_number":2276,"context_line":"                   \"valid keys: %(valid_keys)s or trait filters, use \""},{"line_number":2277,"context_line":"                   \"trait.{field} format to specify trait filter\u0027s field.\" %"},{"line_number":2278,"context_line":"                   {\u0027query\u0027: i, \u0027valid_keys\u0027: evt_model_filter.keys()})"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_7d311aa1","line":2275,"in_reply_to":"baada198_249a3b14","updated":"2014-07-21 01:57:12.000000000","message":"maybe the i.field in \"wsme.exc.UnknownArgument(i.field, msg)\" will specifically show the unsupported query filed. \ni.e, if I use \"ceilometer event-list -q abc\u003dc9da6334-e0a2-4c61-a313-8b5d48acf35f\" command.\nthe return is:\n\nHTTPBadRequest (HTTP 400) ERROR Unknown argument: \"abc\": Unrecognized field in query: \u003cEventQuery u\u0027abc\u0027 eq u\u0027c9da6334-e0a2-4c61-a313-8b5d48acf35f\u0027 \u003e, valid keys: [\u0027start_time\u0027, \u0027end_time\u0027, \u0027event_type\u0027, \u0027message_id\u0027] or trait filters, use trait.{field} format to specify trait filter\u0027s field.\n\naccording this error message, users will clearly known the  query filed(abc) is wrong (personally :D).\n\nrefer to:\nhttps://github.com/openstack/ceilometer/blob/master/ceilometer/api/controllers/v2.py#L402","commit_id":"8f416d5cfb2bcb3e40f52ea064e4ae9c8d13cf74"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"1c19228bf9f04f4df2c5d337633ffb81d899c616","unresolved":false,"context_lines":[{"line_number":2423,"context_line":"            raise ClientSideError(error)"},{"line_number":2424,"context_line":"        if i.field in evt_model_filter:"},{"line_number":2425,"context_line":"            evt_model_filter[i.field] \u003d i.value"},{"line_number":2426,"context_line":"        elif i.field.startswith(\u0027trait.\u0027):"},{"line_number":2427,"context_line":"            traits_filter.append({\"key\": i.field[6:],"},{"line_number":2428,"context_line":"                                  i.type: i._get_value_as_type(),"},{"line_number":2429,"context_line":"                                  \"op\": i.op})"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_a03b86e8","line":2426,"updated":"2015-01-15 07:18:46.000000000","message":"Please add relevant information in the EventQuery\u0027s class docstring, so that users can know how to correctly set trait field to be queried by reading the webapi doc. Otherwise no one knows to how to set unless they read the code.","commit_id":"8fd39f8cdbe4a3106ad9d4a60f352c1235998fcf"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"4802279807ec23a865f7119dc6e3af0ce36b3c1d","unresolved":false,"context_lines":[{"line_number":2423,"context_line":"            raise ClientSideError(error)"},{"line_number":2424,"context_line":"        if i.field in evt_model_filter:"},{"line_number":2425,"context_line":"            evt_model_filter[i.field] \u003d i.value"},{"line_number":2426,"context_line":"        elif i.field.startswith(\u0027trait.\u0027):"},{"line_number":2427,"context_line":"            traits_filter.append({\"key\": i.field[6:],"},{"line_number":2428,"context_line":"                                  i.type: i._get_value_as_type(),"},{"line_number":2429,"context_line":"                                  \"op\": i.op})"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_6330c89e","line":2426,"in_reply_to":"3a961159_a03b86e8","updated":"2015-01-15 07:33:02.000000000","message":"Done","commit_id":"8fd39f8cdbe4a3106ad9d4a60f352c1235998fcf"}],"ceilometer/tests/api/v2/test_event_scenarios.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"40c0a18286df022ecf7bcc4d0bd6efa5a3e25118","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                             q\u003d[{\u0027field\u0027: \u0027abc\u0027,"},{"line_number":237,"context_line":"                                 \u0027value\u0027: \u0027101\u0027,"},{"line_number":238,"context_line":"                                 \u0027type\u0027: \u0027abc\u0027}],"},{"line_number":239,"context_line":"                             expect_errors\u003dTrue)"},{"line_number":240,"context_line":"        self.assertEqual(data.status_code, 400)"},{"line_number":241,"context_line":"        self.assertEqual(\u0027Unknown argument: \"\\\"abc\\\"\": unrecognized\u0027"},{"line_number":242,"context_line":"                         \u0027 field in query: [\u003cEventQuery u\\\u0027abc\\\u0027 eq\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_9a177c51","line":239,"updated":"2014-05-30 03:46:21.000000000","message":"nit: add status\u003d400 as parameter here can reduce the extra line 240","commit_id":"27a379e772980c0cff949a344fc6a602bb35f713"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"40c0a18286df022ecf7bcc4d0bd6efa5a3e25118","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                         \u0027 u\\\u0027abc\\\u0027 None\u003e], valid keys: set(\u0027"},{"line_number":244,"context_line":"                         \u0027[\\\u0027start_time\\\u0027, \\\u0027end_time\\\u0027,\u0027"},{"line_number":245,"context_line":"                         \u0027 \\\u0027event_type\\\u0027, \\\u0027message_id\\\u0027] or trait filters)\u0027,"},{"line_number":246,"context_line":"                         data[0].json[\u0027error_message\u0027][\u0027faultstring\u0027])"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def test_get_events_not_filters(self):"},{"line_number":249,"context_line":"        data \u003d self.get_json(self.PATH, headers\u003dheaders,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_7d09ca2b","line":246,"updated":"2014-05-30 03:46:21.000000000","message":"-1: since this request will fail, I think data actually will be a 400 response, which means data[0] may invoke index error","commit_id":"27a379e772980c0cff949a344fc6a602bb35f713"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"75fa3139108b2e880561719ac60e951a4d4806b9","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                                 \u0027type\u0027: \u0027integer\u0027}],"},{"line_number":239,"context_line":"                             expect_errors\u003dTrue,"},{"line_number":240,"context_line":"                             status\u003d400)"},{"line_number":241,"context_line":"        self.assertEqual(u\u0027Unknown argument: \"abc\": Unrecognized field in \u0027"},{"line_number":242,"context_line":"                         u\u0027query: \u003cEventQuery u\\\u0027abc\\\u0027 eq 100 integer\u003e, valid\u0027"},{"line_number":243,"context_line":"                         u\u0027 keys: [\\\u0027start_time\\\u0027, \\\u0027end_time\\\u0027, \u0027"},{"line_number":244,"context_line":"                         u\u0027\\\u0027event_type\\\u0027, \\\u0027message_id\\\u0027] or trait filters\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_6b18fb81","line":241,"updated":"2014-05-31 08:45:57.000000000","message":"nit: the leading \u0027u\u0027 is not necessary","commit_id":"db67cd5b6f1a35765e24ab772c240927b8fa8fb6"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e005cc8401e0bf85310e0d45a856c332165dc020","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                                 \u0027type\u0027: \u0027integer\u0027}],"},{"line_number":239,"context_line":"                             expect_errors\u003dTrue,"},{"line_number":240,"context_line":"                             status\u003d400)"},{"line_number":241,"context_line":"        self.assertEqual(u\u0027Unknown argument: \"abc\": Unrecognized field in \u0027"},{"line_number":242,"context_line":"                         u\u0027query: \u003cEventQuery u\\\u0027abc\\\u0027 eq 100 integer\u003e, valid\u0027"},{"line_number":243,"context_line":"                         u\u0027 keys: [\\\u0027start_time\\\u0027, \\\u0027end_time\\\u0027, \u0027"},{"line_number":244,"context_line":"                         u\u0027\\\u0027event_type\\\u0027, \\\u0027message_id\\\u0027] or trait filters\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_ab963eee","line":241,"in_reply_to":"1ae5cdf2_6b18fb81","updated":"2014-06-03 09:46:19.000000000","message":"I have remove the \"u\" in PS5, but jenkins run failed for that :(","commit_id":"db67cd5b6f1a35765e24ab772c240927b8fa8fb6"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"e530da4249841fa6f169e5285cb56e6f7668db69","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                         u\u0027 keys: [\\\u0027start_time\\\u0027, \\\u0027end_time\\\u0027, \u0027"},{"line_number":244,"context_line":"                         u\u0027\\\u0027event_type\\\u0027, \\\u0027message_id\\\u0027] or trait filters, \u0027"},{"line_number":245,"context_line":"                         u\u0027use trait.{field} format to specify trait filter\\\u0027s\u0027"},{"line_number":246,"context_line":"                         u\u0027 field\u0027,"},{"line_number":247,"context_line":"                         data.json[\u0027error_message\u0027][\u0027faultstring\u0027])"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def test_get_events_not_filters(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_74b7a93a","line":246,"updated":"2014-06-03 15:31:01.000000000","message":"this assertEqual will fail, not because the leading \u0027u\u0027, although I\u0027m not very sure if it is necessary, but my local test shows it is ok to remove it. you can ask core reviewers for advise, or we can leave it here then someday, some guy may pick this problem up and fix them all....\n\n-1: the reason why it would fail is because the trailing dot (\u0027.\u0027), in v2.py, it has dot, in the ut, it doesn\u0027t, then the two sentences are not equal......","commit_id":"d948d6bb4eeae6a2ac46b9e42f8686fe22038370"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"a880664c774f6034293d774aa1548abf789e3856","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                         u\u0027 keys: [\\\u0027start_time\\\u0027, \\\u0027end_time\\\u0027, \u0027"},{"line_number":244,"context_line":"                         u\u0027\\\u0027event_type\\\u0027, \\\u0027message_id\\\u0027] or trait filters, \u0027"},{"line_number":245,"context_line":"                         u\u0027use trait.{field} format to specify trait filter\\\u0027s\u0027"},{"line_number":246,"context_line":"                         u\u0027 field\u0027,"},{"line_number":247,"context_line":"                         data.json[\u0027error_message\u0027][\u0027faultstring\u0027])"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def test_get_events_not_filters(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_dcb41237","line":246,"in_reply_to":"1ae5cdf2_74b7a93a","updated":"2014-06-04 02:04:00.000000000","message":"haha, you are right :), and I am careless :(","commit_id":"d948d6bb4eeae6a2ac46b9e42f8686fe22038370"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"4cf4c189daf5c6aa63a31e84e4bb9c6a00cc7f9b","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def test_get_events_filter_op_string(self):"},{"line_number":271,"context_line":"        data \u003d self.get_json(self.PATH, headers\u003dheaders,"},{"line_number":272,"context_line":"                             q\u003d[{\u0027field\u0027: \u0027trait_A\u0027,"},{"line_number":273,"context_line":"                                 \u0027value\u0027: \u0027my_Foo_text\u0027,"},{"line_number":274,"context_line":"                                 \u0027type\u0027: \u0027string\u0027,"},{"line_number":275,"context_line":"                                 \u0027op\u0027: \u0027eq\u0027}])"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_a517d4a1","line":272,"updated":"2014-09-15 13:59:01.000000000","message":"If it is proposed a new type of traits filters it seems that it should be changed in all tests.","commit_id":"d2785551e2ce7203038a1e048d2f650936dfe57e"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"9596f02f57f373f5fdabd46f43bff1dc4970da77","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                             status\u003d400)"},{"line_number":257,"context_line":"        self.assertEqual(\u0027Unknown argument: \"abc\": Unrecognized field in \u0027"},{"line_number":258,"context_line":"                         \u0027query: \u003cEventQuery u\\\u0027abc\\\u0027 eq 100 integer\u003e, valid\u0027"},{"line_number":259,"context_line":"                         \u0027 keys: [\\\u0027start_time\\\u0027, \\\u0027end_time\\\u0027, \u0027"},{"line_number":260,"context_line":"                         \u0027\\\u0027event_type\\\u0027, \\\u0027message_id\\\u0027] or trait filters, \u0027"},{"line_number":261,"context_line":"                         \u0027use trait.{field} format to specify trait filter\\\u0027s\u0027"},{"line_number":262,"context_line":"                         \u0027 field.\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_3db8e6e7","line":259,"updated":"2015-01-13 14:31:23.000000000","message":"start_time end_time shoudl be renamed to start_timestamp end_timstamp, recently we have a patch that has provided consistency to all time variable names if I don\u0027t miss something.","commit_id":"6d113bdb01ccdd2210c5cd383f12bccfc311a709"}]}