)]}'
{"id":"openstack%2Fceilometer~97099","triplet_id":"openstack%2Fceilometer~master~If96ca91bf0104e2b532a75015f6c6b0b7ff60a78","project":"openstack/ceilometer","branch":"master","topic":"bug/1325354","hashtags":[],"change_id":"If96ca91bf0104e2b532a75015f6c6b0b7ff60a78","subject":"set debug to true in api test","status":"ABANDONED","created":"2014-06-01 13:34:02.000000000","updated":"2014-06-14 09:08:58.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f0cdb17c433d4db43a356bec4cc3f804b323f7ca","_number":97099,"virtual_id_number":97099,"owner":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"date":"2014-06-10 06:07:00.000000000","_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},{"date":"2014-06-04 15:58:26.000000000","_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"value":1,"date":"2014-06-10 07:08:40.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"disliked":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"all":[{"value":-1,"date":"2014-06-04 14:20:40.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},{"value":-1,"date":"2014-06-06 12:26:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"value":-2,"date":"2014-06-10 14:27:45.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-06-04 06:32:34.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-06-04 06:32:34.000000000","updated_by":{"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"},"reviewer":{"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"},"state":"REVIEWER"},{"updated":"2014-06-04 14:20:40.000000000","updated_by":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"reviewer":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"state":"REVIEWER"},{"updated":"2014-06-06 12:26:50.000000000","updated_by":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"reviewer":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"state":"REVIEWER"},{"updated":"2014-06-10 06:07:00.000000000","updated_by":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"reviewer":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"state":"REVIEWER"},{"updated":"2014-06-10 07:08:40.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-06-10 14:27:45.000000000","updated_by":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"reviewer":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"state":"REVIEWER"}],"messages":[{"id":"ba14bf47fd05003573785d2cac791ef414bc127e","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-06-01 13:34:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"68c8e9d3756fe3313256096ccc0fb54d5ab723ee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-01 13:34:07.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"5a07cb970bdaec61d67170250a9f6b708958ceb6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-01 14:38:05.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-ceilometer-pep8 http://logs.openstack.org/99/97099/1/check/gate-ceilometer-pep8/3b77246 : SUCCESS in 3m 28s\n- gate-ceilometer-docs http://docs-draft.openstack.org/99/97099/1/check/gate-ceilometer-docs/adde468/doc/build/html/ : SUCCESS in 4m 31s\n- gate-ceilometer-python26 http://logs.openstack.org/99/97099/1/check/gate-ceilometer-python26/5645f3a : SUCCESS in 4m 17s\n- gate-ceilometer-python27 http://logs.openstack.org/99/97099/1/check/gate-ceilometer-python27/74e76fa : SUCCESS in 5m 45s\n- check-devstack-dsvm-cells http://logs.openstack.org/99/97099/1/check/check-devstack-dsvm-cells/3e9f0f6 : SUCCESS in 19m 10s\n- check-tempest-dsvm-full http://logs.openstack.org/99/97099/1/check/check-tempest-dsvm-full/e52d70a : SUCCESS in 1h 03m 38s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/99/97099/1/check/check-tempest-dsvm-postgres-full/8b54adc : FAILURE in 15m 13s\n- check-tempest-dsvm-neutron http://logs.openstack.org/99/97099/1/check/check-tempest-dsvm-neutron/ce29ebc : SUCCESS in 59m 00s\n- check-swift-dsvm-functional http://logs.openstack.org/99/97099/1/check/check-swift-dsvm-functional/42abf60 : SUCCESS in 25m 14s","accounts_in_message":[],"_revision_number":1},{"id":"f2806e33d3da599cfb44ccc4926614bb4aacc931","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-06-03 02:30:55.000000000","message":"Patch Set 1:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"6fb104dc5698a85d14bc173ebbdf89d7fa84bc19","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-03 02:30:56.000000000","message":"Patch Set 1: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"86e04cf5f90ed67bbea3e75ed570827574eec3df","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-03 08:51:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-ceilometer-pep8 http://logs.openstack.org/99/97099/1/check/gate-ceilometer-pep8/8052a91 : SUCCESS in 4m 33s\n- gate-ceilometer-docs http://docs-draft.openstack.org/99/97099/1/check/gate-ceilometer-docs/3cb5a97/doc/build/html/ : SUCCESS in 4m 17s\n- gate-ceilometer-python26 http://logs.openstack.org/99/97099/1/check/gate-ceilometer-python26/2944321 : SUCCESS in 4m 28s\n- gate-ceilometer-python27 http://logs.openstack.org/99/97099/1/check/gate-ceilometer-python27/684082a : SUCCESS in 5m 06s\n- check-devstack-dsvm-cells http://logs.openstack.org/99/97099/1/check/check-devstack-dsvm-cells/a6e38e9 : SUCCESS in 15m 28s\n- check-tempest-dsvm-full http://logs.openstack.org/99/97099/1/check/check-tempest-dsvm-full/a1b122b : SUCCESS in 56m 13s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/99/97099/1/check/check-tempest-dsvm-postgres-full/2e747d1 : SUCCESS in 54m 38s\n- check-tempest-dsvm-neutron http://logs.openstack.org/99/97099/1/check/check-tempest-dsvm-neutron/d068213 : SUCCESS in 55m 22s\n- check-swift-dsvm-functional http://logs.openstack.org/99/97099/1/check/check-swift-dsvm-functional/48b3c0f : SUCCESS in 13m 48s","accounts_in_message":[],"_revision_number":1},{"id":"4ceb5d79f3a1f4fb9911fda36c45686f6482bdee","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2014-06-03 15:27:11.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"1daeeee77bc906435b3484fff2070258fe552441","author":{"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"},"date":"2014-06-03 21:54:04.000000000","message":"Patch Set 1: Code-Review-1\n\nIMHO debug should be set to true in tests. It makes debugging of test failures much easier sometimes. If some tests fail cause of debug set to true we should fix the tests not switch debug to off","accounts_in_message":[],"_revision_number":1},{"id":"7f5743e2cc3070c2155e2f103f63ba2af3307e80","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-06-04 03:11:20.000000000","message":"Patch Set 1:\n\n@Alexei Kornienko\n\ncan you read the commit message carefully please, I write so many words just want to explain it explicitly.\n\nSo the problem is not open debug causing many information, the problem is if debug is open then unit test would fail in the scenario I mentioned. The original test code assumes the debug should be disabled!\n\nthanks for your review","accounts_in_message":[],"_revision_number":1},{"id":"bf147c782a704e9ab004aab398ffbf04eaf5d187","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-06-04 03:22:45.000000000","message":"Patch Set 1:\n\n@Alexei Kornienko\n\nfinally, I realize that it is true we should open debug, since we only capture failing test\u0027s log in jenkins. not you\u0027re not reading my commit message carefully, I did not consider your comment carefully :(, sorry for that\n\nI modify the test code and watch the console output, all is ok, thank you very much\n\nwill upload a patchset soon","accounts_in_message":[],"_revision_number":1},{"id":"40825c7c3daeed3e4deb8f8b12947712cb7d8762","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-04 03:31:25.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"847dc9a5d2e7216147ecf3e2fe248eb8084f398b","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-06-04 03:31:25.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f6b117bf45406f37a54f4fa01c701cf652152012","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-04 05:05:45.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-ceilometer-pep8 http://logs.openstack.org/99/97099/2/check/gate-ceilometer-pep8/77ee644 : SUCCESS in 3m 01s\n- gate-ceilometer-docs http://docs-draft.openstack.org/99/97099/2/check/gate-ceilometer-docs/69de41d/doc/build/html/ : SUCCESS in 3m 38s\n- gate-ceilometer-python26 http://logs.openstack.org/99/97099/2/check/gate-ceilometer-python26/6312f8c : SUCCESS in 6m 51s\n- gate-ceilometer-python27 http://logs.openstack.org/99/97099/2/check/gate-ceilometer-python27/f12f306 : SUCCESS in 4m 43s\n- check-devstack-dsvm-cells http://logs.openstack.org/99/97099/2/check/check-devstack-dsvm-cells/2f91fd5 : SUCCESS in 12m 07s\n- check-tempest-dsvm-full http://logs.openstack.org/99/97099/2/check/check-tempest-dsvm-full/f117039 : SUCCESS in 42m 24s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/99/97099/2/check/check-tempest-dsvm-postgres-full/4b607a2 : SUCCESS in 43m 24s\n- check-tempest-dsvm-neutron http://logs.openstack.org/99/97099/2/check/check-tempest-dsvm-neutron/3fa950a : SUCCESS in 54m 32s\n- check-swift-dsvm-functional http://logs.openstack.org/99/97099/2/check/check-swift-dsvm-functional/4ed8b03 : SUCCESS in 13m 02s","accounts_in_message":[],"_revision_number":2},{"id":"7ed6be8aea5b1250cc5082af829f81b3e1a37afa","author":{"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"},"date":"2014-06-04 06:32:34.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"598e272024f115822d74dc73c3910bea7dc2630f","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2014-06-04 13:59:26.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0df91713645e65201006dd4a2a48dfa8fe6fffbf","author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"date":"2014-06-04 14:20:40.000000000","message":"Patch Set 2: Code-Review-1\n\nnot very comfortable with having the flag hardcoded. Is there any way at all to set this thing in the configuration file?\nIt will be hard to imagine that it can\u0027t. The reason not\nfeeling comfortable with this is that in theory, the code\nexecution pass could be different in debug and non-debug mode. would hope there is a way to set it in a config\nfile.","accounts_in_message":[],"_revision_number":2},{"id":"d8f2ee71515cffb47781f5af9270bff3d8a0fd4e","author":{"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"},"date":"2014-06-04 14:22:15.000000000","message":"Patch Set 2:\n\ntests doesn\u0027t have a separate configuration file. And in any cases it should be always on in tests. I don\u0027t know a reason why you would want this set to false.","accounts_in_message":[],"_revision_number":2},{"id":"cda6d265010dc8b0a23f00524eed4c46bb4cba41","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-06-04 15:58:26.000000000","message":"Patch Set 2:\n\n@litong01\n\nI agree that code execution path can be different when debug is true or false, but don\u0027t think most case, debug is true will execute more code than it is false? more problem can be exposed when debug is true, and it is easier for developer to locate problem when test fail\n\ncurrently, there are full of hard code in unit test, I don\u0027t think it is a problem","accounts_in_message":[],"_revision_number":2},{"id":"9e9acda6b75a1cda3d8513a20753eb1f8ea45c96","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2014-06-04 16:18:33.000000000","message":"Patch Set 2:\n\ni would think that debug is a superset of non-debug paths. if that is not the case, we should probably fix that... i can\u0027t think of a scenario where a path would be run in non-debug mode but not run in debug mode.","accounts_in_message":[],"_revision_number":2},{"id":"f8b942329592c5f71d68a2b988fe6e42e6bd9f0c","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-06-04 16:30:51.000000000","message":"Patch Set 2:\n\n@gordon chung\n\nI have another patchset in my local env, which only modify the test_post_sample_scenarios.py:\n\n    -        pipeline_hook \u003d self.app.app.application.app.hooks[2]\n    +        # NOTE(zqfan): debug is true then DebugMiddleware and\n    +        #              StaticFileMiddleware are enabled\n    +        app \u003d self.app.app\n    +        if not getattr(app, \u0027application\u0027, None):\n    +            app \u003d self.app.app.app.app\n    +        pipeline_hook \u003d app.application.app.hooks[2]\n\nno matter the /etc/ceilometer/ceilometer.conf set debug to true or false, the ut both pass\n\nbut I still think we should open debug for unit test, the reason I already repeat 3 times.\n\nwhat\u0027s your opinion???","accounts_in_message":[],"_revision_number":2},{"id":"d763d3698558e440f7fccd2e73572b9123b14e60","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2014-06-04 17:31:28.000000000","message":"Patch Set 2:\n\ni\u0027m ok with the current patch. probably doesn\u0027t make sense to add a clause into production just to satisfy a test","accounts_in_message":[],"_revision_number":2},{"id":"b933a3e9c075a220a60698416514e241233176d3","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2014-06-06 12:26:50.000000000","message":"Patch Set 2: Code-Review-1\n\nWhen I read the commit message, I think the correct fix should be: don\u0027t read /etc/ceilometer/ceilometer.conf when we run unit tests, no ?\n\nAll unit tests assume that the configuration options are set to the default values, if we read options from /etc/ceilometer/ceilometer.conf, this assumption become wrong.","accounts_in_message":[],"_revision_number":2},{"id":"551299b940f3f50eb8a6d339b50ae79bcd8b3dca","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2014-06-06 13:45:35.000000000","message":"Patch Set 2: -Code-Review\n\nyou and llu are fixing the same bug. maybe we can change this patch to what Mehdi suggested... and create a new bug.\n\ni\u0027ll let you and llu and figure it out. :)","accounts_in_message":[],"_revision_number":2},{"id":"0786085867acc6cca9542a308248ab1d93f11a68","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-10 06:07:00.000000000","message":"Patch Set 2: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"75b429685f8f0dc2b1f93a3e2a0e66ecab8f7a4f","author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"date":"2014-06-10 06:07:00.000000000","message":"Patch Set 2:\n\n@Zhiqiang, please see my patch https://review.openstack.org/98295, the way I proposed is that instead of the hacking into the pecan returned app object internals, we just mock the rpc client, so that the test won\u0027t break even if the pecan make some internal changes in the future.\n\nI also agree with gordon, Mehdi\u0027s suggestion to make conf.CONF skip parsing the /etc/ceilometer/ceilometer.conf file worth filing a new bug to address.","accounts_in_message":[],"_revision_number":2},{"id":"236028beee0a49205266a88b12fd509f6caaf750","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-10 07:08:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-ceilometer-pep8 http://logs.openstack.org/99/97099/2/check/gate-ceilometer-pep8/772bfa4 : SUCCESS in 4m 25s\n- gate-ceilometer-docs http://docs-draft.openstack.org/99/97099/2/check/gate-ceilometer-docs/8de7b25/doc/build/html/ : SUCCESS in 3m 40s\n- gate-ceilometer-python26 http://logs.openstack.org/99/97099/2/check/gate-ceilometer-python26/c89ac44 : SUCCESS in 6m 19s\n- gate-ceilometer-python27 http://logs.openstack.org/99/97099/2/check/gate-ceilometer-python27/380989e : SUCCESS in 4m 11s\n- check-devstack-dsvm-cells http://logs.openstack.org/99/97099/2/check/check-devstack-dsvm-cells/19d0ec4 : SUCCESS in 17m 34s\n- check-tempest-dsvm-full http://logs.openstack.org/99/97099/2/check/check-tempest-dsvm-full/282581d : SUCCESS in 52m 27s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/99/97099/2/check/check-tempest-dsvm-postgres-full/1962d2b : SUCCESS in 55m 43s\n- check-tempest-dsvm-neutron http://logs.openstack.org/99/97099/2/check/check-tempest-dsvm-neutron/9a00656 : SUCCESS in 59m 38s\n- check-swift-dsvm-functional http://logs.openstack.org/99/97099/2/check/check-swift-dsvm-functional/cf66dbb : SUCCESS in 13m 42s","accounts_in_message":[],"_revision_number":2},{"id":"d035115449c114fbeaac0d3c06ea9bb334fe7423","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2014-06-10 14:27:45.000000000","message":"Patch Set 2: Code-Review-2\n\ndone... bug 1328550\n\nlet\u0027s create a new patch for this.","accounts_in_message":[],"_revision_number":2},{"id":"fdaffa49faa642bbf515350ba5515b5e78cd2ea6","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-06-14 09:08:58.000000000","message":"Abandoned\n\nllu\u0027s patch is better than this one, and that one has already been merged","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3cfe3613d5552bd9292782ea2c8061b7bf5b4331","revisions":{"261158d5be3b1aa9e69bcbd42be611b7aedd7305":{"kind":"REWORK","_number":1,"created":"2014-06-01 13:34:02.000000000","uploader":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"ref":"refs/changes/99/97099/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/99/97099/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/99/97099/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/99/97099/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/99/97099/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/99/97099/1"}}},"commit":{"parents":[{"commit":"1fa9302feeb604a193741bee2a6dbd7acd108303","subject":"Merge \"reconnect to mongodb on connection failure\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/1fa9302feeb604a193741bee2a6dbd7acd108303"}]}],"author":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2014-06-01 13:24:40.000000000","tz":480},"committer":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2014-06-01 13:24:40.000000000","tz":480},"subject":"set debug to false in api test","message":"set debug to false in api test\n\nceilometer.tests.api.v2.test_post_samples_scenarios:TestPostSamples\nassumes debug is set to false. But in an environment which has\n/etc/ceilometer/ceilometer.conf, for example, an environment runs\ndevstack with ceilometer services enabled, then the debug option may\nbe set to true, in such scenario, the test code will fail.\n\nThe root cause is that ceilometer.api.app will invoke pecan.make_app\nwith cfg.CONF.debug, pecan will wrap the app with DebugMiddleware and\nStaticFileMiddleware if debug is true, then the line of:\npipeline_hook \u003d self.app.app.application.app.hooks[2]\nwill raise AttributeError since the app chain has been extended.\n\nThis patch simply overrides the debug option to False, which can\nensure the test code run properly.\n\nChange-Id: If96ca91bf0104e2b532a75015f6c6b0b7ff60a78\nCloses-Bug: #1325354\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/261158d5be3b1aa9e69bcbd42be611b7aedd7305"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/261158d5be3b1aa9e69bcbd42be611b7aedd7305"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"1fa9302feeb604a193741bee2a6dbd7acd108303","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"3cfe3613d5552bd9292782ea2c8061b7bf5b4331":{"kind":"REWORK","_number":2,"created":"2014-06-04 03:31:25.000000000","uploader":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"ref":"refs/changes/99/97099/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/99/97099/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/99/97099/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/99/97099/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/99/97099/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/99/97099/2"}}},"commit":{"parents":[{"commit":"70882f7cbeba48c35e4e261937bba1481e8dc6cf","subject":"Merge \"Fix doc gate job false success\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/70882f7cbeba48c35e4e261937bba1481e8dc6cf"}]}],"author":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2014-06-01 13:24:40.000000000","tz":480},"committer":{"name":"ZhiQiang Fan","email":"zhiqiang.fan@huawei.com","date":"2014-06-04 03:27:24.000000000","tz":480},"subject":"set debug to true in api test","message":"set debug to true in api test\n\nceilometer.tests.api.v2.test_post_samples_scenarios:TestPostSamples\nassumes debug is set to false. But in an environment which has\n/etc/ceilometer/ceilometer.conf, for example, an environment runs\ndevstack with ceilometer services enabled, then the debug option may\nbe set to true, in such scenario, the test code will fail.\n\nThe root cause is that ceilometer.api.app will invoke pecan.make_app\nwith cfg.CONF.debug, pecan will wrap the app with DebugMiddleware and\nStaticFileMiddleware if debug is true, then the line of:\npipeline_hook \u003d self.app.app.application.app.hooks[2]\nwill raise AttributeError since the app chain has been extended.\n\nWe need to enable debug by default, because for now, we only capture\nlog message for failing test in jenkins, enabling debug can help us to\nlocate the problem when jenkins fail.\n\nThis patch simply overrides the debug option to True in api test, and\nmodifies the corresponding unit test code to ensure the test code run\nproperly.\n\nChange-Id: If96ca91bf0104e2b532a75015f6c6b0b7ff60a78\nCloses-Bug: #1325354\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/3cfe3613d5552bd9292782ea2c8061b7bf5b4331"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/3cfe3613d5552bd9292782ea2c8061b7bf5b4331"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"70882f7cbeba48c35e4e261937bba1481e8dc6cf","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}