)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2e0e43eb4b9265ff530daee46071795a8db60c2f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Doug Hellmann \u003cdoug.hellmann@dreamhost.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-02 08:28:15 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix list of modules not included in auto-gen docs."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The variable for excluding modules should be a sequence of strings."},{"line_number":10,"context_line":"Turn the current value from a string to a tuple so documentation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_cc380da3","line":7,"updated":"2014-06-03 06:43:31.000000000","message":"nit: H803  git commit title should not end with period","commit_id":"40af15921b25eb8ddfb8e77215ad20d4cce16ece"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"aa2936190a72413a1ec9cf695b30f299975de4eb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Doug Hellmann \u003cdoug.hellmann@dreamhost.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-02 08:28:15 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix list of modules not included in auto-gen docs."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The variable for excluding modules should be a sequence of strings."},{"line_number":10,"context_line":"Turn the current value from a string to a tuple so documentation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_8bc42260","line":7,"in_reply_to":"1ae5cdf2_cc380da3","updated":"2014-06-03 09:35:02.000000000","message":"oh, yes, exactly... missed it :) good hit!","commit_id":"40af15921b25eb8ddfb8e77215ad20d4cce16ece"}],"ceilometer/event/converter.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ef628a52c35858a1e32ffbe5720a573929f555d","unresolved":false,"context_lines":[{"line_number":252,"context_line":"    notification will be processed according to the LAST definition that"},{"line_number":253,"context_line":"    matches it\u0027s event_type. (We use the last matching definition because that"},{"line_number":254,"context_line":"    allows you to use YAML merge syntax in the definitions file.)"},{"line_number":255,"context_line":"    Each definition is a dictionary with the following keys (all are"},{"line_number":256,"context_line":"    required):"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    - event_type: this is a list of notification event_types this definition"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_0d2361bd","line":255,"updated":"2014-06-05 18:25:11.000000000","message":"-1: either to be a new paragraph, or append it to the previous line","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"da3ee10324df1f01ad3908300e870081fca90a5f","unresolved":false,"context_lines":[{"line_number":252,"context_line":"    notification will be processed according to the LAST definition that"},{"line_number":253,"context_line":"    matches it\u0027s event_type. (We use the last matching definition because that"},{"line_number":254,"context_line":"    allows you to use YAML merge syntax in the definitions file.)"},{"line_number":255,"context_line":"    Each definition is a dictionary with the following keys (all are"},{"line_number":256,"context_line":"    required):"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    - event_type: this is a list of notification event_types this definition"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_d6cca6bd","line":255,"in_reply_to":"1ae5cdf2_0d2361bd","updated":"2014-06-05 20:16:15.000000000","message":"Sphinx appends it.","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ef628a52c35858a1e32ffbe5720a573929f555d","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    - event_type: this is a list of notification event_types this definition"},{"line_number":259,"context_line":"      will handle. These can be wildcarded with unix shell glob (not regex!)"},{"line_number":260,"context_line":"      wildcards."},{"line_number":261,"context_line":"      An exclusion listing (starting with a \u0027!\u0027) will exclude any types listed"},{"line_number":262,"context_line":"      from matching. If ONLY exclusions are listed, the definition will match"},{"line_number":263,"context_line":"      anything not matching the exclusions."},{"line_number":264,"context_line":"      This item can also be a string, which will be taken as equivalent to 1"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_4d29e999","line":261,"updated":"2014-06-05 18:25:11.000000000","message":"-1: either to be a new paragraph, or append it to the previous line","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"da3ee10324df1f01ad3908300e870081fca90a5f","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    - event_type: this is a list of notification event_types this definition"},{"line_number":259,"context_line":"      will handle. These can be wildcarded with unix shell glob (not regex!)"},{"line_number":260,"context_line":"      wildcards."},{"line_number":261,"context_line":"      An exclusion listing (starting with a \u0027!\u0027) will exclude any types listed"},{"line_number":262,"context_line":"      from matching. If ONLY exclusions are listed, the definition will match"},{"line_number":263,"context_line":"      anything not matching the exclusions."},{"line_number":264,"context_line":"      This item can also be a string, which will be taken as equivalent to 1"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_16c28e84","line":261,"in_reply_to":"1ae5cdf2_4d29e999","updated":"2014-06-05 20:16:15.000000000","message":"Same as above.","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ef628a52c35858a1e32ffbe5720a573929f555d","unresolved":false,"context_lines":[{"line_number":264,"context_line":"      This item can also be a string, which will be taken as equivalent to 1"},{"line_number":265,"context_line":"      item list."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"                Examples:"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"                * [\u0027compute.instance.exists\u0027] will only match"},{"line_number":270,"context_line":"                  compute.intance.exists notifications"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_0d24410b","line":267,"updated":"2014-06-05 18:25:11.000000000","message":"nit: there is no need to use so big indentation...","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"da3ee10324df1f01ad3908300e870081fca90a5f","unresolved":false,"context_lines":[{"line_number":264,"context_line":"      This item can also be a string, which will be taken as equivalent to 1"},{"line_number":265,"context_line":"      item list."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"                Examples:"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"                * [\u0027compute.instance.exists\u0027] will only match"},{"line_number":270,"context_line":"                  compute.intance.exists notifications"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_1670ce70","line":267,"in_reply_to":"1ae5cdf2_0d24410b","updated":"2014-06-05 20:16:15.000000000","message":"It indents the doc output nicely too, which I think looks better. And here we also have the space for this.","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ef628a52c35858a1e32ffbe5720a573929f555d","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    - traits:  dictionary, The keys are trait names, the values are the trait"},{"line_number":285,"context_line":"      definitions"},{"line_number":286,"context_line":"      Each trait definition is a dictionary with the following keys:"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"      - type (optional): The data type for this trait. (as a string)"},{"line_number":289,"context_line":"        Valid options are: \u0027text\u0027, \u0027int\u0027, \u0027float\u0027 and \u0027datetime\u0027, defaults to"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_ad3a6de4","line":286,"updated":"2014-06-05 18:25:11.000000000","message":"-1: either to be a new paragraph, or append it to the previous line","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"da3ee10324df1f01ad3908300e870081fca90a5f","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    - traits:  dictionary, The keys are trait names, the values are the trait"},{"line_number":285,"context_line":"      definitions"},{"line_number":286,"context_line":"      Each trait definition is a dictionary with the following keys:"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"      - type (optional): The data type for this trait. (as a string)"},{"line_number":289,"context_line":"        Valid options are: \u0027text\u0027, \u0027int\u0027, \u0027float\u0027 and \u0027datetime\u0027, defaults to"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_1b2397bd","line":286,"in_reply_to":"1ae5cdf2_ad3a6de4","updated":"2014-06-05 20:16:15.000000000","message":"Sphinx appends it.","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ef628a52c35858a1e32ffbe5720a573929f555d","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        wish to extract. The paths can be specified with a dot syntax"},{"line_number":293,"context_line":"        (e.g. \u0027payload.host\u0027) or dictionary syntax (e.g. \u0027payload[host]\u0027) is"},{"line_number":294,"context_line":"        also supported."},{"line_number":295,"context_line":"        In either case, if the key for the field you are looking for contains"},{"line_number":296,"context_line":"        special charecters, like \u0027.\u0027, it will need to be quoted (with double"},{"line_number":297,"context_line":"        or single quotes) like so::"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_2d573d27","line":295,"updated":"2014-06-05 18:25:11.000000000","message":"-1: either to be a new paragraph, or append it to the previous line","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"da3ee10324df1f01ad3908300e870081fca90a5f","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        wish to extract. The paths can be specified with a dot syntax"},{"line_number":293,"context_line":"        (e.g. \u0027payload.host\u0027) or dictionary syntax (e.g. \u0027payload[host]\u0027) is"},{"line_number":294,"context_line":"        also supported."},{"line_number":295,"context_line":"        In either case, if the key for the field you are looking for contains"},{"line_number":296,"context_line":"        special charecters, like \u0027.\u0027, it will need to be quoted (with double"},{"line_number":297,"context_line":"        or single quotes) like so::"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_7b1bbb80","line":295,"in_reply_to":"1ae5cdf2_2d573d27","updated":"2014-06-05 20:16:15.000000000","message":"Same as above.","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ef628a52c35858a1e32ffbe5720a573929f555d","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        special charecters, like \u0027.\u0027, it will need to be quoted (with double"},{"line_number":297,"context_line":"        or single quotes) like so::"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"         \"payload.image_meta.\u0027org.openstack__1__architecture\u0027\""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        The syntax used for the field specification is a variant of JSONPath,"},{"line_number":302,"context_line":"        and is fairly flexible."}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_4d71e90a","line":299,"updated":"2014-06-05 18:25:11.000000000","message":"nit: only one single space indentation?","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"da3ee10324df1f01ad3908300e870081fca90a5f","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        special charecters, like \u0027.\u0027, it will need to be quoted (with double"},{"line_number":297,"context_line":"        or single quotes) like so::"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"         \"payload.image_meta.\u0027org.openstack__1__architecture\u0027\""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        The syntax used for the field specification is a variant of JSONPath,"},{"line_number":302,"context_line":"        and is fairly flexible."}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_b608fa28","line":299,"in_reply_to":"1ae5cdf2_4d71e90a","updated":"2014-06-05 20:16:15.000000000","message":"This is how Sphinx identifies this module and formats it in another way than plain text. Please check the output of the doc generator job.","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ef628a52c35858a1e32ffbe5720a573929f555d","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        value for the trait will be derived from the matching fields that"},{"line_number":306,"context_line":"        exist and have a non-null (i.e. is not None) values in the"},{"line_number":307,"context_line":"        notification."},{"line_number":308,"context_line":"        By default the value will be the first such field. (plugins can alter"},{"line_number":309,"context_line":"        that, if they wish)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        This configuration value is normally a string, for convenience, it can"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_8d9bf116","line":308,"updated":"2014-06-05 18:25:11.000000000","message":"-1: either to be a new paragraph, or append it to the previous line","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"da3ee10324df1f01ad3908300e870081fca90a5f","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        value for the trait will be derived from the matching fields that"},{"line_number":306,"context_line":"        exist and have a non-null (i.e. is not None) values in the"},{"line_number":307,"context_line":"        notification."},{"line_number":308,"context_line":"        By default the value will be the first such field. (plugins can alter"},{"line_number":309,"context_line":"        that, if they wish)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        This configuration value is normally a string, for convenience, it can"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_f6152240","line":308,"in_reply_to":"1ae5cdf2_8d9bf116","updated":"2014-06-05 20:16:15.000000000","message":"Sphinx appends it.","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ef628a52c35858a1e32ffbe5720a573929f555d","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        This configuration value is normally a string, for convenience, it can"},{"line_number":312,"context_line":"        be specified as a list of specifications, which will be OR\u0027ed together"},{"line_number":313,"context_line":"        (a union query in jsonpath terms)"},{"line_number":314,"context_line":"    - plugin (optional): (dictionary) with the following keys:"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"      - name: (string) name of a plugin to load"},{"line_number":317,"context_line":"      - parameters: (optional) Dictionary of keyword args to pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_0d87e1b5","line":314,"updated":"2014-06-05 18:25:11.000000000","message":"nit: a blank line before this line can be nicer","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"da3ee10324df1f01ad3908300e870081fca90a5f","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        This configuration value is normally a string, for convenience, it can"},{"line_number":312,"context_line":"        be specified as a list of specifications, which will be OR\u0027ed together"},{"line_number":313,"context_line":"        (a union query in jsonpath terms)"},{"line_number":314,"context_line":"    - plugin (optional): (dictionary) with the following keys:"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"      - name: (string) name of a plugin to load"},{"line_number":317,"context_line":"      - parameters: (optional) Dictionary of keyword args to pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_b6a47a08","line":314,"in_reply_to":"1ae5cdf2_0d87e1b5","updated":"2014-06-05 20:16:15.000000000","message":"There is quite big line space between the list items in the generated doc. Please check.","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ef628a52c35858a1e32ffbe5720a573929f555d","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        to the plugin on initialization. See documentation on each plugin to"},{"line_number":319,"context_line":"        see what arguments it accepts."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"      For convenience, this value can also be specified as a"},{"line_number":322,"context_line":"      string, which is interpreted as a plugin name, which will"},{"line_number":323,"context_line":"      be loaded with no parameters."},{"line_number":324,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_cd6fb9fa","line":321,"updated":"2014-06-05 18:25:11.000000000","message":"nit: any reason why this paragraph column width is so small?","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"da3ee10324df1f01ad3908300e870081fca90a5f","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        to the plugin on initialization. See documentation on each plugin to"},{"line_number":319,"context_line":"        see what arguments it accepts."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"      For convenience, this value can also be specified as a"},{"line_number":322,"context_line":"      string, which is interpreted as a plugin name, which will"},{"line_number":323,"context_line":"      be loaded with no parameters."},{"line_number":324,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_b6f2ba03","line":321,"in_reply_to":"1ae5cdf2_cd6fb9fa","updated":"2014-06-05 20:16:15.000000000","message":"I forgot to adapt it to the max line length, but it also does not matter from the output\u0027s PoV. The generated html output will use the available width, as it will not be registered in neither the .rst nor the .html output files that how long are the lines here.","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"451cdcdc464eff6434b9e86b3a857f92d82af017","unresolved":false,"context_lines":[{"line_number":264,"context_line":"      This item can also be a string, which will be taken as equivalent to 1"},{"line_number":265,"context_line":"      item list."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"                Examples:"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"                * [\u0027compute.instance.exists\u0027] will only match"},{"line_number":270,"context_line":"                  compute.intance.exists notifications"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_17795efc","line":267,"updated":"2014-06-09 13:45:32.000000000","message":"double colon?","commit_id":"6abf258b36f3cb4467fc79eba0916bd0d766985a"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"383b9bfda40bd5990b821c293ee1a915708b7477","unresolved":false,"context_lines":[{"line_number":264,"context_line":"      This item can also be a string, which will be taken as equivalent to 1"},{"line_number":265,"context_line":"      item list."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"                Examples:"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"                * [\u0027compute.instance.exists\u0027] will only match"},{"line_number":270,"context_line":"                  compute.intance.exists notifications"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_9a5d934b","line":267,"in_reply_to":"1ae5cdf2_17795efc","updated":"2014-06-09 14:20:27.000000000","message":"I do not think that we should highlight this with an extra box. The generated output looks fine I think.","commit_id":"6abf258b36f3cb4467fc79eba0916bd0d766985a"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5ceddd1e4d8ea8cf39e036679182bad86de9201f","unresolved":false,"context_lines":[{"line_number":264,"context_line":"      This item can also be a string, which will be taken as equivalent to 1"},{"line_number":265,"context_line":"      item list."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"                Examples:"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"                * [\u0027compute.instance.exists\u0027] will only match"},{"line_number":270,"context_line":"                  compute.intance.exists notifications"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_a6ab1ad5","line":267,"in_reply_to":"1ae5cdf2_9a5d934b","updated":"2014-06-09 15:29:31.000000000","message":"ok. it seems better to use double colon to be consistent with other changes but not a blocker for me.","commit_id":"6abf258b36f3cb4467fc79eba0916bd0d766985a"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"e28b5ec24df8bedd2fba91fcc078b5c29b291f13","unresolved":false,"context_lines":[{"line_number":264,"context_line":"      This item can also be a string, which will be taken as equivalent to 1"},{"line_number":265,"context_line":"      item list."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"                Examples:"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"                * [\u0027compute.instance.exists\u0027] will only match"},{"line_number":270,"context_line":"                  compute.intance.exists notifications"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_06120eb4","line":267,"in_reply_to":"1ae5cdf2_a6ab1ad5","updated":"2014-06-09 15:55:51.000000000","message":"I usually used double colon for those examples, which includes on link or a fewlines of config, but not for those that contain more text, than other stuff. Here this looks better as a simple bullet point list I think, but we can argue about this, when I upload a \u0027fix cosmetics of source code doc\u0027 patch. :)","commit_id":"6abf258b36f3cb4467fc79eba0916bd0d766985a"}],"ceilometer/event/trait_plugins.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ef628a52c35858a1e32ffbe5720a573929f555d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        appropriate type for the trait."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        :param match_list: A list (may be empty if no matches) of *tuples*."},{"line_number":55,"context_line":"          Each tuple is (field_path, value) where field_path is the jsonpath"},{"line_number":56,"context_line":"          for that specific field."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        Example::"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_90886672","line":55,"updated":"2014-06-05 18:25:11.000000000","message":"nit: one single space indentation?","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"da3ee10324df1f01ad3908300e870081fca90a5f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        appropriate type for the trait."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        :param match_list: A list (may be empty if no matches) of *tuples*."},{"line_number":55,"context_line":"          Each tuple is (field_path, value) where field_path is the jsonpath"},{"line_number":56,"context_line":"          for that specific field."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        Example::"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_960bfed4","line":55,"in_reply_to":"1ae5cdf2_90886672","updated":"2014-06-05 20:16:15.000000000","message":"Sphinx needs two.","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ef628a52c35858a1e32ffbe5720a573929f555d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            notification body:"},{"line_number":64,"context_line":"                        {"},{"line_number":65,"context_line":"                            \u0027message_id\u0027: \u002712345\u0027,"},{"line_number":66,"context_line":"                            \u0027publisher\u0027:    \u0027someservice.host\u0027,"},{"line_number":67,"context_line":"                            \u0027payload\u0027:  {"},{"line_number":68,"context_line":"                                            \u0027foobar\u0027: \u0027test\u0027,"},{"line_number":69,"context_line":"                                            \u0027thing\u0027:    {"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_f04d2a3f","line":66,"updated":"2014-06-05 18:25:11.000000000","message":"-1: if this is a json example, please correct the format, at least the space and indentation are ugly","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"da3ee10324df1f01ad3908300e870081fca90a5f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            notification body:"},{"line_number":64,"context_line":"                        {"},{"line_number":65,"context_line":"                            \u0027message_id\u0027: \u002712345\u0027,"},{"line_number":66,"context_line":"                            \u0027publisher\u0027:    \u0027someservice.host\u0027,"},{"line_number":67,"context_line":"                            \u0027payload\u0027:  {"},{"line_number":68,"context_line":"                                            \u0027foobar\u0027: \u0027test\u0027,"},{"line_number":69,"context_line":"                                            \u0027thing\u0027:    {"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_16cc4e88","line":66,"in_reply_to":"1ae5cdf2_f04d2a3f","updated":"2014-06-05 20:16:15.000000000","message":"I\u0027m mostly correcting here only the formatting issues, because of which Shinx could not generate the autodoc, besides a few nits, like dot instead of comma, where I recognize. I can remove the spaces in the next patch set, there is no more I can do for this part now.","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ef628a52c35858a1e32ffbe5720a573929f555d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        .. code-block:: python"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"          class DefaultPlugin(TraitPluginBase):"},{"line_number":84,"context_line":"              \"Plugin that returns the first field value\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"              def __init__(self, **kw):"},{"line_number":87,"context_line":"                  super(DefaultPlugin, self).__init__()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_900b06d5","line":84,"updated":"2014-06-05 18:25:11.000000000","message":"tiny nit: as an example, add a dot after value...............","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"da3ee10324df1f01ad3908300e870081fca90a5f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        .. code-block:: python"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"          class DefaultPlugin(TraitPluginBase):"},{"line_number":84,"context_line":"              \"Plugin that returns the first field value\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"              def __init__(self, **kw):"},{"line_number":87,"context_line":"                  super(DefaultPlugin, self).__init__()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_76b912cb","line":84,"in_reply_to":"1ae5cdf2_900b06d5","updated":"2014-06-05 20:16:15.000000000","message":"I think the point here is on the source code part, but no worries, I will add a dot. ;)","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"}],"ceilometer/network/statistics/opencontrail/driver.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ef628a52c35858a1e32ffbe5720a573929f555d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"      This is username used by Opencontrail Analytics.(default None)"},{"line_number":42,"context_line":"    * password:"},{"line_number":43,"context_line":"      This is password used by Opencontrail Analytics.(default None)"},{"line_number":44,"context_line":"    * domain"},{"line_number":45,"context_line":"      This is domain used by Opencontrail Analytics.(default None)"},{"line_number":46,"context_line":"    * verify_ssl"},{"line_number":47,"context_line":"      Specify if the certificate will be checked for https request."}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_90d94659","line":44,"updated":"2014-06-05 18:25:11.000000000","message":"tiny nit: : after domain, like others","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"da3ee10324df1f01ad3908300e870081fca90a5f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"      This is username used by Opencontrail Analytics.(default None)"},{"line_number":42,"context_line":"    * password:"},{"line_number":43,"context_line":"      This is password used by Opencontrail Analytics.(default None)"},{"line_number":44,"context_line":"    * domain"},{"line_number":45,"context_line":"      This is domain used by Opencontrail Analytics.(default None)"},{"line_number":46,"context_line":"    * verify_ssl"},{"line_number":47,"context_line":"      Specify if the certificate will be checked for https request."}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_762e72fc","line":44,"in_reply_to":"1ae5cdf2_90d94659","updated":"2014-06-05 20:16:15.000000000","message":"Done","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ef628a52c35858a1e32ffbe5720a573929f555d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      This is password used by Opencontrail Analytics.(default None)"},{"line_number":44,"context_line":"    * domain"},{"line_number":45,"context_line":"      This is domain used by Opencontrail Analytics.(default None)"},{"line_number":46,"context_line":"    * verify_ssl"},{"line_number":47,"context_line":"      Specify if the certificate will be checked for https request."},{"line_number":48,"context_line":"      (default false)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_b0dc8247","line":46,"updated":"2014-06-05 18:25:11.000000000","message":"tiny nit: ditto","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"da3ee10324df1f01ad3908300e870081fca90a5f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      This is password used by Opencontrail Analytics.(default None)"},{"line_number":44,"context_line":"    * domain"},{"line_number":45,"context_line":"      This is domain used by Opencontrail Analytics.(default None)"},{"line_number":46,"context_line":"    * verify_ssl"},{"line_number":47,"context_line":"      Specify if the certificate will be checked for https request."},{"line_number":48,"context_line":"      (default false)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_d637464b","line":46,"in_reply_to":"1ae5cdf2_b0dc8247","updated":"2014-06-05 20:16:15.000000000","message":"Done","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ef628a52c35858a1e32ffbe5720a573929f555d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      Specify if the certificate will be checked for https request."},{"line_number":48,"context_line":"      (default false)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    e.g.:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"      opencontrail://localhost:8143/?username\u003dadmin\u0026password\u003dadmin\u0026"},{"line_number":53,"context_line":"      scheme\u003dhttps\u0026domain\u003d\u0026verify_ssl\u003dtrue"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_101e160c","line":50,"updated":"2014-06-05 18:25:11.000000000","message":"tiny nit: want to quoted? double ::?","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"da3ee10324df1f01ad3908300e870081fca90a5f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      Specify if the certificate will be checked for https request."},{"line_number":48,"context_line":"      (default false)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    e.g.:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"      opencontrail://localhost:8143/?username\u003dadmin\u0026password\u003dadmin\u0026"},{"line_number":53,"context_line":"      scheme\u003dhttps\u0026domain\u003d\u0026verify_ssl\u003dtrue"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_76075282","line":50,"in_reply_to":"1ae5cdf2_101e160c","updated":"2014-06-05 20:16:15.000000000","message":"Done","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"}],"ceilometer/network/statistics/opendaylight/driver.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ef628a52c35858a1e32ffbe5720a573929f555d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      Name of container of OpenDaylight.(default \"default\")"},{"line_number":73,"context_line":"      This parameter allows multi vaues."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    e.g.:"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"      opendaylight://127.0.0.1:8080/controller/nb/v2?container_name\u003ddefault\u0026"},{"line_number":78,"context_line":"      container_name\u003degg\u0026auth\u003dbasic\u0026user\u003dadmin\u0026password\u003dadmin\u0026scheme\u003dhttp"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_10cc5688","line":75,"updated":"2014-06-05 18:25:11.000000000","message":"tiny nit: double ::?","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"da3ee10324df1f01ad3908300e870081fca90a5f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      Name of container of OpenDaylight.(default \"default\")"},{"line_number":73,"context_line":"      This parameter allows multi vaues."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    e.g.:"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"      opendaylight://127.0.0.1:8080/controller/nb/v2?container_name\u003ddefault\u0026"},{"line_number":78,"context_line":"      container_name\u003degg\u0026auth\u003dbasic\u0026user\u003dadmin\u0026password\u003dadmin\u0026scheme\u003dhttp"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_36486acb","line":75,"in_reply_to":"1ae5cdf2_10cc5688","updated":"2014-06-05 20:16:15.000000000","message":"Done","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ef628a52c35858a1e32ffbe5720a573929f555d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      opendaylight://127.0.0.1:8080/controller/nb/v2?container_name\u003ddefault\u0026"},{"line_number":78,"context_line":"      container_name\u003degg\u0026auth\u003dbasic\u0026user\u003dadmin\u0026password\u003dadmin\u0026scheme\u003dhttp"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"      In this case, the driver send request to below URL:"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        http://127.0.0.1:8080/controller/nb/v2/statistics/default/flow and"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_90a786bc","line":80,"updated":"2014-06-05 18:25:11.000000000","message":"tiny nit: ditto","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"da3ee10324df1f01ad3908300e870081fca90a5f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      opendaylight://127.0.0.1:8080/controller/nb/v2?container_name\u003ddefault\u0026"},{"line_number":78,"context_line":"      container_name\u003degg\u0026auth\u003dbasic\u0026user\u003dadmin\u0026password\u003dadmin\u0026scheme\u003dhttp"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"      In this case, the driver send request to below URL:"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        http://127.0.0.1:8080/controller/nb/v2/statistics/default/flow and"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_f628c2e3","line":80,"in_reply_to":"1ae5cdf2_90a786bc","updated":"2014-06-05 20:16:15.000000000","message":"These two links appear as links in the doc, so it does not need any additional formatting here.","commit_id":"44cbbd248791d289c3c48d1a842510f753e4cde9"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"94afcffe7ebf2f90c394447abb39aec501967148","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    In this case, the driver send request to below URLs:"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"      http://127.0.0.1:8080/controller/nb/v2/statistics/default/flow"},{"line_number":83,"context_line":"      http://127.0.0.1:8080/controller/nb/v2/statistics/egg/flow"},{"line_number":84,"context_line":"    \"\"\""},{"line_number":85,"context_line":"    @staticmethod"},{"line_number":86,"context_line":"    def _prepare_cache(endpoint, params, cache):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_ee01b9af","line":83,"updated":"2014-06-06 09:37:49.000000000","message":"nit: the two link will be in single line with only one space in html doc, is that ok?","commit_id":"6abf258b36f3cb4467fc79eba0916bd0d766985a"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"8945192645c490834be3b530cab0b6b47006275d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    In this case, the driver send request to below URLs:"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"      http://127.0.0.1:8080/controller/nb/v2/statistics/default/flow"},{"line_number":83,"context_line":"      http://127.0.0.1:8080/controller/nb/v2/statistics/egg/flow"},{"line_number":84,"context_line":"    \"\"\""},{"line_number":85,"context_line":"    @staticmethod"},{"line_number":86,"context_line":"    def _prepare_cache(endpoint, params, cache):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_7b5c847d","line":83,"in_reply_to":"1ae5cdf2_1b08e0d8","updated":"2014-06-06 11:45:08.000000000","message":"They are not that close, there is enough space between those two lines, so IMHO it is not an issue, there are bigger issues regarindg to the formatting of the output. But if you don\u0027t like especially this one, then you can propose a change in another patch set.","commit_id":"6abf258b36f3cb4467fc79eba0916bd0d766985a"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"9d268c3681c6fec63f35f5fc78bdf8f0c1d32dea","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    In this case, the driver send request to below URLs:"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"      http://127.0.0.1:8080/controller/nb/v2/statistics/default/flow"},{"line_number":83,"context_line":"      http://127.0.0.1:8080/controller/nb/v2/statistics/egg/flow"},{"line_number":84,"context_line":"    \"\"\""},{"line_number":85,"context_line":"    @staticmethod"},{"line_number":86,"context_line":"    def _prepare_cache(endpoint, params, cache):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_1b08e0d8","line":83,"in_reply_to":"1ae5cdf2_d853dedf","updated":"2014-06-06 11:32:31.000000000","message":"do you mean they will not be one url? then that is right, but they are so close to each other in one line, which seems a bit odd. http://docs-draft.openstack.org/68/97268/6/check/gate-ceilometer-docs/9bc04a6/doc/build/html/sourcecode/ceilometer/ceilometer.network.statistics.opendaylight.driver.html\n\nhow about change the two links to ul list (bullet?), then they are close to each other in docstring and will be seperate in html file?","commit_id":"6abf258b36f3cb4467fc79eba0916bd0d766985a"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"3165615501af40efa410ca75191973ff612108de","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    In this case, the driver send request to below URLs:"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"      http://127.0.0.1:8080/controller/nb/v2/statistics/default/flow"},{"line_number":83,"context_line":"      http://127.0.0.1:8080/controller/nb/v2/statistics/egg/flow"},{"line_number":84,"context_line":"    \"\"\""},{"line_number":85,"context_line":"    @staticmethod"},{"line_number":86,"context_line":"    def _prepare_cache(endpoint, params, cache):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_d853dedf","line":83,"in_reply_to":"1ae5cdf2_ee01b9af","updated":"2014-06-06 11:01:38.000000000","message":"Actually these two lines are not concatenated into one, so it is not a problem here. Please check the generated doc.","commit_id":"6abf258b36f3cb4467fc79eba0916bd0d766985a"}],"ceilometer/openstack/common/db/sqlalchemy/session.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"56c16112117c9382902e25541a7e4f00dda6e776","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  Examples:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  .. code-block:: python"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def get_foo(context, foo):"},{"line_number":39,"context_line":"        return (model_query(context, models.Foo)."}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_77038273","line":36,"updated":"2014-06-09 13:43:25.000000000","message":"this is common code. maybe we should skip this as well","commit_id":"6abf258b36f3cb4467fc79eba0916bd0d766985a"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"e28b5ec24df8bedd2fba91fcc078b5c29b291f13","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  Examples:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  .. code-block:: python"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def get_foo(context, foo):"},{"line_number":39,"context_line":"        return (model_query(context, models.Foo)."}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_06604e34","line":36,"in_reply_to":"1ae5cdf2_6673d2b1","updated":"2014-06-09 15:55:51.000000000","message":"Hmm, I thought it is enough to include a reference to the patch in the commit message. This wouldn\u0027t be the first patch, where oslo-incubator changes are mixed with others, but anyway, I will propose a new patch with only this change.","commit_id":"6abf258b36f3cb4467fc79eba0916bd0d766985a"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"383b9bfda40bd5990b821c293ee1a915708b7477","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  Examples:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  .. code-block:: python"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def get_foo(context, foo):"},{"line_number":39,"context_line":"        return (model_query(context, models.Foo)."}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_9aaf532b","line":36,"in_reply_to":"1ae5cdf2_77038273","updated":"2014-06-09 14:20:27.000000000","message":"The patch that fixes this in oslo-incubator is already merged.","commit_id":"6abf258b36f3cb4467fc79eba0916bd0d766985a"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5ceddd1e4d8ea8cf39e036679182bad86de9201f","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  Examples:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  .. code-block:: python"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def get_foo(context, foo):"},{"line_number":39,"context_line":"        return (model_query(context, models.Foo)."}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_6673d2b1","line":36,"in_reply_to":"1ae5cdf2_9aaf532b","updated":"2014-06-09 15:29:31.000000000","message":"we should put this in a separate patch so it\u0027s easier to track","commit_id":"6abf258b36f3cb4467fc79eba0916bd0d766985a"}]}