)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"8fec6100e68d2d2f7c0de61d3c738355cc3b4774","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ac175f54_0294a2c5","updated":"2026-01-20 23:18:31.000000000","message":"The rgw_service_name config option and the part inside the \"if\" was added later than the rest of the code. The rgw_service_name is None by default and it\u0027ll be None for users updating from previous versions of ceilometer. I wonder what will happen in that case?\n\nSo when the service type is set, but the service name is None, will it still find the service by the service type as before?","commit_id":"ff4a598ab51a77d41950952f27c4f0de6b79f00d"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"bca6f01a25de8c8ef0ec3f5bcdf0ab1aa2374dfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f8574b02_95abd0cb","in_reply_to":"ac175f54_0294a2c5","updated":"2026-01-21 18:57:40.000000000","message":"Yes! The service_name and the service_type are filters. SO if one of them is None, it is ignore. This review was split from https://review.opendev.org/c/openstack/ceilometer/+/973302/, where I\u0027ve also added some unit tests to ensure the expected behaviour from ServiceCatalogV3.get_url() and ServiceCatalogV3.url_for().\n\nBefore I split it, I also left a comment in the original comment with the expected behaviour: https://review.opendev.org/c/openstack/ceilometer/+/973302/comment/3e95f5ad_dca47418/","commit_id":"ff4a598ab51a77d41950952f27c4f0de6b79f00d"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"509f17790672858db243a77e0be070c2b79ba75d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6e18f44f_b2279fe3","in_reply_to":"f8574b02_95abd0cb","updated":"2026-01-22 08:29:06.000000000","message":"Also the original code tried to deal with a situation where we have 2 different services of the same service type in keystone at once. Something like:\n```\n- service_type: radosgw; service_name: radosgw\n- service_type: radosgw; service_name: swift\n```\nIn which case the service name should be the deciding parameter. But I\u0027m pretty sure that\u0027s how querying keystone works.\n\nSo once the relation chain isn\u0027t WIP, this patch LGTM.","commit_id":"ff4a598ab51a77d41950952f27c4f0de6b79f00d"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"8e24b56ccf7ef20e0b20431a368995c107ce125f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fc5a8afc_f33ad9a0","updated":"2026-02-13 16:19:12.000000000","message":"recheck","commit_id":"97ad60c27c5a4b3d44d67bd8925852b9572a2df7"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"d3ceb7a2f22598cec3dd1b1c769005d49022fb88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a3f79e28_4a4e05f5","updated":"2026-02-27 19:59:24.000000000","message":"recheck\n\nCheck that the CI issues from this week are cleared","commit_id":"97ad60c27c5a4b3d44d67bd8925852b9572a2df7"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"76f695472292bc6267236ee2564dbcb7a8f8856c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8f8fe39a_375289f4","updated":"2026-03-04 08:53:45.000000000","message":"LGTM, we can merge it, but this\u0027ll wait until the Depends-On merges first.","commit_id":"864e5ad5200f8278231f0785e7c1267a93764167"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"f7e83c1a7913f66c73eaffceb88aabe37a4cfa7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f415cd3a_fbb3657e","updated":"2026-03-10 17:07:16.000000000","message":"recheck docs job hit an OSError reading some files","commit_id":"d3c8ae0842167f490c876fac763d170ede5c4a1e"}]}