)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"87c98fa4be41ed5758bdaf7d7c91e3b207d89d7a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"scenarios."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch moves the _convert_storage_trait method from"},{"line_number":15,"context_line":"Event class to Trait class, since the method closer to Trait model."},{"line_number":16,"context_line":"And uses it to properly initialize the trait object."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia7bf667967a31a3cc6e8d457f3b6330ffc728471"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_c4dc30e7","line":15,"updated":"2014-06-04 10:19:00.000000000","message":"I don\u0027t see the event class changed into the patch, the file is missing or the commit message is not up to date ?","commit_id":"82b2e11cd2fe9dbfb843ac47fef5b36ee7a6e04d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"a59a57905fe9d53d957d010cbf5d3e72ac82b608","unresolved":false,"context_lines":[{"line_number":12,"context_line":"scenarios."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch moves the _convert_storage_trait method from"},{"line_number":15,"context_line":"Event class to Trait class, since the method closer to Trait model."},{"line_number":16,"context_line":"And uses it to properly initialize the trait object."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia7bf667967a31a3cc6e8d457f3b6330ffc728471"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_38da544c","line":15,"in_reply_to":"1ae5cdf2_4433c013","updated":"2014-06-04 10:33:38.000000000","message":"Sorry my bad, I have mix the Event Class in API and the one in event part.","commit_id":"82b2e11cd2fe9dbfb843ac47fef5b36ee7a6e04d"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"f982af0494cf026bf260a92defe68e338b6abd28","unresolved":false,"context_lines":[{"line_number":12,"context_line":"scenarios."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch moves the _convert_storage_trait method from"},{"line_number":15,"context_line":"Event class to Trait class, since the method closer to Trait model."},{"line_number":16,"context_line":"And uses it to properly initialize the trait object."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia7bf667967a31a3cc6e8d457f3b6330ffc728471"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_4433c013","line":15,"in_reply_to":"1ae5cdf2_c4dc30e7","updated":"2014-06-04 10:24:07.000000000","message":"My English is not good, so maybe the commit message is misleading.\n\nWhat I mean is I delete the _convert_storage_trait in the Event class, then add it to the Trait class, because this static method is much closer to Trait\n\nThanks for your review","commit_id":"82b2e11cd2fe9dbfb843ac47fef5b36ee7a6e04d"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"ef917d7ae9676fe5fcf022b4569b6c54a436e28f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, when we try to get trait, the api service uses storage"},{"line_number":10,"context_line":"data to directly initialize the trait model. However, the trait class"},{"line_number":11,"context_line":"init method expects value field as wsme.text type, while in storage,"},{"line_number":12,"context_line":"it could be int, float, or datetime. So, end user will get 400 error"},{"line_number":13,"context_line":"in such scenarios."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The static method _convert_storage_trait() in Event class can convert"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_00d3d638","line":12,"updated":"2014-06-09 14:59:33.000000000","message":"If it is not difficult, please remove \",\" after float.","commit_id":"f114452363e115dc778afbbb259c7626e1a42152"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"1a66bfc390db8aab6392408859dd06807dbecb0a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, when we try to get trait, the api service uses storage"},{"line_number":10,"context_line":"data to directly initialize the trait model. However, the trait class"},{"line_number":11,"context_line":"init method expects value field as wsme.text type, while in storage,"},{"line_number":12,"context_line":"it could be int, float, or datetime. So, end user will get 400 error"},{"line_number":13,"context_line":"in such scenarios."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The static method _convert_storage_trait() in Event class can convert"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_c558045a","line":12,"in_reply_to":"1ae5cdf2_00d3d638","updated":"2014-06-10 05:00:10.000000000","message":"a long time ago, my friend tells me that my format is correct too, and she shows me an academic paper to prove it. But I didn\u0027t research deeper on this issue since both can be used makes me happy... thanks","commit_id":"f114452363e115dc778afbbb259c7626e1a42152"}]}