)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"0deb6bfd511bd42aa4b726fe8a2625c49de0749b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Alarm default description update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Alarm default description message will be updated automatically"},{"line_number":10,"context_line":"when we update the threshold value."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ida7e4e42b6bbc6e839aaf5f8df3b777107d044c2"},{"line_number":13,"context_line":"Closes-Bug: #1325436"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ae5cdf2_abd66c25","line":10,"updated":"2014-06-10 02:26:19.000000000","message":"nit: s/will/should/\n\n-1: not only threshold value, other related value in threshold type alarm and alarm_ids, operator in combination alarm will affect it too","commit_id":"8390fcfe55a235801914e431b5830e6aa4025105"}],"ceilometer/api/controllers/v2.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"6f849af615ddbeeb2266bd43d49d89aed5558fc6","unresolved":false,"context_lines":[{"line_number":1812,"context_line":"                   repeat_actions\u003dFalse,"},{"line_number":1813,"context_line":"                   )"},{"line_number":1814,"context_line":""},{"line_number":1815,"context_line":"    def as_dict(self, db_model,change_description\u003dFalse):"},{"line_number":1816,"context_line":"        d \u003d super(Alarm, self).as_dict(db_model)"},{"line_number":1817,"context_line":"        for k in d:"},{"line_number":1818,"context_line":"            if k.endswith(\u0027_rule\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_1b1f4509","line":1815,"updated":"2014-06-04 16:26:00.000000000","message":"-1: pep8 will complain that there should be a space between parameters","commit_id":"29ffdc9a44a41351d17779a07d8fa252edc9782a"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"6f849af615ddbeeb2266bd43d49d89aed5558fc6","unresolved":false,"context_lines":[{"line_number":1825,"context_line":"                d[\u0027rule\u0027][\u0027comparison_operator\u0027],"},{"line_number":1826,"context_line":"                d[\u0027rule\u0027][\u0027statistic\u0027],"},{"line_number":1827,"context_line":"                d[\u0027rule\u0027][\u0027threshold\u0027],"},{"line_number":1828,"context_line":"                d[\u0027rule\u0027][\u0027period\u0027]) "},{"line_number":1829,"context_line":"        return d"},{"line_number":1830,"context_line":""},{"line_number":1831,"context_line":"class AlarmChange(_Base):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_bbdbb14d","line":1828,"updated":"2014-06-04 16:26:00.000000000","message":"-1: trailing space should be removed","commit_id":"29ffdc9a44a41351d17779a07d8fa252edc9782a"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"6f849af615ddbeeb2266bd43d49d89aed5558fc6","unresolved":false,"context_lines":[{"line_number":1827,"context_line":"                d[\u0027rule\u0027][\u0027threshold\u0027],"},{"line_number":1828,"context_line":"                d[\u0027rule\u0027][\u0027period\u0027]) "},{"line_number":1829,"context_line":"        return d"},{"line_number":1830,"context_line":""},{"line_number":1831,"context_line":"class AlarmChange(_Base):"},{"line_number":1832,"context_line":"    \"\"\"Representation of an event in an alarm\u0027s history"},{"line_number":1833,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_9b8fd529","line":1830,"updated":"2014-06-04 16:26:00.000000000","message":"-1: pep requires two blank lines between global classes","commit_id":"29ffdc9a44a41351d17779a07d8fa252edc9782a"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"6f849af615ddbeeb2266bd43d49d89aed5558fc6","unresolved":false,"context_lines":[{"line_number":1911,"context_line":"                       project_id\u003dproject_id,"},{"line_number":1912,"context_line":"                       on_behalf_of\u003don_behalf_of,"},{"line_number":1913,"context_line":"                       timestamp\u003dnow)"},{"line_number":1914,"context_line":"        try:"},{"line_number":1915,"context_line":"            self.conn.record_alarm_change(payload)"},{"line_number":1916,"context_line":"        except NotImplementedError:"},{"line_number":1917,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_db85dd07","line":1914,"updated":"2014-06-04 16:26:00.000000000","message":"-1: no necessary to remove the blank line","commit_id":"29ffdc9a44a41351d17779a07d8fa252edc9782a"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"6f849af615ddbeeb2266bd43d49d89aed5558fc6","unresolved":false,"context_lines":[{"line_number":1968,"context_line":"            if self._id in data.combination_rule.alarm_ids:"},{"line_number":1969,"context_line":"                raise ClientSideError(_(\u0027Cannot specify alarm %s itself in \u0027"},{"line_number":1970,"context_line":"                                        \u0027combination rule\u0027) % self._id)"},{"line_number":1971,"context_line":"        "},{"line_number":1972,"context_line":"        old_alarm \u003d Alarm.from_db_model(alarm_in).as_dict(storage.models.Alarm)"},{"line_number":1973,"context_line":"        change_description\u003dFalse"},{"line_number":1974,"context_line":"        default_description\u003d\u0027Alarm when %s is %s a %s of %d.0 over %d seconds\u0027 % \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_1b7bc528","line":1971,"updated":"2014-06-04 16:26:00.000000000","message":"-1: leading spaces are not necessary","commit_id":"29ffdc9a44a41351d17779a07d8fa252edc9782a"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"6f849af615ddbeeb2266bd43d49d89aed5558fc6","unresolved":false,"context_lines":[{"line_number":1976,"context_line":"            old_alarm[\u0027rule\u0027][\u0027comparison_operator\u0027],"},{"line_number":1977,"context_line":"            old_alarm[\u0027rule\u0027][\u0027statistic\u0027],"},{"line_number":1978,"context_line":"            old_alarm[\u0027rule\u0027][\u0027threshold\u0027],"},{"line_number":1979,"context_line":"            old_alarm[\u0027rule\u0027][\u0027period\u0027])\t"},{"line_number":1980,"context_line":"        #checking if previous description was default_description"},{"line_number":1981,"context_line":"        if old_alarm[\u0027description\u0027] \u003d\u003d default_description:"},{"line_number":1982,"context_line":"            #checking if user has not upadted the description and if he is using the default one"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_1ba2e598","line":1979,"updated":"2014-06-04 16:26:00.000000000","message":"-1: tab should be replaced with spaces, and trailing blank characters should be removed","commit_id":"29ffdc9a44a41351d17779a07d8fa252edc9782a"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"6f849af615ddbeeb2266bd43d49d89aed5558fc6","unresolved":false,"context_lines":[{"line_number":1980,"context_line":"        #checking if previous description was default_description"},{"line_number":1981,"context_line":"        if old_alarm[\u0027description\u0027] \u003d\u003d default_description:"},{"line_number":1982,"context_line":"            #checking if user has not upadted the description and if he is using the default one"},{"line_number":1983,"context_line":"            if data.description \u003d\u003d old_alarm[\u0027description\u0027]: "},{"line_number":1984,"context_line":"                change_description\u003dTrue\t\t"},{"line_number":1985,"context_line":"        updated_alarm \u003d data.as_dict(storage.models.Alarm,change_description)"},{"line_number":1986,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_5ba8ed76","line":1983,"updated":"2014-06-04 16:26:00.000000000","message":"-1: ditto","commit_id":"29ffdc9a44a41351d17779a07d8fa252edc9782a"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"6f849af615ddbeeb2266bd43d49d89aed5558fc6","unresolved":false,"context_lines":[{"line_number":1981,"context_line":"        if old_alarm[\u0027description\u0027] \u003d\u003d default_description:"},{"line_number":1982,"context_line":"            #checking if user has not upadted the description and if he is using the default one"},{"line_number":1983,"context_line":"            if data.description \u003d\u003d old_alarm[\u0027description\u0027]: "},{"line_number":1984,"context_line":"                change_description\u003dTrue\t\t"},{"line_number":1985,"context_line":"        updated_alarm \u003d data.as_dict(storage.models.Alarm,change_description)"},{"line_number":1986,"context_line":"        try:"},{"line_number":1987,"context_line":"            alarm_in \u003d storage.models.Alarm(**updated_alarm)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_dbb31de7","line":1984,"updated":"2014-06-04 16:26:00.000000000","message":"-1: ditto","commit_id":"29ffdc9a44a41351d17779a07d8fa252edc9782a"},{"author":{"_account_id":10200,"name":"Christian Martinez","email":"chmartinez35@gmail.com","username":"cmart"},"change_message_id":"a9c1bc9a37398fc1982f8e5c42b13c0b9042764e","unresolved":false,"context_lines":[{"line_number":1981,"context_line":"        if old_alarm[\u0027description\u0027] \u003d\u003d default_description:"},{"line_number":1982,"context_line":"            #checking if user has not upadted the description and if he is using the default one"},{"line_number":1983,"context_line":"            if data.description \u003d\u003d old_alarm[\u0027description\u0027]: "},{"line_number":1984,"context_line":"                change_description\u003dTrue\t\t"},{"line_number":1985,"context_line":"        updated_alarm \u003d data.as_dict(storage.models.Alarm,change_description)"},{"line_number":1986,"context_line":"        try:"},{"line_number":1987,"context_line":"            alarm_in \u003d storage.models.Alarm(**updated_alarm)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_e7ef69af","line":1984,"updated":"2014-06-04 13:03:45.000000000","message":"Please check if pep8 run correctly over this file. I think that you have extra whitespaces and some extra characters (like » ) on lines 1828, 1971, 1979 and 1983-84.","commit_id":"29ffdc9a44a41351d17779a07d8fa252edc9782a"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"6f849af615ddbeeb2266bd43d49d89aed5558fc6","unresolved":false,"context_lines":[{"line_number":1982,"context_line":"            #checking if user has not upadted the description and if he is using the default one"},{"line_number":1983,"context_line":"            if data.description \u003d\u003d old_alarm[\u0027description\u0027]: "},{"line_number":1984,"context_line":"                change_description\u003dTrue\t\t"},{"line_number":1985,"context_line":"        updated_alarm \u003d data.as_dict(storage.models.Alarm,change_description)"},{"line_number":1986,"context_line":"        try:"},{"line_number":1987,"context_line":"            alarm_in \u003d storage.models.Alarm(**updated_alarm)"},{"line_number":1988,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_7bdf690d","line":1985,"updated":"2014-06-04 16:26:00.000000000","message":"-1: pep requires single space between parameters","commit_id":"29ffdc9a44a41351d17779a07d8fa252edc9782a"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"0deb6bfd511bd42aa4b726fe8a2625c49de0749b","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        # output before: a.b:c\u003dd"},{"line_number":584,"context_line":"        # output now: a.b.c\u003dd"},{"line_number":585,"context_line":"        # So to keep the first variant just replace all dots except the first"},{"line_number":586,"context_line":"        return dict((k.replace(\u0027.\u0027, \u0027:\u0027).replace(\u0027:\u0027, \u0027.\u0027, 1), unicode(v))"},{"line_number":587,"context_line":"                    for k, v in utils.recursive_keypairs(metadata,"},{"line_number":588,"context_line":"                                                         separator\u003d\u0027.\u0027)"},{"line_number":589,"context_line":"                    if type(v) is not set)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_ebe074fc","line":586,"updated":"2014-06-10 02:26:19.000000000","message":"-1: should not revert unrelated code","commit_id":"8390fcfe55a235801914e431b5830e6aa4025105"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"f03ccaaa1eda4c000f12ee48a2adea7391c6451a","unresolved":false,"context_lines":[{"line_number":1820,"context_line":"        d[\u0027rule\u0027] \u003d getattr(self, \"%s_rule\" % self.type).as_dict()"},{"line_number":1821,"context_line":"        d[\u0027time_constraints\u0027] \u003d [tc.as_dict() for tc in self.time_constraints]"},{"line_number":1822,"context_line":"        if change_description \u003d\u003d True:"},{"line_number":1823,"context_line":"            d[\u0027description\u0027] \u003d \u0027Alarm when %s is %s a %s of %d.0 over %d seconds\u0027 % \\"},{"line_number":1824,"context_line":"                (d[\u0027rule\u0027][\u0027meter_name\u0027],"},{"line_number":1825,"context_line":"                d[\u0027rule\u0027][\u0027comparison_operator\u0027],"},{"line_number":1826,"context_line":"                d[\u0027rule\u0027][\u0027statistic\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_343c9893","line":1823,"updated":"2014-06-09 13:00:10.000000000","message":"please use the following string formatting here:\n\n\"some string %(s1)s and some string %(s2)s\" % {\u0027s1\u0027: \u0027bla1\u0027, \u0027s2\u0027: \u0027bla2\u0027} - that\u0027s more clear to have self-describing names in the string to be formatted then just %s %s %s %s ... - it\u0027s more readable :)","commit_id":"8390fcfe55a235801914e431b5830e6aa4025105"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"0deb6bfd511bd42aa4b726fe8a2625c49de0749b","unresolved":false,"context_lines":[{"line_number":1820,"context_line":"        d[\u0027rule\u0027] \u003d getattr(self, \"%s_rule\" % self.type).as_dict()"},{"line_number":1821,"context_line":"        d[\u0027time_constraints\u0027] \u003d [tc.as_dict() for tc in self.time_constraints]"},{"line_number":1822,"context_line":"        if change_description \u003d\u003d True:"},{"line_number":1823,"context_line":"            d[\u0027description\u0027] \u003d \u0027Alarm when %s is %s a %s of %d.0 over %d seconds\u0027 % \\"},{"line_number":1824,"context_line":"                (d[\u0027rule\u0027][\u0027meter_name\u0027],"},{"line_number":1825,"context_line":"                d[\u0027rule\u0027][\u0027comparison_operator\u0027],"},{"line_number":1826,"context_line":"                d[\u0027rule\u0027][\u0027statistic\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_abbd8cd9","line":1823,"in_reply_to":"1ae5cdf2_343c9893","updated":"2014-06-10 02:26:19.000000000","message":"nit: since d[\u0027rule\u0027] is already a dict, it should be much easy to follow dina\u0027s idea\n\n-1: doesn\u0027t consider combination alarm scenarios","commit_id":"8390fcfe55a235801914e431b5830e6aa4025105"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"0deb6bfd511bd42aa4b726fe8a2625c49de0749b","unresolved":false,"context_lines":[{"line_number":1973,"context_line":""},{"line_number":1974,"context_line":"        old_alarm \u003d Alarm.from_db_model(alarm_in).as_dict(storage.models.Alarm)"},{"line_number":1975,"context_line":"        change_description\u003dFalse"},{"line_number":1976,"context_line":"        default_description\u003d\u0027Alarm when %s is %s a %s of %d.0 over %d seconds\u0027 % \\"},{"line_number":1977,"context_line":"            (old_alarm[\u0027rule\u0027][\u0027meter_name\u0027],"},{"line_number":1978,"context_line":"            old_alarm[\u0027rule\u0027][\u0027comparison_operator\u0027],"},{"line_number":1979,"context_line":"            old_alarm[\u0027rule\u0027][\u0027statistic\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_cbb018e0","line":1976,"updated":"2014-06-10 02:26:19.000000000","message":"-1: doesn\u0027t consider combination alarm scenarios","commit_id":"8390fcfe55a235801914e431b5830e6aa4025105"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"0deb6bfd511bd42aa4b726fe8a2625c49de0749b","unresolved":false,"context_lines":[{"line_number":1979,"context_line":"            old_alarm[\u0027rule\u0027][\u0027statistic\u0027],"},{"line_number":1980,"context_line":"            old_alarm[\u0027rule\u0027][\u0027threshold\u0027],"},{"line_number":1981,"context_line":"            old_alarm[\u0027rule\u0027][\u0027period\u0027])"},{"line_number":1982,"context_line":"        #checking if previous description was default_description"},{"line_number":1983,"context_line":"        if old_alarm[\u0027description\u0027] \u003d\u003d default_description:"},{"line_number":1984,"context_line":"            #checking if user has not upadted the description and if he is using the default one"},{"line_number":1985,"context_line":"            if data.description \u003d\u003d old_alarm[\u0027description\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_ebea34ab","line":1982,"updated":"2014-06-10 02:26:19.000000000","message":"-1: there should be a space after #","commit_id":"8390fcfe55a235801914e431b5830e6aa4025105"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"0deb6bfd511bd42aa4b726fe8a2625c49de0749b","unresolved":false,"context_lines":[{"line_number":1980,"context_line":"            old_alarm[\u0027rule\u0027][\u0027threshold\u0027],"},{"line_number":1981,"context_line":"            old_alarm[\u0027rule\u0027][\u0027period\u0027])"},{"line_number":1982,"context_line":"        #checking if previous description was default_description"},{"line_number":1983,"context_line":"        if old_alarm[\u0027description\u0027] \u003d\u003d default_description:"},{"line_number":1984,"context_line":"            #checking if user has not upadted the description and if he is using the default one"},{"line_number":1985,"context_line":"            if data.description \u003d\u003d old_alarm[\u0027description\u0027]:"},{"line_number":1986,"context_line":"                change_description\u003dTrue"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_eb86b4da","line":1983,"updated":"2014-06-10 02:26:19.000000000","message":"I remember that when I saw that bug, I test it in devstack with 4 lines fix, here is my solution, but may not be right:\n\n    1. first we get the old alarm from storage, convert it to api model\n    2. check if the old alarm\u0027s description is equal to rule.default_description\n    3. check if new alarm\u0027s description is equal to old description\n    4. set the new default description\n\nthe point is that, the %(type)_rule.default_description can do the dirty job for us.","commit_id":"8390fcfe55a235801914e431b5830e6aa4025105"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"b7f38362243a29fc92f1cbf291278c35c64f90d9","unresolved":false,"context_lines":[{"line_number":1980,"context_line":"            old_alarm[\u0027rule\u0027][\u0027threshold\u0027],"},{"line_number":1981,"context_line":"            old_alarm[\u0027rule\u0027][\u0027period\u0027])"},{"line_number":1982,"context_line":"        #checking if previous description was default_description"},{"line_number":1983,"context_line":"        if old_alarm[\u0027description\u0027] \u003d\u003d default_description:"},{"line_number":1984,"context_line":"            #checking if user has not upadted the description and if he is using the default one"},{"line_number":1985,"context_line":"            if data.description \u003d\u003d old_alarm[\u0027description\u0027]:"},{"line_number":1986,"context_line":"                change_description\u003dTrue"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_5735a644","line":1983,"updated":"2014-06-09 13:44:39.000000000","message":"I think \"if exp1 or exp2:\" will be more clearer than \n\"if exp:\n     if exp:\"","commit_id":"8390fcfe55a235801914e431b5830e6aa4025105"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"0deb6bfd511bd42aa4b726fe8a2625c49de0749b","unresolved":false,"context_lines":[{"line_number":1981,"context_line":"            old_alarm[\u0027rule\u0027][\u0027period\u0027])"},{"line_number":1982,"context_line":"        #checking if previous description was default_description"},{"line_number":1983,"context_line":"        if old_alarm[\u0027description\u0027] \u003d\u003d default_description:"},{"line_number":1984,"context_line":"            #checking if user has not upadted the description and if he is using the default one"},{"line_number":1985,"context_line":"            if data.description \u003d\u003d old_alarm[\u0027description\u0027]:"},{"line_number":1986,"context_line":"                change_description\u003dTrue"},{"line_number":1987,"context_line":"        updated_alarm \u003d data.as_dict(storage.models.Alarm, change_description)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_2bcc1c61","line":1984,"updated":"2014-06-10 02:26:19.000000000","message":"-1: there should be a space after #","commit_id":"8390fcfe55a235801914e431b5830e6aa4025105"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"b7f38362243a29fc92f1cbf291278c35c64f90d9","unresolved":false,"context_lines":[{"line_number":1981,"context_line":"            old_alarm[\u0027rule\u0027][\u0027period\u0027])"},{"line_number":1982,"context_line":"        #checking if previous description was default_description"},{"line_number":1983,"context_line":"        if old_alarm[\u0027description\u0027] \u003d\u003d default_description:"},{"line_number":1984,"context_line":"            #checking if user has not upadted the description and if he is using the default one"},{"line_number":1985,"context_line":"            if data.description \u003d\u003d old_alarm[\u0027description\u0027]:"},{"line_number":1986,"context_line":"                change_description\u003dTrue"},{"line_number":1987,"context_line":"        updated_alarm \u003d data.as_dict(storage.models.Alarm, change_description)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_d7ac568f","line":1984,"range":{"start_line":1984,"start_character":38,"end_line":1984,"end_character":45},"updated":"2014-06-09 13:44:39.000000000","message":"I think there is typo here. %s/upadted/updated","commit_id":"8390fcfe55a235801914e431b5830e6aa4025105"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"9f3fd37cac256548d9823f2394c29183546bb053","unresolved":false,"context_lines":[{"line_number":1822,"context_line":"        d[\u0027rule\u0027] \u003d getattr(self, \"%s_rule\" % self.type).as_dict()"},{"line_number":1823,"context_line":"        d[\u0027time_constraints\u0027] \u003d [tc.as_dict() for tc in self.time_constraints]"},{"line_number":1824,"context_line":"        if change_description is True:"},{"line_number":1825,"context_line":"            d[\u0027description\u0027] \u003d \\"},{"line_number":1826,"context_line":"                \u0027Alarm when %(meter_name)s is %(comparison_operator)s a \u0027 \\"},{"line_number":1827,"context_line":"                \u0027%(statistic)s of %(threshold)s over %(period)s seconds\u0027 % \\"},{"line_number":1828,"context_line":"                {\u0027meter_name\u0027: d[\u0027rule\u0027][\u0027meter_name\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_c4c0cde2","line":1825,"updated":"2014-07-03 09:27:28.000000000","message":"Please wrap long lines in parentheses instead of a backslash","commit_id":"6475bffc24b6f1819e61637b5d31477f49600b7a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"8b012b6b0e7e4cbb6388b9e3aa8fe8e513cb2c5a","unresolved":false,"context_lines":[{"line_number":1823,"context_line":"        d[\u0027time_constraints\u0027] \u003d [tc.as_dict() for tc in self.time_constraints]"},{"line_number":1824,"context_line":"        if change_description is True:"},{"line_number":1825,"context_line":"            d[\u0027description\u0027] \u003d \\"},{"line_number":1826,"context_line":"                \u0027Alarm when %(meter_name)s is %(comparison_operator)s a \u0027 \\"},{"line_number":1827,"context_line":"                \u0027%(statistic)s of %(threshold)s over %(period)s seconds\u0027 % \\"},{"line_number":1828,"context_line":"                {\u0027meter_name\u0027: d[\u0027rule\u0027][\u0027meter_name\u0027],"},{"line_number":1829,"context_line":"                 \u0027comparison_operator\u0027: d[\u0027rule\u0027][\u0027comparison_operator\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_a1f8527d","line":1826,"updated":"2014-07-02 12:22:52.000000000","message":"Maybe it should to used with _(%s) and may be translated?","commit_id":"6475bffc24b6f1819e61637b5d31477f49600b7a"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"7c6b3fcc2dac9d3ca5b798d98fe0e7e86f78b0b9","unresolved":false,"context_lines":[{"line_number":1823,"context_line":"        d[\u0027time_constraints\u0027] \u003d [tc.as_dict() for tc in self.time_constraints]"},{"line_number":1824,"context_line":"        if change_description is True:"},{"line_number":1825,"context_line":"            d[\u0027description\u0027] \u003d \\"},{"line_number":1826,"context_line":"                \u0027Alarm when %(meter_name)s is %(comparison_operator)s a \u0027 \\"},{"line_number":1827,"context_line":"                \u0027%(statistic)s of %(threshold)s over %(period)s seconds\u0027 % \\"},{"line_number":1828,"context_line":"                {\u0027meter_name\u0027: d[\u0027rule\u0027][\u0027meter_name\u0027],"},{"line_number":1829,"context_line":"                 \u0027comparison_operator\u0027: d[\u0027rule\u0027][\u0027comparison_operator\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_4bc0507c","line":1826,"in_reply_to":"baada198_a1f8527d","updated":"2014-07-03 07:45:33.000000000","message":"no... this should be not the _(%s) but _(all string without the strings inserting %s) % bla - if it\u0027s needed to translate the desc, and I\u0027m not really sure that should happen.","commit_id":"6475bffc24b6f1819e61637b5d31477f49600b7a"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"9f3fd37cac256548d9823f2394c29183546bb053","unresolved":false,"context_lines":[{"line_number":1978,"context_line":"        old_alarm \u003d Alarm.from_db_model(alarm_in).as_dict(storage.models.Alarm)"},{"line_number":1979,"context_line":"        change_description \u003d False"},{"line_number":1980,"context_line":"        if data.type \u003d\u003d \u0027threshold\u0027:"},{"line_number":1981,"context_line":"            default_description \u003d \\"},{"line_number":1982,"context_line":"                \u0027Alarm when %(meter_name)s is %(comparison_operator)s a \u0027 \\"},{"line_number":1983,"context_line":"                \u0027%(statistic)s of %(threshold)s over %(period)s seconds\u0027 % \\"},{"line_number":1984,"context_line":"                {\u0027meter_name\u0027: old_alarm[\u0027rule\u0027][\u0027meter_name\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_a4bd996a","line":1981,"updated":"2014-07-03 09:27:28.000000000","message":"ditto","commit_id":"6475bffc24b6f1819e61637b5d31477f49600b7a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"8b012b6b0e7e4cbb6388b9e3aa8fe8e513cb2c5a","unresolved":false,"context_lines":[{"line_number":1979,"context_line":"        change_description \u003d False"},{"line_number":1980,"context_line":"        if data.type \u003d\u003d \u0027threshold\u0027:"},{"line_number":1981,"context_line":"            default_description \u003d \\"},{"line_number":1982,"context_line":"                \u0027Alarm when %(meter_name)s is %(comparison_operator)s a \u0027 \\"},{"line_number":1983,"context_line":"                \u0027%(statistic)s of %(threshold)s over %(period)s seconds\u0027 % \\"},{"line_number":1984,"context_line":"                {\u0027meter_name\u0027: old_alarm[\u0027rule\u0027][\u0027meter_name\u0027],"},{"line_number":1985,"context_line":"                 \u0027comparison_operator\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_01d73eee","line":1982,"range":{"start_line":1982,"start_character":17,"end_line":1982,"end_character":22},"updated":"2014-07-02 12:22:52.000000000","message":"same","commit_id":"6475bffc24b6f1819e61637b5d31477f49600b7a"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"76ae91d25f3506150dacec5b92636055e0b66887","unresolved":false,"context_lines":[{"line_number":1987,"context_line":"                 \u0027statistic\u0027: old_alarm[\u0027rule\u0027][\u0027statistic\u0027],"},{"line_number":1988,"context_line":"                 \u0027threshold\u0027: old_alarm[\u0027rule\u0027][\u0027threshold\u0027],"},{"line_number":1989,"context_line":"                 \u0027period\u0027: old_alarm[\u0027rule\u0027][\u0027period\u0027]}"},{"line_number":1990,"context_line":"            # checking if previous description was default_description and if"},{"line_number":1991,"context_line":"            # user has not updated the description."},{"line_number":1992,"context_line":"            if (old_alarm[\u0027description\u0027] \u003d\u003d default_description"},{"line_number":1993,"context_line":"                    and data.description \u003d\u003d old_alarm[\u0027description\u0027]):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_e1b89577","line":1990,"updated":"2014-06-17 15:22:07.000000000","message":"was or is?","commit_id":"6475bffc24b6f1819e61637b5d31477f49600b7a"}]}