)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6498,"name":"Divakar Padiyar Nandavar","email":"divakar.padiyar-nandavar@hpe.com","username":"divakar-padiyar-nandavar"},"change_message_id":"c62fa038b74df6d0542b46f33906781d07bef7ea","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VMware: Fixes ceilometer-compute service start failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently ceilometer-compute service is failing to start in the"},{"line_number":10,"context_line":"vmware region, because of the additonal parameter\u0027port\u0027, is being"},{"line_number":11,"context_line":"added to the oslo.vmware _get_wsdl_loc method."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fixes it by introducing an additional config entry"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_369df866","line":10,"updated":"2014-06-04 18:23:58.000000000","message":"missing space between parameter and \u0027port\u0027","commit_id":"5fe11efd3b32981f03f9a75d68ba1199a7643f03"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"0112518d4f9ca11304f9373ac31c943cdef54725","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VMware: Fixes ceilometer-compute service start failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently ceilometer-compute service is failing to start in the"},{"line_number":10,"context_line":"vmware region, because of the additonal parameter\u0027port\u0027, is being"},{"line_number":11,"context_line":"added to the oslo.vmware _get_wsdl_loc method."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fixes it by introducing an additional config entry"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_4018f974","line":10,"in_reply_to":"1ae5cdf2_369df866","updated":"2014-06-04 18:26:12.000000000","message":"Done","commit_id":"5fe11efd3b32981f03f9a75d68ba1199a7643f03"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2462e49513ec3fa18b60aa55821276cfc1340e97","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This patch fixes it by introducing an additional config entry"},{"line_number":14,"context_line":"\u0027host_port\u0027, which gives a user an option to configure it in the"},{"line_number":15,"context_line":"ceilometer conf file.  Default it is set to 443. Hence avoiding"},{"line_number":16,"context_line":"the mismatch in the method call."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib70092c1ccb14421701acdf8ff4a3805becbeef4"},{"line_number":19,"context_line":"Closes-Bug: #1326230"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ae5cdf2_5200ab33","line":16,"updated":"2014-06-05 16:03:55.000000000","message":"-1: after have a glance at the test code and oslo.vmware code, I agree that test code can not be added, but you need to add the reason to this commit message, because other reviewers may not notice your review comment, and after it is merged, it can be some curious for the developer who checks the git log and finds no test code in this patch. Sorry for the late discovery which will definitely waste your time, I\u0027m not meant it\n\nnit: as you mentioned that we should not access a private method of an object, I think the test code https://github.com/openstack/ceilometer/blob/master/ceilometer/tests/compute/virt/vmware/test_inspector.py#L34 can be updated too, since we have a property named vim: https://github.com/openstack/oslo.vmware/blob/master/oslo/vmware/api.py#L174, (the _vim only used in vim.VIM, I think it is safe and reasonable)","commit_id":"72caf28b8dc8c887ec60744563f22cc4aefc1160"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"8fae0e3d3548b316803c6232f94c53b3cfa7572f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This patch fixes it by introducing an additional config entry"},{"line_number":14,"context_line":"\u0027host_port\u0027, which gives a user an option to configure it in the"},{"line_number":15,"context_line":"ceilometer conf file.  Default it is set to 443. Hence avoiding"},{"line_number":16,"context_line":"the mismatch in the method call."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib70092c1ccb14421701acdf8ff4a3805becbeef4"},{"line_number":19,"context_line":"Closes-Bug: #1326230"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ae5cdf2_47df0ad6","line":16,"in_reply_to":"1ae5cdf2_5200ab33","updated":"2014-06-05 17:40:33.000000000","message":"Yes, i\u0027ll update the commit message. and change the test case by removing https://github.com/openstack/ceilometer/blob/master/ceilometer/tests/compute/virt/vmware/test_inspector.py#L34 \ntoo.","commit_id":"72caf28b8dc8c887ec60744563f22cc4aefc1160"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"df5879451a38e340923015f146b0d4fe1ce079c8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"ceilometer conf file.  Default it is set to 443. Hence avoiding"},{"line_number":16,"context_line":"the mismatch in the method call."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Test cases are not added, since the changed method just calls the"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ib70092c1ccb14421701acdf8ff4a3805becbeef4"},{"line_number":21,"context_line":"Closes-Bug: #1326230"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_4a454f41","line":18,"updated":"2014-06-05 18:03:43.000000000","message":"nit: is there anything missed?","commit_id":"b547bae21d6a87f4a9a2e3607a820fd1e568002a"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"d367cbe61acbe88b98cb76184eb28ae119fe2e6e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"ceilometer conf file.  Default it is set to 443. Hence avoiding"},{"line_number":16,"context_line":"the mismatch in the method call."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Test cases are not added, since the changed method just calls the"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ib70092c1ccb14421701acdf8ff4a3805becbeef4"},{"line_number":21,"context_line":"Closes-Bug: #1326230"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_50b89e10","line":18,"in_reply_to":"1ae5cdf2_4a454f41","updated":"2014-06-05 18:19:34.000000000","message":"oops, sent it by mistake :( will complete it.","commit_id":"b547bae21d6a87f4a9a2e3607a820fd1e568002a"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"7c4b87c1bf7ec8313aac98ad2b964b7395540944","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixes ceilometer-compute service start failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently ceilometer-compute service is failing to start in the"},{"line_number":10,"context_line":"vmware region, because of the additional parameter \u0027port\u0027, is being"},{"line_number":11,"context_line":"added to the oslo.vmware _get_wsdl_loc method."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fixes it by introducing an additional config entry"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1ae5cdf2_e76f175e","line":10,"updated":"2014-06-06 13:26:14.000000000","message":"\u0027is being\u0027 is not really needed here :)","commit_id":"a76a5852e8775257dcbb929c98476fa97a74becd"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"03d8171786fd3aa3007f03c7957165e1c2d37c75","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixes ceilometer-compute service start failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently ceilometer-compute service is failing to start in the"},{"line_number":10,"context_line":"vmware region, because of the additional parameter \u0027port\u0027, is being"},{"line_number":11,"context_line":"added to the oslo.vmware _get_wsdl_loc method."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fixes it by introducing an additional config entry"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1ae5cdf2_bb59a75d","line":10,"in_reply_to":"1ae5cdf2_e76f175e","updated":"2014-06-06 14:09:59.000000000","message":"Done","commit_id":"a76a5852e8775257dcbb929c98476fa97a74becd"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"ddd01ac23b53c742e3bfd32ad89344287f4517e7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixes ceilometer-compute service start failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently ceilometer-compute service is failing to start in the"},{"line_number":10,"context_line":"vmware region, because of the additional parameter \u0027port\u0027, is"},{"line_number":11,"context_line":"added to the oslo.vmware _get_wsdl_loc method."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fixes it by not calling the private method _get_wsdl_loc,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1ae5cdf2_d0b21ce4","line":10,"updated":"2014-06-12 10:58:44.000000000","message":"just a nit: VMware :)","commit_id":"450bff2ec07866ed43698e799cdb3ec07125483e"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"5e178907da210aad09b66dd55adf9b0735f6530c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixes ceilometer-compute service start failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently ceilometer-compute service is failing to start in the"},{"line_number":10,"context_line":"vmware region, because of the additional parameter \u0027port\u0027, is"},{"line_number":11,"context_line":"added to the oslo.vmware _get_wsdl_loc method."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fixes it by not calling the private method _get_wsdl_loc,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1ae5cdf2_7b75a996","line":10,"in_reply_to":"1ae5cdf2_d0b21ce4","updated":"2014-06-12 11:17:33.000000000","message":"Its the section name in the config file. Hence retained it as it is.","commit_id":"450bff2ec07866ed43698e799cdb3ec07125483e"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"ddd01ac23b53c742e3bfd32ad89344287f4517e7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u0027wsdl_location\u0027 is added to over-ride to default location for bug"},{"line_number":16,"context_line":"work-arounds."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Test cases are not added, since the changed method just calls the"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ib70092c1ccb14421701acdf8ff4a3805becbeef4"},{"line_number":21,"context_line":"Closes-Bug: #1326807"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1ae5cdf2_f0cab84d","line":18,"updated":"2014-06-12 10:58:44.000000000","message":"just calls what? uncompleted sentence, I guess :)","commit_id":"450bff2ec07866ed43698e799cdb3ec07125483e"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"5e178907da210aad09b66dd55adf9b0735f6530c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u0027wsdl_location\u0027 is added to over-ride to default location for bug"},{"line_number":16,"context_line":"work-arounds."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Test cases are not added, since the changed method just calls the"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ib70092c1ccb14421701acdf8ff4a3805becbeef4"},{"line_number":21,"context_line":"Closes-Bug: #1326807"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1ae5cdf2_db707da6","line":18,"in_reply_to":"1ae5cdf2_f0cab84d","updated":"2014-06-12 11:17:33.000000000","message":"yes. will complete it.","commit_id":"450bff2ec07866ed43698e799cdb3ec07125483e"}],"ceilometer/compute/virt/vmware/inspector.py":[{"author":{"_account_id":6498,"name":"Divakar Padiyar Nandavar","email":"divakar.padiyar-nandavar@hpe.com","username":"divakar-padiyar-nandavar"},"change_message_id":"c62fa038b74df6d0542b46f33906781d07bef7ea","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def get_api_session():"},{"line_number":63,"context_line":"    hostIp \u003d cfg.CONF.vmware.host_ip"},{"line_number":64,"context_line":"    wsdl_loc \u003d vim.Vim._get_wsdl_loc(\"https\", hostIp)"},{"line_number":65,"context_line":"    api_session \u003d api.VMwareAPISession("},{"line_number":66,"context_line":"        hostIp,"},{"line_number":67,"context_line":"        cfg.CONF.vmware.host_username,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_8d515a38","side":"PARENT","line":64,"updated":"2014-06-04 18:23:58.000000000","message":"specifying the wsdl location may be required for vSphere version 5.0 or earlier,    Shouldn\u0027t this also be a configurable parameter \"wsdl_location\" as in compute driver?   This can be optional parameter which needs to be specified only for vSphere version 5.0 or earlier","commit_id":"70882f7cbeba48c35e4e261937bba1481e8dc6cf"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"ca953dec24d7006d1edb0aad86d614391c49e416","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def get_api_session():"},{"line_number":63,"context_line":"    hostIp \u003d cfg.CONF.vmware.host_ip"},{"line_number":64,"context_line":"    wsdl_loc \u003d vim.Vim._get_wsdl_loc(\"https\", hostIp)"},{"line_number":65,"context_line":"    api_session \u003d api.VMwareAPISession("},{"line_number":66,"context_line":"        hostIp,"},{"line_number":67,"context_line":"        cfg.CONF.vmware.host_username,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_60dfb50d","side":"PARENT","line":64,"in_reply_to":"1ae5cdf2_8d515a38","updated":"2014-06-04 18:41:03.000000000","message":"yes, it will be better if its configurable. will address it.","commit_id":"70882f7cbeba48c35e4e261937bba1481e8dc6cf"},{"author":{"_account_id":7239,"name":"Kiran Kumar Vaddi","email":"kiran-kumar.vaddi@hp.com","username":"kirankv"},"change_message_id":"1ce05f73a71a2d497cfcbf006132befeccf65d55","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        cfg.CONF.vmware.host_password,"},{"line_number":69,"context_line":"        cfg.CONF.vmware.api_retry_count,"},{"line_number":70,"context_line":"        cfg.CONF.vmware.task_poll_interval,"},{"line_number":71,"context_line":"        wsdl_loc\u003dwsdl_loc)"},{"line_number":72,"context_line":"    return api_session"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_f0fab8bb","side":"PARENT","line":71,"updated":"2014-06-04 16:02:40.000000000","message":"why is the wsdl location being removed? the api\u0027s __init__ method still takes wsdl as an argument and is still used in api.py.","commit_id":"70882f7cbeba48c35e4e261937bba1481e8dc6cf"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"d30f37c83cebbec0e0d550fa173ecb5706cc899a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        cfg.CONF.vmware.host_password,"},{"line_number":69,"context_line":"        cfg.CONF.vmware.api_retry_count,"},{"line_number":70,"context_line":"        cfg.CONF.vmware.task_poll_interval,"},{"line_number":71,"context_line":"        wsdl_loc\u003dwsdl_loc)"},{"line_number":72,"context_line":"    return api_session"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_b658288b","side":"PARENT","line":71,"in_reply_to":"1ae5cdf2_f0fab8bb","updated":"2014-06-04 17:04:48.000000000","message":"_get_wsdl_loc is a private method to the Vim. So i thought it is not a convention to call it from outside. api.VMwareAPISession , will call the same method if the wsdl_loc is not passed. Hence removed it.","commit_id":"70882f7cbeba48c35e4e261937bba1481e8dc6cf"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"aabb80de56bfdd487607fe61259fa7f6bad668b3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\"Implementation of Inspector abstraction for VMware vSphere\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo.config import cfg"},{"line_number":19,"context_line":"from oslo.vmware import api"},{"line_number":20,"context_line":"from oslo.vmware import vim"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from ceilometer.compute.virt import inspector as virt_inspector"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_56a52445","line":19,"updated":"2014-06-04 17:07:48.000000000","message":"can be removed","commit_id":"5fe11efd3b32981f03f9a75d68ba1199a7643f03"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"9b2b2f69f44a58cbf23ea65ec4c120c655e8597d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\"Implementation of Inspector abstraction for VMware vSphere\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo.config import cfg"},{"line_number":19,"context_line":"from oslo.vmware import api"},{"line_number":20,"context_line":"from oslo.vmware import vim"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from ceilometer.compute.virt import inspector as virt_inspector"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_2a8e6c79","line":19,"in_reply_to":"1ae5cdf2_56a52445","updated":"2014-06-04 17:18:10.000000000","message":"Done","commit_id":"5fe11efd3b32981f03f9a75d68ba1199a7643f03"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"aabb80de56bfdd487607fe61259fa7f6bad668b3","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    cfg.FloatOpt(\u0027task_poll_interval\u0027,"},{"line_number":44,"context_line":"                 default\u003d0.5,"},{"line_number":45,"context_line":"                 help\u003d\u0027Sleep time in seconds for polling an ongoing async \u0027"},{"line_number":46,"context_line":"                 \u0027task\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027host_port\u0027,"},{"line_number":48,"context_line":"               default\u003d443,"},{"line_number":49,"context_line":"               help\u003d\u0027Port for connection to VMware VC host.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_f603903f","line":46,"updated":"2014-06-04 17:07:48.000000000","message":"tiny nit: may be \u0027task\u0027 can align to the Sleep","commit_id":"5fe11efd3b32981f03f9a75d68ba1199a7643f03"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"9b2b2f69f44a58cbf23ea65ec4c120c655e8597d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    cfg.FloatOpt(\u0027task_poll_interval\u0027,"},{"line_number":44,"context_line":"                 default\u003d0.5,"},{"line_number":45,"context_line":"                 help\u003d\u0027Sleep time in seconds for polling an ongoing async \u0027"},{"line_number":46,"context_line":"                 \u0027task\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027host_port\u0027,"},{"line_number":48,"context_line":"               default\u003d443,"},{"line_number":49,"context_line":"               help\u003d\u0027Port for connection to VMware VC host.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_ca5a6829","line":46,"in_reply_to":"1ae5cdf2_f603903f","updated":"2014-06-04 17:18:10.000000000","message":"Not a change part of this patch. But will do it.","commit_id":"5fe11efd3b32981f03f9a75d68ba1199a7643f03"},{"author":{"_account_id":6498,"name":"Divakar Padiyar Nandavar","email":"divakar.padiyar-nandavar@hpe.com","username":"divakar-padiyar-nandavar"},"change_message_id":"c62fa038b74df6d0542b46f33906781d07bef7ea","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                 default\u003d0.5,"},{"line_number":45,"context_line":"                 help\u003d\u0027Sleep time in seconds for polling an ongoing async \u0027"},{"line_number":46,"context_line":"                 \u0027task\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027host_port\u0027,"},{"line_number":48,"context_line":"               default\u003d443,"},{"line_number":49,"context_line":"               help\u003d\u0027Port for connection to VMware VC host.\u0027),"},{"line_number":50,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_8de4fae1","line":47,"updated":"2014-06-04 18:23:58.000000000","message":"Is there any documentation update required for this additional parameter?","commit_id":"5fe11efd3b32981f03f9a75d68ba1199a7643f03"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"c3d38d69b8ed88f7f4c772f0c10b78b8a33699ed","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                 default\u003d0.5,"},{"line_number":45,"context_line":"                 help\u003d\u0027Sleep time in seconds for polling an ongoing async \u0027"},{"line_number":46,"context_line":"                 \u0027task\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027host_port\u0027,"},{"line_number":48,"context_line":"               default\u003d443,"},{"line_number":49,"context_line":"               help\u003d\u0027Port for connection to VMware VC host.\u0027),"},{"line_number":50,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_12b63a8a","line":47,"in_reply_to":"1ae5cdf2_004a7125","updated":"2014-06-05 02:13:46.000000000","message":"actually, there is a doc/source/configurations.rst, but it seems all vmware insepctor options are not there, so maybe it can be handled by others","commit_id":"5fe11efd3b32981f03f9a75d68ba1199a7643f03"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"ca953dec24d7006d1edb0aad86d614391c49e416","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                 default\u003d0.5,"},{"line_number":45,"context_line":"                 help\u003d\u0027Sleep time in seconds for polling an ongoing async \u0027"},{"line_number":46,"context_line":"                 \u0027task\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027host_port\u0027,"},{"line_number":48,"context_line":"               default\u003d443,"},{"line_number":49,"context_line":"               help\u003d\u0027Port for connection to VMware VC host.\u0027),"},{"line_number":50,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_004a7125","line":47,"in_reply_to":"1ae5cdf2_8de4fae1","updated":"2014-06-04 18:41:03.000000000","message":"as /etc/ceilometer/README-ceilometer.conf.txt says, you can generate this sample configuration file by running ``tox -e genconfig``.\nSo no change there, i suppose. Please guide me through, if its needed to be updated somewhere else.","commit_id":"5fe11efd3b32981f03f9a75d68ba1199a7643f03"},{"author":{"_account_id":7239,"name":"Kiran Kumar Vaddi","email":"kiran-kumar.vaddi@hp.com","username":"kirankv"},"change_message_id":"1ce05f73a71a2d497cfcbf006132befeccf65d55","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                 \u0027task\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027host_port\u0027,"},{"line_number":48,"context_line":"               default\u003d443,"},{"line_number":49,"context_line":"               help\u003d\u0027Port for connection to VMware VC host.\u0027),"},{"line_number":50,"context_line":"]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"cfg.CONF.register_group(opt_group)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_90e414e2","line":49,"updated":"2014-06-04 16:02:40.000000000","message":"Can you change the help to \"Port for connection to VMware ESX/VC host.\" to make it consistent with what is present in the VMwareVC nova driver.","commit_id":"5fe11efd3b32981f03f9a75d68ba1199a7643f03"},{"author":{"_account_id":6498,"name":"Divakar Padiyar Nandavar","email":"divakar.padiyar-nandavar@hpe.com","username":"divakar-padiyar-nandavar"},"change_message_id":"c62fa038b74df6d0542b46f33906781d07bef7ea","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                 \u0027task\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027host_port\u0027,"},{"line_number":48,"context_line":"               default\u003d443,"},{"line_number":49,"context_line":"               help\u003d\u0027Port for connection to VMware VC host.\u0027),"},{"line_number":50,"context_line":"]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"cfg.CONF.register_group(opt_group)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_6d140ea0","line":49,"updated":"2014-06-04 18:23:58.000000000","message":"Just to keep it consistent with description for earlier parameters you may want to just keep it as  \"Communication Port of VMware Vsphere\u0027","commit_id":"5fe11efd3b32981f03f9a75d68ba1199a7643f03"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"aabb80de56bfdd487607fe61259fa7f6bad668b3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                 \u0027task\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027host_port\u0027,"},{"line_number":48,"context_line":"               default\u003d443,"},{"line_number":49,"context_line":"               help\u003d\u0027Port for connection to VMware VC host.\u0027),"},{"line_number":50,"context_line":"]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"cfg.CONF.register_group(opt_group)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_b6e668ae","line":49,"updated":"2014-06-04 17:07:48.000000000","message":"nit : last comma is not necessary","commit_id":"5fe11efd3b32981f03f9a75d68ba1199a7643f03"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"d30f37c83cebbec0e0d550fa173ecb5706cc899a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                 \u0027task\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027host_port\u0027,"},{"line_number":48,"context_line":"               default\u003d443,"},{"line_number":49,"context_line":"               help\u003d\u0027Port for connection to VMware VC host.\u0027),"},{"line_number":50,"context_line":"]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"cfg.CONF.register_group(opt_group)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d6ebf475","line":49,"in_reply_to":"1ae5cdf2_90e414e2","updated":"2014-06-04 17:04:48.000000000","message":"since  ESX driver support will be deprecated. Didn\u0027t really think its mandate to have ESX/VC","commit_id":"5fe11efd3b32981f03f9a75d68ba1199a7643f03"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"9b2b2f69f44a58cbf23ea65ec4c120c655e8597d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                 \u0027task\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027host_port\u0027,"},{"line_number":48,"context_line":"               default\u003d443,"},{"line_number":49,"context_line":"               help\u003d\u0027Port for connection to VMware VC host.\u0027),"},{"line_number":50,"context_line":"]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"cfg.CONF.register_group(opt_group)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_ca7fc864","line":49,"in_reply_to":"1ae5cdf2_b6e668ae","updated":"2014-06-04 17:18:10.000000000","message":"http://docs.openstack.org/developer/hacking/\nhere they say \"the last item in the dictionary should have a trailing comma\" , hence applied the same to lists.","commit_id":"5fe11efd3b32981f03f9a75d68ba1199a7643f03"},{"author":{"_account_id":7239,"name":"Kiran Kumar Vaddi","email":"kiran-kumar.vaddi@hp.com","username":"kirankv"},"change_message_id":"1ce05f73a71a2d497cfcbf006132befeccf65d55","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        cfg.CONF.vmware.host_password,"},{"line_number":70,"context_line":"        cfg.CONF.vmware.api_retry_count,"},{"line_number":71,"context_line":"        cfg.CONF.vmware.task_poll_interval,"},{"line_number":72,"context_line":"        port\u003dcfg.CONF.vmware.host_port)"},{"line_number":73,"context_line":"    return api_session"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_f0cf187d","line":72,"updated":"2014-06-04 16:02:40.000000000","message":"This change of specifying port is fine.\nOnly concern is removal of the wsdl loc.","commit_id":"5fe11efd3b32981f03f9a75d68ba1199a7643f03"},{"author":{"_account_id":7239,"name":"Kiran Kumar Vaddi","email":"kiran-kumar.vaddi@hp.com","username":"kirankv"},"change_message_id":"4e83c024909a53bb56af94a80c1db82c221627f7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    cfg.FloatOpt(\u0027task_poll_interval\u0027,"},{"line_number":43,"context_line":"                 default\u003d0.5,"},{"line_number":44,"context_line":"                 help\u003d\u0027Sleep time in seconds for polling an ongoing async\u0027"},{"line_number":45,"context_line":"                      \u0027task\u0027),"},{"line_number":46,"context_line":"    cfg.IntOpt(\u0027host_port\u0027,"},{"line_number":47,"context_line":"               default\u003d443,"},{"line_number":48,"context_line":"               help\u003d\u0027Communication Port of VMware Vsphere\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_020b478e","line":45,"updated":"2014-06-05 06:54:43.000000000","message":"Need to retain the space.","commit_id":"fa2b8c41a2eb6c634d2dd3ee13e0e0b53f4d51c1"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"3434c316e559bf163d21c6f6ddf4a6c8d0e628c4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    cfg.FloatOpt(\u0027task_poll_interval\u0027,"},{"line_number":43,"context_line":"                 default\u003d0.5,"},{"line_number":44,"context_line":"                 help\u003d\u0027Sleep time in seconds for polling an ongoing async\u0027"},{"line_number":45,"context_line":"                      \u0027task\u0027),"},{"line_number":46,"context_line":"    cfg.IntOpt(\u0027host_port\u0027,"},{"line_number":47,"context_line":"               default\u003d443,"},{"line_number":48,"context_line":"               help\u003d\u0027Communication Port of VMware Vsphere\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_42470f77","line":45,"in_reply_to":"1ae5cdf2_020b478e","updated":"2014-06-05 07:06:56.000000000","message":"Done","commit_id":"fa2b8c41a2eb6c634d2dd3ee13e0e0b53f4d51c1"},{"author":{"_account_id":7239,"name":"Kiran Kumar Vaddi","email":"kiran-kumar.vaddi@hp.com","username":"kirankv"},"change_message_id":"6299c167e66d17ee2f5c9a241234c06bb2378927","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        cfg.CONF.vmware.host_password,"},{"line_number":74,"context_line":"        cfg.CONF.vmware.api_retry_count,"},{"line_number":75,"context_line":"        cfg.CONF.vmware.task_poll_interval,"},{"line_number":76,"context_line":"        wsdl_loc\u003dcfg.CONF.vmware.wsdl_location,"},{"line_number":77,"context_line":"        port\u003dcfg.CONF.vmware.host_port)"},{"line_number":78,"context_line":"    return api_session"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_6f4eb43c","line":76,"updated":"2014-06-05 06:07:20.000000000","message":"wsdl location should be set as done earlier\nwsdl_loc \u003d vim.Vim._get_wsdl_loc(\"https\", hostIp)\n\nThis patch sets it to empty if the user has not specified it in the nova.conf. The user will always specify the hostIp and therefore we should retain the old code that generates the url based on the hostIp data.","commit_id":"fa2b8c41a2eb6c634d2dd3ee13e0e0b53f4d51c1"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"3b24451f3180659227eee2d690ec169b62eaacb8","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        cfg.CONF.vmware.host_password,"},{"line_number":74,"context_line":"        cfg.CONF.vmware.api_retry_count,"},{"line_number":75,"context_line":"        cfg.CONF.vmware.task_poll_interval,"},{"line_number":76,"context_line":"        wsdl_loc\u003dcfg.CONF.vmware.wsdl_location,"},{"line_number":77,"context_line":"        port\u003dcfg.CONF.vmware.host_port)"},{"line_number":78,"context_line":"    return api_session"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_c2995f7a","line":76,"in_reply_to":"1ae5cdf2_6f4eb43c","updated":"2014-06-05 06:41:44.000000000","message":"No. if the user has specified wsdl_loc in ceilometer conf, it will be passed to VMwareAPISession and will be used, if the user didn\u0027t specify it, it will calculated like this \nhttps://github.com/openstack/oslo.vmware/blob/master/oslo/vmware/vim.py#L83\n\nWe should pass \"cfg.CONF.vmware.wsdl_location\" because, if the vCenter is below 5.1 ,  _get_wsdl_loc will always return the buggy wsdl file, then user cant configure it if he has the proper wsdl file hosted somewhere. \n\nAnd also I disagree using the private method calls here, which basically lead to this paramater mismatch bug.","commit_id":"fa2b8c41a2eb6c634d2dd3ee13e0e0b53f4d51c1"},{"author":{"_account_id":7239,"name":"Kiran Kumar Vaddi","email":"kiran-kumar.vaddi@hp.com","username":"kirankv"},"change_message_id":"4e83c024909a53bb56af94a80c1db82c221627f7","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        cfg.CONF.vmware.host_password,"},{"line_number":74,"context_line":"        cfg.CONF.vmware.api_retry_count,"},{"line_number":75,"context_line":"        cfg.CONF.vmware.task_poll_interval,"},{"line_number":76,"context_line":"        wsdl_loc\u003dcfg.CONF.vmware.wsdl_location,"},{"line_number":77,"context_line":"        port\u003dcfg.CONF.vmware.host_port)"},{"line_number":78,"context_line":"    return api_session"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_a2f1b396","line":76,"in_reply_to":"1ae5cdf2_c2995f7a","updated":"2014-06-05 06:54:43.000000000","message":"Ok. the olso.vmware handles this now so this is fine.","commit_id":"fa2b8c41a2eb6c634d2dd3ee13e0e0b53f4d51c1"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2462e49513ec3fa18b60aa55821276cfc1340e97","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                      \u0027task\u0027),"},{"line_number":46,"context_line":"    cfg.IntOpt(\u0027host_port\u0027,"},{"line_number":47,"context_line":"               default\u003d443,"},{"line_number":48,"context_line":"               help\u003d\u0027Communication Port of VMware Vsphere\u0027),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027wsdl_location\u0027, default\u003d\u0027\u0027,"},{"line_number":50,"context_line":"               help\u003d\u0027Optional VIM Service WSDL Location \u0027"},{"line_number":51,"context_line":"                    \u0027e.g http://\u003cserver\u003e/vimService.wsdl. \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_d2ef5b1c","line":48,"updated":"2014-06-05 16:03:55.000000000","message":"nit: only first letter and special word should be capitalized","commit_id":"72caf28b8dc8c887ec60744563f22cc4aefc1160"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"8fae0e3d3548b316803c6232f94c53b3cfa7572f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                      \u0027task\u0027),"},{"line_number":46,"context_line":"    cfg.IntOpt(\u0027host_port\u0027,"},{"line_number":47,"context_line":"               default\u003d443,"},{"line_number":48,"context_line":"               help\u003d\u0027Communication Port of VMware Vsphere\u0027),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027wsdl_location\u0027, default\u003d\u0027\u0027,"},{"line_number":50,"context_line":"               help\u003d\u0027Optional VIM Service WSDL Location \u0027"},{"line_number":51,"context_line":"                    \u0027e.g http://\u003cserver\u003e/vimService.wsdl. \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_87f4b25b","line":48,"in_reply_to":"1ae5cdf2_d2ef5b1c","updated":"2014-06-05 17:40:33.000000000","message":"Done","commit_id":"72caf28b8dc8c887ec60744563f22cc4aefc1160"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2462e49513ec3fa18b60aa55821276cfc1340e97","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               default\u003d443,"},{"line_number":48,"context_line":"               help\u003d\u0027Communication Port of VMware Vsphere\u0027),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027wsdl_location\u0027, default\u003d\u0027\u0027,"},{"line_number":50,"context_line":"               help\u003d\u0027Optional VIM Service WSDL Location \u0027"},{"line_number":51,"context_line":"                    \u0027e.g http://\u003cserver\u003e/vimService.wsdl. \u0027"},{"line_number":52,"context_line":"                    \u0027Optional over-ride to default location for bug \u0027"},{"line_number":53,"context_line":"                    \u0027work-arounds\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_12f623f9","line":50,"updated":"2014-06-05 16:03:55.000000000","message":"nit: ditto","commit_id":"72caf28b8dc8c887ec60744563f22cc4aefc1160"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"8fae0e3d3548b316803c6232f94c53b3cfa7572f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               default\u003d443,"},{"line_number":48,"context_line":"               help\u003d\u0027Communication Port of VMware Vsphere\u0027),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027wsdl_location\u0027, default\u003d\u0027\u0027,"},{"line_number":50,"context_line":"               help\u003d\u0027Optional VIM Service WSDL Location \u0027"},{"line_number":51,"context_line":"                    \u0027e.g http://\u003cserver\u003e/vimService.wsdl. \u0027"},{"line_number":52,"context_line":"                    \u0027Optional over-ride to default location for bug \u0027"},{"line_number":53,"context_line":"                    \u0027work-arounds\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_a7e7eeaa","line":50,"in_reply_to":"1ae5cdf2_12f623f9","updated":"2014-06-05 17:40:33.000000000","message":"Done","commit_id":"72caf28b8dc8c887ec60744563f22cc4aefc1160"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"2906fe58373a1a0ce083a587e24d5b981618c1bd","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def get_api_session():"},{"line_number":70,"context_line":"    api_session \u003d api.VMwareAPISession("},{"line_number":71,"context_line":"        cfg.CONF.vmware.host_ip,"},{"line_number":72,"context_line":"        cfg.CONF.vmware.host_username,"},{"line_number":73,"context_line":"        cfg.CONF.vmware.host_password,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_4708cb27","line":70,"updated":"2014-06-06 13:10:58.000000000","message":"this will cause issues i believe: https://github.com/openstack/oslo.vmware/blob/93feabb736bbaf7ecb7e459317b05ed61f97cb48/oslo/vmware/api.py#L135-L155\n\ninit expects port to be the second parameter, but here the second parameter is host_username and port is a named arg... we should be passing everything in as named parameters to be safe.\n\nalso... does this require a specific version of oslo.vmware? i assume this would be needed since current version of oslo.vmware doesn\u0027t expect port arg","commit_id":"a76a5852e8775257dcbb929c98476fa97a74becd"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"d9ea406acc1c16b6accb905eb9d7cc5fd467fb5f","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def get_api_session():"},{"line_number":70,"context_line":"    api_session \u003d api.VMwareAPISession("},{"line_number":71,"context_line":"        cfg.CONF.vmware.host_ip,"},{"line_number":72,"context_line":"        cfg.CONF.vmware.host_username,"},{"line_number":73,"context_line":"        cfg.CONF.vmware.host_password,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_5586ac66","line":70,"in_reply_to":"1ae5cdf2_4708cb27","updated":"2014-06-06 16:06:08.000000000","message":"@gordon chung\n\nwhy the blob is not an usual tag?\n\nwhat you said is true, the kwargs is always safer than args,\n\nthe code I read is master branch, so I mark it as +1, and now I check the version what we currently using is 0.3, and is true, there is no port https://github.com/openstack/oslo.vmware/blob/0.3/oslo/vmware/api.py#L134, so it will be broken, sorry for not found that","commit_id":"a76a5852e8775257dcbb929c98476fa97a74becd"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"03d8171786fd3aa3007f03c7957165e1c2d37c75","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def get_api_session():"},{"line_number":70,"context_line":"    api_session \u003d api.VMwareAPISession("},{"line_number":71,"context_line":"        cfg.CONF.vmware.host_ip,"},{"line_number":72,"context_line":"        cfg.CONF.vmware.host_username,"},{"line_number":73,"context_line":"        cfg.CONF.vmware.host_password,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_7e5c6dee","line":70,"in_reply_to":"1ae5cdf2_4708cb27","updated":"2014-06-06 14:09:59.000000000","message":"If you see the TOT oslo.vmware : https://github.com/openstack/oslo.vmware/blob/master/oslo/vmware/api.py#L135\nport is a keyword arg. But as you say named parameters are safe, ill update it.\n\nif user is using other than 443 port,  it should be configurable.Hence the additional Opt.","commit_id":"a76a5852e8775257dcbb929c98476fa97a74becd"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"f564f4b5cde96625c50f21bc4945b20a3b452868","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def get_api_session():"},{"line_number":70,"context_line":"    api_session \u003d api.VMwareAPISession("},{"line_number":71,"context_line":"        cfg.CONF.vmware.host_ip,"},{"line_number":72,"context_line":"        cfg.CONF.vmware.host_username,"},{"line_number":73,"context_line":"        cfg.CONF.vmware.host_password,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_ce34a1e1","line":70,"in_reply_to":"1ae5cdf2_5586ac66","updated":"2014-06-10 06:28:50.000000000","message":"alright, i\u0027ll remove the host_port option to support with 0.3 and TOT oslo.vmware  as well.","commit_id":"a76a5852e8775257dcbb929c98476fa97a74becd"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0a948da68dbf25ec39d540cddac55e00493e1b4a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d\u0027Optional vim service WSDL location \u0027"},{"line_number":48,"context_line":"                    \u0027e.g http://\u003cserver\u003e/vimService.wsdl. \u0027"},{"line_number":49,"context_line":"                    \u0027Optional over-ride to default location for bug \u0027"},{"line_number":50,"context_line":"                    \u0027work-arounds\u0027),"},{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"cfg.CONF.register_group(opt_group)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_13fdc5b1","line":50,"updated":"2014-06-17 19:47:42.000000000","message":"what is this bug workaround? i\u0027m worried why we needed to create an option just to avoid bug","commit_id":"3edb4dcdd502b17447cefbbeaacc9bf4fb27d5ec"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"b2d3ceea05aee35bf1acdcebe5f2e37084636e18","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d\u0027Optional vim service WSDL location \u0027"},{"line_number":48,"context_line":"                    \u0027e.g http://\u003cserver\u003e/vimService.wsdl. \u0027"},{"line_number":49,"context_line":"                    \u0027Optional over-ride to default location for bug \u0027"},{"line_number":50,"context_line":"                    \u0027work-arounds\u0027),"},{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"cfg.CONF.register_group(opt_group)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_fd81f1fb","line":50,"in_reply_to":"1ae5cdf2_13fdc5b1","updated":"2014-06-18 06:08:02.000000000","message":"its a vCenter bug, if the vCenter version is below 5.1, because of their faulty wsdl the session doesn\u0027t get created with vCenter. Hence the additional option.","commit_id":"3edb4dcdd502b17447cefbbeaacc9bf4fb27d5ec"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0a948da68dbf25ec39d540cddac55e00493e1b4a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        cfg.CONF.vmware.host_password,"},{"line_number":71,"context_line":"        cfg.CONF.vmware.api_retry_count,"},{"line_number":72,"context_line":"        cfg.CONF.vmware.task_poll_interval,"},{"line_number":73,"context_line":"        wsdl_loc\u003dcfg.CONF.vmware.wsdl_location)"},{"line_number":74,"context_line":"    return api_session"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_93df153a","line":73,"updated":"2014-06-17 19:47:42.000000000","message":"if this is optional is oslo.vmware smart enough to take empty string default? should option default to None since thats\u0027 what oslo.vmware does:\nhttps://github.com/openstack/oslo.vmware/blob/master/oslo/vmware/api.py#L137","commit_id":"3edb4dcdd502b17447cefbbeaacc9bf4fb27d5ec"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"b2d3ceea05aee35bf1acdcebe5f2e37084636e18","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        cfg.CONF.vmware.host_password,"},{"line_number":71,"context_line":"        cfg.CONF.vmware.api_retry_count,"},{"line_number":72,"context_line":"        cfg.CONF.vmware.task_poll_interval,"},{"line_number":73,"context_line":"        wsdl_loc\u003dcfg.CONF.vmware.wsdl_location)"},{"line_number":74,"context_line":"    return api_session"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_9ddf0dd6","line":73,"in_reply_to":"1ae5cdf2_93df153a","updated":"2014-06-18 06:08:02.000000000","message":"done","commit_id":"3edb4dcdd502b17447cefbbeaacc9bf4fb27d5ec"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"22b2f1347f1365c069ae0185dfa94e3d68e8a177","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                 default\u003d0.5,"},{"line_number":44,"context_line":"                 help\u003d\u0027Sleep time in seconds for polling an ongoing async \u0027"},{"line_number":45,"context_line":"                      \u0027task\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027wsdl_location\u0027, default\u003dNone,"},{"line_number":47,"context_line":"               help\u003d\u0027Optional vim service WSDL location \u0027"},{"line_number":48,"context_line":"                    \u0027e.g http://\u003cserver\u003e/vimService.wsdl. \u0027"},{"line_number":49,"context_line":"                    \u0027Optional over-ride to default location for bug \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_ff8477d4","line":46,"updated":"2014-06-18 13:25:28.000000000","message":"sorry. should\u0027ve clarified... but you don\u0027t need default if it\u0027s None","commit_id":"f47aa133c579aa11587b889af020ffab3afbcc40"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"3376750ac124259a117973b4262419bbd454eeca","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                 default\u003d0.5,"},{"line_number":44,"context_line":"                 help\u003d\u0027Sleep time in seconds for polling an ongoing async \u0027"},{"line_number":45,"context_line":"                      \u0027task\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027wsdl_location\u0027, default\u003dNone,"},{"line_number":47,"context_line":"               help\u003d\u0027Optional vim service WSDL location \u0027"},{"line_number":48,"context_line":"                    \u0027e.g http://\u003cserver\u003e/vimService.wsdl. \u0027"},{"line_number":49,"context_line":"                    \u0027Optional over-ride to default location for bug \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_a5602236","line":46,"in_reply_to":"1ae5cdf2_ff8477d4","updated":"2014-06-18 14:05:10.000000000","message":"ah, I should have known. will fix it right away.","commit_id":"f47aa133c579aa11587b889af020ffab3afbcc40"}],"ceilometer/tests/compute/virt/vmware/test_inspector.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"df5879451a38e340923015f146b0d4fe1ce079c8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        api_session \u003d api.VMwareAPISession(\"test_server\", \"test_user\","},{"line_number":32,"context_line":"                                           \"test_password\", 0, None,"},{"line_number":33,"context_line":"                                           create_session\u003dFalse)"},{"line_number":34,"context_line":"        api_session._vim \u003d mock.MagicMock()"},{"line_number":35,"context_line":"        vsphere_inspector.get_api_session \u003d mock.Mock("},{"line_number":36,"context_line":"            return_value\u003dapi_session)"},{"line_number":37,"context_line":"        self._inspector \u003d vsphere_inspector.VsphereInspector()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_6a8beb1e","side":"PARENT","line":34,"updated":"2014-06-05 18:03:43.000000000","message":"maybe my comment is a bit misleading, what I said is that, I think \n\n    api_session._vim \u003d mock.MagicMock()\n\ncan be changed to:\n\n    api_session.vim \u003d mock.MagicMock()\n\nbut I run you patchset 6 in my local environment, it shows passed, I don\u0027t know why, seems I need to read more code","commit_id":"70882f7cbeba48c35e4e261937bba1481e8dc6cf"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"d367cbe61acbe88b98cb76184eb28ae119fe2e6e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        api_session \u003d api.VMwareAPISession(\"test_server\", \"test_user\","},{"line_number":32,"context_line":"                                           \"test_password\", 0, None,"},{"line_number":33,"context_line":"                                           create_session\u003dFalse)"},{"line_number":34,"context_line":"        api_session._vim \u003d mock.MagicMock()"},{"line_number":35,"context_line":"        vsphere_inspector.get_api_session \u003d mock.Mock("},{"line_number":36,"context_line":"            return_value\u003dapi_session)"},{"line_number":37,"context_line":"        self._inspector \u003d vsphere_inspector.VsphereInspector()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_d0df4e38","side":"PARENT","line":34,"in_reply_to":"1ae5cdf2_6a8beb1e","updated":"2014-06-05 18:19:34.000000000","message":"I dont\u0027 think mocking of vim is needed anymore.  Since we no more use vim.VIM here in inspector.py. hence removed it.","commit_id":"70882f7cbeba48c35e4e261937bba1481e8dc6cf"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"2906fe58373a1a0ce083a587e24d5b981618c1bd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        api_session \u003d api.VMwareAPISession(\"test_server\", \"test_user\","},{"line_number":32,"context_line":"                                           \"test_password\", 0, None,"},{"line_number":33,"context_line":"                                           create_session\u003dFalse)"},{"line_number":34,"context_line":"        api_session._vim \u003d mock.MagicMock()"},{"line_number":35,"context_line":"        vsphere_inspector.get_api_session \u003d mock.Mock("},{"line_number":36,"context_line":"            return_value\u003dapi_session)"},{"line_number":37,"context_line":"        self._inspector \u003d vsphere_inspector.VsphereInspector()"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_87157341","side":"PARENT","line":34,"updated":"2014-06-06 13:10:58.000000000","message":"what\u0027s this change for?","commit_id":"70882f7cbeba48c35e4e261937bba1481e8dc6cf"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"03d8171786fd3aa3007f03c7957165e1c2d37c75","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        api_session \u003d api.VMwareAPISession(\"test_server\", \"test_user\","},{"line_number":32,"context_line":"                                           \"test_password\", 0, None,"},{"line_number":33,"context_line":"                                           create_session\u003dFalse)"},{"line_number":34,"context_line":"        api_session._vim \u003d mock.MagicMock()"},{"line_number":35,"context_line":"        vsphere_inspector.get_api_session \u003d mock.Mock("},{"line_number":36,"context_line":"            return_value\u003dapi_session)"},{"line_number":37,"context_line":"        self._inspector \u003d vsphere_inspector.VsphereInspector()"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_1e0449c5","side":"PARENT","line":34,"in_reply_to":"1ae5cdf2_87157341","updated":"2014-06-06 14:09:59.000000000","message":"vim.Vim is no more used, so the mocking is unnecessary.","commit_id":"70882f7cbeba48c35e4e261937bba1481e8dc6cf"}]}