)]}'
{"ceilometer/alarm/storage/base.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"1f62f9a169e51178d27118d8eae5b0119cc4d74f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                                         \u0027complex\u0027: False}}},"},{"line_number":30,"context_line":"    }"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, url, connection_cache):"},{"line_number":33,"context_line":"        \"\"\"Constructor.\"\"\""},{"line_number":34,"context_line":"        pass"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_4f4e1d98","line":32,"updated":"2014-06-06 15:30:12.000000000","message":"What about making connection_cache an optional named parameter defaulting to None? Then you wouldn\u0027t need to make quite so many changes while still preserving the option for the future?","commit_id":"f5c8f8a477f19c0828adb82868cb47cf8f46cd5c"}],"ceilometer/storage/__init__.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"11fa33d057f28864a1e14d78b9d115f96fd51e1b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    LOG.debug(_(\u0027looking for %(name)r driver in %(namespace)r\u0027) % ("},{"line_number":90,"context_line":"              {\u0027name\u0027: engine_name, \u0027namespace\u0027: namespace}))"},{"line_number":91,"context_line":"    mgr \u003d driver.DriverManager(namespace, engine_name)"},{"line_number":92,"context_line":"    return mgr.driver(url, connection_engine_cache)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"def get_cached(cache, key, builder, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_7d2a6830","line":92,"updated":"2014-07-23 09:32:15.000000000","message":"I think that it should be get_connection() that should use get_cached(), not each driver.","commit_id":"52768e4c3e897213f5b71b1fb465e261f6ff56ff"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"9962ae1a7c0c18000ffb9dca585ffc7bada8860f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    LOG.debug(_(\u0027looking for %(name)r driver in %(namespace)r\u0027) % ("},{"line_number":90,"context_line":"              {\u0027name\u0027: engine_name, \u0027namespace\u0027: namespace}))"},{"line_number":91,"context_line":"    mgr \u003d driver.DriverManager(namespace, engine_name)"},{"line_number":92,"context_line":"    return mgr.driver(url, connection_engine_cache)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"def get_cached(cache, key, builder, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_9a87deb5","line":92,"in_reply_to":"baada198_7d2a6830","updated":"2014-07-25 14:35:40.000000000","message":"I have changed that a bit, lets me know WDYT ?","commit_id":"52768e4c3e897213f5b71b1fb465e261f6ff56ff"}]}