)]}'
{"ceilometer/central/plugin.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"29e65a84b5a785196fcba642faf172337301be94","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            manager \u003d args[0]"},{"line_number":40,"context_line":"        keystone \u003d getattr(manager, \u0027keystone\u0027, None)"},{"line_number":41,"context_line":"        if not keystone or isinstance(keystone, Exception):"},{"line_number":42,"context_line":"            LOG.info(_(\u0027Skip due to keystone error %s\u0027),"},{"line_number":43,"context_line":"                     str(keystone) if keystone else \u0027\u0027)"},{"line_number":44,"context_line":"            return itertools.chain([])"},{"line_number":45,"context_line":"        return f(self, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_7a5d27e9","line":42,"updated":"2014-06-09 14:03:54.000000000","message":"error instead of info since we expect keystone to be set up","commit_id":"7229f9c2bf51c07187712d78c0e4ff5757d90565"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"5dbb4eef11b76d2624e7c210e83d1e84d123eeb0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            manager \u003d args[0]"},{"line_number":40,"context_line":"        keystone \u003d getattr(manager, \u0027keystone\u0027, None)"},{"line_number":41,"context_line":"        if not keystone or isinstance(keystone, Exception):"},{"line_number":42,"context_line":"            LOG.info(_(\u0027Skip due to keystone error %s\u0027),"},{"line_number":43,"context_line":"                     str(keystone) if keystone else \u0027\u0027)"},{"line_number":44,"context_line":"            return itertools.chain([])"},{"line_number":45,"context_line":"        return f(self, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_f5e69315","line":42,"in_reply_to":"1ae5cdf2_7a5d27e9","updated":"2014-06-10 01:05:13.000000000","message":"Done","commit_id":"7229f9c2bf51c07187712d78c0e4ff5757d90565"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"29e65a84b5a785196fcba642faf172337301be94","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        if not keystone or isinstance(keystone, Exception):"},{"line_number":42,"context_line":"            LOG.info(_(\u0027Skip due to keystone error %s\u0027),"},{"line_number":43,"context_line":"                     str(keystone) if keystone else \u0027\u0027)"},{"line_number":44,"context_line":"            return itertools.chain([])"},{"line_number":45,"context_line":"        return f(self, *args, **kwargs)"},{"line_number":46,"context_line":"    return func"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_ba6ecf94","line":44,"updated":"2014-06-09 14:03:54.000000000","message":"what\u0027s this for?","commit_id":"7229f9c2bf51c07187712d78c0e4ff5757d90565"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"5dbb4eef11b76d2624e7c210e83d1e84d123eeb0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        if not keystone or isinstance(keystone, Exception):"},{"line_number":42,"context_line":"            LOG.info(_(\u0027Skip due to keystone error %s\u0027),"},{"line_number":43,"context_line":"                     str(keystone) if keystone else \u0027\u0027)"},{"line_number":44,"context_line":"            return itertools.chain([])"},{"line_number":45,"context_line":"        return f(self, *args, **kwargs)"},{"line_number":46,"context_line":"    return func"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_958b8f1d","line":44,"in_reply_to":"1ae5cdf2_ba6ecf94","updated":"2014-06-10 01:05:13.000000000","message":"According to the interface definition, the get_samples() should return an interable. I\u0027ll change it to the simple form iter([]) though.","commit_id":"7229f9c2bf51c07187712d78c0e4ff5757d90565"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"dc3cb8ce84efab50cfd4855982efa3dc2d129d92","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        if not manager and len(args) \u003e 0:"},{"line_number":37,"context_line":"            manager \u003d args[0]"},{"line_number":38,"context_line":"        keystone \u003d getattr(manager, \u0027keystone\u0027, None)"},{"line_number":39,"context_line":"        if not keystone or isinstance(keystone, Exception):"},{"line_number":40,"context_line":"            LOG.error(_(\u0027Skip due to keystone error %s\u0027),"},{"line_number":41,"context_line":"                      str(keystone) if keystone else \u0027\u0027)"},{"line_number":42,"context_line":"            return iter([])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_1f607134","line":39,"updated":"2014-06-10 10:03:41.000000000","message":"Non-blocking nitpick: the \u0027not keystone or\u0027 clause is unnecessary.","commit_id":"5e5559b5450bf933d4aefcbd45abbcacac405e1b"}]}