)]}'
{"ceilometer/exceptions.py":[{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"be3100cce4260454c38e177b76e3df3706c6775a","unresolved":true,"context_lines":[{"line_number":13,"context_line":"\"\"\"Ceilometer exception definitions.\"\"\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class NotFound(Exception):"},{"line_number":17,"context_line":"    \"\"\"Resource not found."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    Raised when a find operation matches no resources."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8f22fa_70741e1f","line":16,"updated":"2026-04-14 20:17:04.000000000","message":"If we\u0027re now going to have a series of Ceilometer exceptions, maybe it would be prudent to have a `CeilometerError` base class that these exception classes inherit from.","commit_id":"d11657313136ae41e58387e0cda0283d4c365d65"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"6a2610d851b0e99bfddaad929e6be00bc8d3126d","unresolved":true,"context_lines":[{"line_number":13,"context_line":"\"\"\"Ceilometer exception definitions.\"\"\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class NotFound(Exception):"},{"line_number":17,"context_line":"    \"\"\"Resource not found."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    Raised when a find operation matches no resources."}],"source_content_type":"text/x-python","patch_set":4,"id":"8a8b2771_b40f2cd5","line":16,"in_reply_to":"5a8f22fa_70741e1f","updated":"2026-04-15 19:49:16.000000000","message":"I think this is done in other OpenStack projects.\n\n\nI could fix it here, or I could propose it in a follow-up patch. What do you think?","commit_id":"d11657313136ae41e58387e0cda0283d4c365d65"},{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"f88a828a04eccf86d95d64b60ef70f769bf28da2","unresolved":true,"context_lines":[{"line_number":13,"context_line":"\"\"\"Ceilometer exception definitions.\"\"\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class NotFound(Exception):"},{"line_number":17,"context_line":"    \"\"\"Resource not found."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    Raised when a find operation matches no resources."}],"source_content_type":"text/x-python","patch_set":4,"id":"f3de2726_0e5e4ba6","line":16,"in_reply_to":"8a8b2771_b40f2cd5","updated":"2026-04-15 19:50:40.000000000","message":"It\u0027s not a large addition, would you be able to do it in this change?","commit_id":"d11657313136ae41e58387e0cda0283d4c365d65"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"47a3064ef3c08fb85fddf37771af1a77b84314bf","unresolved":true,"context_lines":[{"line_number":13,"context_line":"\"\"\"Ceilometer exception definitions.\"\"\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class NotFound(Exception):"},{"line_number":17,"context_line":"    \"\"\"Resource not found."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    Raised when a find operation matches no resources."}],"source_content_type":"text/x-python","patch_set":4,"id":"f6886a08_984d580b","line":16,"in_reply_to":"f3de2726_0e5e4ba6","updated":"2026-04-16 11:50:55.000000000","message":"Done. I\u0027ve written a minimal CeilometerException class. There\u0027s currently no special logic in it.","commit_id":"d11657313136ae41e58387e0cda0283d4c365d65"},{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"c356c03a2e30086b016ae9fa049d7acffa81c57e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\"\"\"Ceilometer exception definitions.\"\"\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class NotFound(Exception):"},{"line_number":17,"context_line":"    \"\"\"Resource not found."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    Raised when a find operation matches no resources."}],"source_content_type":"text/x-python","patch_set":4,"id":"652cbb10_0001640b","line":16,"in_reply_to":"f6886a08_984d580b","updated":"2026-04-16 20:38:56.000000000","message":"Looks good, thanks!","commit_id":"d11657313136ae41e58387e0cda0283d4c365d65"}],"ceilometer/publisher/gnocchi.py":[{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"cfb5500540702cbcb2cd812c119420c546d12467","unresolved":true,"context_lines":[{"line_number":311,"context_line":"                    project \u003d self._ks_client.find_project("},{"line_number":312,"context_line":"                        name\u003dself.filter_project,"},{"line_number":313,"context_line":"                        domain_id\u003ddomain.id)"},{"line_number":314,"context_line":"                except (ceilo_exc.NotFound, ceilo_exc.NoUniqueMatch):"},{"line_number":315,"context_line":"                    LOG.warning(\u0027Filtered project [%s] not found in keystone, \u0027"},{"line_number":316,"context_line":"                                \u0027ignoring the filter_project option\u0027,"},{"line_number":317,"context_line":"                                self.filter_project)"}],"source_content_type":"text/x-python","patch_set":2,"id":"062c5851_212e8ef4","line":314,"range":{"start_line":314,"start_character":16,"end_line":314,"end_character":69},"updated":"2026-04-13 13:38:06.000000000","message":"This is not the same behaviour.\n\nPreviously, the NoUniqueMatch would have been caught in Exception, so it should remain tat way.","commit_id":"3db4d256ac9ef862250df890e574bcc54fa04bec"}]}
