)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"53e3fcc23e448a7148e686032a76d5db5fdc9769","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"36ebaf40_08ad51ea","updated":"2026-04-08 09:19:46.000000000","message":"What do you think about additional cleanup by removing the `with mock.patch(\u0027openstack.connection.Connection\u0027)` in test_designate.py, test_manila.py and test_octavia.py now that you have the FakeConnectionFixture in the base class? I tried doing that in my devstack and tests seem to pass. (could be done as a followup as well)","commit_id":"68f8f646789c99d5b40c2fe18ea2135d17938c3c"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"06bcface2f465f025a03c3852d724a6e94ae1281","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4534314d_79846299","in_reply_to":"36ebaf40_08ad51ea","updated":"2026-04-09 18:54:08.000000000","message":"I think that that\u0027s better as a follow-up, since there might be some more updates needed to add octavia, designate and manila clients to the FakeConnection.\n\nThe way that the mocking is done in octavia needs to be updated a bit to conform to the fakeconnetion + fixture \u0026 set up the return values to reflect what\u0027s being returned from Connection, rather than from the clients in ceilometer.","commit_id":"68f8f646789c99d5b40c2fe18ea2135d17938c3c"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"70b27486cd3dbef2da39d7f78c49f37d9b2a3990","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"73bd5975_6d0e4550","in_reply_to":"4534314d_79846299","updated":"2026-04-09 21:16:46.000000000","message":"Acknowledged","commit_id":"68f8f646789c99d5b40c2fe18ea2135d17938c3c"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"3c7dad0ef728f5067a33aa5e4cbe9822e09df3a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"43ff0eda_32537a1b","updated":"2026-04-13 06:09:28.000000000","message":"Thank you, looks good to me","commit_id":"ff46adce85be1bb805acc6d6f5cbb94e0ac96c77"}],"ceilometer/tests/unit/fakes.py":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"53e3fcc23e448a7148e686032a76d5db5fdc9769","unresolved":true,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    Usage::"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        fix \u003d self.useFixture(fakes.FakeConnectionFixture()"},{"line_number":111,"context_line":"        fix.fake_conn.list_projects.assert_called_once_with(...)"},{"line_number":112,"context_line":"        fix.mock.assert_called_once_with(session\u003d..., service_types\u003d...)"},{"line_number":113,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"e63b8c37_88fb417e","line":110,"updated":"2026-04-08 09:19:46.000000000","message":"```suggestion\n        fix \u003d self.useFixture(fakes.FakeConnectionFixture())\n```","commit_id":"68f8f646789c99d5b40c2fe18ea2135d17938c3c"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"d77b35614cd1c6cb27eacb8feb076aa33070785b","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    Usage::"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        fix \u003d self.useFixture(fakes.FakeConnectionFixture()"},{"line_number":111,"context_line":"        fix.fake_conn.list_projects.assert_called_once_with(...)"},{"line_number":112,"context_line":"        fix.mock.assert_called_once_with(session\u003d..., service_types\u003d...)"},{"line_number":113,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7c6f2724_a9112e76","line":110,"in_reply_to":"e63b8c37_88fb417e","updated":"2026-04-10 11:12:54.000000000","message":"Done","commit_id":"68f8f646789c99d5b40c2fe18ea2135d17938c3c"}]}