)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"41250d56b41746e2a4849eb6d5864669567fdc14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0c445475_a241af0e","updated":"2026-05-06 23:03:35.000000000","message":"The mocking looks right, but it\u0027s done at the wrong level, which only became obvious in the next change in the series.","commit_id":"8904f5867ae60c78eea1eed525f48251f59e20b4"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"613d458925f35a014d340734fbaf95659da5b0fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"13fdd1b3_ec580dd3","updated":"2026-05-11 13:57:54.000000000","message":"ditto for the other testcases","commit_id":"4fba323f63aee033b63ca12a0a06a945499693f5"}],"ceilometer/tests/unit/volume/test_discovery.py":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"a982a67c46ea7080abeba965467ef6248a5a9869","unresolved":true,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.assertEqual(fakes.VOLUME_LIST, resources)"},{"line_number":56,"context_line":"        self.assertEqual(len(fakes.VOLUME_LIST), len(resources))"},{"line_number":57,"context_line":"        self.assertEqual(fakes.VOLUME.id, resources[0].id)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_discover_empty(self):"},{"line_number":60,"context_line":"        self.discovery.client.volumes.list \u003d mock.Mock("}],"source_content_type":"text/x-python","patch_set":5,"id":"25b8f4ed_43272803","line":57,"updated":"2026-05-11 13:57:29.000000000","message":"I think the bottom 2 lines are redundant. If `assertEqual(fakes.VOLUME_LIST, resources)` passes, then we also know the length is the same and we also know the id of the first element is the same as well. Similarly, if the first line fails, I don\u0027t think the other 2 will get executed.\n\nIt may make a little bit more sense if the order of the lines was reversed, which may give us some more detailed error message, but imo we should be fine with just the first line.","commit_id":"4fba323f63aee033b63ca12a0a06a945499693f5"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"613d458925f35a014d340734fbaf95659da5b0fd","unresolved":true,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.assertEqual(fakes.VOLUME_LIST, resources)"},{"line_number":56,"context_line":"        self.assertEqual(len(fakes.VOLUME_LIST), len(resources))"},{"line_number":57,"context_line":"        self.assertEqual(fakes.VOLUME.id, resources[0].id)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_discover_empty(self):"},{"line_number":60,"context_line":"        self.discovery.client.volumes.list \u003d mock.Mock("}],"source_content_type":"text/x-python","patch_set":5,"id":"590afb41_5289eb4d","line":57,"in_reply_to":"25b8f4ed_43272803","updated":"2026-05-11 13:57:54.000000000","message":"ditto for the other testcases.","commit_id":"4fba323f63aee033b63ca12a0a06a945499693f5"}]}