)]}'
{"ceilometer/messaging.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"35a98dabf1a9f187f3540a6ec4e08ef405a8b892","unresolved":false,"context_lines":[{"line_number":99,"context_line":"def get_rpc_server(topic, endpoint):"},{"line_number":100,"context_line":"    \"\"\"Return a configured oslo.messaging rpc server.\"\"\""},{"line_number":101,"context_line":"    global TRANSPORT"},{"line_number":102,"context_line":"    cfg.CONF.import_opt(\u0027host\u0027, \u0027ceilometer.service\u0027)"},{"line_number":103,"context_line":"    target \u003d oslo.messaging.Target(server\u003dcfg.CONF.host, topic\u003dtopic)"},{"line_number":104,"context_line":"    serializer \u003d RequestContextSerializer(JsonPayloadSerializer())"},{"line_number":105,"context_line":"    return oslo.messaging.get_rpc_server(TRANSPORT, target, [endpoint],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_607448fe","line":102,"updated":"2014-06-11 09:57:26.000000000","message":"Can we move this \u0027import_opt\u0027 in global ?","commit_id":"46d4f175b0b556df27fb339c2e446e7cd0e972fe"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"4f7859c448dd63d25fb2f2b6e15ef40549625332","unresolved":false,"context_lines":[{"line_number":99,"context_line":"def get_rpc_server(topic, endpoint):"},{"line_number":100,"context_line":"    \"\"\"Return a configured oslo.messaging rpc server.\"\"\""},{"line_number":101,"context_line":"    global TRANSPORT"},{"line_number":102,"context_line":"    cfg.CONF.import_opt(\u0027host\u0027, \u0027ceilometer.service\u0027)"},{"line_number":103,"context_line":"    target \u003d oslo.messaging.Target(server\u003dcfg.CONF.host, topic\u003dtopic)"},{"line_number":104,"context_line":"    serializer \u003d RequestContextSerializer(JsonPayloadSerializer())"},{"line_number":105,"context_line":"    return oslo.messaging.get_rpc_server(TRANSPORT, target, [endpoint],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_fb5b861f","line":102,"in_reply_to":"1ae5cdf2_2ac5ba8d","updated":"2014-06-12 02:41:31.000000000","message":"Yes, it\u0027s because of the recursive import. I\u0027ll move the host definition into this file.","commit_id":"46d4f175b0b556df27fb339c2e446e7cd0e972fe"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"e83c642b19b0c95988d587d4135c22aa8a10c72f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"def get_rpc_server(topic, endpoint):"},{"line_number":100,"context_line":"    \"\"\"Return a configured oslo.messaging rpc server.\"\"\""},{"line_number":101,"context_line":"    global TRANSPORT"},{"line_number":102,"context_line":"    cfg.CONF.import_opt(\u0027host\u0027, \u0027ceilometer.service\u0027)"},{"line_number":103,"context_line":"    target \u003d oslo.messaging.Target(server\u003dcfg.CONF.host, topic\u003dtopic)"},{"line_number":104,"context_line":"    serializer \u003d RequestContextSerializer(JsonPayloadSerializer())"},{"line_number":105,"context_line":"    return oslo.messaging.get_rpc_server(TRANSPORT, target, [endpoint],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_2ac5ba8d","line":102,"in_reply_to":"1ae5cdf2_607448fe","updated":"2014-06-11 09:59:30.000000000","message":"Or move the cfg.CONF.host definition into this file, if this is due to a recursive import issue.","commit_id":"46d4f175b0b556df27fb339c2e446e7cd0e972fe"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"8717675199cf25f74c67284a9d24b0666a751f52","unresolved":false,"context_lines":[{"line_number":99,"context_line":"def get_rpc_server(topic, endpoint):"},{"line_number":100,"context_line":"    \"\"\"Return a configured oslo.messaging rpc server.\"\"\""},{"line_number":101,"context_line":"    global TRANSPORT"},{"line_number":102,"context_line":"    cfg.CONF.import_opt(\u0027host\u0027, \u0027ceilometer.service\u0027)"},{"line_number":103,"context_line":"    target \u003d oslo.messaging.Target(server\u003dcfg.CONF.host, topic\u003dtopic)"},{"line_number":104,"context_line":"    serializer \u003d RequestContextSerializer(JsonPayloadSerializer())"},{"line_number":105,"context_line":"    return oslo.messaging.get_rpc_server(TRANSPORT, target, [endpoint],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_fb89c66f","line":102,"in_reply_to":"1ae5cdf2_fb5b861f","updated":"2014-06-12 02:44:10.000000000","message":"@Mehdi, on a second thought, why not leave the host definition there, I think it is more reasonable to find the host definition in the service module, though the service.py never use that.","commit_id":"46d4f175b0b556df27fb339c2e446e7cd0e972fe"}],"ceilometer/tests/api/__init__.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"d77b196d386cb7b018819e321847159b60075ffb","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.CONF.set_override(\"auth_version\", \"v2.0\","},{"line_number":47,"context_line":"                               group\u003dOPT_GROUP_NAME)"},{"line_number":48,"context_line":"        self.CONF.import_opt(\"policy_file\","},{"line_number":49,"context_line":"                             \"ceilometer.openstack.common.policy\")"},{"line_number":50,"context_line":"        self.CONF.set_override(\"policy_file\","},{"line_number":51,"context_line":"                               self.path_get(\u0027etc/ceilometer/policy.json\u0027))"},{"line_number":52,"context_line":"        self.app \u003d self._make_app()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d7fd08b3","line":49,"updated":"2014-06-17 20:00:46.000000000","message":"out of curiosity, why do we need to import this opt but not auth_version above?\n\nit\u0027d also be better if we import this globally above","commit_id":"46d4f175b0b556df27fb339c2e446e7cd0e972fe"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"5dfef0caf2ca1e9671ae71e36138425adf589995","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.CONF.set_override(\"auth_version\", \"v2.0\","},{"line_number":47,"context_line":"                               group\u003dOPT_GROUP_NAME)"},{"line_number":48,"context_line":"        self.CONF.import_opt(\"policy_file\","},{"line_number":49,"context_line":"                             \"ceilometer.openstack.common.policy\")"},{"line_number":50,"context_line":"        self.CONF.set_override(\"policy_file\","},{"line_number":51,"context_line":"                               self.path_get(\u0027etc/ceilometer/policy.json\u0027))"},{"line_number":52,"context_line":"        self.app \u003d self._make_app()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_e9769ba2","line":49,"in_reply_to":"1ae5cdf2_d7fd08b3","updated":"2014-06-18 02:51:21.000000000","message":"The auth_version above is already imported.\n\nimport it globally.","commit_id":"46d4f175b0b556df27fb339c2e446e7cd0e972fe"}],"ceilometer/tests/test_collector.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"d77b196d386cb7b018819e321847159b60075ffb","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.CONF \u003d self.useFixture(config.Config()).conf"},{"line_number":47,"context_line":"        self.CONF.import_opt(\"connection\","},{"line_number":48,"context_line":"                             \"ceilometer.openstack.common.db.options\","},{"line_number":49,"context_line":"                             group\u003d\"database\")"},{"line_number":50,"context_line":"        self.CONF.set_override(\"connection\", \"log://\", group\u003d\u0027database\u0027)"},{"line_number":51,"context_line":"        self.CONF.set_override(\u0027metering_secret\u0027, \u0027not-so-secret\u0027,"},{"line_number":52,"context_line":"                               group\u003d\u0027publisher\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_777b5429","line":49,"updated":"2014-06-17 20:00:46.000000000","message":"same question as before, why no need to import metering_secret?","commit_id":"46d4f175b0b556df27fb339c2e446e7cd0e972fe"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"5dfef0caf2ca1e9671ae71e36138425adf589995","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.CONF \u003d self.useFixture(config.Config()).conf"},{"line_number":47,"context_line":"        self.CONF.import_opt(\"connection\","},{"line_number":48,"context_line":"                             \"ceilometer.openstack.common.db.options\","},{"line_number":49,"context_line":"                             group\u003d\"database\")"},{"line_number":50,"context_line":"        self.CONF.set_override(\"connection\", \"log://\", group\u003d\u0027database\u0027)"},{"line_number":51,"context_line":"        self.CONF.set_override(\u0027metering_secret\u0027, \u0027not-so-secret\u0027,"},{"line_number":52,"context_line":"                               group\u003d\u0027publisher\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_69c8cb75","line":49,"in_reply_to":"1ae5cdf2_777b5429","updated":"2014-06-18 02:51:21.000000000","message":"because of the statement of line 33: from ceiloemter.publisher import utils","commit_id":"46d4f175b0b556df27fb339c2e446e7cd0e972fe"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"50b5afedd32515ddf9e9648e267ed99c28e75535","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":"import msgpack"},{"line_number":22,"context_line":"import oslo.messaging"},{"line_number":23,"context_line":"import oslo.messaging.conffixture"},{"line_number":24,"context_line":"from stevedore import extension"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from ceilometer import collector"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_8bc26251","line":23,"updated":"2014-06-18 09:24:25.000000000","message":"This should be not needed. It\u0027s already done by the tests base class","commit_id":"f543c55ea8a4627dea0a061e8a4a4111b4c07dd1"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"9cb07ffada691603e99965801f8839ddde94b0cf","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":"import msgpack"},{"line_number":22,"context_line":"import oslo.messaging"},{"line_number":23,"context_line":"import oslo.messaging.conffixture"},{"line_number":24,"context_line":"from stevedore import extension"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from ceilometer import collector"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_ff974543","line":23,"in_reply_to":"1ae5cdf2_8bc26251","updated":"2014-06-25 00:49:42.000000000","message":"i\u0027ve moved this into test base.","commit_id":"f543c55ea8a4627dea0a061e8a4a4111b4c07dd1"}],"ceilometer/tests/test_middleware.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"50b5afedd32515ddf9e9648e267ed99c28e75535","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def setUp(self):"},{"line_number":75,"context_line":"        super(TestNotifications, self).setUp()"},{"line_number":76,"context_line":"        self.CONF \u003d self.useFixture(config.Config()).conf"},{"line_number":77,"context_line":"        self.useFixture(oslo.messaging.conffixture.ConfFixture(self.CONF))"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_process_request_notification(self):"},{"line_number":80,"context_line":"        sample \u003d list(middleware.HTTPRequest(mock.Mock()).process_notification("}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_ab047ec6","line":77,"updated":"2014-06-18 09:24:25.000000000","message":"If we needs this fixture, this is because the rpc layer need to be setuped in tests.\nSo to setup it correctly for testing purpose, I have added recently a helper method into ceilometer/tests/base.py base class to do that like this:\n\n    self.setup_messaging(self.CONF)","commit_id":"f543c55ea8a4627dea0a061e8a4a4111b4c07dd1"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"9cb07ffada691603e99965801f8839ddde94b0cf","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def setUp(self):"},{"line_number":75,"context_line":"        super(TestNotifications, self).setUp()"},{"line_number":76,"context_line":"        self.CONF \u003d self.useFixture(config.Config()).conf"},{"line_number":77,"context_line":"        self.useFixture(oslo.messaging.conffixture.ConfFixture(self.CONF))"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_process_request_notification(self):"},{"line_number":80,"context_line":"        sample \u003d list(middleware.HTTPRequest(mock.Mock()).process_notification("}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_ffa5859f","line":77,"in_reply_to":"1ae5cdf2_ab047ec6","updated":"2014-06-25 00:49:42.000000000","message":"Done","commit_id":"f543c55ea8a4627dea0a061e8a4a4111b4c07dd1"}]}