)]}'
{"id":"openstack%2Fceilometer~993969","triplet_id":"openstack%2Fceilometer~master~I1f7ba6d370446f6c0887d200e36ca0746ab1ed2d","project":"openstack/ceilometer","branch":"master","topic":"oslotest-autospec","attention_set":{"8213":{"account":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"last_update":"2026-06-29 11:26:12.000000000","reason":"\u003cGERRIT_ACCOUNT_11604\u003e replied on the change","reason_account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I1f7ba6d370446f6c0887d200e36ca0746ab1ed2d","subject":"tests: Enforce autospec\u003dTrue on mock patches","status":"NEW","created":"2026-06-18 16:47:39.000000000","updated":"2026-06-29 11:30:24.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":3,"unresolved_comment_count":3,"has_review_started":true,"meta_rev_id":"3f23c68d431b410db429b4318dc92c3b42092c51","_number":993969,"virtual_id_number":993969,"owner":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},{"tag":"autogenerated:zuul:check","value":1,"date":"2026-06-22 09:58:07.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"all":[{"value":-1,"date":"2026-06-29 11:26:12.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":-1,"date":"2026-06-29 11:30:24.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-18 17:01:51.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-06-29 11:26:12.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2026-06-29 11:30:24.000000000","updated_by":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"reviewer":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"state":"REVIEWER"}],"messages":[{"id":"7cfd1719c5855d16b697461dc3c0ebedc675b17b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"date":"2026-06-18 16:47:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2359a21d9a0cf86e58fb3dc677af58a4545f4481","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-18 17:01:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/03cd248101ea4612804fb51970d27070\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/cc2649af6866420a8cdf58874ad27540 : SUCCESS in 8m 48s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8cde5873a16343f9a41309db9c731392 : SUCCESS in 3m 16s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/b34e6c637e634dd599713def9ec80099 : SUCCESS in 4m 11s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/d261ac9382814380a0340512c894021a : SUCCESS in 4m 24s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/b7218971a11a4e1fbe17b5c1c1e6c646 : SUCCESS in 6m 24s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9d4d45916cbd4353a6f21db74a17dd59 : SUCCESS in 7m 50s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/af14975a15e64dd5a1d003c98eaf7df5 : SUCCESS in 5m 44s","accounts_in_message":[],"_revision_number":1},{"id":"592cd8e20cc35869cfa355acf28151f7c677277d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"date":"2026-06-22 09:44:39.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"NEVER\")\n","accounts_in_message":[],"_revision_number":2},{"id":"4858922aa6541609d20bfe90d19d43206a54f640","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-22 09:58:07.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/74aecf95b3244c9c911d1bca51955896\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/701e4c7e201e4c6e9ad243b05f2b73f7 : SUCCESS in 8m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a0b7daac0a194a2d87e8c74a8c2542b3 : SUCCESS in 2m 19s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/e2eb030c85de49c0aef231c2650b790a : SUCCESS in 5m 04s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/0de3c2f515ff4af1971560e3210f68bc : SUCCESS in 3m 47s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/5348c51b284148cf807d038a65b50350 : SUCCESS in 5m 49s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a873782f9f834aaca6dd24f66fd29407 : SUCCESS in 4m 21s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/de474206a88044a1909d1abdb66bc94b : SUCCESS in 6m 07s","accounts_in_message":[],"_revision_number":2},{"id":"2a4768e725d63fa68552ede24712817a42482959","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"date":"2026-06-28 16:17:41.000000000","message":"Topic set to oslotest-autospec","accounts_in_message":[],"_revision_number":2},{"id":"ad166eca68a5b4ebe140ae13a6d2177f82165308","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2026-06-29 11:26:12.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3f23c68d431b410db429b4318dc92c3b42092c51","author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"date":"2026-06-29 11:30:24.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4d28dec524d3704bb954dcbbef6c90c3e6c0c48f","revisions":{"0ffce45973b8287a6bee6a2ffb13781d6793e7a5":{"kind":"REWORK","_number":1,"created":"2026-06-18 16:47:39.000000000","uploader":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"ref":"refs/changes/69/993969/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/69/993969/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/69/993969/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/69/993969/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/69/993969/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/69/993969/1"}}},"commit":{"parents":[{"commit":"44bcfc24036cdbef030e5d97caea2dc8c26379d2","subject":"Merge \"Add comprehensive test coverage for cinder pollsters\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/44bcfc24036cdbef030e5d97caea2dc8c26379d2"}]}],"author":{"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","date":"2026-06-13 10:33:34.000000000","tz":0},"committer":{"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","date":"2026-06-18 16:47:28.000000000","tz":0},"subject":"tests: enforce autospec\u003dTrue via oslotest mock_fixture","message":"tests: enforce autospec\u003dTrue via oslotest mock_fixture\n\nUsing mock_fixture.patch_mock_module() will enforce autospec\u003dTrue on all\nthe mock.patch and similar calls. This will enforce signature checks on\nthe mocked methods and functions, catching potential bugs missed by\notherwise false positive unit tests.\n\nAdditionally, mock_fixture adds the ability to add autospecs to\nmock.Mock and mock.MagicMock.\n\nChange-Id: I1f7ba6d370446f6c0887d200e36ca0746ab1ed2d\nSigned-off-by: Claudiu Belu \u003ccbelu@cloudbasesolutions.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/0ffce45973b8287a6bee6a2ffb13781d6793e7a5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/0ffce45973b8287a6bee6a2ffb13781d6793e7a5"}]},"branch":"refs/heads/master"},"4d28dec524d3704bb954dcbbef6c90c3e6c0c48f":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-06-22 09:44:39.000000000","uploader":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"ref":"refs/changes/69/993969/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/69/993969/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/69/993969/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/69/993969/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/69/993969/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/69/993969/2"}}},"commit":{"parents":[{"commit":"44bcfc24036cdbef030e5d97caea2dc8c26379d2","subject":"Merge \"Add comprehensive test coverage for cinder pollsters\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/44bcfc24036cdbef030e5d97caea2dc8c26379d2"}]}],"author":{"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","date":"2026-06-13 10:33:34.000000000","tz":0},"committer":{"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","date":"2026-06-22 09:44:28.000000000","tz":0},"subject":"tests: Enforce autospec\u003dTrue on mock patches","message":"tests: Enforce autospec\u003dTrue on mock patches\n\nUsing mock_fixture.patch_mock_module() will enforce autospec\u003dTrue on all\nthe mock.patch and similar calls. This will enforce signature checks on\nthe mocked methods and functions, catching potential bugs missed by\notherwise false positive unit tests.\n\nAdditionally, mock_fixture adds the ability to add autospecs to\nmock.Mock and mock.MagicMock.\n\nChange-Id: I1f7ba6d370446f6c0887d200e36ca0746ab1ed2d\nSigned-off-by: Claudiu Belu \u003ccbelu@cloudbasesolutions.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/4d28dec524d3704bb954dcbbef6c90c3e6c0c48f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/4d28dec524d3704bb954dcbbef6c90c3e6c0c48f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"}},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}