)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"9bffe68173c0a5877b290054b43eba5756b2659d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c8e10681_b99a365f","updated":"2026-07-02 01:56:11.000000000","message":"recheck let\u0027s see if it is just a CI problem","commit_id":"c70d873004f57feb8a5334de1419fcf14bfe0969"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"4eae274c998d49a64a1721cdd743c968014e3d13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"98954cad_e51ac0a4","updated":"2026-07-09 13:45:49.000000000","message":"Also, it would be nice to add some tests for this specific use case.","commit_id":"89a38ad4c58ec351fee503a96590c864277a887f"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"e0308e03c0ee855d540f4e1b76d92eb8b53b802d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8f8f1214_d76fa11a","in_reply_to":"98954cad_e51ac0a4","updated":"2026-07-13 19:32:31.000000000","message":"Done. Can you review it again?","commit_id":"89a38ad4c58ec351fee503a96590c864277a887f"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"df65e52dae77401df2a8136cacebb2e9f0aaa68e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"10e058c9_e18dbc36","updated":"2026-07-14 17:15:40.000000000","message":"Everything seems to be fine for a review now.","commit_id":"b31cf127349043d3885460649c2cb7da1b53419b"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"96d991da4f80a814faf2e2e02e8da326dc784123","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f3cef42f_91bbedd7","updated":"2026-08-06 12:12:15.000000000","message":"Rafael, can you please update the patch and take at least your print(\"RAFAEL TODOS: \") out?","commit_id":"b31cf127349043d3885460649c2cb7da1b53419b"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"5ffdf03290fe0cf10d2e1f7fb1ef71e850a0928f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2165c1b2_17380079","in_reply_to":"f3cef42f_91bbedd7","updated":"2026-08-06 22:04:14.000000000","message":"Done.\n I missed them...","commit_id":"b31cf127349043d3885460649c2cb7da1b53419b"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"44a18d25d1838d1019a3062a7297b7feea9a92b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3bfa09b2_29b1f8f2","updated":"2026-08-07 07:11:51.000000000","message":"Thank you, looks good to me now.","commit_id":"3b83d59fefbaf9075b579f0c07ec705c9a467292"}],"ceilometer/polling/discovery/endpoint.py":[{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"96f51ccc51b247ecc39b0b09385a403701221ae7","unresolved":true,"context_lines":[{"line_number":40,"context_line":"                        \"\u003call services\u003e\" if param is None else param)"},{"line_number":41,"context_line":"            return []"},{"line_number":42,"context_line":"        return endpoints"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def group_id(self):"},{"line_number":45,"context_line":"        if self.instance_group_id:"},{"line_number":46,"context_line":"            return self.instance_group_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"a2b00250_af905225","line":43,"updated":"2026-07-09 13:00:43.000000000","message":"This should add @property to match the DiscoveryBase class","commit_id":"89a38ad4c58ec351fee503a96590c864277a887f"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"e0308e03c0ee855d540f4e1b76d92eb8b53b802d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                        \"\u003call services\u003e\" if param is None else param)"},{"line_number":41,"context_line":"            return []"},{"line_number":42,"context_line":"        return endpoints"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def group_id(self):"},{"line_number":45,"context_line":"        if self.instance_group_id:"},{"line_number":46,"context_line":"            return self.instance_group_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a4d8082_9db33e16","line":43,"in_reply_to":"a2b00250_af905225","updated":"2026-07-13 19:32:31.000000000","message":"Done","commit_id":"89a38ad4c58ec351fee503a96590c864277a887f"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"96f51ccc51b247ecc39b0b09385a403701221ae7","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        if self.instance_group_id:"},{"line_number":46,"context_line":"            return self.instance_group_id"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        return super(EndpointDiscovery).group_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"f5f3c6b4_3f3b6bbc","line":48,"updated":"2026-07-09 13:00:43.000000000","message":"I believe this is wrong, calling super() with just one argument will not work. This should be super().group_id for python3.","commit_id":"89a38ad4c58ec351fee503a96590c864277a887f"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"e0308e03c0ee855d540f4e1b76d92eb8b53b802d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if self.instance_group_id:"},{"line_number":46,"context_line":"            return self.instance_group_id"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        return super(EndpointDiscovery).group_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"842eec0a_e642530a","line":48,"in_reply_to":"f5f3c6b4_3f3b6bbc","updated":"2026-07-13 19:32:31.000000000","message":"Exactly, I confused things here.","commit_id":"89a38ad4c58ec351fee503a96590c864277a887f"}],"ceilometer/polling/manager.py":[{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"00c08cb13161cfea6015be11ec229a7a5089685c","unresolved":true,"context_lines":[{"line_number":983,"context_line":""},{"line_number":984,"context_line":"        for d in self.discoveries:"},{"line_number":985,"context_line":"            if d.name \u003d\u003d name:"},{"line_number":986,"context_line":"                discover_found \u003d  d.obj"},{"line_number":987,"context_line":"        return discover_found"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"    def discover(self, discovery\u003dNone, discovery_cache\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"dc111f60_4ade5f23","line":986,"updated":"2026-07-15 07:31:20.000000000","message":"just a nit, but could you please remove the double space after the \u003d?","commit_id":"b31cf127349043d3885460649c2cb7da1b53419b"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"0d573743659a0f8143610fb158fc3d9b0040ecf5","unresolved":false,"context_lines":[{"line_number":983,"context_line":""},{"line_number":984,"context_line":"        for d in self.discoveries:"},{"line_number":985,"context_line":"            if d.name \u003d\u003d name:"},{"line_number":986,"context_line":"                discover_found \u003d  d.obj"},{"line_number":987,"context_line":"        return discover_found"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"    def discover(self, discovery\u003dNone, discovery_cache\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"8f79a961_2d359a0b","line":986,"in_reply_to":"dc111f60_4ade5f23","updated":"2026-08-06 22:03:54.000000000","message":"Done","commit_id":"b31cf127349043d3885460649c2cb7da1b53419b"}],"ceilometer/tests/unit/polling/test_manager.py":[{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"00c08cb13161cfea6015be11ec229a7a5089685c","unresolved":true,"context_lines":[{"line_number":192,"context_line":"            self.create_fake_dynamic_discoveries()"},{"line_number":193,"context_line":"        mgr.discoveries \u003d mgr.discoveries + extensions_dynamic_pollsters_fake"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        print(\"RAFAEL TODOS: [%s].\" % mgr.discoveries)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        barbican_discoverer \u003d None"},{"line_number":198,"context_line":"        for d in mgr.discoveries:"}],"source_content_type":"text/x-python","patch_set":7,"id":"0c8c75b4_5875c23a","line":195,"updated":"2026-07-15 07:31:20.000000000","message":"This seems to be a debug print that should not be merged ;)","commit_id":"b31cf127349043d3885460649c2cb7da1b53419b"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"00c08cb13161cfea6015be11ec229a7a5089685c","unresolved":true,"context_lines":[{"line_number":214,"context_line":"            if d.name \u003d\u003d \"barbican:123456\":"},{"line_number":215,"context_line":"                barbican_discoverer_randon_id \u003d d.obj"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        barbican_discoverer_other_id\u003d None"},{"line_number":218,"context_line":"        for d in mgr.discoveries:"},{"line_number":219,"context_line":"            if d.name \u003d\u003d \"barbican:otherId\":"},{"line_number":220,"context_line":"                barbican_discoverer_other_id \u003d d.obj"}],"source_content_type":"text/x-python","patch_set":7,"id":"30bc52cb_e638f219","line":217,"updated":"2026-07-15 07:31:20.000000000","message":"nit: there is a space missing before \u003d","commit_id":"b31cf127349043d3885460649c2cb7da1b53419b"}]}
