)]}'
{"ceilometer/tests/unit/test_novaclient.py":[{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"ab144b0316d20e08ac0ababfd63832deb2e49152","unresolved":true,"context_lines":[{"line_number":58,"context_line":"            instances[0].flavor[\u0027name\u0027])"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @staticmethod"},{"line_number":61,"context_line":"    def fake_servers_list_unknown_image(*args, **kwargs):"},{"line_number":62,"context_line":"        a \u003d mock.MagicMock()"},{"line_number":63,"context_line":"        a.id \u003d 42"},{"line_number":64,"context_line":"        a.flavor \u003d {\u0027id\u0027: 1}"}],"source_content_type":"text/x-python","patch_set":6,"id":"684f1d2d_1e8604f9","line":61,"updated":"2026-08-13 13:10:40.000000000","message":"I believe this method is not called anymore. Maybe we could clean it up?","commit_id":"4f6712a8a3f973982c4114487682a6c6bcc341f0"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"ab144b0316d20e08ac0ababfd63832deb2e49152","unresolved":true,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_with_flavor_and_image(self):"},{"line_number":80,"context_line":"        results \u003d self.nv._with_flavor_and_image("},{"line_number":81,"context_line":"            [fakes.SERVER_NC_WITH_HOST, fakes.SERVER2_NC_WITH_HOST])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        instance \u003d results[0]"},{"line_number":84,"context_line":"        self.assertEqual(2, len(results))"}],"source_content_type":"text/x-python","patch_set":6,"id":"9eb4824e_9d692e44","line":81,"updated":"2026-08-13 13:10:40.000000000","message":"You are passing here mutable fake servers to test methods that actually modify them, so every time they are being passed again and again, they keep being modified.\n\nThis is not a problem right now, but could be in future tests or executions. The code you are replacing was generating new mocks every time, but this one does not. \n\nI would suggest to use \"copy.deepcopy(fakes.SERVER_NC_WITH_HOST)\" every time so a fresh new copy of every fake gets fed into the method.","commit_id":"4f6712a8a3f973982c4114487682a6c6bcc341f0"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"ab144b0316d20e08ac0ababfd63832deb2e49152","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        self.assertEqual(\u0027unknown-id-1\u0027, instance.image[\u0027name\u0027])"},{"line_number":107,"context_line":"        self.assertEqual("},{"line_number":108,"context_line":"            expected_instance.flavor[\u0027name\u0027], instance.flavor[\u0027name\u0027])"},{"line_number":109,"context_line":"        self.assertIsNone(instance.kernel_id)"},{"line_number":110,"context_line":"        self.assertIsNone(instance.ramdisk_id)"},{"line_number":111,"context_line":"        self.assertEqual({}, instance.image_meta)"}],"source_content_type":"text/x-python","patch_set":6,"id":"99725baf_a58e7d27","line":108,"updated":"2026-08-13 13:10:40.000000000","message":"As expected_instance, instances[0], and instance all point to the same object this assert is just testing the fake, it will always be true, no matter what _with_flavor did, as it modified the object all the references are pointing at.\n\nYou should be using literals to compare self.assertEqual(\"m1.tiny\", instance.flavor[\u0027name\u0027])","commit_id":"4f6712a8a3f973982c4114487682a6c6bcc341f0"}]}