)]}'
{"ceilometer/tests/unit/compute/test_discovery.py":[{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"d73655ea317d13db129254434a668f981d82f698","unresolved":true,"context_lines":[{"line_number":339,"context_line":"    def setUp(self):"},{"line_number":340,"context_line":"        super().setUp()"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        self.instance \u003d mock.MagicMock()"},{"line_number":343,"context_line":"        self.instance.name \u003d \u0027instance-00000001\u0027"},{"line_number":344,"context_line":"        setattr(self.instance, \u0027OS-EXT-SRV-ATTR:instance_name\u0027,"},{"line_number":345,"context_line":"                self.instance.name)"},{"line_number":346,"context_line":"        setattr(self.instance, \u0027OS-EXT-STS:vm_state\u0027,"},{"line_number":347,"context_line":"                \u0027active\u0027)"},{"line_number":348,"context_line":"        # FIXME(sileht): This is wrong, this should be a uuid"},{"line_number":349,"context_line":"        # The internal id of nova can\u0027t be retrieved via API or notification"},{"line_number":350,"context_line":"        self.instance.id \u003d 1"},{"line_number":351,"context_line":"        self.instance.flavor \u003d {\u0027name\u0027: \u0027m1.small\u0027,"},{"line_number":352,"context_line":"                                \u0027id\u0027: \u0027eba4213d-3c6c-4b5f-8158-dd0022d71d62\u0027,"},{"line_number":353,"context_line":"                                \u0027vcpus\u0027: 1,"},{"line_number":354,"context_line":"                                \u0027ram\u0027: 512,"},{"line_number":355,"context_line":"                                \u0027disk\u0027: 20,"},{"line_number":356,"context_line":"                                \u0027ephemeral\u0027: 0,"},{"line_number":357,"context_line":"                                \u0027extra_specs\u0027: {\u0027hw_rng:allowed\u0027: \u0027true\u0027}}"},{"line_number":358,"context_line":"        self.instance.status \u003d \u0027active\u0027"},{"line_number":359,"context_line":"        self.instance.metadata \u003d {"},{"line_number":360,"context_line":"            \u0027fqdn\u0027: \u0027vm_fqdn\u0027,"},{"line_number":361,"context_line":"            \u0027metering.stack\u0027: \u00272cadc4b4-8789-123c-b4eg-edd2f0a9c128\u0027,"},{"line_number":362,"context_line":"            \u0027project_cos\u0027: \u0027dev\u0027}"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":365,"context_line":"            \u0027ceilometer.keystone_client.get_session\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"b59d8577_8f9919ac","line":362,"range":{"start_line":342,"start_character":8,"end_line":362,"end_character":33},"updated":"2026-08-13 13:29:22.000000000","message":"This self.instance is created here but never referenced in any test, we should clean this bloc up and spare the MagicMock creation.","commit_id":"59e336ede2fd9cb604d8bf54f731466f3cf9f4bb"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"d73655ea317d13db129254434a668f981d82f698","unresolved":true,"context_lines":[{"line_number":390,"context_line":"        resources \u003d dsc.discover(mock.MagicMock())"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        self.assertEqual(1, len(resources))"},{"line_number":393,"context_line":"        self.assertEqual(fakes.SERVER_NC_ON_TEST_HOST.id,"},{"line_number":394,"context_line":"                         list(resources)[0].id)"},{"line_number":395,"context_line":"        self.fake_nova.servers.list.assert_called_once_with("},{"line_number":396,"context_line":"            detailed\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":6,"id":"a8d6fe6c_f95e8327","line":393,"updated":"2026-08-13 13:29:22.000000000","message":"The method under test modifies the fake, which is reused in multiple tests, so we should be doing a deepcopy.","commit_id":"59e336ede2fd9cb604d8bf54f731466f3cf9f4bb"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"d73655ea317d13db129254434a668f981d82f698","unresolved":true,"context_lines":[{"line_number":1017,"context_line":""},{"line_number":1018,"context_line":"        ret_server \u003d dsc.get_server(uuid)"},{"line_number":1019,"context_line":"        self.assertEqual(expected_server, ret_server)"},{"line_number":1020,"context_line":"        self.assertEqual(expected_server.flavor[\"id\"],"},{"line_number":1021,"context_line":"                         ret_server.flavor.get(\u0027id\u0027))"},{"line_number":1022,"context_line":"        self.assertEqual(expected_server.metadata,"},{"line_number":1023,"context_line":"                         ret_server.metadata)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3b1d4b9a_77544d2f","line":1020,"updated":"2026-08-13 13:29:22.000000000","message":"expected_server and ret_server point to the same object, so we are comparing an object against itself and it is always true. Replace expected_server.flavor with a literal.","commit_id":"59e336ede2fd9cb604d8bf54f731466f3cf9f4bb"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"d73655ea317d13db129254434a668f981d82f698","unresolved":true,"context_lines":[{"line_number":1019,"context_line":"        self.assertEqual(expected_server, ret_server)"},{"line_number":1020,"context_line":"        self.assertEqual(expected_server.flavor[\"id\"],"},{"line_number":1021,"context_line":"                         ret_server.flavor.get(\u0027id\u0027))"},{"line_number":1022,"context_line":"        self.assertEqual(expected_server.metadata,"},{"line_number":1023,"context_line":"                         ret_server.metadata)"},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"    def test_get_server_notfound(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7e7bd3a4_cfadd51e","line":1022,"updated":"2026-08-13 13:29:22.000000000","message":"Same as above","commit_id":"59e336ede2fd9cb604d8bf54f731466f3cf9f4bb"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"d73655ea317d13db129254434a668f981d82f698","unresolved":true,"context_lines":[{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"    def test_get_server_notfound(self):"},{"line_number":1026,"context_line":"        dsc \u003d discovery.InstanceDiscovery(self.CONF)"},{"line_number":1027,"context_line":"        self.setup_connection(servers\u003d[])"},{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":"        ret_server \u003d dsc.get_server(\u0027123456\u0027)"},{"line_number":1030,"context_line":"        self.assertIsNone(ret_server)"}],"source_content_type":"text/x-python","patch_set":6,"id":"2991b249_1d266ede","line":1027,"updated":"2026-08-13 13:29:22.000000000","message":"This setup_connection does nothing in this test, it passes just because \u002712345\u0027 is not a server id, so remove it.","commit_id":"59e336ede2fd9cb604d8bf54f731466f3cf9f4bb"}]}
