)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33717,"name":"Luciano Lo Giudice","email":"luciano.logiudice@canonical.com","username":"lmlg"},"change_message_id":"d72279c8aa2a0fdd7e868ee9eebdaa1141f12131","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0f0d8188_f8b652f9","updated":"2023-02-22 18:46:15.000000000","message":"charm-recheck\n(node failure)","commit_id":"04f16a53e1b4f42bfb0c33859e616e38c80044eb"},{"author":{"_account_id":20870,"name":"Alex Kavanagh","email":"alex@ajkavanagh.co.uk","username":"ajkavanagh"},"change_message_id":"e6f5f8d6a3c54920777e8f198154d7426ab59e7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ed678163_0df20768","updated":"2023-02-23 08:43:06.000000000","message":"Although, it passes, this is for stable/pacific and the requirements.txt and test-requirements.txt all use the main development branch directly from the git repositories.  That doesn\u0027t seem very stable.  I\u0027d at least try and tie them down to a tag or a commit sha?  Otherwise, tomorrow\u0027s build of this charm may be completely different, add new features, break stuff, that today\u0027s build doesn\u0027t have.","commit_id":"20d65bfdcf563101b7bc49a45c1756dd5e5b7ab8"},{"author":{"_account_id":20870,"name":"Alex Kavanagh","email":"alex@ajkavanagh.co.uk","username":"ajkavanagh"},"change_message_id":"0ec861adee4ab675bbe3d5cf2bd4151d97891a99","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"464bc973_4147a406","in_reply_to":"02265231_20d47f91","updated":"2023-03-06 15:04:58.000000000","message":"Sorry, I wasn\u0027t being clear enough - tricky topic, specifying stable builds!\n\nFrom the requirements.txt:\n\n    git+https://opendev.org/openstack/charm-ops-interface-ceph-client#egg\u003dinterface_ceph_client\n    git+https://opendev.org/openstack/charm-ops-openstack#egg\u003dops_openstack\n    git+https://opendev.org/openstack/charm-ops-interface-tls-certificates#egg\u003dinterface_tls_certificates\n    git+https://github.com/openstack-charmers/ops-interface-ceph-iscsi-admin-access#egg\u003dinterface_ceph_iscsi_admin_access\n    \nThese all reference the master branch of these interfaces, for a stable branch for the build.  From a charm build:\n\n2023-03-06 15:01:33.981 :: 2023-03-06 15:01:33.981 :: 2023-03-06 15:01:33.980    :: Collecting interface_ceph_client                                                               \n2023-03-06 15:01:35.416 :: 2023-03-06 15:01:33.981 :: 2023-03-06 15:01:33.981    ::   Cloning https://opendev.org/openstack/charm-ops-interface-ceph-client to /tmp/pip-install-kieuvu1u/interface-ceph-client                                                                                                                                                         \n2023-03-06 15:01:35.416 :: 2023-03-06 15:01:35.416 :: 2023-03-06 15:01:33.981    ::   Running command git clone -q https://opendev.org/openstack/charm-ops-interface-ceph-client /tmp/pip-install-kieuvu1u/interface-ceph-client                                                                                                                                       \n2023-03-06 15:01:35.416 :: 2023-03-06 15:01:35.416 :: 2023-03-06 15:01:35.416    :: Collecting ops_openstack                                                                       \n2023-03-06 15:01:36.550 :: 2023-03-06 15:01:35.416 :: 2023-03-06 15:01:35.416    ::   Cloning https://opendev.org/openstack/charm-ops-openstack to /tmp/pip-install-kieuvu1u/ops-openstack                                                                                                                                                                             \n2023-03-06 15:01:36.550 :: 2023-03-06 15:01:36.550 :: 2023-03-06 15:01:35.416    ::   Running command git clone -q https://opendev.org/openstack/charm-ops-openstack /tmp/pip-install-kieuvu1u/ops-openstack                                                                                                                                                           \n2023-03-06 15:01:36.550 :: 2023-03-06 15:01:36.550 :: 2023-03-06 15:01:36.549    :: Collecting interface_tls_certificates                                                          \n2023-03-06 15:01:37.787 :: 2023-03-06 15:01:36.550 :: 2023-03-06 15:01:36.550    ::   Cloning https://opendev.org/openstack/charm-ops-interface-tls-certificates to /tmp/pip-install-kieuvu1u/interface-tls-certificates                                                                                                                                               \n2023-03-06 15:01:37.787 :: 2023-03-06 15:01:37.786 :: 2023-03-06 15:01:36.550    ::   Running command git clone -q https://opendev.org/openstack/charm-ops-interface-tls-certificates /tmp/pip-install-kieuvu1u/interface-tls-certificates                                                                                                                             \n2023-03-06 15:01:37.787 :: 2023-03-06 15:01:37.787 :: 2023-03-06 15:01:37.786    :: Collecting interface_ceph_iscsi_admin_access                                                   \n2023-03-06 15:01:38.522 :: 2023-03-06 15:01:37.787 :: 2023-03-06 15:01:37.786    ::   Cloning https://github.com/openstack-charmers/ops-interface-ceph-iscsi-admin-access to /tmp/pip-install-kieuvu1u/interface-ceph-iscsi-admin-access                                                                                                                               \n2023-03-06 15:01:38.540 :: 2023-03-06 15:01:38.521 :: 2023-03-06 15:01:37.787    ::   Running command git clone -q https://github.com/openstack-charmers/ops-interface-ceph-iscsi-admin-access /tmp/pip-install-kieuvu1u/interface-ceph-iscsi-admin-access                                                           \n\ni.e. It\u0027s using the master branch/development tip for the charm build, so those aren\u0027t stable.  What really needs to happen is for these to be pinned to a commit that was current when the stable/pacific charm was originally build/released.","commit_id":"20d65bfdcf563101b7bc49a45c1756dd5e5b7ab8"},{"author":{"_account_id":20870,"name":"Alex Kavanagh","email":"alex@ajkavanagh.co.uk","username":"ajkavanagh"},"change_message_id":"370be09fb0e54d5eabe7444c4267a433a0884008","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8b22767c_086c22e7","in_reply_to":"1b5e4572_4c87b497","updated":"2023-02-23 20:36:33.000000000","message":"I mean that the requirements that install from the master branch from the git repositories are, by definitely, not necessarily stable.  I.e. they are not pinned to anything.  Thus this stable branch will be using unstable test python libs, etc. for testing which may well break with the charm over time.  It\u0027s true that somethings don\u0027t change very frequently, but it\u0027s probably useful to at least lock it down a little bit.","commit_id":"20d65bfdcf563101b7bc49a45c1756dd5e5b7ab8"},{"author":{"_account_id":33717,"name":"Luciano Lo Giudice","email":"luciano.logiudice@canonical.com","username":"lmlg"},"change_message_id":"c077abf39c692d3f388d67bab1bd83bd209864a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e204b194_001ca376","in_reply_to":"464bc973_4147a406","updated":"2023-03-06 21:38:08.000000000","message":"Done","commit_id":"20d65bfdcf563101b7bc49a45c1756dd5e5b7ab8"},{"author":{"_account_id":33717,"name":"Luciano Lo Giudice","email":"luciano.logiudice@canonical.com","username":"lmlg"},"change_message_id":"c5135d65ef30378166d3100d43efcf87557c2872","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"02265231_20d47f91","in_reply_to":"8b22767c_086c22e7","updated":"2023-02-23 20:41:57.000000000","message":"Fair. The only non-pinned dependency that I can see was charm-tools, which is now pinned to a version.","commit_id":"20d65bfdcf563101b7bc49a45c1756dd5e5b7ab8"},{"author":{"_account_id":33717,"name":"Luciano Lo Giudice","email":"luciano.logiudice@canonical.com","username":"lmlg"},"change_message_id":"3b66beb1a014a1f4e399deff3c1adf684088a852","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1b5e4572_4c87b497","in_reply_to":"ed678163_0df20768","updated":"2023-02-23 16:13:18.000000000","message":"Not sure what you mean here, Alex. Are you referring to the `ops` and `charm-tools` dependencies which should be pinned in some manner?","commit_id":"20d65bfdcf563101b7bc49a45c1756dd5e5b7ab8"},{"author":{"_account_id":20870,"name":"Alex Kavanagh","email":"alex@ajkavanagh.co.uk","username":"ajkavanagh"},"change_message_id":"e115fe8ca4148ee235ce9f4c5b248a2deba6ca63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1b9e74c7_addff4a8","updated":"2023-03-08 10:52:31.000000000","message":"LGTM; just needs another +2 for stable branch.\n\nThanks very much for the changes; working out how to pin ops charms is going to be a bit of a project going forward!","commit_id":"fc70dcc2d201187b0163be873bafa1117308c003"},{"author":{"_account_id":33717,"name":"Luciano Lo Giudice","email":"luciano.logiudice@canonical.com","username":"lmlg"},"change_message_id":"c077abf39c692d3f388d67bab1bd83bd209864a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6fe482b0_d15b1b11","updated":"2023-03-06 21:38:08.000000000","message":"charm-recheck\n(CI connection issue)","commit_id":"fc70dcc2d201187b0163be873bafa1117308c003"},{"author":{"_account_id":15382,"name":"Peter Sabaini","email":"peter.sabaini@canonical.com","username":"peter-sabaini"},"change_message_id":"150c5c3c498d600fd3c7ba59bb185da40b7f54dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9d493edc_7f8e9887","updated":"2023-03-09 14:23:55.000000000","message":"lgtm","commit_id":"fc70dcc2d201187b0163be873bafa1117308c003"},{"author":{"_account_id":15382,"name":"Peter Sabaini","email":"peter.sabaini@canonical.com","username":"peter-sabaini"},"change_message_id":"5609f9f55383fa8b8649ca4f4f8a5a130ad3f15f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"593ca3a7_b68281c6","updated":"2023-06-07 08:27:53.000000000","message":"lgtm, thanks","commit_id":"1393f66339d520d1f598884d42526ab0c7b55c3e"}],"tox.ini":[{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"ba0046868f95b0ae0c813f99afbf215ac0e874fc","unresolved":true,"context_lines":[{"line_number":109,"context_line":"deps \u003d -r{toxinidir}/build-requirements.txt"},{"line_number":110,"context_line":"commands \u003d"},{"line_number":111,"context_line":"    charmcraft clean"},{"line_number":112,"context_line":"    charmcraft -v pack"},{"line_number":113,"context_line":"    {toxinidir}/rename.sh"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"[testenv:func-noop]"}],"source_content_type":"text/x-properties","patch_set":5,"id":"f6726f30_767d15f0","line":112,"updated":"2023-05-26 17:20:52.000000000","message":"the recipe is using charmcraft-1.5 which uses \"charmcraft build\", let\u0027s drop this change unless you want to migrate to a newer version of charmcraft in that case you need to update charmed-openstack-info.\n\nhttps://launchpad.net/~openstack-charmers/charm-ceph-iscsi/+charm/charm-ceph-iscsi.stable-pacific.pacific\nhttps://github.com/openstack-charmers/charmed-openstack-info/blob/main/charmed_openstack_info/data/lp-builder-config/ceph.yaml#L227","commit_id":"fc70dcc2d201187b0163be873bafa1117308c003"},{"author":{"_account_id":33717,"name":"Luciano Lo Giudice","email":"luciano.logiudice@canonical.com","username":"lmlg"},"change_message_id":"9dcefe59c4c29271c94212a8c2073a0ef6c92ee5","unresolved":false,"context_lines":[{"line_number":109,"context_line":"deps \u003d -r{toxinidir}/build-requirements.txt"},{"line_number":110,"context_line":"commands \u003d"},{"line_number":111,"context_line":"    charmcraft clean"},{"line_number":112,"context_line":"    charmcraft -v pack"},{"line_number":113,"context_line":"    {toxinidir}/rename.sh"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"[testenv:func-noop]"}],"source_content_type":"text/x-properties","patch_set":5,"id":"ab41ac0b_6632a15f","line":112,"in_reply_to":"f6726f30_767d15f0","updated":"2023-06-02 23:45:16.000000000","message":"Done","commit_id":"fc70dcc2d201187b0163be873bafa1117308c003"}]}