)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"c25c89345f31f5337e0d79146fa113bfccf999e8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Hernan Garcia \u003chernan.garcia@canonical.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-05-19 01:08:51 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"added image conversion config flag"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id3791721f9e38899c87b88591cdc42e46ffea5c1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1172509e_561ca1c8","line":7,"updated":"2021-05-19 08:15:00.000000000","message":"Please take a read through:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages\n\nand rework your commit message to be inline please!\n\nAlso is there a bug reference for this change as well?","commit_id":"84c3f1dbcc9f5acfc50175a00f21cf9837074aa3"},{"author":{"_account_id":8992,"name":"Billy Olsen","email":"billy.olsen@canonical.com","username":"billy-olsen"},"change_message_id":"d991b58a283e076aa6ab366349f22320a4c89740","unresolved":true,"context_lines":[{"line_number":9,"context_line":"image-convertion config enables image convertion to raw format"},{"line_number":10,"context_line":"this optimizes back-end capabilities while not putting the burden"},{"line_number":11,"context_line":"of converting images to their end users"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: 1899767"},{"line_number":14,"context_line":"Change-Id: Id3791721f9e38899c87b88591cdc42e46ffea5c1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"86b9c3af_a97160ce","line":12,"updated":"2021-05-26 03:05:08.000000000","message":"Since we\u0027re adding a feature to enable the image conversion, you\u0027ll want to include a functional test. See https://docs.openstack.org/charm-guide/latest/making-a-change.html#functional-test-changes for more info.","commit_id":"f40b6db589ea9d55113540c7f7a98c488489c92e"}],"config.yaml":[{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"c25c89345f31f5337e0d79146fa113bfccf999e8","unresolved":true,"context_lines":[{"line_number":529,"context_line":"    type: boolean"},{"line_number":530,"context_line":"    default: False"},{"line_number":531,"context_line":"    description: |"},{"line_number":532,"context_line":"      Enable image conversion after image upload (raw format)."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"375035e0_bd34c62b","line":532,"updated":"2021-05-19 08:15:00.000000000","message":"Minor reword to make it clearer:\n\n\"Enable conversion of all images to raw format during image upload.\"","commit_id":"84c3f1dbcc9f5acfc50175a00f21cf9837074aa3"},{"author":{"_account_id":8992,"name":"Billy Olsen","email":"billy.olsen@canonical.com","username":"billy-olsen"},"change_message_id":"d991b58a283e076aa6ab366349f22320a4c89740","unresolved":true,"context_lines":[{"line_number":529,"context_line":"    type: boolean"},{"line_number":530,"context_line":"    default: False"},{"line_number":531,"context_line":"    description: |"},{"line_number":532,"context_line":"      Enable conversion of all images to raw format during image upload."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7985c15b_4b242f26","line":532,"updated":"2021-05-26 03:05:08.000000000","message":"From discussion with you, this is enabled for rocky and newer so we should have a comment in here that indicates it is supported on Rocky and newer. Since Rocky is technically EOL, we should default to saying this is supported on Stein and newer.","commit_id":"f40b6db589ea9d55113540c7f7a98c488489c92e"}],"hooks/glance_contexts.py":[{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"c25c89345f31f5337e0d79146fa113bfccf999e8","unresolved":true,"context_lines":[{"line_number":68,"context_line":"                         \u0027formatting\u0027.format(config(\u0027image-size-cap\u0027)),"},{"line_number":69,"context_line":"                         level\u003dERROR)"},{"line_number":70,"context_line":"                raise"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        return ctxt"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"42b6b421_5dd334f3","line":71,"updated":"2021-05-19 08:15:00.000000000","message":"This change seems unrelated/erroneous - please drop","commit_id":"84c3f1dbcc9f5acfc50175a00f21cf9837074aa3"}],"hooks/glance_utils.py":[{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"c25c89345f31f5337e0d79146fa113bfccf999e8","unresolved":true,"context_lines":[{"line_number":143,"context_line":"APACHE_SSL_DIR \u003d \u0027/etc/apache2/ssl/glance\u0027"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"MEMCACHED_CONF \u003d \u0027/etc/memcached.conf\u0027"},{"line_number":146,"context_line":"GLANCE_IMAGE_IMPORT_CONF \u003d \u0027/etc/glance/glance-image-import.conf\u0027"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"TEMPLATES \u003d \u0027templates/\u0027"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"b153de85_6ca758f3","line":146,"updated":"2021-05-19 08:15:00.000000000","message":"NIT - please push up to line 135 so its grouped with the other GLANCE_* constants","commit_id":"84c3f1dbcc9f5acfc50175a00f21cf9837074aa3"}],"templates/glance-image-import.conf":[{"author":{"_account_id":31289,"name":"Aurelien Lourot","email":"aurelien.lourot@gmail.com","username":"lourot"},"change_message_id":"88bde910cf1e009ef2b9990f6e26738b8f1199b0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{% if image_conversion -%}"},{"line_number":2,"context_line":"[image_import_opts]"},{"line_number":3,"context_line":"image_import_plugins \u003d [\u0027image_conversion\u0027]"},{"line_number":4,"context_line":""}],"source_content_type":"text/plain","patch_set":10,"id":"995a53c4_54f6a5a4","line":1,"updated":"2021-05-31 12:30:26.000000000","message":"I think this comment from Billy hasn\u0027t been addressed:\n\n\"The glance-image-import.conf file will be rendered but be blank when the feature is disabled. In general, I think we should have comment headers at the top of our files that say that this is managed by juju and any contents added by the user will be overwritten. However, I do note that we do not do that in the glance charm today for many of the files - but we should do the right thing here.\"","commit_id":"4ffc71ea2f0ec55b2e9ca38bef0ba841a60bbcbf"},{"author":{"_account_id":31289,"name":"Aurelien Lourot","email":"aurelien.lourot@gmail.com","username":"lourot"},"change_message_id":"bf76f2b38b17b8697d4d744772cb5710fd4d8f7d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{% if image_conversion -%}"},{"line_number":2,"context_line":"[image_import_opts]"},{"line_number":3,"context_line":"image_import_plugins \u003d [\u0027image_conversion\u0027]"},{"line_number":4,"context_line":""}],"source_content_type":"text/plain","patch_set":10,"id":"8d15be74_131556a9","line":1,"in_reply_to":"995a53c4_54f6a5a4","updated":"2021-05-31 13:57:50.000000000","message":"Nevermind: this isn\u0027t needed anymore as we don\u0027t render this template file on the unit anymore. Instead it is jinja-included in glance-api.conf","commit_id":"4ffc71ea2f0ec55b2e9ca38bef0ba841a60bbcbf"}],"templates/stein/glance-api.conf":[{"author":{"_account_id":31289,"name":"Aurelien Lourot","email":"aurelien.lourot@gmail.com","username":"lourot"},"change_message_id":"ea7e70a8d9e51fcd958b876f6304c8e9a04698f1","unresolved":true,"context_lines":[{"line_number":112,"context_line":"{% endfor -%}"},{"line_number":113,"context_line":"{% endfor%}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"{% include \"glance-image-import.conf\" %}"}],"source_content_type":"text/plain","patch_set":10,"id":"ea416aa6_41f3b7ed","line":115,"updated":"2021-05-31 14:43:04.000000000","message":"As discussed offline: this should be either renamed to `parts/section-` or directly inlined here","commit_id":"4ffc71ea2f0ec55b2e9ca38bef0ba841a60bbcbf"}],"unit_tests/test_glance_utils.py":[{"author":{"_account_id":31289,"name":"Aurelien Lourot","email":"aurelien.lourot@gmail.com","username":"lourot"},"change_message_id":"88bde910cf1e009ef2b9990f6e26738b8f1199b0","unresolved":true,"context_lines":[{"line_number":159,"context_line":"                call(conf,"},{"line_number":160,"context_line":"                     utils.CONFIG_FILES[conf][\u0027hook_contexts\u0027])"},{"line_number":161,"context_line":"            )"},{"line_number":162,"context_line":"        configs.register.assert_has_calls(calls, any_order\u003dTrue)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def test_restart_map_rocky(self):"},{"line_number":165,"context_line":"        self.enable_memcache.return_value \u003d True"}],"source_content_type":"text/x-python","patch_set":10,"id":"41a9513a_8fbec1e6","line":162,"updated":"2021-05-31 12:30:26.000000000","message":"assert_has_calls() isn\u0027t enough to prove that there hasn\u0027t been any other other extra calls, see https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_has_calls\n\nYou may want to do something like https://stackoverflow.com/questions/54838354/python-how-can-i-assert-a-mock-object-was-not-called-with-specific-arguments","commit_id":"4ffc71ea2f0ec55b2e9ca38bef0ba841a60bbcbf"}]}