)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"2a574fe4720dc3d9bd30a4254e0a81048d81df75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1bc255b9_36ca11d4","updated":"2021-11-22 14:58:07.000000000","message":"\n\u003e - charm-build https://openstack-ci-reports.ubuntu.com/artifacts/317/810610/6/check/charm-build/317fad2/ : FAILURE in 4m 04s\n\u003e - osci-lint https://openstack-ci-reports.ubuntu.com/artifacts/e44/810610/6/check/osci-lint/e44ce98/ : SUCCESS in 3m 59s\n\u003e - tox-py35 https://openstack-ci-reports.ubuntu.com/artifacts/520/810610/6/check/tox-py35/520d4d0/ : FAILURE in 3m 40s\n\nhttps://github.com/openstack-charmers/release-tools/pull/164\n\nrequirements.txt file needs to be sync\u0027ed\n","commit_id":"6b5201e72a767e7e003b4f47a412aedb0b62f84f"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"84b08ce92626954f2db743ab45db1718b728cf6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7fda68dd_a8bbe4c5","in_reply_to":"1bc255b9_36ca11d4","updated":"2021-11-23 06:45:22.000000000","message":"Planning to rebase once the following commit is merged. This commit is supposed to resolve all generic CI issues\nhttps://review.opendev.org/c/openstack/charm-ironic-conductor/+/816022","commit_id":"6b5201e72a767e7e003b4f47a412aedb0b62f84f"},{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"f7d3b7b9ec4c58c8cd728c4ff4f36b40cdc09b70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c29fa2d9_ffb16a11","updated":"2022-01-06 15:52:24.000000000","message":"2022-01-06 07:39:18.416057 | focal-medium | 2022-01-06 07:39:18 [ERROR] unit-ceph-osd-1.log: 2022-01-06 07:39:01 DEBUG install\n2022-01-06 07:39:18.416124 | focal-medium | 2022-01-06 07:39:18 [ERROR] unit-ceph-osd-1.log: 2022-01-06 07:39:02 WARNING install E: Package \u0027python3-pip\u0027 has no installation candidate\n2022-01-06 07:39:18.416211 | focal-medium | 2022-01-06 07:39:18 [ERROR] unit-ceph-osd-1.log: 2022-01-06 07:39:02 ERROR juju.worker.uniter.operation runhook.go:139 hook \"install\" (via explicit, bespoke hook script) failed: exit status 100","commit_id":"bc7a2501a45ee48dbc29ae036b422cd67be8c2a2"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"d93e577442a5bd0b62556f0700e75935690a8da4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"248c0b42_aef7ee92","updated":"2022-01-20 03:10:14.000000000","message":"charm-recheck","commit_id":"bc7a2501a45ee48dbc29ae036b422cd67be8c2a2"},{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"32dcb9046046bd79b178a8fd529a508e7628da9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"588e2c9e_c09b5598","updated":"2022-01-06 17:34:12.000000000","message":"charm-recheck","commit_id":"bc7a2501a45ee48dbc29ae036b422cd67be8c2a2"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"d1e0933481b23c693625e1673001a134a519d58c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"67bb145a_057f0605","updated":"2022-01-02 02:45:35.000000000","message":"charm-recheck","commit_id":"bc7a2501a45ee48dbc29ae036b422cd67be8c2a2"},{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"3a035f1482fc614de4bb824bead8ee1d1132bbf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f49a3787_b9775a3c","updated":"2022-01-06 18:59:03.000000000","message":"charm-recheck","commit_id":"bc7a2501a45ee48dbc29ae036b422cd67be8c2a2"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"f9107294fa4326d2e1339d73d28d7033bc115806","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"56ff27fb_c173d808","updated":"2022-01-10 03:19:07.000000000","message":"charm-recheck\n\nSome jobs are not executed with RETRY_LIMIT message","commit_id":"bc7a2501a45ee48dbc29ae036b422cd67be8c2a2"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"aeb45c4f32ffff928b420c352d701fef101c57e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"55ec9e71_adbc6a89","updated":"2022-01-06 05:42:34.000000000","message":"charm-recheck\n\nbionic-ussuri job failure not related to changes.\nRan in local and the job is successful, so retriggering the CI.","commit_id":"bc7a2501a45ee48dbc29ae036b422cd67be8c2a2"},{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"b9f70d129ac087166efe7698e5f831e85c95dade","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"058c4588_3ee3ec45","updated":"2022-01-12 14:59:40.000000000","message":"charm-recheck\n\nthere were undercloud changes that should have addresses the problems in the previous runs we were seeing.","commit_id":"bc7a2501a45ee48dbc29ae036b422cd67be8c2a2"},{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"7dacdac53419efec747a134cb7e031a8f1b4fa1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6d7e9c31_54c8858a","updated":"2022-01-24 13:22:53.000000000","message":"hi Hemanth, we\u0027ve had infrastructure issues and that\u0027s why CI jobs have been failing often, not just for this patch but in general, so if you could run `tox -e func` in stsstack and post the results here would be great, because we use that as a replacement of what zosci should have tested.\n\nBest,","commit_id":"bc7a2501a45ee48dbc29ae036b422cd67be8c2a2"},{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"64793fe3113ae4cc436fd10501f780aaf48dec43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f2126162_ec91f262","in_reply_to":"085bdd84_f4e6541e","updated":"2022-02-22 13:54:06.000000000","message":"Hemanth,\n\nIf you rebase this patch on top of [0] we could attempt to run the CI jobs and be ready to merge right after [0].\n\nTo make this change depend on [0] you need to run the following in your repo:\n\ngit checkout master\ngit review -d 821993\ngit checkout bug/1943765\ngit rebase -i review/corey_bryant/...  \n# resolve conflicts if any\ngit review  # this will warn you that you will try to push 2 changes, but since you didn\u0027t touch the change [0] it will end up being a NOOP and just change the parent\u0027s reference for your patch.\n\nBest,\n\n[0] https://review.opendev.org/c/openstack/charm-ironic-conductor/+/821993","commit_id":"bc7a2501a45ee48dbc29ae036b422cd67be8c2a2"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"92431cf78b53f282c7136122ea5bd9fdf8b663b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"085bdd84_f4e6541e","in_reply_to":"6d7e9c31_54c8858a","updated":"2022-01-27 07:18:02.000000000","message":"Hi Felipe\n\nFollowing jobs are successful: bionic-ussuri, focal-ussuri, focal-victoria, focal-wallaby. Log file for tox here [1]\nfocal-xena failed due to bug LP#1952140 [2] and fix is ongoing here [3]\nhirsute-wallaby skipped as hirsute is going to EOL soon.\nimpish-xena is likely to fail with the same issue as [2]\n\n[1] https://pastebin.ubuntu.com/p/5V9sKYVcCS/\n[2] https://review.opendev.org/c/openstack/charm-ironic-conductor/+/821993\n[3] https://bugs.launchpad.net/charm-ironic-conductor/+bug/1952140","commit_id":"bc7a2501a45ee48dbc29ae036b422cd67be8c2a2"},{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"20ed7b57c70087a36c1381b03dd7fe5b3bb6c216","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"348f48c7_2a7c4ec2","updated":"2022-02-23 19:44:19.000000000","message":"LGTM. Thanks, Hemanth","commit_id":"73a5b90d4026b5acf2cefe1f1057d078c8e923e4"}],"src/config.yaml":[{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"31afe42f3621560db5887f0c4ae4d34e637569d3","unresolved":true,"context_lines":[{"line_number":168,"context_line":"        * ipmi"},{"line_number":169,"context_line":"        * redfish"},{"line_number":170,"context_line":"        * idrac"},{"line_number":171,"context_line":"  ipmi-config-params:"},{"line_number":172,"context_line":"    type: string"},{"line_number":173,"context_line":"    default:"},{"line_number":174,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"aa7c57d0_1608b4fe","line":171,"updated":"2021-09-27 14:53:58.000000000","message":"this allows injecting whatever key\u003dvalue into the [ipmi] section, the reported bug only talked about `use_ipmitool_retries`, is there any reason to not expose that as a single option?, the [ipmi] section doesn\u0027t have that many possible options that would make (IMO) a generic *-config-flags/params a better path.","commit_id":"8d2db3a5bea22731bea4165496d9f16465575432"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"1159559b4b579298e2afa16308cf72305871e3af","unresolved":true,"context_lines":[{"line_number":168,"context_line":"        * ipmi"},{"line_number":169,"context_line":"        * redfish"},{"line_number":170,"context_line":"        * idrac"},{"line_number":171,"context_line":"  ipmi-config-params:"},{"line_number":172,"context_line":"    type: string"},{"line_number":173,"context_line":"    default:"},{"line_number":174,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e44c24d2_c4de8430","line":171,"in_reply_to":"aa7c57d0_1608b4fe","updated":"2021-09-28 09:48:57.000000000","message":"Hi Felipe\n\nThe bug description says \"there is some amount of packet loss between ironic-conductor and BMC\" which makes me believe there will be necessity of configuring other ipmi driver configuration parameters command_retry_timeout, min_command_interval when use_ipmitool_retries is false in some deployments.\nGiven the redfish is gaining up popularity, there will be need for more options for redfish driver sooner or later. So thought instead of having so many options, it will be better to have driver level key\u003dvalue configuration parameters.\n\nLet me know if you think the charm options should be explicit instead of open ended key-value pairs (where the errors will be discovered late in the deployment).","commit_id":"8d2db3a5bea22731bea4165496d9f16465575432"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"9910b0b444bd7d9df646a65c7072353073000525","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        * ipmi"},{"line_number":169,"context_line":"        * redfish"},{"line_number":170,"context_line":"        * idrac"},{"line_number":171,"context_line":"  ipmi-config-params:"},{"line_number":172,"context_line":"    type: string"},{"line_number":173,"context_line":"    default:"},{"line_number":174,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff8b6136_a5fd76b8","line":171,"in_reply_to":"e44c24d2_c4de8430","updated":"2021-11-21 01:23:31.000000000","message":"Updated in PS4 as per Felipe comments","commit_id":"8d2db3a5bea22731bea4165496d9f16465575432"}]}