)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25011,"name":"Drew Freiberger","email":"drew.freiberger@canonical.com","username":"afreiberger"},"change_message_id":"2249f663f2e88afca7744e4f067b010b89f76ae1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Facundo Ciccioli \u003cfacundo.ciccioli@canonical.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-11-18 15:33:57 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bring the same NRPE checks the percona-cluster charm has"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These changes were inspired in charm-percona-cluster when it was"},{"line_number":10,"context_line":"sitting at [1], but that has been heavily modified to make explicit the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"31aedd6d_c8e2f125","line":7,"updated":"2021-11-18 16:17:59.000000000","message":"add nrpe check for mysql connection utilization","commit_id":"38580a6b8407e3eee5c801153fbe36f13a27015c"},{"author":{"_account_id":8992,"name":"Billy Olsen","email":"billy.olsen@canonical.com","username":"billy-olsen"},"change_message_id":"10f72b3dceca5a5c410355a62ac8aa277d8e05d5","unresolved":true,"context_lines":[{"line_number":15,"context_line":"setting a password for it), and then the other units can render the"},{"line_number":16,"context_line":"defaults-file for the threads check to use the user."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://opendev.org/openstack/charm-percona-cluster/commit/393afdd1e7c7a07b9b0675fadb1da4fbd6fff5c1"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: If92891924ddbdce80e25df27bc307df9d3b558bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"b667fcba_83dec879","line":18,"updated":"2022-07-14 13:57:57.000000000","message":"I\u0027m not sure how this particular link is relevant?","commit_id":"fd3d90fb5abed9d5d44401107262ea4330248796"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":25011,"name":"Drew Freiberger","email":"drew.freiberger@canonical.com","username":"afreiberger"},"change_message_id":"2249f663f2e88afca7744e4f067b010b89f76ae1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c6762c15_079b809e","updated":"2021-11-18 16:17:59.000000000","message":"Please see comments in-line.\n\nSeveral linting issues and a suggestion to for sanity check and alignment of nrpe-threads-connected value with percona-cluster option format.","commit_id":"38580a6b8407e3eee5c801153fbe36f13a27015c"},{"author":{"_account_id":25011,"name":"Drew Freiberger","email":"drew.freiberger@canonical.com","username":"afreiberger"},"change_message_id":"fc3ef52e5c3ad262a06bcb8a8f34217e0051439a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d896b24f_5f3ba9c8","updated":"2021-11-18 16:25:19.000000000","message":"suggested a fix that black can\u0027t cover","commit_id":"38580a6b8407e3eee5c801153fbe36f13a27015c"},{"author":{"_account_id":29889,"name":"Diko Parvanov","email":"diko.parvanov@canonical.com","username":"dparv"},"change_message_id":"631a2b1345e3d539da89510c3f927a6e4d81a3af","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c69f10ae_4a71d16c","updated":"2021-11-24 09:05:35.000000000","message":"recheck","commit_id":"fbc481060fece9c6e7a81b95ba89ac52d21efbe4"},{"author":{"_account_id":8992,"name":"Billy Olsen","email":"billy.olsen@canonical.com","username":"billy-olsen"},"change_message_id":"10f72b3dceca5a5c410355a62ac8aa277d8e05d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f521d204_46ca0322","updated":"2022-07-14 13:57:57.000000000","message":"This is under discussion. I do not want to add more NRPE checks when the future direction is prometheus integration. Something such as this -\u003e  https://github.com/magenta-aps/check_prometheus_metric may help bridge the gap for installations still requiring nrpe","commit_id":"fd3d90fb5abed9d5d44401107262ea4330248796"},{"author":{"_account_id":8992,"name":"Billy Olsen","email":"billy.olsen@canonical.com","username":"billy-olsen"},"change_message_id":"08d0cc0e837ecb7555f16aac60710880d416ceb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"46c2d284_d61ed1ca","updated":"2022-06-15 03:15:10.000000000","message":"charm-recheck","commit_id":"fd3d90fb5abed9d5d44401107262ea4330248796"},{"author":{"_account_id":34720,"name":"JamesLin","display_name":"jneo8","email":"james.lin@canonical.com","username":"jneo8"},"change_message_id":"1af74be744e399d0d6123110d249b166daa12b2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"75feaa28_6cb21504","updated":"2022-05-17 02:54:28.000000000","message":"recheck","commit_id":"fd3d90fb5abed9d5d44401107262ea4330248796"},{"author":{"_account_id":34720,"name":"JamesLin","display_name":"jneo8","email":"james.lin@canonical.com","username":"jneo8"},"change_message_id":"bef3bb7f63014a313ef62bcabdbced64b49bb02c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9777c99f_0794f4d9","updated":"2022-05-17 01:55:01.000000000","message":"recheck","commit_id":"fd3d90fb5abed9d5d44401107262ea4330248796"},{"author":{"_account_id":34720,"name":"JamesLin","display_name":"jneo8","email":"james.lin@canonical.com","username":"jneo8"},"change_message_id":"e8b83bf387ce24bd0871e401d9b6244efd4b0124","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"af534688_780a7ce3","updated":"2022-05-18 03:10:46.000000000","message":"recheck\n","commit_id":"fd3d90fb5abed9d5d44401107262ea4330248796"},{"author":{"_account_id":34720,"name":"JamesLin","display_name":"jneo8","email":"james.lin@canonical.com","username":"jneo8"},"change_message_id":"453a46d9d43dd1f12289e7ff03a12108f9ddc81b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"de91f2a2_e257a651","updated":"2022-05-18 03:39:57.000000000","message":"recheck\n\n","commit_id":"fd3d90fb5abed9d5d44401107262ea4330248796"}],"src/config.yaml":[{"author":{"_account_id":25011,"name":"Drew Freiberger","email":"drew.freiberger@canonical.com","username":"afreiberger"},"change_message_id":"2249f663f2e88afca7744e4f067b010b89f76ae1","unresolved":true,"context_lines":[{"line_number":193,"context_line":"    type: string"},{"line_number":194,"context_line":"    default: \u0027-w 80 -c 90\u0027"},{"line_number":195,"context_line":"    description: |"},{"line_number":196,"context_line":"      Thresholds for Threads_connected to max_connections ratio from the DB global status variables."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2880eab6_f9a697b8","line":196,"updated":"2021-11-18 16:17:59.000000000","message":"Given this is noted as a ratio, but is expressed in percentages, at a minimum, I\u0027d like to add:\nThe defaults trigger WARNING at 80% of max_connections utilized and CRITICAL at 90%.\n\nThe source charm has the following in config.yaml, so the formatting will change as people move from percona-cluster to mysql-innodb-cluster.  I\u0027m not sure if this is good or bad, but may be nice to be consistent with the prior charm, so those changing the charm name in their bundle and not inspecting options may expect the same behavior from their prior changes to this option.\n\n   nrpe-threads-connected:\n    type: string\n    default: \u002780,90\u0027\n    description: |\n      This configuration option represents the warning and critical percentages\n      that are used to check the number of threads connected to MySQL.\n      The value should be written as a string containing two numbers separated by commas.","commit_id":"38580a6b8407e3eee5c801153fbe36f13a27015c"},{"author":{"_account_id":31836,"name":"Facundo Ciccioli","email":"facundo.ciccioli@canonical.com","username":"facu"},"change_message_id":"00a031fd3f142d859fe6904ff4c578a63d047ccc","unresolved":true,"context_lines":[{"line_number":193,"context_line":"    type: string"},{"line_number":194,"context_line":"    default: \u0027-w 80 -c 90\u0027"},{"line_number":195,"context_line":"    description: |"},{"line_number":196,"context_line":"      Thresholds for Threads_connected to max_connections ratio from the DB global status variables."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d20449a2_85b1285d","line":196,"in_reply_to":"2880eab6_f9a697b8","updated":"2021-11-18 17:54:45.000000000","message":"I get and agree with your note on consistency. But I\u0027m afraid this time it would be best to be consistent with the tens of checks the nrpe charm itself already has and use the \"command options\" notation.\n\nGiven all the work I\u0027ve done in the past weeks on this PR (it may seem relatively small, but it was a long journey 😕), I would very much like to at least get a PR started to the percona-cluster charm to mimic some of the ideas I used here (to the extent possible, given percona is a classic charm).","commit_id":"38580a6b8407e3eee5c801153fbe36f13a27015c"},{"author":{"_account_id":25011,"name":"Drew Freiberger","email":"drew.freiberger@canonical.com","username":"afreiberger"},"change_message_id":"830ae5e96ebdbf374964e52e3135d06519a0010b","unresolved":true,"context_lines":[{"line_number":193,"context_line":"    type: string"},{"line_number":194,"context_line":"    default: \u0027-w 80 -c 90\u0027"},{"line_number":195,"context_line":"    description: |"},{"line_number":196,"context_line":"      Thresholds for Threads_connected to max_connections ratio from the DB global status variables."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"68e360dc_18c023d2","line":196,"in_reply_to":"d20449a2_85b1285d","updated":"2021-11-18 20:43:52.000000000","message":"While I understand the idea that our pattern for other charms is to pass the entire string of flags to the check, this particular charm and check are a replacement/upgrade from percona-cluster, and should try to be as compatible as possible without being overburdensome on maintaining legacy compatibility.\n\nWhile I understand wanting to backport some of this to percona-cluster, I think that we won\u0027t want to change the format of the config.yaml variable for the check, unless you write code around accepting the current format while supporting the new format.  Hence, percona-cluster will likely maintain the 80,90 type config.  We should really take the extra few lines of code to make this an equivalent setting unless you envision additional flags for this particular check in the future.","commit_id":"38580a6b8407e3eee5c801153fbe36f13a27015c"}],"src/reactive/mysql_innodb_cluster_handlers.py":[{"author":{"_account_id":25011,"name":"Drew Freiberger","email":"drew.freiberger@canonical.com","username":"afreiberger"},"change_message_id":"2249f663f2e88afca7744e4f067b010b89f76ae1","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"charm.use_defaults(\u0027update-status\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"@reactive.hook(\u0027upgrade-charm\u0027)"},{"line_number":23,"context_line":"def custom_upgrade_charm():"},{"line_number":24,"context_line":"    \"\"\"Custom upgrade charm."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"99e01865_bcecc25e","line":22,"in_reply_to":"15709f9b_19067096","updated":"2021-11-18 16:17:59.000000000","message":"\u003e pep8: E302 expected 2 blank lines, found 1\n\nPlease fix.","commit_id":"38580a6b8407e3eee5c801153fbe36f13a27015c"},{"author":{"_account_id":25011,"name":"Drew Freiberger","email":"drew.freiberger@canonical.com","username":"afreiberger"},"change_message_id":"2249f663f2e88afca7744e4f067b010b89f76ae1","unresolved":true,"context_lines":[{"line_number":503,"context_line":"def write_threads_check_credentials():"},{"line_number":504,"context_line":"    context \u003d {"},{"line_number":505,"context_line":"        \"mysql_user\": \"nagios\","},{"line_number":506,"context_line":"        \"mysql_passwd\": ch_core.hookenv.leader_get(\u0027mysql-nagios.passwd\u0027),"},{"line_number":507,"context_line":"    }"},{"line_number":508,"context_line":"    # Target file path is the default as documented on pmp-check-mysql-status"},{"line_number":509,"context_line":"    # --help output."}],"source_content_type":"text/x-python","patch_set":2,"id":"2543a603_a1164797","line":506,"updated":"2021-11-18 16:17:59.000000000","message":"We should sanity check that the password has a value.  The changed.mysql-nagios.password may be a change to a blank which would be bad for the check, I think.","commit_id":"38580a6b8407e3eee5c801153fbe36f13a27015c"},{"author":{"_account_id":25011,"name":"Drew Freiberger","email":"drew.freiberger@canonical.com","username":"afreiberger"},"change_message_id":"830ae5e96ebdbf374964e52e3135d06519a0010b","unresolved":true,"context_lines":[{"line_number":503,"context_line":"def write_threads_check_credentials():"},{"line_number":504,"context_line":"    context \u003d {"},{"line_number":505,"context_line":"        \"mysql_user\": \"nagios\","},{"line_number":506,"context_line":"        \"mysql_passwd\": ch_core.hookenv.leader_get(\u0027mysql-nagios.passwd\u0027),"},{"line_number":507,"context_line":"    }"},{"line_number":508,"context_line":"    # Target file path is the default as documented on pmp-check-mysql-status"},{"line_number":509,"context_line":"    # --help output."}],"source_content_type":"text/x-python","patch_set":2,"id":"5cde85f0_f5981b85","line":506,"in_reply_to":"1ebf9b2e_ccad7a14","updated":"2021-11-18 20:43:52.000000000","message":"I agree that there shouldn\u0027t be an issue.  I\u0027m basing my concern on this bug/fix from Percona-cluster earlier this year.\nhttps://review.opendev.org/c/openstack/charm-percona-cluster/+/786947\n\nI\u0027ve re-reviewed and I think we can do without the extra checks given the state flags required for this function.  I reviewed for race conditions around leadership changing to new units and racing between leader and nrpe relations, but it should be safe with the flags as-is.","commit_id":"38580a6b8407e3eee5c801153fbe36f13a27015c"},{"author":{"_account_id":31836,"name":"Facundo Ciccioli","email":"facundo.ciccioli@canonical.com","username":"facu"},"change_message_id":"00a031fd3f142d859fe6904ff4c578a63d047ccc","unresolved":true,"context_lines":[{"line_number":503,"context_line":"def write_threads_check_credentials():"},{"line_number":504,"context_line":"    context \u003d {"},{"line_number":505,"context_line":"        \"mysql_user\": \"nagios\","},{"line_number":506,"context_line":"        \"mysql_passwd\": ch_core.hookenv.leader_get(\u0027mysql-nagios.passwd\u0027),"},{"line_number":507,"context_line":"    }"},{"line_number":508,"context_line":"    # Target file path is the default as documented on pmp-check-mysql-status"},{"line_number":509,"context_line":"    # --help output."}],"source_content_type":"text/x-python","patch_set":2,"id":"1ebf9b2e_ccad7a14","line":506,"in_reply_to":"2543a603_a1164797","updated":"2021-11-18 17:54:45.000000000","message":"Hmmm... the password is supposed to be used/set internally by the charm. The only way I can think of to change the password externally is through leader-set. I think the question is: do we want to support this?\n\nI believe the answer to the above question changes how we may deal with a blank password. If we go for no (we don\u0027t support changing the password), a blank password is a charm error (maybe we could set the unit in an error state? I\u0027m not sure, we\u0027d be looking at a bug in this case).\n\nIf we do support changing the password, then I think we should block on a blank one, waiting for the user to fix the situation.\n\nWhat are your thoughts on this?","commit_id":"38580a6b8407e3eee5c801153fbe36f13a27015c"},{"author":{"_account_id":25011,"name":"Drew Freiberger","email":"drew.freiberger@canonical.com","username":"afreiberger"},"change_message_id":"2249f663f2e88afca7744e4f067b010b89f76ae1","unresolved":true,"context_lines":[{"line_number":508,"context_line":"    # Target file path is the default as documented on pmp-check-mysql-status"},{"line_number":509,"context_line":"    # --help output."},{"line_number":510,"context_line":"    ch_core.templating.render(\"nagios-my.cnf\", \"/etc/nagios/mysql.cnf\","},{"line_number":511,"context_line":"            context,"},{"line_number":512,"context_line":"           owner\u003d\"nagios\", group\u003d\"nagios\", perms\u003d0o640)"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"    reactive.set_flag(\u0027threads-check-credentials-file.created\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4279db98_25c926e3","line":511,"in_reply_to":"28826295_fe89291c","updated":"2021-11-18 16:17:59.000000000","message":"\u003e pep8: E128 continuation line under-indented for visual indent\n\nPlease fix. Pattern should be indenting all variables one per line if they don\u0027t all fit on one line.\n\nch_core.templating.render(\n    \"x\",\n    \"y\",\n    \"z\",\n)","commit_id":"38580a6b8407e3eee5c801153fbe36f13a27015c"},{"author":{"_account_id":25011,"name":"Drew Freiberger","email":"drew.freiberger@canonical.com","username":"afreiberger"},"change_message_id":"2249f663f2e88afca7744e4f067b010b89f76ae1","unresolved":true,"context_lines":[{"line_number":521,"context_line":"    # nrpe-external-master-{joined,changed} hooks. We know it won\u0027t be any of"},{"line_number":522,"context_line":"    # -{departed,broken} hooks because the nrpe-external-master layer would"},{"line_number":523,"context_line":"    # have unset the available flag."},{"line_number":524,"context_line":"    if ch_core.hookenv.relation_type() !\u003d \u0027nrpe-external-master\u0027 and ch_core.hookenv.hook_name() !\u003d \u0027config-changed\u0027:"},{"line_number":525,"context_line":"        return"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    # python-dbus is used by check_upstart_job"}],"source_content_type":"text/x-python","patch_set":2,"id":"9b535b4c_9fe293f3","line":524,"in_reply_to":"6efdc831_eda59a31","updated":"2021-11-18 16:17:59.000000000","message":"\u003e pep8: E501 line too long (117 \u003e 79 characters)\n\nPlease fix. Black suggests:\n\nif (\n    ch_core.hookenv.relation_type() !\u003d \"nrpe-external-master\"\n    and ch_core.hookenv.hook_name() !\u003d \"config-changed\"\n):","commit_id":"38580a6b8407e3eee5c801153fbe36f13a27015c"},{"author":{"_account_id":25011,"name":"Drew Freiberger","email":"drew.freiberger@canonical.com","username":"afreiberger"},"change_message_id":"2249f663f2e88afca7744e4f067b010b89f76ae1","unresolved":true,"context_lines":[{"line_number":527,"context_line":"    # python-dbus is used by check_upstart_job"},{"line_number":528,"context_line":"    # nagios-plugins-contrib add pmp-check-mysql-status check"},{"line_number":529,"context_line":"    packages \u003d fetch.filter_installed_packages([\"python-dbus\","},{"line_number":530,"context_line":"                                          \"nagios-plugins-contrib\"])"},{"line_number":531,"context_line":"    fetch.apt_install(packages)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    current_unit \u003d nrpe.get_nagios_unit_name()"}],"source_content_type":"text/x-python","patch_set":2,"id":"287550c9_7183b21e","line":530,"in_reply_to":"ca945caa_0b2d7bef","updated":"2021-11-18 16:17:59.000000000","message":"\u003e pep8: E128 continuation line under-indented for visual indent\n\nPlease fix.\n\n    packages \u003d fetch.filter_installed_packages(\n        [\"python-dbus\", \"nagios-plugins-contrib\"]\n    )","commit_id":"38580a6b8407e3eee5c801153fbe36f13a27015c"},{"author":{"_account_id":25011,"name":"Drew Freiberger","email":"drew.freiberger@canonical.com","username":"afreiberger"},"change_message_id":"2249f663f2e88afca7744e4f067b010b89f76ae1","unresolved":true,"context_lines":[{"line_number":533,"context_line":"    current_unit \u003d nrpe.get_nagios_unit_name()"},{"line_number":534,"context_line":"    nrpe_setup \u003d nrpe.NRPE()"},{"line_number":535,"context_line":"    with charm.provide_charm_instance() as instance:"},{"line_number":536,"context_line":"        nrpe.add_init_service_checks(nrpe_setup, instance.services, current_unit)"},{"line_number":537,"context_line":"    nrpe_setup.add_check("},{"line_number":538,"context_line":"        shortname\u003d\u0027mysql_proc\u0027,"},{"line_number":539,"context_line":"        description\u003d\u0027Check MySQL process {}\u0027.format(current_unit),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ce960873_162ae992","line":536,"in_reply_to":"ad4e4731_eb0048f0","updated":"2021-11-18 16:17:59.000000000","message":"\u003e pep8: E501 line too long (81 \u003e 79 characters)\n\nPlease fix.\n\n        nrpe.add_init_service_checks(\n            nrpe_setup, instance.services, current_unit\n        )","commit_id":"38580a6b8407e3eee5c801153fbe36f13a27015c"},{"author":{"_account_id":25011,"name":"Drew Freiberger","email":"drew.freiberger@canonical.com","username":"afreiberger"},"change_message_id":"2249f663f2e88afca7744e4f067b010b89f76ae1","unresolved":true,"context_lines":[{"line_number":543,"context_line":"        shortname\u003d\u0027mysql_threads\u0027,"},{"line_number":544,"context_line":"        description\u003d\u0027Check MySQL connected threads\u0027,"},{"line_number":545,"context_line":"        check_cmd\u003d\u0027pmp-check-mysql-status \u0027"},{"line_number":546,"context_line":"                  \u0027-x Threads_connected -o / -y max_connections -T pct {thresholds}\u0027.format("},{"line_number":547,"context_line":"                      thresholds\u003dch_core.hookenv.config(\u0027nrpe-threads-connected\u0027))"},{"line_number":548,"context_line":"    )"},{"line_number":549,"context_line":"    nrpe_setup.write()"}],"source_content_type":"text/x-python","patch_set":2,"id":"33b7dec8_d24f9766","line":546,"in_reply_to":"1800cee9_4560ce9c","updated":"2021-11-18 16:17:59.000000000","message":"\u003e pep8: E501 line too long (92 \u003e 79 characters)\n\nPlease fix. Black suggests:\n\n    nrpe_setup.add_check(\n        shortname\u003d\"mysql_threads\",\n        description\u003d\"Check MySQL connected threads\",\n        check_cmd\u003d\"pmp-check-mysql-status \"\n        \"-x Threads_connected -o / -y max_connections -T pct {thresholds}\".format(\n            thresholds\u003dch_core.hookenv.config(\"nrpe-threads-connected\")\n        ),\n    )","commit_id":"38580a6b8407e3eee5c801153fbe36f13a27015c"},{"author":{"_account_id":25011,"name":"Drew Freiberger","email":"drew.freiberger@canonical.com","username":"afreiberger"},"change_message_id":"fc3ef52e5c3ad262a06bcb8a8f34217e0051439a","unresolved":true,"context_lines":[{"line_number":543,"context_line":"        shortname\u003d\u0027mysql_threads\u0027,"},{"line_number":544,"context_line":"        description\u003d\u0027Check MySQL connected threads\u0027,"},{"line_number":545,"context_line":"        check_cmd\u003d\u0027pmp-check-mysql-status \u0027"},{"line_number":546,"context_line":"                  \u0027-x Threads_connected -o / -y max_connections -T pct {thresholds}\u0027.format("},{"line_number":547,"context_line":"                      thresholds\u003dch_core.hookenv.config(\u0027nrpe-threads-connected\u0027))"},{"line_number":548,"context_line":"    )"},{"line_number":549,"context_line":"    nrpe_setup.write()"}],"source_content_type":"text/x-python","patch_set":2,"id":"679c7ba6_ef2b427e","line":546,"in_reply_to":"33b7dec8_d24f9766","updated":"2021-11-18 16:25:19.000000000","message":"if foo:\n    nrpe_setup.add_check(\n        shortname\u003d\"mysql_threads\",\n        description\u003d\"Check MySQL connected threads\",\n        check_cmd\u003d\"pmp-check-mysql-status -x Threads_connected -o / \" \n        \" -y max_connections -T pct {thresholds}\".format(\n            thresholds\u003dch_core.hookenv.config(\"nrpe-threads-connected\")\n        ),\n    )","commit_id":"38580a6b8407e3eee5c801153fbe36f13a27015c"},{"author":{"_account_id":25011,"name":"Drew Freiberger","email":"drew.freiberger@canonical.com","username":"afreiberger"},"change_message_id":"2249f663f2e88afca7744e4f067b010b89f76ae1","unresolved":true,"context_lines":[{"line_number":544,"context_line":"        description\u003d\u0027Check MySQL connected threads\u0027,"},{"line_number":545,"context_line":"        check_cmd\u003d\u0027pmp-check-mysql-status \u0027"},{"line_number":546,"context_line":"                  \u0027-x Threads_connected -o / -y max_connections -T pct {thresholds}\u0027.format("},{"line_number":547,"context_line":"                      thresholds\u003dch_core.hookenv.config(\u0027nrpe-threads-connected\u0027))"},{"line_number":548,"context_line":"    )"},{"line_number":549,"context_line":"    nrpe_setup.write()"},{"line_number":550,"context_line":"    # request CPU governor check from nrpe relation to be performance"}],"source_content_type":"text/x-python","patch_set":2,"id":"33788aba_6276eeee","line":547,"updated":"2021-11-18 16:17:59.000000000","message":"This thresholds may need to change based on my comment in config.yaml if we switch to warn_int_pct,crit_int_pct, this will need to be formatted to -w warn_int_pct -c crit_int_pct before the check is added.","commit_id":"38580a6b8407e3eee5c801153fbe36f13a27015c"},{"author":{"_account_id":25011,"name":"Drew Freiberger","email":"drew.freiberger@canonical.com","username":"afreiberger"},"change_message_id":"2249f663f2e88afca7744e4f067b010b89f76ae1","unresolved":true,"context_lines":[{"line_number":552,"context_line":"        \u0027requested_cpu_governor\u0027: \u0027performance\u0027,"},{"line_number":553,"context_line":"    }"},{"line_number":554,"context_line":"    for rid in ch_core.hookenv.relation_ids(\u0027nrpe-external-master\u0027):"},{"line_number":555,"context_line":"        ch_core.hookenv.relation_set(relation_id\u003drid, relation_settings\u003drel_settings)"}],"source_content_type":"text/x-python","patch_set":2,"id":"8dadf363_53dc729f","line":555,"in_reply_to":"ff87994b_de632006","updated":"2021-11-18 16:17:59.000000000","message":"\u003e pep8: E501 line too long (85 \u003e 79 characters)\n\nPlease fix.\n\n        ch_core.hookenv.relation_set(\n            relation_id\u003drid, relation_settings\u003drel_settings\n        )","commit_id":"38580a6b8407e3eee5c801153fbe36f13a27015c"}]}