)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"23969e015edc7a6bce5aedb5334c9cb605b631ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5e158a34_5c785a8a","updated":"2023-10-05 19:53:46.000000000","message":"LGTM","commit_id":"a6c5567354175755762ec9a3e20fc628a06fcd43"}],"hooks/neutron_api_utils.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"222c7e821016a01a30fcca20458471db35a8c5b7","unresolved":true,"context_lines":[{"line_number":110,"context_line":"    \u0027python3-neutron\u0027,"},{"line_number":111,"context_line":"    \u0027python3-neutron-lbaas\u0027,"},{"line_number":112,"context_line":"    \u0027python3-neutron-dynamic-routing\u0027,"},{"line_number":113,"context_line":"    \u0027python3-networking-hyperv\u0027,"},{"line_number":114,"context_line":"    \u0027python3-memcache\u0027,"},{"line_number":115,"context_line":"]"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"d555d4a8_3b182c5c","line":113,"range":{"start_line":113,"start_character":5,"end_line":113,"end_character":30},"updated":"2023-10-05 13:55:43.000000000","message":"We don\u0027t need this anymore","commit_id":"59b2185a58a1aa1d6114522a05e6a47c5470088e"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"5f30c4fe44375beed5c7a895c4afe7177c4db53b","unresolved":true,"context_lines":[{"line_number":110,"context_line":"    \u0027python3-neutron\u0027,"},{"line_number":111,"context_line":"    \u0027python3-neutron-lbaas\u0027,"},{"line_number":112,"context_line":"    \u0027python3-neutron-dynamic-routing\u0027,"},{"line_number":113,"context_line":"    \u0027python3-networking-hyperv\u0027,"},{"line_number":114,"context_line":"    \u0027python3-memcache\u0027,"},{"line_number":115,"context_line":"]"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dd9e003a_3b9b7e6d","line":113,"range":{"start_line":113,"start_character":5,"end_line":113,"end_character":30},"in_reply_to":"d555d4a8_3b182c5c","updated":"2023-10-05 15:46:21.000000000","message":"This gets removed down below in line 471. I guess since we now have charm stable branches that map to openstack releases we could remove old release specific code. I\u0027m holding out hope that we can go back to a single stable branch someday that supports all the releases.","commit_id":"59b2185a58a1aa1d6114522a05e6a47c5470088e"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"222c7e821016a01a30fcca20458471db35a8c5b7","unresolved":true,"context_lines":[{"line_number":120,"context_line":"    \u0027python-neutron-fwaas\u0027,"},{"line_number":121,"context_line":"    \u0027python-neutron-vpnaas\u0027,"},{"line_number":122,"context_line":"    \u0027python-neutron-dynamic-routing\u0027,"},{"line_number":123,"context_line":"    \u0027python-networking-hyperv\u0027,"},{"line_number":124,"context_line":"    \u0027python-memcache\u0027,"},{"line_number":125,"context_line":"    \u0027python-keystoneclient\u0027,"},{"line_number":126,"context_line":"    \u0027python-mysqldb\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1923b433_82c76617","line":123,"range":{"start_line":123,"start_character":5,"end_line":123,"end_character":29},"updated":"2023-10-05 13:55:43.000000000","message":"Same","commit_id":"59b2185a58a1aa1d6114522a05e6a47c5470088e"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"5f30c4fe44375beed5c7a895c4afe7177c4db53b","unresolved":true,"context_lines":[{"line_number":120,"context_line":"    \u0027python-neutron-fwaas\u0027,"},{"line_number":121,"context_line":"    \u0027python-neutron-vpnaas\u0027,"},{"line_number":122,"context_line":"    \u0027python-neutron-dynamic-routing\u0027,"},{"line_number":123,"context_line":"    \u0027python-networking-hyperv\u0027,"},{"line_number":124,"context_line":"    \u0027python-memcache\u0027,"},{"line_number":125,"context_line":"    \u0027python-keystoneclient\u0027,"},{"line_number":126,"context_line":"    \u0027python-mysqldb\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3d4f3247_6797c9d1","line":123,"range":{"start_line":123,"start_character":5,"end_line":123,"end_character":29},"in_reply_to":"1923b433_82c76617","updated":"2023-10-05 15:46:21.000000000","message":"This shouldn\u0027t be affected because it is old PY2-\u003ePY3 transition code.","commit_id":"59b2185a58a1aa1d6114522a05e6a47c5470088e"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"222c7e821016a01a30fcca20458471db35a8c5b7","unresolved":true,"context_lines":[{"line_number":490,"context_line":"        if cmp_release \u003e\u003d \u0027pike\u0027:"},{"line_number":491,"context_line":"            packages.remove(\u0027python-neutron-vpnaas\u0027)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        if release \u003d\u003d \u0027kilo\u0027 or cmp_release \u003e\u003d \u0027mitaka\u0027:"},{"line_number":494,"context_line":"            packages.append(\u0027python-networking-hyperv\u0027)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    if config(\u0027neutron-plugin\u0027) \u003d\u003d \u0027vsp\u0027 and cmp_release \u003c \u0027newton\u0027:"},{"line_number":497,"context_line":"        nuage_pkgs \u003d config(\u0027nuage-packages\u0027).split()"}],"source_content_type":"text/x-python","patch_set":2,"id":"93675c6d_3e604a29","line":494,"range":{"start_line":493,"start_character":0,"end_line":494,"end_character":55},"updated":"2023-10-05 13:55:43.000000000","message":"add logic as you did in the other file","commit_id":"59b2185a58a1aa1d6114522a05e6a47c5470088e"},{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"23969e015edc7a6bce5aedb5334c9cb605b631ce","unresolved":false,"context_lines":[{"line_number":490,"context_line":"        if cmp_release \u003e\u003d \u0027pike\u0027:"},{"line_number":491,"context_line":"            packages.remove(\u0027python-neutron-vpnaas\u0027)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        if release \u003d\u003d \u0027kilo\u0027 or cmp_release \u003e\u003d \u0027mitaka\u0027:"},{"line_number":494,"context_line":"            packages.append(\u0027python-networking-hyperv\u0027)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    if config(\u0027neutron-plugin\u0027) \u003d\u003d \u0027vsp\u0027 and cmp_release \u003c \u0027newton\u0027:"},{"line_number":497,"context_line":"        nuage_pkgs \u003d config(\u0027nuage-packages\u0027).split()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ae5cad8_b3c5da72","line":494,"range":{"start_line":493,"start_character":0,"end_line":494,"end_character":55},"in_reply_to":"4cbfaf0e_9ae6625d","updated":"2023-10-05 19:53:46.000000000","message":"I agree. this is a nested `if`.","commit_id":"59b2185a58a1aa1d6114522a05e6a47c5470088e"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"5f30c4fe44375beed5c7a895c4afe7177c4db53b","unresolved":true,"context_lines":[{"line_number":490,"context_line":"        if cmp_release \u003e\u003d \u0027pike\u0027:"},{"line_number":491,"context_line":"            packages.remove(\u0027python-neutron-vpnaas\u0027)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        if release \u003d\u003d \u0027kilo\u0027 or cmp_release \u003e\u003d \u0027mitaka\u0027:"},{"line_number":494,"context_line":"            packages.append(\u0027python-networking-hyperv\u0027)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    if config(\u0027neutron-plugin\u0027) \u003d\u003d \u0027vsp\u0027 and cmp_release \u003c \u0027newton\u0027:"},{"line_number":497,"context_line":"        nuage_pkgs \u003d config(\u0027nuage-packages\u0027).split()"}],"source_content_type":"text/x-python","patch_set":2,"id":"4cbfaf0e_9ae6625d","line":494,"range":{"start_line":493,"start_character":0,"end_line":494,"end_character":55},"in_reply_to":"93675c6d_3e604a29","updated":"2023-10-05 15:46:21.000000000","message":"I don\u0027t think this is needed since this is wrapped with a \u003c \u0027rocky\u0027 check","commit_id":"59b2185a58a1aa1d6114522a05e6a47c5470088e"}],"unit_tests/test_neutron_api_context.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"222c7e821016a01a30fcca20458471db35a8c5b7","unresolved":true,"context_lines":[{"line_number":221,"context_line":"    def test_get_ml2_mechanism_drivers(self):"},{"line_number":222,"context_line":"        self.os_release.return_value \u003d \u0027mitaka\u0027"},{"line_number":223,"context_line":"        self.assertEqual(context.get_ml2_mechanism_drivers(),"},{"line_number":224,"context_line":"                         \u0027openvswitch,hyperv,l2population\u0027)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    def test_get_ml2_mechanism_drivers_kilo(self):"},{"line_number":227,"context_line":"        self.os_release.return_value \u003d \u0027kilo\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"30a76dcc_cdba55ad","line":224,"range":{"start_line":224,"start_character":38,"end_line":224,"end_character":44},"updated":"2023-10-05 13:55:43.000000000","message":"This unit test needs to be fixed. There are several States below that needs to be addressed.","commit_id":"59b2185a58a1aa1d6114522a05e6a47c5470088e"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"5f30c4fe44375beed5c7a895c4afe7177c4db53b","unresolved":true,"context_lines":[{"line_number":221,"context_line":"    def test_get_ml2_mechanism_drivers(self):"},{"line_number":222,"context_line":"        self.os_release.return_value \u003d \u0027mitaka\u0027"},{"line_number":223,"context_line":"        self.assertEqual(context.get_ml2_mechanism_drivers(),"},{"line_number":224,"context_line":"                         \u0027openvswitch,hyperv,l2population\u0027)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    def test_get_ml2_mechanism_drivers_kilo(self):"},{"line_number":227,"context_line":"        self.os_release.return_value \u003d \u0027kilo\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"36bc07c4_633dcf93","line":224,"range":{"start_line":224,"start_character":38,"end_line":224,"end_character":44},"in_reply_to":"30a76dcc_cdba55ad","updated":"2023-10-05 15:46:21.000000000","message":"They run on \u003c bobcat releases so they\u0027re successful. I could add a new one to test bobcat though.","commit_id":"59b2185a58a1aa1d6114522a05e6a47c5470088e"},{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"23969e015edc7a6bce5aedb5334c9cb605b631ce","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    def test_get_ml2_mechanism_drivers(self):"},{"line_number":222,"context_line":"        self.os_release.return_value \u003d \u0027mitaka\u0027"},{"line_number":223,"context_line":"        self.assertEqual(context.get_ml2_mechanism_drivers(),"},{"line_number":224,"context_line":"                         \u0027openvswitch,hyperv,l2population\u0027)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    def test_get_ml2_mechanism_drivers_kilo(self):"},{"line_number":227,"context_line":"        self.os_release.return_value \u003d \u0027kilo\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"0314c1d1_8501046e","line":224,"range":{"start_line":224,"start_character":38,"end_line":224,"end_character":44},"in_reply_to":"36bc07c4_633dcf93","updated":"2023-10-05 19:53:46.000000000","message":"The unit test was added.","commit_id":"59b2185a58a1aa1d6114522a05e6a47c5470088e"}]}