)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31289,"name":"Aurelien Lourot","email":"aurelien.lourot@gmail.com","username":"lourot"},"change_message_id":"eb8c119ad67bab66c4fc30f8df9b0fd097709669","unresolved":true,"context_lines":[{"line_number":12,"context_line":"on neutron-api charm."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"neutron-api charm adds enabled-fwaas as relation data in the commit"},{"line_number":15,"context_line":"53013249b205abd1ae51de22f0504c98b5ac08df."},{"line_number":16,"context_line":"This patch adds fwaas_v2 to l3_extension_plugins when enable-fwaas"},{"line_number":17,"context_line":"is set to true in relation data."},{"line_number":18,"context_line":"This patch also purges python3-neutron-fwaas from victoria release."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d50f5f77_895a55b5","line":15,"updated":"2021-09-07 12:57:54.000000000","message":"This is outdated because this review has moved meanwhile. I think you should write\n\n    https://review.opendev.org/c/openstack/charm-neutron-api/+/806676\n\ninstead, thanks!","commit_id":"c4c94261d2565941383fcba7a9ce0774983ee821"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"7b6f00096c300d23f4a1eec867d5c302217975a1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"on neutron-api charm."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"neutron-api charm adds enabled-fwaas as relation data in the commit"},{"line_number":15,"context_line":"53013249b205abd1ae51de22f0504c98b5ac08df."},{"line_number":16,"context_line":"This patch adds fwaas_v2 to l3_extension_plugins when enable-fwaas"},{"line_number":17,"context_line":"is set to true in relation data."},{"line_number":18,"context_line":"This patch also purges python3-neutron-fwaas from victoria release."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9852c242_8adda1c0","line":15,"in_reply_to":"d50f5f77_895a55b5","updated":"2021-09-09 09:16:53.000000000","message":"Done","commit_id":"c4c94261d2565941383fcba7a9ce0774983ee821"}],"hooks/neutron_contexts.py":[{"author":{"_account_id":31289,"name":"Aurelien Lourot","email":"aurelien.lourot@gmail.com","username":"lourot"},"change_message_id":"eb8c119ad67bab66c4fc30f8df9b0fd097709669","unresolved":true,"context_lines":[{"line_number":135,"context_line":"        # only enable it for stein although fwaasv2 was added in Queens"},{"line_number":136,"context_line":"        is_stein \u003d cmp_os_release \u003e\u003d \u0027stein\u0027"},{"line_number":137,"context_line":"        if is_stein:"},{"line_number":138,"context_line":"            l3_extension_plugins.append(\u0027fwaas_v2\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        if (is_stein and api_settings.get(\u0027enable_nfg_logging\u0027)):"},{"line_number":141,"context_line":"            l3_extension_plugins.append(\u0027fwaas_v2_log\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5b9d3b46_773cf6ff","side":"PARENT","line":138,"updated":"2021-09-07 12:57:54.000000000","message":"Don\u0027t we need to conditionally add it now when enabled_fwaas is True on the relation?\n\nEDIT: I suspect I\u0027m blind and I can\u0027t see where this is set, because how would be the test passing otherwise?","commit_id":"443ffbde880ee3c29c952dd3dec57310ec11cdf9"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"ea9462df614df26e0e46e8448f1c8d89e54d0d7a","unresolved":true,"context_lines":[{"line_number":135,"context_line":"        # only enable it for stein although fwaasv2 was added in Queens"},{"line_number":136,"context_line":"        is_stein \u003d cmp_os_release \u003e\u003d \u0027stein\u0027"},{"line_number":137,"context_line":"        if is_stein:"},{"line_number":138,"context_line":"            l3_extension_plugins.append(\u0027fwaas_v2\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        if (is_stein and api_settings.get(\u0027enable_nfg_logging\u0027)):"},{"line_number":141,"context_line":"            l3_extension_plugins.append(\u0027fwaas_v2_log\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"838129bd_edc26832","side":"PARENT","line":138,"in_reply_to":"5b9d3b46_773cf6ff","updated":"2021-09-07 18:42:22.000000000","message":"Hi Aurelien, this is now handled in a central place in charm-helpers i.e. https://github.com/juju/charm-helpers/blob/f9d6d2f8cc1616a63b234e2d41c49800d39ab306/charmhelpers/contrib/openstack/context.py#L1831 and the correct release is calculated by the associated neutron-api change.","commit_id":"443ffbde880ee3c29c952dd3dec57310ec11cdf9"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"7b6f00096c300d23f4a1eec867d5c302217975a1","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        # only enable it for stein although fwaasv2 was added in Queens"},{"line_number":136,"context_line":"        is_stein \u003d cmp_os_release \u003e\u003d \u0027stein\u0027"},{"line_number":137,"context_line":"        if is_stein:"},{"line_number":138,"context_line":"            l3_extension_plugins.append(\u0027fwaas_v2\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        if (is_stein and api_settings.get(\u0027enable_nfg_logging\u0027)):"},{"line_number":141,"context_line":"            l3_extension_plugins.append(\u0027fwaas_v2_log\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7eb652bc_d032ec39","side":"PARENT","line":138,"in_reply_to":"838129bd_edc26832","updated":"2021-09-09 09:16:53.000000000","message":"Aurelien, \nAs Ed mentioned the fwaas is added to l3_agent_extensions in charmhelpers.","commit_id":"443ffbde880ee3c29c952dd3dec57310ec11cdf9"}],"hooks/neutron_utils.py":[{"author":{"_account_id":31289,"name":"Aurelien Lourot","email":"aurelien.lourot@gmail.com","username":"lourot"},"change_message_id":"eb8c119ad67bab66c4fc30f8df9b0fd097709669","unresolved":true,"context_lines":[{"line_number":313,"context_line":"        if plugin in (OVS, OVS_ODL):"},{"line_number":314,"context_line":"            purge_packages_list.append(\u0027neutron-lbaasv2-agent\u0027)"},{"line_number":315,"context_line":"    if cmp_os_source \u003e\u003d \u0027victoria\u0027:"},{"line_number":316,"context_line":"        purge_packages_list.append(\u0027python3-neutron-fwaas\u0027)"},{"line_number":317,"context_line":"    return purge_packages_list"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8a13eead_c6f7815b","line":316,"updated":"2021-09-07 12:57:54.000000000","message":"Shouldn\u0027t it be removed from line 207 from the PY3_PACKAGES list?","commit_id":"c4c94261d2565941383fcba7a9ce0774983ee821"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"7b6f00096c300d23f4a1eec867d5c302217975a1","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        if plugin in (OVS, OVS_ODL):"},{"line_number":314,"context_line":"            purge_packages_list.append(\u0027neutron-lbaasv2-agent\u0027)"},{"line_number":315,"context_line":"    if cmp_os_source \u003e\u003d \u0027victoria\u0027:"},{"line_number":316,"context_line":"        purge_packages_list.append(\u0027python3-neutron-fwaas\u0027)"},{"line_number":317,"context_line":"    return purge_packages_list"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8f7d7bba_b8a691c6","line":316,"in_reply_to":"4dc563fd_16214c74","updated":"2021-09-09 09:16:53.000000000","message":"After some tests, realised python3-neutron-fwaas is installed as dependency during installation of package neutron-l3-agent. So purging python3-neutron-fwaas has adverse effects and no need to purge. Removing the above logic in the PS5.\npython3-neutron-fwaas is added to PY3 packages specifically to support Rocky release while swithching from Python2 to Python3.\n\nhttps://opendev.org/openstack/charm-neutron-gateway/commit/73afa34c38c2143d4dca7c4504443ecd1d088f82","commit_id":"c4c94261d2565941383fcba7a9ce0774983ee821"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"498cc13d10993e3610708efb193ba55b6d92c0cd","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        if plugin in (OVS, OVS_ODL):"},{"line_number":314,"context_line":"            purge_packages_list.append(\u0027neutron-lbaasv2-agent\u0027)"},{"line_number":315,"context_line":"    if cmp_os_source \u003e\u003d \u0027victoria\u0027:"},{"line_number":316,"context_line":"        purge_packages_list.append(\u0027python3-neutron-fwaas\u0027)"},{"line_number":317,"context_line":"    return purge_packages_list"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"279103fb_2350666f","line":316,"in_reply_to":"7222848a_be4c15b7","updated":"2021-09-12 01:11:55.000000000","message":"Sorry I mean PS4. Updated the inline comments with information about Rocky py2 py3 conversion. I dont think there is need for explicit mention for python3-neutron-fwaas as it is applicable to all python-{nova,neutron} packages.","commit_id":"c4c94261d2565941383fcba7a9ce0774983ee821"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"ea9462df614df26e0e46e8448f1c8d89e54d0d7a","unresolved":true,"context_lines":[{"line_number":313,"context_line":"        if plugin in (OVS, OVS_ODL):"},{"line_number":314,"context_line":"            purge_packages_list.append(\u0027neutron-lbaasv2-agent\u0027)"},{"line_number":315,"context_line":"    if cmp_os_source \u003e\u003d \u0027victoria\u0027:"},{"line_number":316,"context_line":"        purge_packages_list.append(\u0027python3-neutron-fwaas\u0027)"},{"line_number":317,"context_line":"    return purge_packages_list"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"4dc563fd_16214c74","line":316,"in_reply_to":"8a13eead_c6f7815b","updated":"2021-09-07 18:42:22.000000000","message":"So what needs to happen is two things; (a) don\u0027t install it for \u003e\u003d V OR if fwaas is disabled and (b) remove/purge it for \u003e\u003d V. Hemanth please ensure both of these are happening here.","commit_id":"c4c94261d2565941383fcba7a9ce0774983ee821"},{"author":{"_account_id":31289,"name":"Aurelien Lourot","email":"aurelien.lourot@gmail.com","username":"lourot"},"change_message_id":"13c86a7f4548d592f769939a1b25ef1f95877368","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        if plugin in (OVS, OVS_ODL):"},{"line_number":314,"context_line":"            purge_packages_list.append(\u0027neutron-lbaasv2-agent\u0027)"},{"line_number":315,"context_line":"    if cmp_os_source \u003e\u003d \u0027victoria\u0027:"},{"line_number":316,"context_line":"        purge_packages_list.append(\u0027python3-neutron-fwaas\u0027)"},{"line_number":317,"context_line":"    return purge_packages_list"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7222848a_be4c15b7","line":316,"in_reply_to":"8f7d7bba_b8a691c6","updated":"2021-09-09 12:00:55.000000000","message":"\"Removing the above logic in the PS5\" \u003c- Do you mean there is a new patchset 5 coming soon?\n\nAlso, this is very valuable information you are sharing here. I think we should add it as an inline note around line 207.","commit_id":"c4c94261d2565941383fcba7a9ce0774983ee821"}],"unit_tests/test_neutron_contexts.py":[{"author":{"_account_id":31289,"name":"Aurelien Lourot","email":"aurelien.lourot@gmail.com","username":"lourot"},"change_message_id":"eb8c119ad67bab66c4fc30f8df9b0fd097709669","unresolved":true,"context_lines":[{"line_number":67,"context_line":"                \u0027rpc_response_timeout\u0027: 60,"},{"line_number":68,"context_line":"                \u0027enable_l3ha\u0027: True,"},{"line_number":69,"context_line":"                \u0027enable_fwaas\u0027: True,"},{"line_number":70,"context_line":"                \u0027l3_extension_plugins\u0027: [\u0027fwaas_v2\u0027],"},{"line_number":71,"context_line":"            })"},{"line_number":72,"context_line":"        self.test_config.set(\u0027run-internal-router\u0027, \u0027none\u0027)"},{"line_number":73,"context_line":"        self.test_config.set(\u0027external-network-id\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"85b1e36e_aaf70f9b","line":70,"updated":"2021-09-07 12:57:54.000000000","message":"As mentioned in another comment, I don\u0027t understand where this is set now. I must be blind, sorry about that.","commit_id":"c4c94261d2565941383fcba7a9ce0774983ee821"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"7b6f00096c300d23f4a1eec867d5c302217975a1","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                \u0027rpc_response_timeout\u0027: 60,"},{"line_number":68,"context_line":"                \u0027enable_l3ha\u0027: True,"},{"line_number":69,"context_line":"                \u0027enable_fwaas\u0027: True,"},{"line_number":70,"context_line":"                \u0027l3_extension_plugins\u0027: [\u0027fwaas_v2\u0027],"},{"line_number":71,"context_line":"            })"},{"line_number":72,"context_line":"        self.test_config.set(\u0027run-internal-router\u0027, \u0027none\u0027)"},{"line_number":73,"context_line":"        self.test_config.set(\u0027external-network-id\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"83f28092_f9b3b0d1","line":70,"in_reply_to":"85b1e36e_aaf70f9b","updated":"2021-09-09 09:16:53.000000000","message":"Replied by Ed in the previous comment","commit_id":"c4c94261d2565941383fcba7a9ce0774983ee821"}]}