)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"0881c5fd21c60077cedbf50076a25d64d885c934","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodrigo Barbieri \u003crodrigo.barbieri2010@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-07-25 14:02:30 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Fix migration across apps when using ceph ephemeral"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change app name sent to ceph to \u0027nova-compute\u0027,"},{"line_number":10,"context_line":"allowing all nova-compute apps to use the same"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ec59a331_c01a2b7c","line":7,"range":{"start_line":7,"start_character":43,"end_line":7,"end_character":57},"updated":"2023-08-11 11:58:38.000000000","message":"libvirt-image-backend\u003drbd","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"59e5089c414b17c1be1158dc9173d4374330b1e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a32f1609_18af16cd","updated":"2023-07-26 13:49:53.000000000","message":"CI failed due to ceph-osd unit not deploying correctly","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c421fd9e927206dd428840668aa99c91b604836b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2e04bdbc_6a549fdc","updated":"2023-08-10 12:47:36.000000000","message":"Felipe, discussing this further with the SEG team, I am not sure there is a strong motivation for cleaning up the old cephx keys. If it is a security concern, then it is the same risk as the new keys. Also, it would introduce a problem where if some nodes are cleaned up, but not all of them (because of running VMs the user hasn\u0027t been able to reboot to refresh the XML with the new key), then a VM migration (of a VM using the old key) that would previously succeed (between same charm apps) would now fail because the old key is not present on all the nodes.","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"211e2c04a8318191082dcd94b8d3e8732fb17cc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"42ceccfb_f13f3dc8","updated":"2023-08-22 09:16:47.000000000","message":"Provision +1 on what is proposed here but some tidy and removal of WIP needed.","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":8108,"name":"Nobuto Murata","email":"nobuto.murata@canonical.com","username":"nobuto-m"},"change_message_id":"a2218989dfa222b3b6e05c0ec3786dc7dbeb509a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"da0a69d2_6df72f9a","updated":"2023-07-25 17:15:27.000000000","message":"What happens if an user had two separate applications as `nova-compute-ssd-backed` and `nova-compute-hdd-backed` on purpose?","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8db76885564cf9416810c30bbfe08e9558254645","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"120355ab_474c9d19","updated":"2023-07-26 13:49:42.000000000","message":"charm-recheck","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":8108,"name":"Nobuto Murata","email":"nobuto.murata@canonical.com","username":"nobuto-m"},"change_message_id":"20c972a4c215017a00aa7934343f896bc98516fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1e952beb_fbacb99a","in_reply_to":"af18b69c_034dc06d","updated":"2023-07-25 17:20:07.000000000","message":"I was under the impression that charms would create two separate pools if there are two applications. But that wasn\u0027t the case.","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":8108,"name":"Nobuto Murata","email":"nobuto.murata@canonical.com","username":"nobuto-m"},"change_message_id":"b70966f3b3b464b5c80352aca20713383838e6c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"af18b69c_034dc06d","in_reply_to":"da0a69d2_6df72f9a","updated":"2023-07-25 17:18:38.000000000","message":"ah, never mind. The pool name was not from the app name but from an explicit config.\n\n\u003e   rbd-pool:\n\u003e     type: string\n\u003e     default: nova","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"81a00db22d2f7a1017fe799f30000683839ed24b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"243de45b_e0e23652","in_reply_to":"da0a69d2_6df72f9a","updated":"2023-07-25 17:17:09.000000000","message":"that\u0027s exactly the point of the patch. Both will be seen as the same by ceph, therefore migrations will now work, where before they wouldn\u0027t. Running instances are not disrupted, but to \"obtain the fix\" running instances need to be stopped/started to refresh their libvirt xml.","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"b3ac2bcfc4a16ef99552e49b6f5ed428f212c361","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cbee1adb_c15e353d","updated":"2023-08-28 15:40:16.000000000","message":"Felipe suggested rechecking as the CI had some network issues last week","commit_id":"c3c2cf0349c086dad7f23b180c3ee9ea0f865e8f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"38cc8d0da899c96092484cea025d569490162ab3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a0fba964_f5b974d5","updated":"2023-08-23 13:58:42.000000000","message":"Same error connecting to vault. The original patch had passed CI and the latest patchset was just slightly refactored","commit_id":"c3c2cf0349c086dad7f23b180c3ee9ea0f865e8f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e9398a71dcf508e2613cadfde8f35cc54d171057","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0608c4c5_29576916","updated":"2023-08-23 11:11:42.000000000","message":"charm-recheck","commit_id":"c3c2cf0349c086dad7f23b180c3ee9ea0f865e8f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c143f328dbf9bd0f213ead0ee5463e010cc1b04d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5d6b359a_70e730b9","updated":"2023-08-28 15:40:00.000000000","message":"charm-recheck","commit_id":"c3c2cf0349c086dad7f23b180c3ee9ea0f865e8f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"0878e8d790245c8d911e7e2e652b94e0e0515032","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1b23f77d_bee9d0ab","updated":"2023-08-24 12:38:44.000000000","message":"same vault connection CI error","commit_id":"c3c2cf0349c086dad7f23b180c3ee9ea0f865e8f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8688f36140c5546e624e327e2da70f4db0e374f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"51000602_338cf874","updated":"2023-08-23 11:11:31.000000000","message":"the error in jammy-antelope doesn\u0027t seem to be related to the deployment itself, one of the tests failed trying to scp to the instance","commit_id":"c3c2cf0349c086dad7f23b180c3ee9ea0f865e8f"}],"hooks/nova_compute_context.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"bc3760c78145e15938588222b2333ff606850a85","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# This is just a label and it must be consistent across"},{"line_number":64,"context_line":"# nova-compute nodes to support live migration."},{"line_number":65,"context_line":"CEPH_SECRET_UUID \u003d \u0027c91ce26f-403d-4058-9c38-6b56e1c428e0\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"OVS_BRIDGE \u003d \u0027br-int\u0027"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b3ed816f_9488f960","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":57},"updated":"2023-07-25 18:44:30.000000000","message":"why this needs to change? and what will happen if a deployment is upgrading and has the old id?","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"5f249eaf1d8c5dce06e2e7bded00a520223a611e","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# This is just a label and it must be consistent across"},{"line_number":64,"context_line":"# nova-compute nodes to support live migration."},{"line_number":65,"context_line":"CEPH_SECRET_UUID \u003d \u0027c91ce26f-403d-4058-9c38-6b56e1c428e0\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"OVS_BRIDGE \u003d \u0027br-int\u0027"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4f9d86ba_1392ebe4","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":57},"in_reply_to":"7836e80c_50f344a1","updated":"2023-08-11 19:34:59.000000000","message":"After some research, an interesting point to note here is that the new and the old UUID will have the same secret/usage, since that is created by ceph based on the client name. So, for the upgrade cases where only 1 app is used, I believe we are covered, as long as we don\u0027t delete the old keyring the VMs are using.\n\nIf you have 2 applications, which is main use case for this change, changing the uuid will not allow old vms to migrate anyways since they will be bound to their key.app-name.","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ae00714405bd9f4a8f8d997a376d074d8bba3f0e","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# This is just a label and it must be consistent across"},{"line_number":64,"context_line":"# nova-compute nodes to support live migration."},{"line_number":65,"context_line":"CEPH_SECRET_UUID \u003d \u0027c91ce26f-403d-4058-9c38-6b56e1c428e0\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"OVS_BRIDGE \u003d \u0027br-int\u0027"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7836e80c_50f344a1","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":57},"in_reply_to":"b3ed816f_9488f960","updated":"2023-07-26 13:47:14.000000000","message":"The upgrade-path could either be a) update the secret with same uuid changing its \"usage\" field replacing nova-compute-kvm to nova-compute, or b) add a new secret with a new uuid.\n\n(a) is a bit complicated because libvirt secrets cannot have their \"usage\" field updated, so the secret would have to be deleted and added again, which infers disruptibility to the VMs, deleting a secret that they could be using. (b) is cleaner because it is non-disruptive to existing VMs and the new secret will have a new UUID, so they do not conflict.","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"615445ee25d4579eb874febc675068911696e0e5","unresolved":true,"context_lines":[{"line_number":413,"context_line":"        ctxt \u003d super(NovaComputeCephContext, self).__call__()"},{"line_number":414,"context_line":"        if not ctxt:"},{"line_number":415,"context_line":"            return {}"},{"line_number":416,"context_line":"        svc \u003d \u0027nova-compute\u0027"},{"line_number":417,"context_line":"        # secret.xml"},{"line_number":418,"context_line":"        ctxt[\u0027ceph_secret_uuid\u0027] \u003d CEPH_SECRET_UUID"},{"line_number":419,"context_line":"        # nova.conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"dc654c8a_6a712ae8","line":416,"updated":"2023-07-31 15:30:52.000000000","message":"as a proof of concept works, but this is an assumption that every deployed cloud has a charm application named \"nova-compute\", does this work if I deploy an environment with \"nova-compute-foo\" and \"nova-compute-bar\" only?","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ab02543fd4b0e4f9d85e0f72a1ab71d89982c432","unresolved":true,"context_lines":[{"line_number":413,"context_line":"        ctxt \u003d super(NovaComputeCephContext, self).__call__()"},{"line_number":414,"context_line":"        if not ctxt:"},{"line_number":415,"context_line":"            return {}"},{"line_number":416,"context_line":"        svc \u003d \u0027nova-compute\u0027"},{"line_number":417,"context_line":"        # secret.xml"},{"line_number":418,"context_line":"        ctxt[\u0027ceph_secret_uuid\u0027] \u003d CEPH_SECRET_UUID"},{"line_number":419,"context_line":"        # nova.conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"e9155699_e8b4e936","line":416,"in_reply_to":"2d9190c1_74c6e7cb","updated":"2023-08-07 15:20:11.000000000","message":"oh I see, so what happens is that:\n1) the ceph credential for the user \u0027nova-compute\u0027 is created (where before it would exist for \u0027nova-compute-foo\u0027. The ceph credential for \u0027nova-compute-foo\u0027 remains on ceph. The ceph conf and secret xml files are rewritten with \u0027nova-compute\u0027 instead of \u0027nova-compute-foo\u0027, therefore pointing to the new \u0027nova-compute\u0027 ceph credential. The old credential key file client.ceph.nova-compute-foo will continue to exist. Running VMs are not disrupted as they were created with the nova-compute-foo ceph credential key. New VMs are created with the new key.","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"929d42116b748878ffa5d1aa6a4c4a8a1daa6ec9","unresolved":true,"context_lines":[{"line_number":413,"context_line":"        ctxt \u003d super(NovaComputeCephContext, self).__call__()"},{"line_number":414,"context_line":"        if not ctxt:"},{"line_number":415,"context_line":"            return {}"},{"line_number":416,"context_line":"        svc \u003d \u0027nova-compute\u0027"},{"line_number":417,"context_line":"        # secret.xml"},{"line_number":418,"context_line":"        ctxt[\u0027ceph_secret_uuid\u0027] \u003d CEPH_SECRET_UUID"},{"line_number":419,"context_line":"        # nova.conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"6bb162d9_a1992de0","line":416,"in_reply_to":"48da5807_5131e67d","updated":"2023-08-08 14:29:56.000000000","message":"If there are any running VMs using the old keys then we cannot perform such action. If there are no longer running VMs, then yes, but we could be in either of 2 scenarios:\n\n1) there are no more existing computes with the old keys, but the old credentials are still in ceph. Probably nothing needs to be done in this scenario. I don\u0027t think the leftover credentials in ceph are harmful.\n\n2) let\u0027s say all running VMs have been rebooted and are now using the new keys, then we could clean up the old keys. Doing so proactively is probably possible if the charm has permissions to talk to libvirt and check the running VM XMLs. Doing this by an action shifts the responsibility to the user, which may not have checked the VMs properly and may regret the action if there is still a VM running with the old key.","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"e7f0fa39329c7578d33a71946ba474cbf116c5b4","unresolved":true,"context_lines":[{"line_number":413,"context_line":"        ctxt \u003d super(NovaComputeCephContext, self).__call__()"},{"line_number":414,"context_line":"        if not ctxt:"},{"line_number":415,"context_line":"            return {}"},{"line_number":416,"context_line":"        svc \u003d \u0027nova-compute\u0027"},{"line_number":417,"context_line":"        # secret.xml"},{"line_number":418,"context_line":"        ctxt[\u0027ceph_secret_uuid\u0027] \u003d CEPH_SECRET_UUID"},{"line_number":419,"context_line":"        # nova.conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"2d9190c1_74c6e7cb","line":416,"in_reply_to":"7863a30c_0e232e30","updated":"2023-08-07 15:15:45.000000000","message":"I\u0027m thinking on the upgrade path here. If today you have nova-compute-foo deployed (and no nova-compute), what will happen when you upgrade to this code?","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"313adea6cf834d66a5cedeadd90be140be326b28","unresolved":true,"context_lines":[{"line_number":413,"context_line":"        ctxt \u003d super(NovaComputeCephContext, self).__call__()"},{"line_number":414,"context_line":"        if not ctxt:"},{"line_number":415,"context_line":"            return {}"},{"line_number":416,"context_line":"        svc \u003d \u0027nova-compute\u0027"},{"line_number":417,"context_line":"        # secret.xml"},{"line_number":418,"context_line":"        ctxt[\u0027ceph_secret_uuid\u0027] \u003d CEPH_SECRET_UUID"},{"line_number":419,"context_line":"        # nova.conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"7863a30c_0e232e30","line":416,"in_reply_to":"dc654c8a_6a712ae8","updated":"2023-08-07 15:12:44.000000000","message":"Hey Felipe. If I understood your comment correctly, it is actually the exact opposite of what you are implying. By changing it to svc \u003d \u0027nova-compute\u0027, it means that it will be handled as \u0027nova-compute\u0027 regardless of the app name, so if it is nova-compute-foo, or nova-compute-bar, both are seen as \u0027nova-compute\u0027. It does not require an app named \u0027nova-compute\u0027.","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"1b20e8853989ec22916b83874f488bc9b290a20e","unresolved":true,"context_lines":[{"line_number":413,"context_line":"        ctxt \u003d super(NovaComputeCephContext, self).__call__()"},{"line_number":414,"context_line":"        if not ctxt:"},{"line_number":415,"context_line":"            return {}"},{"line_number":416,"context_line":"        svc \u003d \u0027nova-compute\u0027"},{"line_number":417,"context_line":"        # secret.xml"},{"line_number":418,"context_line":"        ctxt[\u0027ceph_secret_uuid\u0027] \u003d CEPH_SECRET_UUID"},{"line_number":419,"context_line":"        # nova.conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"48da5807_5131e67d","line":416,"in_reply_to":"e9155699_e8b4e936","updated":"2023-08-07 16:08:48.000000000","message":"ok, I understand, thanks for the explanation. I wonder if we should consider a juju action or something to invalidate no longer needed cephx keys.","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"}],"hooks/nova_compute_hooks.py":[{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"211e2c04a8318191082dcd94b8d3e8732fb17cc9","unresolved":true,"context_lines":[{"line_number":89,"context_line":"    get_broker_rsp_key,"},{"line_number":90,"context_line":"    get_request_states,"},{"line_number":91,"context_line":"    get_previous_request,"},{"line_number":92,"context_line":"    # send_application_name,"},{"line_number":93,"context_line":")"},{"line_number":94,"context_line":"from charmhelpers.payload.execd import execd_preinstall"},{"line_number":95,"context_line":"from nova_compute_utils import ("}],"source_content_type":"text/x-python","patch_set":1,"id":"4248654a_b9560a2a","line":92,"updated":"2023-08-22 09:16:47.000000000","message":"What\u0027s the plan with regards to this? we\u0027re doing something quite specific to nova-compute here so I think having the code in this charm is fine (but these redundant commented out blocks need to be dropped).","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9f3f6a8292de030d52d1cebb20958078094e3df3","unresolved":true,"context_lines":[{"line_number":89,"context_line":"    get_broker_rsp_key,"},{"line_number":90,"context_line":"    get_request_states,"},{"line_number":91,"context_line":"    get_previous_request,"},{"line_number":92,"context_line":"    # send_application_name,"},{"line_number":93,"context_line":")"},{"line_number":94,"context_line":"from charmhelpers.payload.execd import execd_preinstall"},{"line_number":95,"context_line":"from nova_compute_utils import ("}],"source_content_type":"text/x-python","patch_set":1,"id":"5570c3f4_966733e7","line":92,"in_reply_to":"4248654a_b9560a2a","updated":"2023-08-22 11:48:30.000000000","message":"this is why the patch is WIP, so it is easier to review and test with the CI without having to propose a patch to charmhelpers to add a new param to send_application_name. The ideal fix is updating charmhelpers. This is the only reason it is commented and WIP.","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"5f249eaf1d8c5dce06e2e7bded00a520223a611e","unresolved":true,"context_lines":[{"line_number":694,"context_line":""},{"line_number":695,"context_line":"@hooks.hook(\u0027ceph-relation-broken\u0027)"},{"line_number":696,"context_line":"def ceph_broken():"},{"line_number":697,"context_line":"    delete_keyring(service\u003d\u0027nova-compute\u0027)"},{"line_number":698,"context_line":"    # cleanup old entries based on application name"},{"line_number":699,"context_line":"    delete_keyring(service\u003dservice_name())"},{"line_number":700,"context_line":"    update_all_configs()"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f0d73420_f1ce8a79","line":699,"range":{"start_line":697,"start_character":0,"end_line":699,"end_character":42},"updated":"2023-08-11 19:34:59.000000000","message":"if service_name() !\u003d \u0027nova-compute\u0027:\n   delete_keyring(service\u003dservice_name())","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9ad72c009aae360fcf0db4493a5fbedb648822e5","unresolved":true,"context_lines":[{"line_number":694,"context_line":""},{"line_number":695,"context_line":"@hooks.hook(\u0027ceph-relation-broken\u0027)"},{"line_number":696,"context_line":"def ceph_broken():"},{"line_number":697,"context_line":"    delete_keyring(service\u003d\u0027nova-compute\u0027)"},{"line_number":698,"context_line":"    # cleanup old entries based on application name"},{"line_number":699,"context_line":"    delete_keyring(service\u003dservice_name())"},{"line_number":700,"context_line":"    update_all_configs()"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1554c161_eea38d47","line":699,"range":{"start_line":697,"start_character":0,"end_line":699,"end_character":42},"in_reply_to":"f0d73420_f1ce8a79","updated":"2023-08-14 13:20:16.000000000","message":"nice optimization suggestion! I will include it in the next non-WIP patchset!","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"211e2c04a8318191082dcd94b8d3e8732fb17cc9","unresolved":true,"context_lines":[{"line_number":728,"context_line":"        relation_set("},{"line_number":729,"context_line":"            relation_id\u003dr_id,"},{"line_number":730,"context_line":"            relation_settings\u003d{\u0027application-name\u0027: \u0027nova-compute\u0027})"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"    if is_relation_made(\u0027nrpe-external-master\u0027):"},{"line_number":733,"context_line":"        update_nrpe_config()"},{"line_number":734,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4acbbbd6_1fab1669","line":731,"updated":"2023-08-22 09:16:47.000000000","message":"Rather than repeating the logic from the ceph_joined function please can you follow the pattern used for amqp_joined above where the relation_id is passed as an optional parameter.\n\nThis results in a single location where the application-name is provided and keeps this change inline with the rest of the codebase.","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9f3f6a8292de030d52d1cebb20958078094e3df3","unresolved":true,"context_lines":[{"line_number":728,"context_line":"        relation_set("},{"line_number":729,"context_line":"            relation_id\u003dr_id,"},{"line_number":730,"context_line":"            relation_settings\u003d{\u0027application-name\u0027: \u0027nova-compute\u0027})"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"    if is_relation_made(\u0027nrpe-external-master\u0027):"},{"line_number":733,"context_line":"        update_nrpe_config()"},{"line_number":734,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4b20ae47_4cfcad8c","line":731,"in_reply_to":"4acbbbd6_1fab1669","updated":"2023-08-22 11:48:30.000000000","message":"exactly, this will be simplified with the charmhelpers update","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"}],"unit_tests/test_nova_compute_hooks.py":[{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"211e2c04a8318191082dcd94b8d3e8732fb17cc9","unresolved":true,"context_lines":[{"line_number":600,"context_line":"        self.libvirt_daemon.assert_called()"},{"line_number":601,"context_line":"        # TODO(ganso): restore below line when adding back"},{"line_number":602,"context_line":"        # call to send_application_name(\u0027nova-compute\u0027)"},{"line_number":603,"context_line":"        # self.send_application_name.assert_called_once_with()"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"    @patch.object(hooks, \u0027CONFIGS\u0027)"},{"line_number":606,"context_line":"    def test_ceph_changed_missing_relation_data(self, configs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"d5015434_1ab9c371","line":603,"updated":"2023-08-22 09:16:47.000000000","message":"Obviously needs and update to assert that nova-compute is always sent as the application-name key.","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9f3f6a8292de030d52d1cebb20958078094e3df3","unresolved":true,"context_lines":[{"line_number":600,"context_line":"        self.libvirt_daemon.assert_called()"},{"line_number":601,"context_line":"        # TODO(ganso): restore below line when adding back"},{"line_number":602,"context_line":"        # call to send_application_name(\u0027nova-compute\u0027)"},{"line_number":603,"context_line":"        # self.send_application_name.assert_called_once_with()"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"    @patch.object(hooks, \u0027CONFIGS\u0027)"},{"line_number":606,"context_line":"    def test_ceph_changed_missing_relation_data(self, configs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"f29c4282_435a9641","line":603,"in_reply_to":"d5015434_1ab9c371","updated":"2023-08-22 11:48:30.000000000","message":"yes","commit_id":"b07a27bade007bda7353c07d295fd4fdc8a1aeb9"}]}