)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"cf3dd5a7c690973c6374bb7556317fae8766598f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dca98e28_abf695c2","updated":"2021-11-29 10:36:39.000000000","message":"Rebased the patch as cffi/pyparsing related errors are now merged here https://review.opendev.org/c/openstack/charm-octavia/+/787700","commit_id":"1e3563abc13cdc203a78ef909503b2365d12ecdc"},{"author":{"_account_id":20870,"name":"Alex Kavanagh","email":"alex@ajkavanagh.co.uk","username":"ajkavanagh"},"change_message_id":"ff218326b458a68512ac43ccdd497a95a8e090dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"851f436a_92f91aa2","updated":"2022-03-28 16:49:28.000000000","message":"This needs to be held until this [0] review has landed.  Thanks.\n\n0 - https://review.opendev.org/c/openstack/charm-octavia/+/826711","commit_id":"1e3563abc13cdc203a78ef909503b2365d12ecdc"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"75c28652cfa2383183eb697505bef3be9c46b92c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bd2188bd_33133eff","updated":"2022-03-28 15:24:13.000000000","message":"charm-recheck","commit_id":"1e3563abc13cdc203a78ef909503b2365d12ecdc"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6a56d37f6b7b577b44b9d1eed5a38e182333c872","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"76c29a49_5fe73027","updated":"2022-04-05 21:25:26.000000000","message":"charm recheck","commit_id":"53ae615c4546d35d7f7daab5f73e5edbd82d9e46"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"57d1894dd7d68e1ee82b4e26696f8b84911adec6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c4cac40a_b37635e7","updated":"2022-04-06 13:46:51.000000000","message":"charm-recheck","commit_id":"53ae615c4546d35d7f7daab5f73e5edbd82d9e46"},{"author":{"_account_id":8992,"name":"Billy Olsen","email":"billy.olsen@canonical.com","username":"billy-olsen"},"change_message_id":"de93a5afed4c76d32ffdb05760c33568490c3e52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d50356c4_dd34b679","updated":"2022-04-05 01:49:42.000000000","message":"charm-recheck","commit_id":"53ae615c4546d35d7f7daab5f73e5edbd82d9e46"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"5a1ff04ddaab4b26b60b5cef8b03b2cd76b7db06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"bbf28831_20ad0b98","updated":"2022-04-11 03:20:42.000000000","message":"Please see inline comment about octavia-api.conf\n\nI see func-test-pr change introduced new class VolumeBasedAmphoraTest but it is not used in tests.\nCan you update tests.yaml\n\nRest of the changes are good, so better to submit a charm-guide release notes patch as well.","commit_id":"56c4c5719998ac8cffec1d807532d2863237599d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ad1baa51d650ad8abe8e894cf443c43b5431b98c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b1f541a7_31f023cc","updated":"2022-04-12 14:32:48.000000000","message":"Hi Hemanth, I added the tests.yaml change and removed the octavia-api.conf from the ussuri folder, as the Rocky one is used.","commit_id":"124d2d6b1f1f75fb45198500b3a49c35cfa8c561"},{"author":{"_account_id":8992,"name":"Billy Olsen","email":"billy.olsen@canonical.com","username":"billy-olsen"},"change_message_id":"a99277ee3af85fe0f319177db8dcbf498d9cc326","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"416903b7_d762b67f","updated":"2022-04-18 17:51:51.000000000","message":"Patch to the test-requirements.txt is at https://review.opendev.org/c/openstack/charm-octavia/+/838331","commit_id":"124d2d6b1f1f75fb45198500b3a49c35cfa8c561"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"633c71a7b34d58f4c2d441c6ce8f03573f95cc51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"168374ee_ef257a40","updated":"2022-04-13 03:11:06.000000000","message":"Reason for CI failure:\nI think func-test-pr is not taken into consideration as the regex to parse and replace zaza/zaza-openstack in src/test-requirements did not worked. This is due to zaza, zaza-openstack pointing to gnuoy\u0027s github branch [1] rather than usual zaza/zaza-openstack github. I will discuss with gnuoy.\n\n[1] https://opendev.org/openstack/charm-octavia/src/branch/master/src/test-requirements.txt#L12\n\n","commit_id":"124d2d6b1f1f75fb45198500b3a49c35cfa8c561"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"de3e39a8debb20ebf3b7aa1162688eff16e04c51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a86ebc84_23f9821b","updated":"2022-04-26 00:42:33.000000000","message":"Rodrigo,\nPlease rebase after the following patch https://review.opendev.org/c/openstack/charm-octavia/+/838331 is merged","commit_id":"f2f05c005c3076a404b5ee80531ebefb1401b6d3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cb971e259b430b234dba25f50193c36401ba3036","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"6ce12f96_dfa55916","updated":"2022-04-28 17:59:25.000000000","message":"again no logs in the crashdump, but the error was different and unrelated to vault apparently","commit_id":"f2f05c005c3076a404b5ee80531ebefb1401b6d3"},{"author":{"_account_id":21232,"name":"josephillips","email":"jose.phillips@topmanage.com","username":"josephillips"},"change_message_id":"fbc5f90f56112735e3bbc01208a7ae1af9d9c933","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"20d40132_2fe82549","updated":"2022-07-25 18:20:28.000000000","message":"charm-recheck","commit_id":"f2f05c005c3076a404b5ee80531ebefb1401b6d3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7d7fafa3e6a420ca871ee0a8b231bc351bbbc7c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"449bede7_654beebe","updated":"2022-04-28 18:26:27.000000000","message":"charm-recheck","commit_id":"f2f05c005c3076a404b5ee80531ebefb1401b6d3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"76581f933ba88b6751e323651d6d289142cad7dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"6c949fbe_c7306d0d","updated":"2022-04-25 16:59:54.000000000","message":"charm-recheck","commit_id":"f2f05c005c3076a404b5ee80531ebefb1401b6d3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9ec0ebe915f9cc2566adc9f6c08ef81f8b28eb83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"943fbe81_4e2f9a5e","updated":"2022-04-28 13:00:29.000000000","message":"charm-recheck","commit_id":"f2f05c005c3076a404b5ee80531ebefb1401b6d3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f6d275b96da8fe0414918de578cd6182e9aa3041","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"95c1e12e_0c4fe8e0","updated":"2022-04-25 19:37:05.000000000","message":"charm-recheck","commit_id":"f2f05c005c3076a404b5ee80531ebefb1401b6d3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"fef0084f0a5782bd585407f9dc6a9181f8d6bfb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e50dfd88_59e1ad0c","updated":"2022-04-28 12:38:35.000000000","message":"charm-recheck","commit_id":"f2f05c005c3076a404b5ee80531ebefb1401b6d3"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"fae57cb3acd6ac17bf283c27548ee49f83bf1104","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"5c2f547c_07d1c6a3","updated":"2022-04-26 09:35:37.000000000","message":"charm-recheck \n\nhttps://review.opendev.org/c/openstack/charm-octavia/+/838331 is merged","commit_id":"f2f05c005c3076a404b5ee80531ebefb1401b6d3"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"d758b1b98588bdd760ea254614a26145eaa8a300","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"6c1a20a7_34530372","updated":"2022-04-27 02:50:15.000000000","message":"nicknjihian/rodrigo\n\nI think CI failed because the func-test PR patch is 142 commits behind openstack-charmers/zaza-openstack-tests:master. \nCan you rebase the func-test PR and ensure all checks are passed and review comments are handled.\nAnd then charm-recheck here.\n\nThanks!","commit_id":"f2f05c005c3076a404b5ee80531ebefb1401b6d3"},{"author":{"_account_id":21232,"name":"josephillips","email":"jose.phillips@topmanage.com","username":"josephillips"},"change_message_id":"4829243581a40cc789868a3c820f7139897b08dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"01190cf8_5953ac72","updated":"2022-07-25 18:19:09.000000000","message":"recheck\n\u003e Patch Set 12:\n\u003e \n\u003e Build FAILURE by Canonical OpenStack Charm CI.\n\u003e \n\u003e Re-test comment options:\n\u003e \n\u003e - \u0027recheck\u0027 (run/re-run the default upstream and charm test sets)\n\u003e - \u0027charm-recheck\u0027 (run/re-run the default charm verify test set) with Jenkins and Zuul\n\u003e - \u0027zosci-recheck\u0027 (run/re-run the default charm verify test set) with only Zuul\n\u003e \n\u003e For more info, see http://docs.openstack.org/developer/charm-guide/ and https://wiki.openstack.org/wiki/ThirdPartySystems/Canonical_Charm_CI.\n\u003e \n\u003e \n\u003e - charm-build https://openstack-ci-reports.ubuntu.com/artifacts/215/810567/12/check/charm-build/21536cf/ : SUCCESS in 35m 52s\n\u003e - osci-lint https://openstack-ci-reports.ubuntu.com/artifacts/1eb/810567/12/check/osci-lint/1ebcb83/ : SUCCESS in 7m 14s\n\u003e - tox-py38 https://openstack-ci-reports.ubuntu.com/artifacts/82d/810567/12/check/tox-py38/82d42df/ : SUCCESS in 6m 30s\n\u003e - focal-xena-ha https://openstack-ci-reports.ubuntu.com/artifacts/c62/810567/12/check/focal-xena-ha/c62fb50/ : FAILURE in 2h 07m 22s\n\u003e - focal-xena-ha-ovn focal-xena-ha-ovn : SKIPPED\n\u003e - focal-yoga-ha focal-yoga-ha : SKIPPED (non-voting)\n\u003e - focal-yoga-ha-ovn focal-yoga-ha-ovn : SKIPPED (non-voting)\n\u003e - jammy-yoga-ha jammy-yoga-ha : SKIPPED (non-voting)\n\u003e - jammy-yoga-ha-ovn jammy-yoga-ha-ovn : SKIPPED (non-voting)\n\n","commit_id":"f2f05c005c3076a404b5ee80531ebefb1401b6d3"},{"author":{"_account_id":21232,"name":"josephillips","email":"jose.phillips@topmanage.com","username":"josephillips"},"change_message_id":"a8889c8df3890fda39c903b6883c7d1571e0d179","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"430253e3_160b7dba","in_reply_to":"20d40132_2fe82549","updated":"2022-10-13 07:00:53.000000000","message":"Done","commit_id":"f2f05c005c3076a404b5ee80531ebefb1401b6d3"},{"author":{"_account_id":33856,"name":"Nicholas Njihia","display_name":"nicknjihian","email":"nicholas.njihia@canonical.com","username":"nicknjihian"},"change_message_id":"e29a7aa5acbc73b9d07afe3202a55eba0a473108","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"13888b17_b150517c","in_reply_to":"6c1a20a7_34530372","updated":"2022-04-27 23:24:47.000000000","message":"I\u0027ve rebased the zaza-openstack-tests PR as requested Hemanth. I\u0027ll get it reviewed as well.","commit_id":"f2f05c005c3076a404b5ee80531ebefb1401b6d3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5a7f6dc6fb5d2e51892200244b2140fca7af0cbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"35779532_ef138ef8","in_reply_to":"a86ebc84_23f9821b","updated":"2022-04-26 13:11:06.000000000","message":"Hi Hemanth, it already is. Check the parent on this patch.","commit_id":"f2f05c005c3076a404b5ee80531ebefb1401b6d3"},{"author":{"_account_id":20870,"name":"Alex Kavanagh","email":"alex@ajkavanagh.co.uk","username":"ajkavanagh"},"change_message_id":"14adcba908e9e1091541588a41f377fed43ea97f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"da9774c1_95e453b4","updated":"2022-07-28 15:44:25.000000000","message":"Turns out it\u0027s a warning from this code: https://github.com/juju/charm-tools/pull/616\n\nI\u0027ll put a PR up and change it from a warning to info which doesn\u0027t trigger the error.","commit_id":"d21bcf09616ea3552e72462515b3dab0d7d48ed6"},{"author":{"_account_id":20870,"name":"Alex Kavanagh","email":"alex@ajkavanagh.co.uk","username":"ajkavanagh"},"change_message_id":"e67f2b4aefa72770f3ffe0f4cf95a8a67f74d2a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"14c1d4df_603bfc40","updated":"2022-07-28 15:09:23.000000000","message":"Yup, manual build results in the same thing, so it\u0027s not a launchpad issue.","commit_id":"d21bcf09616ea3552e72462515b3dab0d7d48ed6"},{"author":{"_account_id":21232,"name":"josephillips","email":"jose.phillips@topmanage.com","username":"josephillips"},"change_message_id":"66874dd66afdba0d77d350a09e2e4a9a009eaa64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"177f2738_bbd6fb3b","updated":"2022-09-06 03:07:27.000000000","message":"charm-recheck","commit_id":"d21bcf09616ea3552e72462515b3dab0d7d48ed6"},{"author":{"_account_id":21232,"name":"josephillips","email":"jose.phillips@topmanage.com","username":"josephillips"},"change_message_id":"808e24894ce2bc149e801264ea0daa89d3239456","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ce7b89c9_856c0d6a","updated":"2022-08-09 00:48:15.000000000","message":"charm-recheck","commit_id":"d21bcf09616ea3552e72462515b3dab0d7d48ed6"},{"author":{"_account_id":21232,"name":"josephillips","email":"jose.phillips@topmanage.com","username":"josephillips"},"change_message_id":"5ffad69f41912379a34db6131ec78ccab6185573","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"fb845b87_f6568993","updated":"2022-08-05 17:51:43.000000000","message":"charm-recheck","commit_id":"d21bcf09616ea3552e72462515b3dab0d7d48ed6"},{"author":{"_account_id":20870,"name":"Alex Kavanagh","email":"alex@ajkavanagh.co.uk","username":"ajkavanagh"},"change_message_id":"ac3ac17709e70fc0dbc1a3bfccff5f3c58abf1b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"92c72b7e_5085f15d","updated":"2022-07-28 15:50:43.000000000","message":"https://github.com/juju/charm-tools/pull/618 \u003c- fixes the build problem; can do a charm recheck when the patch lands.","commit_id":"d21bcf09616ea3552e72462515b3dab0d7d48ed6"},{"author":{"_account_id":21232,"name":"josephillips","email":"jose.phillips@topmanage.com","username":"josephillips"},"change_message_id":"b676f1871362b020cce9e6c94e75e4ca285a449f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"15f8945a_665158c7","updated":"2022-07-28 04:11:08.000000000","message":"looks like something is broken on charmcraft","commit_id":"d21bcf09616ea3552e72462515b3dab0d7d48ed6"},{"author":{"_account_id":21232,"name":"josephillips","email":"jose.phillips@topmanage.com","username":"josephillips"},"change_message_id":"a8889c8df3890fda39c903b6883c7d1571e0d179","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"dc7c6c12_b7cbc14b","in_reply_to":"15f8945a_665158c7","updated":"2022-10-13 07:00:53.000000000","message":"Done","commit_id":"d21bcf09616ea3552e72462515b3dab0d7d48ed6"},{"author":{"_account_id":21232,"name":"josephillips","email":"jose.phillips@topmanage.com","username":"josephillips"},"change_message_id":"a8889c8df3890fda39c903b6883c7d1571e0d179","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"2ad3ce9e_56496426","updated":"2022-10-13 07:00:53.000000000","message":"charm-recheck","commit_id":"c34360d6340b683f1242280a0456ce1f2125754c"},{"author":{"_account_id":8108,"name":"Nobuto Murata","email":"nobuto.murata@canonical.com","username":"nobuto-m"},"change_message_id":"6f61839ab65140652512c60e719dd9daba8d28d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"978b25a5_3d58bbb0","updated":"2023-01-31 01:34:13.000000000","message":"I\u0027ve rebased this on the origin/master just to see the current status. But tbh, this needs a face list on both the patchset and rebasing the fuctional tests.","commit_id":"c9029453e58603f5b0d0184cfaa68a656adc3eb0"},{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"f6e230fc068b39a297a40771396b9d207c3c49d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7f0a14c3_b6c87d03","updated":"2023-12-07 17:26:20.000000000","message":"I need to look into the CI failure.","commit_id":"2d44b56df81ae930171bbf7184043b40f1cc6dae"},{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"a146194bd6722975e99981834b586e99c63d92eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"a68c450f_4e944fc8","updated":"2023-12-06 13:55:39.000000000","message":"charm-recheck\n\nhttps://github.com/openstack-charmers/zaza-openstack-tests/compare/0dc90ac53eb319bb3287702ecefbeb08140096e7..d434fc9cf511fbfe502f4ad354e71707ba8bf0c8","commit_id":"2d44b56df81ae930171bbf7184043b40f1cc6dae"},{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"73f544bcf8457ca06026873661a11e9e10b44339","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7be4a6a3_a5e34e70","updated":"2023-12-07 13:09:58.000000000","message":"charm-recheck\n\nhttps://github.com/openstack-charmers/zaza-openstack-tests/compare/d434fc9cf511fbfe502f4ad354e71707ba8bf0c8..c70ac579599ce91eebfe8f1ecc9401424ab8bf8f","commit_id":"2d44b56df81ae930171bbf7184043b40f1cc6dae"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"a379ed4f784225d79edd235aa939a77f44718802","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"55599977_27c85818","updated":"2024-08-07 16:11:47.000000000","message":"I have updated the functional (zaza) test to hopefully work better so running again.","commit_id":"8259da28b3da738a61474c2b5f715f86a09adb0c"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"cb2ff4db62db1e88f253144233ee2df6ffa26025","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"bbe898fa_7bd43920","updated":"2024-08-06 10:15:24.000000000","message":"Seems that zaza.openstack.charm_tests.octavia.tests.VolumeBasedAmphoraTest is repeatedly failing and because it hasn\u0027t attached any volumes. Needs investigation.","commit_id":"8259da28b3da738a61474c2b5f715f86a09adb0c"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"b2cbde20f36393243502922e013ebb67dd385fb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"121e7a52_51ad1fcd","updated":"2024-08-08 12:21:25.000000000","message":"charm-recheck","commit_id":"8259da28b3da738a61474c2b5f715f86a09adb0c"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"bcadd339b8b6af30b9871e6bea51add6fb93d197","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"21f32f98_4224f1b0","updated":"2024-08-05 15:37:48.000000000","message":"charm-recheck","commit_id":"8259da28b3da738a61474c2b5f715f86a09adb0c"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"2884ad09a9787f30d6fe88640c2a7e9195ba2a28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"d9632f4d_ab58d445","updated":"2024-08-07 16:12:40.000000000","message":"charm-recheck","commit_id":"8259da28b3da738a61474c2b5f715f86a09adb0c"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"460514ea2bc2bc925c34ce7476189c48334ccd6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"e99daeb3_251b7c0d","updated":"2024-08-09 10:21:37.000000000","message":"charm-recheck","commit_id":"8259da28b3da738a61474c2b5f715f86a09adb0c"},{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"06492b377b5fc00e34bd69c9cc1143e7cba2b32c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"9a13ca17_66753b9b","updated":"2024-07-31 15:08:52.000000000","message":"charm-recheck\n\n\n```\n2024-07-30 18:49:35.104594 | focal-medium | zaza.model.MachineError: Machines 11 in error state\n```\n\nundercloud issue","commit_id":"8259da28b3da738a61474c2b5f715f86a09adb0c"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"a94bc29041c021b11502e6d0d1eadf34827ded1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"70d7d08a_41eb5425","updated":"2024-08-15 16:40:38.000000000","message":"charm-recheck","commit_id":"2b84ce08bcefe751d4ac35c499c86b960b0ebcbb"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"aaff426c62cb172461a4c8098d27585688a2e849","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"8694130e_e74ed586","updated":"2024-08-13 22:01:36.000000000","message":"charm-recheck","commit_id":"2b84ce08bcefe751d4ac35c499c86b960b0ebcbb"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"4003863bc5be1207df5b0767cc7504aa9fa4209e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"9e945fcf_1cfa3636","updated":"2024-08-14 10:27:37.000000000","message":"charm-recheck","commit_id":"2b84ce08bcefe751d4ac35c499c86b960b0ebcbb"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"9a967fd7e2b1436dd527ad67f5d171ed8c610caf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"a2186056_93376f1b","updated":"2024-08-14 19:52:42.000000000","message":"charm-recheck","commit_id":"2b84ce08bcefe751d4ac35c499c86b960b0ebcbb"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"84fba1c426b681032cb86b0406fddf33c369cd76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"ac18fd56_3bddafb6","updated":"2024-08-16 19:32:37.000000000","message":"charm-recheck","commit_id":"2b84ce08bcefe751d4ac35c499c86b960b0ebcbb"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"3480df8a66d41086840906402786c4fd378dd145","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"f8d7d9bb_684161e7","updated":"2024-08-15 12:31:16.000000000","message":"charm-recheck","commit_id":"2b84ce08bcefe751d4ac35c499c86b960b0ebcbb"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"aefba36c9dea4a477b7c3bb8badc2c475b3793ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"8f6cb25d_bdad78d8","updated":"2024-10-16 15:24:58.000000000","message":"All the backports are merged and tests passing so I\u0027d like to proceed with landing this now. Any remaining functest issues will be fixed with a followup patch.","commit_id":"a4711f55d757c8bcbe22079e09880254c961f213"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"22300f45991df5dc1f8733c99f91ce87ef493254","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"8fcaf54b_b099a938","updated":"2024-09-19 12:52:34.000000000","message":"Initial patch will now target stable/2024.1 since master branch is not ready for running functional tests. It will however be kept up-to-date so that when the tests are ready they can be run.","commit_id":"a4711f55d757c8bcbe22079e09880254c961f213"}],"src/config.yaml":[{"author":{"_account_id":8108,"name":"Nobuto Murata","email":"nobuto.murata@canonical.com","username":"nobuto-m"},"change_message_id":"167b1316b5ccacd5873ebff7af273fd2e72aa3ab","unresolved":true,"context_lines":[{"line_number":201,"context_line":"      Type of volume for amphora volume root disk. Applies only when"},{"line_number":202,"context_line":"      enable-volume-based-amphora is True.If this isn\u0027t specified,"},{"line_number":203,"context_line":"      the default_volume_type from cinder.conf will be used."},{"line_number":204,"context_line":"  volume-create-retry-interval:"},{"line_number":205,"context_line":"    default: 5"},{"line_number":206,"context_line":"    type: int"},{"line_number":207,"context_line":"    description: |"},{"line_number":208,"context_line":"      Interval time to wait, in seconds, for created volume to reach the"},{"line_number":209,"context_line":"      available state. Applies only when enable-volume-based-amphora is True."},{"line_number":210,"context_line":"  volume-create-timeout:"},{"line_number":211,"context_line":"    default: 300"},{"line_number":212,"context_line":"    type: int"},{"line_number":213,"context_line":"    description: |"},{"line_number":214,"context_line":"      Timeout, in seconds, to wait for volume creation success. Applies only"},{"line_number":215,"context_line":"      when enable-volume-based-amphora is True."},{"line_number":216,"context_line":"  volume-create-max-retries:"},{"line_number":217,"context_line":"    default: 5"},{"line_number":218,"context_line":"    type: int"},{"line_number":219,"context_line":"    description: |"},{"line_number":220,"context_line":"      Maximum number of retries to create a volume. Applies only when"},{"line_number":221,"context_line":"      enable-volume-based-amphora is True."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"616bab59_d2f12672","line":221,"range":{"start_line":204,"start_character":0,"end_line":221,"end_character":42},"updated":"2021-09-23 09:47:21.000000000","message":"Do we have to expose those as charm configs? If the timeout as 300 seconds is from the upstream, then it\u0027s a fair number to say a hard failure. I don\u0027t feel it should be configurable at this stage?","commit_id":"b6c5b8bcdf9b54be07ec4238602b49d79c1e511e"},{"author":{"_account_id":33856,"name":"Nicholas Njihia","display_name":"nicknjihian","email":"nicholas.njihia@canonical.com","username":"nicknjihian"},"change_message_id":"3fdf764970ea5e110ad3e17f82f9dc00edd5cb67","unresolved":true,"context_lines":[{"line_number":201,"context_line":"      Type of volume for amphora volume root disk. Applies only when"},{"line_number":202,"context_line":"      enable-volume-based-amphora is True.If this isn\u0027t specified,"},{"line_number":203,"context_line":"      the default_volume_type from cinder.conf will be used."},{"line_number":204,"context_line":"  volume-create-retry-interval:"},{"line_number":205,"context_line":"    default: 5"},{"line_number":206,"context_line":"    type: int"},{"line_number":207,"context_line":"    description: |"},{"line_number":208,"context_line":"      Interval time to wait, in seconds, for created volume to reach the"},{"line_number":209,"context_line":"      available state. Applies only when enable-volume-based-amphora is True."},{"line_number":210,"context_line":"  volume-create-timeout:"},{"line_number":211,"context_line":"    default: 300"},{"line_number":212,"context_line":"    type: int"},{"line_number":213,"context_line":"    description: |"},{"line_number":214,"context_line":"      Timeout, in seconds, to wait for volume creation success. Applies only"},{"line_number":215,"context_line":"      when enable-volume-based-amphora is True."},{"line_number":216,"context_line":"  volume-create-max-retries:"},{"line_number":217,"context_line":"    default: 5"},{"line_number":218,"context_line":"    type: int"},{"line_number":219,"context_line":"    description: |"},{"line_number":220,"context_line":"      Maximum number of retries to create a volume. Applies only when"},{"line_number":221,"context_line":"      enable-volume-based-amphora is True."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f82cc234_130041d2","line":221,"range":{"start_line":204,"start_character":0,"end_line":221,"end_character":42},"in_reply_to":"616bab59_d2f12672","updated":"2021-09-23 11:32:39.000000000","message":"That does make quite a lot of sense to leave them as their defaults and thinking about it now, they (the defaults) do suffice.","commit_id":"b6c5b8bcdf9b54be07ec4238602b49d79c1e511e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"921736da0ada0258afa6200fb6553638b7bd6d44","unresolved":true,"context_lines":[{"line_number":236,"context_line":"    type: string"},{"line_number":237,"context_line":"    description: |"},{"line_number":238,"context_line":"      Type of volume for amphora volume root disk. Applies only when"},{"line_number":239,"context_line":"      enable-volume-based-amphora is True.If this isn\u0027t specified,"},{"line_number":240,"context_line":"      the default_volume_type from cinder.conf will be used."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"0b968735_58ef3fa1","line":239,"range":{"start_line":239,"start_character":37,"end_line":239,"end_character":44},"updated":"2024-08-05 15:42:45.000000000","message":"nit: missing space after period here","commit_id":"8259da28b3da738a61474c2b5f715f86a09adb0c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"921736da0ada0258afa6200fb6553638b7bd6d44","unresolved":true,"context_lines":[{"line_number":236,"context_line":"    type: string"},{"line_number":237,"context_line":"    description: |"},{"line_number":238,"context_line":"      Type of volume for amphora volume root disk. Applies only when"},{"line_number":239,"context_line":"      enable-volume-based-amphora is True.If this isn\u0027t specified,"},{"line_number":240,"context_line":"      the default_volume_type from cinder.conf will be used."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"6475d09f_4402125a","line":239,"range":{"start_line":239,"start_character":50,"end_line":239,"end_character":55},"updated":"2024-08-05 15:42:45.000000000","message":"super nit: I would use \u0027is not\u0027 and not abbreviate","commit_id":"8259da28b3da738a61474c2b5f715f86a09adb0c"}],"src/templates/ussuri/octavia-api.conf":[{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"5a1ff04ddaab4b26b60b5cef8b03b2cd76b7db06","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Listen {{ options.service_listen_info.octavia_api.public_port }}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# workaround problem with Python Cryptography and libssl1.0.0 by adding"},{"line_number":4,"context_line":"# WSGIApplicationGroup %{GLOBAL}"},{"line_number":5,"context_line":"# See https://cryptography.io/en/latest/faq/#starting-cryptography-using-mod-wsgi-produces-an-internalerror-during-a-call-in-register-osrandom-engine"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003cVirtualHost *:{{ options.service_listen_info.octavia_api.public_port }}\u003e"},{"line_number":8,"context_line":"    WSGIDaemonProcess octavia-api processes\u003d{{ options.wsgi_worker_context.processes }} threads\u003d1 user\u003doctavia group\u003doctavia display-name\u003d%{GROUP}"},{"line_number":9,"context_line":"    WSGIProcessGroup octavia-api"},{"line_number":10,"context_line":"    WSGIApplicationGroup %{GLOBAL}"},{"line_number":11,"context_line":"    WSGIScriptAlias / /usr/bin/octavia-wsgi"},{"line_number":12,"context_line":"    \u003cDirectory /usr/bin\u003e"},{"line_number":13,"context_line":"        \u003cFiles octavia-wsgi\u003e"},{"line_number":14,"context_line":"            Require all granted"},{"line_number":15,"context_line":"        \u003c/Files\u003e"},{"line_number":16,"context_line":"    \u003c/Directory\u003e"},{"line_number":17,"context_line":"    ErrorLog /var/log/apache2/octavia_error.log"},{"line_number":18,"context_line":"    CustomLog /var/log/apache2/octavia_access.log combined"},{"line_number":19,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/plain","patch_set":10,"id":"17e2c6d1_e2a18bd5","line":19,"range":{"start_line":1,"start_character":0,"end_line":19,"end_character":14},"updated":"2022-04-11 03:20:42.000000000","message":"Can you add in the commit message about these changes as well.","commit_id":"56c4c5719998ac8cffec1d807532d2863237599d"}]}