)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"11ecdad742a703a9847e73357f0db902bb0c0ba6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b4c61c4d_d437e49e","updated":"2024-02-02 09:56:40.000000000","message":"@Fronde Do you mind checking this and giving your thoughts ?","commit_id":"81fc941f63049023c96f24750c11467296047451"},{"author":{"_account_id":20870,"name":"Alex Kavanagh","email":"alex@ajkavanagh.co.uk","username":"ajkavanagh"},"change_message_id":"bdadab51265563f52cff0677a4a6e594fa2f0a55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"49542bcd_6a02059a","updated":"2024-05-03 17:42:44.000000000","message":"LGTM","commit_id":"81fc941f63049023c96f24750c11467296047451"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"9f277fec7ef9e436f9ce855de44202de2c77d01a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0e74bd0b_26f38061","updated":"2024-04-04 15:03:03.000000000","message":"LGTM, thanks!","commit_id":"81fc941f63049023c96f24750c11467296047451"}],"src/lib/charm/openstack/api_crud.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"57e7cb2b602a7ed93bf6989a8d9ee5392f060e8d","unresolved":true,"context_lines":[{"line_number":364,"context_line":"            # because the current logic heavily depends on neutron\u0027s internal"},{"line_number":365,"context_line":"            # behavior."},{"line_number":366,"context_line":"            \u0027device_owner\u0027: ("},{"line_number":367,"context_line":"                neutron_lib.services.trunk.constants.TRUNK_SUBPORT_OWNER),"},{"line_number":368,"context_line":"            \u0027security_groups\u0027: ["},{"line_number":369,"context_line":"                health_secgrp[\u0027id\u0027],"},{"line_number":370,"context_line":"            ],"}],"source_content_type":"text/x-python","patch_set":1,"id":"430416c9_ee4e0787","line":367,"updated":"2023-12-04 14:46:09.000000000","message":"The original code was already a hack, I don\u0027t think we should propagate it further if possible. I was going to reach out to Frode about the below bug that added the original code here to see if we can now maybe just remove all of this instead.\n\nhttps://bugs.launchpad.net/charm-octavia/+bug/1845303","commit_id":"81fc941f63049023c96f24750c11467296047451"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"10caca465ea6858f4fd45b528074290440651d02","unresolved":true,"context_lines":[{"line_number":364,"context_line":"            # because the current logic heavily depends on neutron\u0027s internal"},{"line_number":365,"context_line":"            # behavior."},{"line_number":366,"context_line":"            \u0027device_owner\u0027: ("},{"line_number":367,"context_line":"                neutron_lib.services.trunk.constants.TRUNK_SUBPORT_OWNER),"},{"line_number":368,"context_line":"            \u0027security_groups\u0027: ["},{"line_number":369,"context_line":"                health_secgrp[\u0027id\u0027],"},{"line_number":370,"context_line":"            ],"}],"source_content_type":"text/x-python","patch_set":1,"id":"78212565_a5ae24cc","line":367,"in_reply_to":"216577d7_9171ac5a","updated":"2024-04-04 19:47:20.000000000","message":"Do you mean the Canonical CI test? I couldn\u0027t tell if it was due to the patch, but this one has passed.","commit_id":"81fc941f63049023c96f24750c11467296047451"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"9f277fec7ef9e436f9ce855de44202de2c77d01a","unresolved":true,"context_lines":[{"line_number":364,"context_line":"            # because the current logic heavily depends on neutron\u0027s internal"},{"line_number":365,"context_line":"            # behavior."},{"line_number":366,"context_line":"            \u0027device_owner\u0027: ("},{"line_number":367,"context_line":"                neutron_lib.services.trunk.constants.TRUNK_SUBPORT_OWNER),"},{"line_number":368,"context_line":"            \u0027security_groups\u0027: ["},{"line_number":369,"context_line":"                health_secgrp[\u0027id\u0027],"},{"line_number":370,"context_line":"            ],"}],"source_content_type":"text/x-python","patch_set":1,"id":"216577d7_9171ac5a","line":367,"in_reply_to":"227634f5_d79dc5e9","updated":"2024-04-04 15:03:03.000000000","message":"Great, thank you for that insight, Brian.\n\nGiven the test appears to fail for the alternative approach in https://review.opendev.org/c/openstack/charm-octavia/+/909319, I guess we should continue with this one instead then?","commit_id":"81fc941f63049023c96f24750c11467296047451"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2176a1b034728b5bb101643af73afe1f9523da2d","unresolved":true,"context_lines":[{"line_number":364,"context_line":"            # because the current logic heavily depends on neutron\u0027s internal"},{"line_number":365,"context_line":"            # behavior."},{"line_number":366,"context_line":"            \u0027device_owner\u0027: ("},{"line_number":367,"context_line":"                neutron_lib.services.trunk.constants.TRUNK_SUBPORT_OWNER),"},{"line_number":368,"context_line":"            \u0027security_groups\u0027: ["},{"line_number":369,"context_line":"                health_secgrp[\u0027id\u0027],"},{"line_number":370,"context_line":"            ],"}],"source_content_type":"text/x-python","patch_set":1,"id":"faf7f3b3_79478fa2","line":367,"in_reply_to":"430416c9_ee4e0787","updated":"2023-12-04 14:47:57.000000000","message":"Ah, that\u0027s very good to know. I agree this is a hack and replacing it by another hack is not ideal. If we can remove this completely then that\u0027s the best approach.","commit_id":"81fc941f63049023c96f24750c11467296047451"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0e410e12f9e7ecbbdb436495c989c24aeeb542e3","unresolved":true,"context_lines":[{"line_number":364,"context_line":"            # because the current logic heavily depends on neutron\u0027s internal"},{"line_number":365,"context_line":"            # behavior."},{"line_number":366,"context_line":"            \u0027device_owner\u0027: ("},{"line_number":367,"context_line":"                neutron_lib.services.trunk.constants.TRUNK_SUBPORT_OWNER),"},{"line_number":368,"context_line":"            \u0027security_groups\u0027: ["},{"line_number":369,"context_line":"                health_secgrp[\u0027id\u0027],"},{"line_number":370,"context_line":"            ],"}],"source_content_type":"text/x-python","patch_set":1,"id":"227634f5_d79dc5e9","line":367,"in_reply_to":"c330066f_a10ab433","updated":"2024-02-22 16:19:44.000000000","message":"Actually, TRUNK_SUBPORT_OWNER is the only device_owner left in the \"special\" list checked via the is_dvr_serviced() call, so could be used in its place.","commit_id":"81fc941f63049023c96f24750c11467296047451"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"518c8b9c1f51d8328869d5c10546c600473cace0","unresolved":true,"context_lines":[{"line_number":364,"context_line":"            # because the current logic heavily depends on neutron\u0027s internal"},{"line_number":365,"context_line":"            # behavior."},{"line_number":366,"context_line":"            \u0027device_owner\u0027: ("},{"line_number":367,"context_line":"                neutron_lib.services.trunk.constants.TRUNK_SUBPORT_OWNER),"},{"line_number":368,"context_line":"            \u0027security_groups\u0027: ["},{"line_number":369,"context_line":"                health_secgrp[\u0027id\u0027],"},{"line_number":370,"context_line":"            ],"}],"source_content_type":"text/x-python","patch_set":1,"id":"c330066f_a10ab433","line":367,"in_reply_to":"e049d67a_7347a765","updated":"2024-02-22 15:30:14.000000000","message":"Frode - I think for now we can just merge this other patch, I don\u0027t think it will break anything:\n\nhttps://review.opendev.org/c/openstack/charm-octavia/+/909319","commit_id":"81fc941f63049023c96f24750c11467296047451"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"aefd75c32ffc8e3a1268d0a170e345500954e0a3","unresolved":true,"context_lines":[{"line_number":364,"context_line":"            # because the current logic heavily depends on neutron\u0027s internal"},{"line_number":365,"context_line":"            # behavior."},{"line_number":366,"context_line":"            \u0027device_owner\u0027: ("},{"line_number":367,"context_line":"                neutron_lib.services.trunk.constants.TRUNK_SUBPORT_OWNER),"},{"line_number":368,"context_line":"            \u0027security_groups\u0027: ["},{"line_number":369,"context_line":"                health_secgrp[\u0027id\u0027],"},{"line_number":370,"context_line":"            ],"}],"source_content_type":"text/x-python","patch_set":1,"id":"e049d67a_7347a765","line":367,"in_reply_to":"faf7f3b3_79478fa2","updated":"2024-02-22 06:53:10.000000000","message":"While the code was moved around in https://review.opendev.org/c/openstack/charm-octavia/+/685942 referred to in bug 1845303, it has been there since the initial implementation.\n\nThe port is created to provide a endpoint inside the load balancer admin network so that the Octavia daemons can speak privately with its amphorae.\n\nAny other suggestions for value of `device_owner` for such a port?","commit_id":"81fc941f63049023c96f24750c11467296047451"}]}