)]}'
{"id":"openstack%2Fcharm-openstack-dashboard~774305","triplet_id":"openstack%2Fcharm-openstack-dashboard~master~Idfd8654732289481806aea8b47ffa28cf3f97697","project":"openstack/charm-openstack-dashboard","branch":"master","topic":"bug/1883196","hashtags":[],"change_id":"Idfd8654732289481806aea8b47ffa28cf3f97697","subject":"Add ENFORCE_PASSWORD_CHECK setting","status":"MERGED","created":"2021-02-05 20:36:02.000000000","updated":"2021-02-12 17:13:40.000000000","submitted":"2021-02-12 17:13:40.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":10,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"774305-bug/1883196","meta_rev_id":"0348a25bc34b79cab64c2aa6ba6198e2dd89aea4","_number":774305,"virtual_id_number":774305,"owner":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"recommended":{"_account_id":20648,"name":"Canonical CI","email":"uosci-testing-bot@ubuntu.com","username":"uosci-testing-bot","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},{"value":1,"date":"2021-02-12 01:25:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":20648,"name":"Canonical CI","email":"uosci-testing-bot@ubuntu.com","username":"uosci-testing-bot","tags":["SERVICE_USER"]},{"value":0,"_account_id":20634,"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","username":"Chris.MacNaughton"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-02-12 17:13:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},"all":[{"value":2,"date":"2021-02-12 17:03:16.000000000","_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},{"value":0,"_account_id":20648,"name":"Canonical CI","email":"uosci-testing-bot@ubuntu.com","username":"uosci-testing-bot","tags":["SERVICE_USER"]},{"value":2,"date":"2021-02-12 15:01:43.000000000","_account_id":20634,"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","username":"Chris.MacNaughton"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},"all":[{"value":1,"date":"2021-02-12 17:03:16.000000000","_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},{"value":0,"_account_id":20648,"name":"Canonical CI","email":"uosci-testing-bot@ubuntu.com","username":"uosci-testing-bot","tags":["SERVICE_USER"]},{"value":0,"_account_id":20634,"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","username":"Chris.MacNaughton"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},{"value":0,"_account_id":20648,"name":"Canonical CI","email":"uosci-testing-bot@ubuntu.com","username":"uosci-testing-bot","tags":["SERVICE_USER"]},{"value":0,"_account_id":20634,"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","username":"Chris.MacNaughton"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},{"value":0,"_account_id":20648,"name":"Canonical CI","email":"uosci-testing-bot@ubuntu.com","username":"uosci-testing-bot","tags":["SERVICE_USER"]},{"value":0,"_account_id":20634,"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","username":"Chris.MacNaughton"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},{"_account_id":20634,"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","username":"Chris.MacNaughton"},{"_account_id":20648,"name":"Canonical CI","email":"uosci-testing-bot@ubuntu.com","username":"uosci-testing-bot","tags":["SERVICE_USER"]},{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-05 20:46:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-02-05 21:36:38.000000000","updated_by":{"_account_id":20648,"name":"Canonical CI","email":"uosci-testing-bot@ubuntu.com","username":"uosci-testing-bot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":20648,"name":"Canonical CI","email":"uosci-testing-bot@ubuntu.com","username":"uosci-testing-bot","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-02-08 15:36:03.000000000","updated_by":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"reviewer":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"state":"REVIEWER"},{"updated":"2021-02-08 15:36:30.000000000","updated_by":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"reviewer":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},"state":"REVIEWER"},{"updated":"2021-02-08 15:36:30.000000000","updated_by":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"reviewer":{"_account_id":20634,"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","username":"Chris.MacNaughton"},"state":"REVIEWER"}],"messages":[{"id":"13b2e5f013cb95c6a77226eab962663aa870508e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"date":"2021-02-05 20:36:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"858249d081ad7ea4d0543faf3073b9419759ae24","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-05 20:46:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f8716a92577a43ad83e17157713c6059 : SUCCESS in 4m 03s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/9b90c2e5425447408e2b52f4289d62be : SUCCESS in 4m 56s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f64af9cd46054558929bee791cc74aed : SUCCESS in 4m 15s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/ef5577f14cc74abc80aac2e4bd5bd917 : SUCCESS in 4m 43s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/526beea9fa7b493595e158b3bbe4e261 : SUCCESS in 4m 32s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8d8fab2ec63841bd9000a071ec29b12d : SUCCESS in 4m 08s","accounts_in_message":[],"_revision_number":1},{"id":"448210da54f0fb0737f98174752b80a4f159a8e4","author":{"_account_id":20648,"name":"Canonical CI","email":"uosci-testing-bot@ubuntu.com","username":"uosci-testing-bot","tags":["SERVICE_USER"]},"date":"2021-02-05 21:36:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild SUCCESS by Canonical OpenStack Charm CI.\n* test_charm_unit https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_smoke/openstack/charm-openstack-dashboard/774305/1/21565/index.html : SUCCESS\n* test_charm_func_smoke https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_smoke/openstack/charm-openstack-dashboard/774305/1/21565/index.html : SUCCESS\n* test_charm_single https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_smoke/openstack/charm-openstack-dashboard/774305/1/21565/index.html : SUCCESS\n* test_charm_lint https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_smoke/openstack/charm-openstack-dashboard/774305/1/21565/index.html : SUCCESS\n\nRe-test comment options:\n\n- \u0027recheck\u0027 (run/re-run the default upstream and charm test sets)\n- \u0027charm-recheck\u0027 (run/re-run the default charm verify test set)\n- \u0027charm-recheck-full\u0027 (run/re-run the full charm functional test set - may take hours!)\n\nFor more info, see http://docs.openstack.org/developer/charm-guide/ and https://wiki.openstack.org/wiki/ThirdPartySystems/Canonical_Charm_CI.","accounts_in_message":[],"_revision_number":1},{"id":"1b491817af4b77370a5222a785d14cad812eecf2","author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"date":"2021-02-08 15:36:03.000000000","message":"Patch Set 1: Code-Review+1\n\nThanks for this Garrett. It looks good to me. One thing is this will need a release note to describe the behavioral change (this won\u0027t land this release but next release). Also I\u0027d like thedac or icey to review because there is code in actions/security_checklist.py has \u0027def enforce_password_check\u0027 so want to ensure we\u0027re all on the same page.","accounts_in_message":[],"_revision_number":1},{"id":"6d34d359e4cc679ff5d1d87f3e1fd53864772c63","author":{"_account_id":20634,"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","username":"Chris.MacNaughton"},"date":"2021-02-08 15:45:58.000000000","message":"Patch Set 1:\n\nGiven that we\u0027re modifying the security bits, it would be great to see this test (https://github.com/openstack-charmers/zaza-openstack-tests/blob/master/zaza/openstack/charm_tests/openstack_dashboard/tests.py#L410-L419) expanded to more completely reflect what we expect to be passing and failing like we do here for nova: https://github.com/openstack-charmers/zaza-openstack-tests/blob/35840a66d6788dc4899847747ee7523895f46e1b/zaza/openstack/charm_tests/nova/tests.py#L485-L529","accounts_in_message":[],"_revision_number":1},{"id":"e3f444908aed3eb9d6dd93c678eb68d52285360c","author":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},"date":"2021-02-09 00:08:50.000000000","message":"Patch Set 1:\n\nLooks good from my perspective. I agree with Chris. Please add a security checklist test to the dashboard zaza tests.","accounts_in_message":[],"_revision_number":1},{"id":"4106764fa4883de58b8cc1cb9d7329c1a44dbf31","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"date":"2021-02-10 04:03:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"49ab192e89d9aefcfacfdc89dfd499ca9009343d","author":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"date":"2021-02-10 04:04:21.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 1: Code-Review+1\n\u003e \n\u003e Thanks for this Garrett. It looks good to me. One thing is this will need a release note to describe the behavioral change (this won\u0027t land this release but next release). Also I\u0027d like thedac or icey to review because there is code in actions/security_checklist.py has \u0027def enforce_password_check\u0027 so want to ensure we\u0027re all on the same page.\n\nThanks for reviewing this! I\u0027ll follow up with you on where to put a release note.","accounts_in_message":[],"_revision_number":2},{"id":"4df906aacffbb4c7a4f1baa1dc94b4f86912f0a0","author":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"date":"2021-02-10 04:04:56.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 1:\n\u003e \n\u003e Given that we\u0027re modifying the security bits, it would be great to see this test (https://github.com/openstack-charmers/zaza-openstack-tests/blob/master/zaza/openstack/charm_tests/openstack_dashboard/tests.py#L410-L419) expanded to more completely reflect what we expect to be passing and failing like we do here for nova: https://github.com/openstack-charmers/zaza-openstack-tests/blob/35840a66d6788dc4899847747ee7523895f46e1b/zaza/openstack/charm_tests/nova/tests.py#L485-L529\n\nThanks for the suggestion! I\u0027ve added this into the second revision.","accounts_in_message":[],"_revision_number":2},{"id":"fd1414428cd5ffec2670b8c63652983de0dd2a5b","author":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"date":"2021-02-10 04:05:16.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 1:\n\u003e \n\u003e Looks good from my perspective. I agree with Chris. Please add a security checklist test to the dashboard zaza tests.\n\nThanks for the review! I\u0027ve added this to the second revision.","accounts_in_message":[],"_revision_number":2},{"id":"3480c8dae8921c916fa029be184283fa359b0857","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-10 04:12:30.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e0370cdab9004c1a8be8b5303709b100 : SUCCESS in 5m 30s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/c8869c408d0b45eb9f8e7ac64884b896 : SUCCESS in 4m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/31a4ccec30f540f0878a333ffe03561a : SUCCESS in 3m 51s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/d31fe6aa6afa4b57964dd89e2f864c8e : SUCCESS in 4m 05s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ee5c21b0f24c45479d3b7f6bf18971bd : SUCCESS in 3m 44s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d42c1d2b8d7645f0a2000e07a265ace9 : SUCCESS in 3m 47s","accounts_in_message":[],"_revision_number":2},{"id":"ccebe1d79ee7af5ec49d07b1180997db94969189","author":{"_account_id":20648,"name":"Canonical CI","email":"uosci-testing-bot@ubuntu.com","username":"uosci-testing-bot","tags":["SERVICE_USER"]},"date":"2021-02-10 05:00:45.000000000","message":"Patch Set 2: Verified+1\n\nBuild SUCCESS by Canonical OpenStack Charm CI.\n* test_charm_unit https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_smoke/openstack/charm-openstack-dashboard/774305/2/21596/index.html : SUCCESS\n* test_charm_func_smoke https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_smoke/openstack/charm-openstack-dashboard/774305/2/21596/index.html : SUCCESS\n* test_charm_single https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_smoke/openstack/charm-openstack-dashboard/774305/2/21596/index.html : SUCCESS\n* test_charm_lint https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_smoke/openstack/charm-openstack-dashboard/774305/2/21596/index.html : SUCCESS\n\nRe-test comment options:\n\n- \u0027recheck\u0027 (run/re-run the default upstream and charm test sets)\n- \u0027charm-recheck\u0027 (run/re-run the default charm verify test set)\n- \u0027charm-recheck-full\u0027 (run/re-run the full charm functional test set - may take hours!)\n\nFor more info, see http://docs.openstack.org/developer/charm-guide/ and https://wiki.openstack.org/wiki/ThirdPartySystems/Canonical_Charm_CI.","accounts_in_message":[],"_revision_number":2},{"id":"062ecb0f2caefe992a53006cac88b6ccbbf744db","author":{"_account_id":20634,"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","username":"Chris.MacNaughton"},"date":"2021-02-10 07:36:41.000000000","message":"Patch Set 2:\n\ncharm-recheck-full","accounts_in_message":[],"_revision_number":2},{"id":"70eb994e3e8d8eb296d3bf019a97f1ad6c6469f5","author":{"_account_id":20648,"name":"Canonical CI","email":"uosci-testing-bot@ubuntu.com","username":"uosci-testing-bot","tags":["SERVICE_USER"]},"date":"2021-02-10 12:50:55.000000000","message":"Patch Set 2: Verified-1\n\nBuild FAILURE by Canonical OpenStack Charm CI.\n* test_charm_func_full https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_full/openstack/charm-openstack-dashboard/774305/2/8101/index.html : FAILURE\n* test_charm_unit https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_full/openstack/charm-openstack-dashboard/774305/2/8101/index.html : SUCCESS\n* test_charm_single https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_full/openstack/charm-openstack-dashboard/774305/2/8101/index.html : SUCCESS\n* test_charm_lint https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_full/openstack/charm-openstack-dashboard/774305/2/8101/index.html : SUCCESS\n\nRe-test comment options:\n\n- \u0027recheck\u0027 (run/re-run the default upstream and charm test sets)\n- \u0027charm-recheck\u0027 (run/re-run the default charm verify test set)\n- \u0027charm-recheck-full\u0027 (run/re-run the full charm functional test set - may take hours!)\n\nFor more info, see http://docs.openstack.org/developer/charm-guide/ and https://wiki.openstack.org/wiki/ThirdPartySystems/Canonical_Charm_CI.","accounts_in_message":[],"_revision_number":2},{"id":"4fd531023bdef425b1d50642817b7885bd3e1d67","author":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"date":"2021-02-11 00:05:51.000000000","message":"Patch Set 2:\n\ncharm-recheck-full","accounts_in_message":[],"_revision_number":2},{"id":"654945e5eb32fd61344e2bf6125baa59135056dd","author":{"_account_id":20648,"name":"Canonical CI","email":"uosci-testing-bot@ubuntu.com","username":"uosci-testing-bot","tags":["SERVICE_USER"]},"date":"2021-02-11 01:16:42.000000000","message":"Patch Set 2:\n\nBuild FAILURE by Canonical OpenStack Charm CI.\n* test_charm_func_full https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_full/openstack/charm-openstack-dashboard/774305/2/8105/index.html : FAILURE\n* test_charm_unit https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_full/openstack/charm-openstack-dashboard/774305/2/8105/index.html : SUCCESS\n* test_charm_single https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_full/openstack/charm-openstack-dashboard/774305/2/8105/index.html : SUCCESS\n* test_charm_lint https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_full/openstack/charm-openstack-dashboard/774305/2/8105/index.html : SUCCESS\n\nRe-test comment options:\n\n- \u0027recheck\u0027 (run/re-run the default upstream and charm test sets)\n- \u0027charm-recheck\u0027 (run/re-run the default charm verify test set)\n- \u0027charm-recheck-full\u0027 (run/re-run the full charm functional test set - may take hours!)\n\nFor more info, see http://docs.openstack.org/developer/charm-guide/ and https://wiki.openstack.org/wiki/ThirdPartySystems/Canonical_Charm_CI.","accounts_in_message":[],"_revision_number":2},{"id":"4965832ed8bf2ccfbcafdd7f739fd731e0ff9b89","author":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"date":"2021-02-11 14:37:05.000000000","message":"Patch Set 2:\n\ncharm-recheck-full","accounts_in_message":[],"_revision_number":2},{"id":"f662b087daec1a893343d38d1adc018efca1bd9d","author":{"_account_id":20648,"name":"Canonical CI","email":"uosci-testing-bot@ubuntu.com","username":"uosci-testing-bot","tags":["SERVICE_USER"]},"date":"2021-02-11 19:46:01.000000000","message":"Patch Set 2:\n\nBuild FAILURE by Canonical OpenStack Charm CI.\n* test_charm_func_full https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_full/openstack/charm-openstack-dashboard/774305/2/8107/index.html : FAILURE\n* test_charm_unit https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_full/openstack/charm-openstack-dashboard/774305/2/8107/index.html : SUCCESS\n* test_charm_single https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_full/openstack/charm-openstack-dashboard/774305/2/8107/index.html : SUCCESS\n* test_charm_lint https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_full/openstack/charm-openstack-dashboard/774305/2/8107/index.html : SUCCESS\n\nRe-test comment options:\n\n- \u0027recheck\u0027 (run/re-run the default upstream and charm test sets)\n- \u0027charm-recheck\u0027 (run/re-run the default charm verify test set)\n- \u0027charm-recheck-full\u0027 (run/re-run the full charm functional test set - may take hours!)\n\nFor more info, see http://docs.openstack.org/developer/charm-guide/ and https://wiki.openstack.org/wiki/ThirdPartySystems/Canonical_Charm_CI.","accounts_in_message":[],"_revision_number":2},{"id":"84aaa9519cd86f8696f9bff18ffc54052778aba5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"date":"2021-02-11 20:52:28.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"3f0ec4d3d7337567e584e1541b48bce18ec8780e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"date":"2021-02-11 21:02:43.000000000","message":"Patch Set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"5706a92bb1e40e615f6e776b6f88b72d2690a623","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-11 21:15:21.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5e6c4632abe24de8aacd09d6b8a0353f : SUCCESS in 6m 47s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/dd623d98c92a48aaa42c1a01686a1e6b : SUCCESS in 6m 44s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c1257ba382964f609ec36a5cba799001 : SUCCESS in 5m 57s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/a1ea0e0a10324cd0856767be2688c082 : SUCCESS in 4m 28s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/26d5ef244524465fa4f4847614e27e6a : SUCCESS in 4m 04s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e754ae4c44934c79a11fc1a6b160f104 : SUCCESS in 7m 27s","accounts_in_message":[],"_revision_number":4},{"id":"101e96d6a4e4e006e0d51fb5cf1b2369d3221330","author":{"_account_id":20648,"name":"Canonical CI","email":"uosci-testing-bot@ubuntu.com","username":"uosci-testing-bot","tags":["SERVICE_USER"]},"date":"2021-02-11 22:00:41.000000000","message":"Patch Set 4: Verified+1\n\nBuild SUCCESS by Canonical OpenStack Charm CI.\n* test_charm_unit https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_smoke/openstack/charm-openstack-dashboard/774305/4/21644/index.html : SUCCESS\n* test_charm_func_smoke https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_smoke/openstack/charm-openstack-dashboard/774305/4/21644/index.html : SUCCESS\n* test_charm_single https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_smoke/openstack/charm-openstack-dashboard/774305/4/21644/index.html : SUCCESS\n* test_charm_lint https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_smoke/openstack/charm-openstack-dashboard/774305/4/21644/index.html : SUCCESS\n\nRe-test comment options:\n\n- \u0027recheck\u0027 (run/re-run the default upstream and charm test sets)\n- \u0027charm-recheck\u0027 (run/re-run the default charm verify test set)\n- \u0027charm-recheck-full\u0027 (run/re-run the full charm functional test set - may take hours!)\n\nFor more info, see http://docs.openstack.org/developer/charm-guide/ and https://wiki.openstack.org/wiki/ThirdPartySystems/Canonical_Charm_CI.","accounts_in_message":[],"_revision_number":4},{"id":"464b66c1005480b453a9311f6282d56ee48692ee","author":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},"date":"2021-02-12 00:09:42.000000000","message":"Patch Set 4: Code-Review-1\n\n(5 comments)\n\nSome changes requested for the tests.yaml.\n\nThen also between patchset 2 and patchset 4 it looks like you updated tempates/queens/local_settings.py that has differences which may change the previous behavior. Let\u0027s discuss.","accounts_in_message":[],"_revision_number":4},{"id":"748f7d3cf6146b9a46fc9c7a7410bea5950d6bc0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"date":"2021-02-12 00:22:46.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"a9612aa8b41bd5abab516b1897eda536f98c7f85","author":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"date":"2021-02-12 00:23:47.000000000","message":"Patch Set 4:\n\n\u003e Patch Set 4: Code-Review-1\n\u003e \n\u003e (5 comments)\n\u003e \n\u003e Some changes requested for the tests.yaml.\n\u003e \n\u003e Then also between patchset 2 and patchset 4 it looks like you updated tempates/queens/local_settings.py that has differences which may change the previous behavior. Let\u0027s discuss.\n\nAs discussed, the local_settings file was updated to use Ocata\u0027s file as a starting point, instead of Mitaka\u0027s. These changes have been updated in the latest patchset, including the removal of the test bundles as discussed. Thanks for reviewing!","accounts_in_message":[],"_revision_number":4},{"id":"9ea9f1f9825e9aacf939f780167757d961064f3a","author":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"date":"2021-02-12 00:25:27.000000000","message":"Patch Set 5:\n\n(5 comments)","accounts_in_message":[],"_revision_number":5},{"id":"fcef236f125485e344dcdf0f24faa469c775496f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"date":"2021-02-12 00:26:36.000000000","message":"Patch Set 6: Commit message was updated.","accounts_in_message":[],"_revision_number":6},{"id":"37314f88302155fa2cb21b64cee27f567bff1561","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"date":"2021-02-12 00:27:34.000000000","message":"Patch Set 7: Commit message was updated.","accounts_in_message":[],"_revision_number":7},{"id":"32970e43f815988d93f79a6d0e578dc55df91d2a","author":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},"date":"2021-02-12 00:30:24.000000000","message":"Patch Set 7: Code-Review+1\n\nThis looks great. Thank you for the contribution. I have also +1\u0027d the func test PR. We will land both when OSCI finishes a full run.","accounts_in_message":[],"_revision_number":7},{"id":"8e15ab8b2ee3d09403c1f742bea456cda262ae03","author":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},"date":"2021-02-12 00:30:33.000000000","message":"Patch Set 7:\n\ncharm-recheck-full","accounts_in_message":[],"_revision_number":7},{"id":"70c610c693f14f74eb3610806840563c229cfdc7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-12 00:37:45.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2fb39ca2a30c4baabfa981ecd194e6e3 : SUCCESS in 6m 04s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/963c5ce3ad4546deb186ce5a481790d0 : SUCCESS in 4m 56s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/178f77e300df42b18de1a148ea151439 : SUCCESS in 4m 42s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/79e33d6f32b24d64b4e606ae6b082bac : SUCCESS in 5m 11s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0afc12274b464244a877691a40a313b0 : SUCCESS in 5m 01s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/196fae9791214f7a9bc43ecf9e9a6f24 : SUCCESS in 6m 26s","accounts_in_message":[],"_revision_number":7},{"id":"35b0f6b28269591c6d5f4df6fe11c4dc7fe22b9b","author":{"_account_id":20648,"name":"Canonical CI","email":"uosci-testing-bot@ubuntu.com","username":"uosci-testing-bot","tags":["SERVICE_USER"]},"date":"2021-02-12 01:25:12.000000000","message":"Patch Set 7: Verified+1\n\nBuild SUCCESS by Canonical OpenStack Charm CI.\n* test_charm_unit https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_smoke/openstack/charm-openstack-dashboard/774305/7/21650/index.html : SUCCESS\n* test_charm_func_smoke https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_smoke/openstack/charm-openstack-dashboard/774305/7/21650/index.html : SUCCESS\n* test_charm_single https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_smoke/openstack/charm-openstack-dashboard/774305/7/21650/index.html : SUCCESS\n* test_charm_lint https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_smoke/openstack/charm-openstack-dashboard/774305/7/21650/index.html : SUCCESS\n\nRe-test comment options:\n\n- \u0027recheck\u0027 (run/re-run the default upstream and charm test sets)\n- \u0027charm-recheck\u0027 (run/re-run the default charm verify test set)\n- \u0027charm-recheck-full\u0027 (run/re-run the full charm functional test set - may take hours!)\n\nFor more info, see http://docs.openstack.org/developer/charm-guide/ and https://wiki.openstack.org/wiki/ThirdPartySystems/Canonical_Charm_CI.","accounts_in_message":[],"_revision_number":7},{"id":"27691ca831ef71abe742fdd258fa10088ec80990","author":{"_account_id":20648,"name":"Canonical CI","email":"uosci-testing-bot@ubuntu.com","username":"uosci-testing-bot","tags":["SERVICE_USER"]},"date":"2021-02-12 04:27:37.000000000","message":"Patch Set 7:\n\nBuild SUCCESS by Canonical OpenStack Charm CI.\n* test_charm_func_full https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_full/openstack/charm-openstack-dashboard/774305/7/8109/index.html : SUCCESS\n* test_charm_unit https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_full/openstack/charm-openstack-dashboard/774305/7/8109/index.html : SUCCESS\n* test_charm_single https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_full/openstack/charm-openstack-dashboard/774305/7/8109/index.html : SUCCESS\n* test_charm_lint https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_full/openstack/charm-openstack-dashboard/774305/7/8109/index.html : SUCCESS\n\nRe-test comment options:\n\n- \u0027recheck\u0027 (run/re-run the default upstream and charm test sets)\n- \u0027charm-recheck\u0027 (run/re-run the default charm verify test set)\n- \u0027charm-recheck-full\u0027 (run/re-run the full charm functional test set - may take hours!)\n\nFor more info, see http://docs.openstack.org/developer/charm-guide/ and https://wiki.openstack.org/wiki/ThirdPartySystems/Canonical_Charm_CI.","accounts_in_message":[],"_revision_number":7},{"id":"e91c2fd9641bbf1cea5bd4699c9ac80edcc2476a","author":{"_account_id":20634,"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","username":"Chris.MacNaughton"},"date":"2021-02-12 07:45:25.000000000","message":"Patch Set 7:\n\nThis change doesn\u0027t currently resolve the issue where the security action will pass even when it has an import failure because of the removal of support for failing with exit codes","accounts_in_message":[],"_revision_number":7},{"id":"a2d6c971f8dbe746f6f61b8276258065fe5bacf1","author":{"_account_id":20634,"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","username":"Chris.MacNaughton"},"date":"2021-02-12 15:01:43.000000000","message":"Patch Set 7: Code-Review+2\n\nThe failure in the assertion audits is due to a missing check in zaza-openstack-tests. Fixing that is likely to have a higher impact, so I intend to take that and make a separate change.\n\nFor reference, the charms that are using this helper currently and will need auditing is:\n\nCinder\nCeph OSD\nNova\nKeystone\nNeutron\n\nI\u0027m giving this my CR+2, and want to let David weigh in on the plan above.","accounts_in_message":[],"_revision_number":7},{"id":"bf70777ad8f5782ecca3794204c44265c2581a73","author":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},"date":"2021-02-12 17:03:16.000000000","message":"Patch Set 7: Code-Review+2 Workflow+1\n\nI agree with Chris\u0027 assessment. We will resolve the testing bug separately. This can land.","accounts_in_message":[],"_revision_number":7},{"id":"d9c7b3e8ca279e67ac1548d2cb8e77a77dac016e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-12 17:03:31.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":7},{"id":"2870356eb5f1c7b6b3acedf1e75e54e4958be64f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-12 17:13:39.000000000","message":"Patch Set 7: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2f9741681c89469080e5d386c28bdde5 : SUCCESS in 4m 26s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/e36727a84aa247f18852e0607eaf4645 : SUCCESS in 5m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/088aa442f1fa42a3adb2f1224a0d58ca : SUCCESS in 4m 35s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/f39b2cefa67b4562866dce5e73ccc01a : SUCCESS in 5m 28s","accounts_in_message":[],"_revision_number":7},{"id":"0348a25bc34b79cab64c2aa6ba6198e2dd89aea4","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-12 17:13:40.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"8e4dc4844a0cf52b32c9bea6d9553be7d6f93906","revisions":{"2345478ecfc9f085181c8f3fdb890f7c5ce9c16e":{"kind":"REWORK","_number":1,"created":"2021-02-05 20:36:02.000000000","uploader":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"ref":"refs/changes/05/774305/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/charm-openstack-dashboard","ref":"refs/changes/05/774305/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/1"}}},"commit":{"parents":[{"commit":"87e6acf25ca8ba38020cea21eec3d355f3671bb2","subject":"Merge \"Add Groovy to the test gate\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/87e6acf25ca8ba38020cea21eec3d355f3671bb2"}]}],"author":{"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","date":"2021-02-05 20:25:18.000000000","tz":-480},"committer":{"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","date":"2021-02-05 20:36:01.000000000","tz":-480},"subject":"Add ENFORCE_PASSWORD_CHECK setting","message":"Add ENFORCE_PASSWORD_CHECK setting\n\nThis setting is a behavior change, requring the admin password\nto be provided when changing the password of an admin user. Enabling\nthis setting by default adheres to the security recommendation\nprovided in the OpenStack security guide [0].\n\nTo enable this setting for Queens (the oldest supported OpenStack release\nat the time of this commit), a new local_settings.py file was copied\nfrom the Mitaka template to ensure that any future versions will inherit\nthis setting until a new change is made.\n\n[0] https://docs.openstack.org/security-guide/dashboard/checklist.html\n\nCloses-Bug: #1883196\nChange-Id: Idfd8654732289481806aea8b47ffa28cf3f97697\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/2345478ecfc9f085181c8f3fdb890f7c5ce9c16e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/2345478ecfc9f085181c8f3fdb890f7c5ce9c16e"}]},"branch":"refs/heads/master"},"83cbed680bba0a9553f00cb03755bbe3a39e9d67":{"kind":"REWORK","_number":2,"created":"2021-02-10 04:03:26.000000000","uploader":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"ref":"refs/changes/05/774305/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/charm-openstack-dashboard","ref":"refs/changes/05/774305/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/2"}}},"commit":{"parents":[{"commit":"87e6acf25ca8ba38020cea21eec3d355f3671bb2","subject":"Merge \"Add Groovy to the test gate\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/87e6acf25ca8ba38020cea21eec3d355f3671bb2"}]}],"author":{"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","date":"2021-02-05 20:25:18.000000000","tz":-480},"committer":{"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","date":"2021-02-10 03:57:21.000000000","tz":-480},"subject":"Add ENFORCE_PASSWORD_CHECK setting","message":"Add ENFORCE_PASSWORD_CHECK setting\n\nThis setting is a behavior change, requring the admin password\nto be provided when changing the password of an admin user. Enabling\nthis setting by default adheres to the security recommendation\nprovided in the OpenStack security guide [0].\n\nTo enable this setting for Queens (the oldest supported OpenStack release\nat the time of this commit), a new local_settings.py file was copied\nfrom the Mitaka template to ensure that any future versions will inherit\nthis setting until a new change is made.\n\n[0] https://docs.openstack.org/security-guide/dashboard/checklist.html\n\nFunc-Test-PR: https://github.com/openstack-charmers/zaza-openstack-tests/pull/501\nCloses-Bug: #1883196\nChange-Id: Idfd8654732289481806aea8b47ffa28cf3f97697\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/83cbed680bba0a9553f00cb03755bbe3a39e9d67"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/83cbed680bba0a9553f00cb03755bbe3a39e9d67"}]},"branch":"refs/heads/master"},"6aeea5bf62a276021ac8e555751b28cdc8fdbba2":{"kind":"REWORK","_number":3,"created":"2021-02-11 20:52:28.000000000","uploader":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"ref":"refs/changes/05/774305/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/charm-openstack-dashboard","ref":"refs/changes/05/774305/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/3"}}},"commit":{"parents":[{"commit":"87e6acf25ca8ba38020cea21eec3d355f3671bb2","subject":"Merge \"Add Groovy to the test gate\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/87e6acf25ca8ba38020cea21eec3d355f3671bb2"}]}],"author":{"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","date":"2021-02-05 20:25:18.000000000","tz":-480},"committer":{"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","date":"2021-02-11 20:51:39.000000000","tz":-480},"subject":"Add ENFORCE_PASSWORD_CHECK setting","message":"Add ENFORCE_PASSWORD_CHECK setting\n\nThis setting is a behavior change, requring the admin password\nto be provided when changing the password of an admin user. Enabling\nthis setting by default adheres to the security recommendation\nprovided in the OpenStack security guide [0].\n\nTo enable this setting for Queens (the oldest supported OpenStack\nrelease at the time of this commit), a new local_settings.py file was\ncopied from the Ocata template to ensure that any future versions will\ninherit this setting until a new change is made.\n\nDue to the security-checklist action currently failing [1], these have been\nextracted to another class, and refactored in the zaza-openstack-tests\nrepo [2].\n\n[0] https://docs.openstack.org/security-guide/dashboard/checklist.html\n\n[1] https://github.com/openstack-charmers/zaza-openstack-tests/blob/2ef404be7563ab9a4907376c3b33719fee41679f/zaza/openstack/charm_tests/openstack_dashboard/tests.py#L418\n\n[2] https://github.com/openstack-charmers/zaza-openstack-tests/pull/501\n\nFunc-Test-PR: https: //github.com/openstack-charmers/zaza-openstack-tests/pull/501\nCloses-Bug: #1883196\nChange-Id: Idfd8654732289481806aea8b47ffa28cf3f97697\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/6aeea5bf62a276021ac8e555751b28cdc8fdbba2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/6aeea5bf62a276021ac8e555751b28cdc8fdbba2"}]},"branch":"refs/heads/master"},"40b5e06bf0c0571db9ecf806feff8358e2bc5cd8":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2021-02-11 21:02:43.000000000","uploader":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"ref":"refs/changes/05/774305/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/charm-openstack-dashboard","ref":"refs/changes/05/774305/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/4"}}},"commit":{"parents":[{"commit":"87e6acf25ca8ba38020cea21eec3d355f3671bb2","subject":"Merge \"Add Groovy to the test gate\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/87e6acf25ca8ba38020cea21eec3d355f3671bb2"}]}],"author":{"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","date":"2021-02-05 20:25:18.000000000","tz":-480},"committer":{"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","date":"2021-02-11 21:02:24.000000000","tz":0},"subject":"Add ENFORCE_PASSWORD_CHECK setting","message":"Add ENFORCE_PASSWORD_CHECK setting\n\nThis setting is a behavior change, requring the admin password\nto be provided when changing the password of an admin user. Enabling\nthis setting by default adheres to the security recommendation\nprovided in the OpenStack security guide [0].\n\nTo enable this setting for Queens (the oldest supported OpenStack\nrelease at the time of this commit), a new local_settings.py file was\ncopied from the Ocata template to ensure that any future versions will\ninherit this setting until a new change is made.\n\nDue to the security-checklist action currently failing [1], these have been\nextracted to another class, and refactored in the zaza-openstack-tests\nrepo [2].\n\n[0] https://docs.openstack.org/security-guide/dashboard/checklist.html\n\n[1] https://github.com/openstack-charmers/zaza-openstack-tests/blob/2ef404be7563ab9a4907376c3b33719fee41679f/zaza/openstack/charm_tests/openstack_dashboard/tests.py#L418\n\n[2] https://github.com/openstack-charmers/zaza-openstack-tests/pull/501\n\nFunc-Test-PR: https://github.com/openstack-charmers/zaza-openstack-tests/pull/501\nCloses-Bug: #1883196\nChange-Id: Idfd8654732289481806aea8b47ffa28cf3f97697\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/40b5e06bf0c0571db9ecf806feff8358e2bc5cd8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/40b5e06bf0c0571db9ecf806feff8358e2bc5cd8"}]},"branch":"refs/heads/master","description":"Edit commit message"},"72e4cd9109a71bb21830262feabda20a8ac29c8c":{"kind":"REWORK","_number":5,"created":"2021-02-12 00:22:46.000000000","uploader":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"ref":"refs/changes/05/774305/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/charm-openstack-dashboard","ref":"refs/changes/05/774305/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/5"}}},"commit":{"parents":[{"commit":"87e6acf25ca8ba38020cea21eec3d355f3671bb2","subject":"Merge \"Add Groovy to the test gate\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/87e6acf25ca8ba38020cea21eec3d355f3671bb2"}]}],"author":{"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","date":"2021-02-05 20:25:18.000000000","tz":-480},"committer":{"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","date":"2021-02-12 00:22:22.000000000","tz":-480},"subject":"Add ENFORCE_PASSWORD_CHECK setting","message":"Add ENFORCE_PASSWORD_CHECK setting\n\nThis setting is a behavior change, requring the admin password\nto be provided when changing the password of an admin user. Enabling\nthis setting by default adheres to the security recommendation\nprovided in the OpenStack security guide [0].\n\nTo enable this setting for Queens (the oldest supported OpenStack\nrelease at the time of this commit), a new local_settings.py file was\ncopied from the Ocata template to ensure that any future versions will\ninherit this setting until a new change is made.\n\nDue to the security-checklist action currently failing [1], these have been\nextracted to another class, and refactored in the zaza-openstack-tests\nrepo [2].\n\n[0] https://docs.openstack.org/security-guide/dashboard/checklist.html\n\n[1] https://github.com/openstack-charmers/zaza-openstack-tests/blob/2ef404be7563ab9a4907376c3b33719fee41679f/zaza/openstack/charm_tests/openstack_dashboard/tests.py#L418\n\n[2] https://github.com/openstack-charmers/zaza-openstack-tests/pull/501\n\nFunc-Test-PR: https: //github.com/openstack-charmers/zaza-openstack-tests/pull/501\nCloses-Bug: #1883196\nChange-Id: Idfd8654732289481806aea8b47ffa28cf3f97697\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/72e4cd9109a71bb21830262feabda20a8ac29c8c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/72e4cd9109a71bb21830262feabda20a8ac29c8c"}]},"branch":"refs/heads/master"},"9f5f3582b57c0e7f59d144dea4bf46aad649841d":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2021-02-12 00:26:36.000000000","uploader":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"ref":"refs/changes/05/774305/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/charm-openstack-dashboard","ref":"refs/changes/05/774305/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/6"}}},"commit":{"parents":[{"commit":"87e6acf25ca8ba38020cea21eec3d355f3671bb2","subject":"Merge \"Add Groovy to the test gate\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/87e6acf25ca8ba38020cea21eec3d355f3671bb2"}]}],"author":{"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","date":"2021-02-05 20:25:18.000000000","tz":-480},"committer":{"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","date":"2021-02-12 00:26:30.000000000","tz":0},"subject":"Add ENFORCE_PASSWORD_CHECK setting","message":"Add ENFORCE_PASSWORD_CHECK setting\n\nThis setting is a behavior change, requring the admin password\nto be provided when changing the password of an admin user. Enabling\nthis setting by default adheres to the security recommendation\nprovided in the OpenStack security guide [0].\n\nTo enable this setting for Queens (the oldest supported OpenStack\nrelease at the time of this commit), a new local_settings.py file was\ncopied from the Ocata template to ensure that any future versions will\ninherit this setting until a new change is made.\n\nDue to the security-checklist action currently failing [1], these have been\nextracted to another class, and refactored in the zaza-openstack-tests\nrepo [2].\n\n[0] https://docs.openstack.org/security-guide/dashboard/checklist.html\n\n[1] https://github.com/openstack-charmers/zaza-openstack-tests/blob/2ef404be7563ab9a4907376c3b33719fee41679f/zaza/openstack/charm_tests/openstack_dashboard/tests.py#L418\n\n[2] https://github.com/openstack-charmers/zaza-openstack-tests/pull/501\n\nFunc-Test-PR: https://github.com/openstack-charmers/zaza-openstack-tests/pull/501\nCloses-Bug: #1883196\nChange-Id: Idfd8654732289481806aea8b47ffa28cf3f97697\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/9f5f3582b57c0e7f59d144dea4bf46aad649841d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/9f5f3582b57c0e7f59d144dea4bf46aad649841d"}]},"branch":"refs/heads/master","description":"Edit commit message"},"8e4dc4844a0cf52b32c9bea6d9553be7d6f93906":{"kind":"NO_CODE_CHANGE","_number":7,"created":"2021-02-12 00:27:34.000000000","uploader":{"_account_id":32803,"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","username":"thogarre"},"ref":"refs/changes/05/774305/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/charm-openstack-dashboard","ref":"refs/changes/05/774305/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/charm-openstack-dashboard refs/changes/05/774305/7"}}},"commit":{"parents":[{"commit":"87e6acf25ca8ba38020cea21eec3d355f3671bb2","subject":"Merge \"Add Groovy to the test gate\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/87e6acf25ca8ba38020cea21eec3d355f3671bb2"}]}],"author":{"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","date":"2021-02-05 20:25:18.000000000","tz":-480},"committer":{"name":"Garrett Thompson","email":"garrett.thompson@canonical.com","date":"2021-02-12 00:27:27.000000000","tz":0},"subject":"Add ENFORCE_PASSWORD_CHECK setting","message":"Add ENFORCE_PASSWORD_CHECK setting\n\nThis setting is a behavior change, requring the admin password\nto be provided when changing the password of an admin user. Enabling\nthis setting by default adheres to the security recommendation\nprovided in the OpenStack security guide [0].\n\nTo enable this setting for Queens (the oldest supported OpenStack\nrelease at the time of this commit), a new local_settings.py file was\ncopied from the Ocata template to ensure that any future versions will\ninherit this setting until a new change is made.\n\nDue to the security-checklist action currently failing [1], these have been\nextracted to another class, and refactored in the zaza-openstack-tests\nrepo [2].\n\n[0] https://docs.openstack.org/security-guide/dashboard/checklist.html\n\n[1] https://github.com/openstack-charmers/zaza-openstack-tests/blob/2ef404be7563ab9a4907376c3b33719fee41679f/zaza/openstack/charm_tests/openstack_dashboard/tests.py#L418\n\n[2] https://github.com/openstack-charmers/zaza-openstack-tests/pull/501\n\nfunc-test-pr: https://github.com/openstack-charmers/zaza-openstack-tests/pull/501\nCloses-Bug: #1883196\nChange-Id: Idfd8654732289481806aea8b47ffa28cf3f97697\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/8e4dc4844a0cf52b32c9bea6d9553be7d6f93906"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/charm-openstack-dashboard/commit/8e4dc4844a0cf52b32c9bea6d9553be7d6f93906"}]},"branch":"refs/heads/master","description":"Edit commit message"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}