)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20870,"name":"Alex Kavanagh","email":"alex@ajkavanagh.co.uk","username":"ajkavanagh"},"change_message_id":"6ab7a511929431d371f4e05a44ffca60d2b3801b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0de8475d_9afdb09e","updated":"2024-03-22 20:15:03.000000000","message":"Thanks for the patch.  This is a great start, but it needs a little more work to turn it into a working solution. The key is that some code similar to:\n\n    \u0027openstack_keystone_mfa_totp_enabled\u0027:\n        config(\u0027openstack-keystone-mfa-totp-enabled\u0027),\n\nneeds to be added to the `HorizonContext` class in hooks/horizon_contexts.py. This takes the config value from Juju and puts it into the jinja2 context so that the template can find the value.\n\nAlso, note that config names in the config.yaml use \u0027-\u0027 (hyphen) not \u0027_\u0027 (underscore) as a convention - strange, but sadly true!\n\nSome tests may need to be altered to test the new value.\n\nThanks again.","commit_id":"c9d3d52316a218195f185b2aa41ab8e59b37bc8b"},{"author":{"_account_id":36909,"name":"Carlos Bravo","display_name":"Carlos Bravo","email":"cbravo@itcservicios.com","username":"cbravo"},"change_message_id":"89d482021d706285ff090b4f2f828006fe2bd258","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"00a010d3_d396b352","in_reply_to":"04c96cac_7849fddb","updated":"2024-03-22 21:21:46.000000000","message":"I think i did something wrong. I got a new link instead of this one: https://review.opendev.org/c/openstack/charm-openstack-dashboard/+/914030","commit_id":"c9d3d52316a218195f185b2aa41ab8e59b37bc8b"},{"author":{"_account_id":36909,"name":"Carlos Bravo","display_name":"Carlos Bravo","email":"cbravo@itcservicios.com","username":"cbravo"},"change_message_id":"86276fb341197e45cd52988555673a4522181b84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"04c96cac_7849fddb","in_reply_to":"0de8475d_9afdb09e","updated":"2024-03-22 21:17:55.000000000","message":"Hi, I just sent a new review with the required changes. Hopefully I didn\u0027t make a mistake on how I sent it.","commit_id":"c9d3d52316a218195f185b2aa41ab8e59b37bc8b"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"327b4bcef6060cb335e6224af44de22ced383d0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ec8c8416_1193a91c","updated":"2024-03-28 01:13:32.000000000","message":"LGTM","commit_id":"f9cc25307e2db2819844951617201c758b3c86f3"},{"author":{"_account_id":8992,"name":"Billy Olsen","email":"billy.olsen@canonical.com","username":"billy-olsen"},"change_message_id":"265f0c4847cb1fe7932a458e462e93983f46009d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cc192ef1_e4e593df","updated":"2024-03-28 01:30:13.000000000","message":"small comment regarding the name of the option, but otherwise looks good","commit_id":"f9cc25307e2db2819844951617201c758b3c86f3"},{"author":{"_account_id":20870,"name":"Alex Kavanagh","email":"alex@ajkavanagh.co.uk","username":"ajkavanagh"},"change_message_id":"920e733a77457eee573c34852d8483d1382cb8be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"999fb21e_32a5c968","updated":"2024-03-28 11:23:18.000000000","message":"LGTM - thank you for the patch.","commit_id":"ab66a192f46f375037d951587e9fb8bc03040830"},{"author":{"_account_id":8992,"name":"Billy Olsen","email":"billy.olsen@canonical.com","username":"billy-olsen"},"change_message_id":"1cf7fe9fd3ff5a27f830c0f39274e042519d078c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"851b7cad_6c5e6ada","updated":"2024-03-28 13:50:02.000000000","message":"Marking as eligible for backport to 2023.2 branch","commit_id":"ab66a192f46f375037d951587e9fb8bc03040830"}],"config.yaml":[{"author":{"_account_id":8992,"name":"Billy Olsen","email":"billy.olsen@canonical.com","username":"billy-olsen"},"change_message_id":"265f0c4847cb1fe7932a458e462e93983f46009d","unresolved":true,"context_lines":[{"line_number":529,"context_line":"          \"another cluster\": \"https://another.example.com/identity/v3\""},{"line_number":530,"context_line":"        }"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"  openstack-keystone-mfa-totp-enabled:"},{"line_number":533,"context_line":"    type: boolean"},{"line_number":534,"context_line":"    default: False"},{"line_number":535,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1673f319_650fa1d2","line":532,"updated":"2024-03-28 01:30:13.000000000","message":"Can we shorten the option name to something like totp-enabled or mfa-totp-enabled? The openstack-keystone prefix makes this option a bit long.","commit_id":"f9cc25307e2db2819844951617201c758b3c86f3"},{"author":{"_account_id":36909,"name":"Carlos Bravo","display_name":"Carlos Bravo","email":"cbravo@itcservicios.com","username":"cbravo"},"change_message_id":"c948354382787acbb94cda99b69f1cb73af33421","unresolved":true,"context_lines":[{"line_number":529,"context_line":"          \"another cluster\": \"https://another.example.com/identity/v3\""},{"line_number":530,"context_line":"        }"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"  openstack-keystone-mfa-totp-enabled:"},{"line_number":533,"context_line":"    type: boolean"},{"line_number":534,"context_line":"    default: False"},{"line_number":535,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1fb731a7_199e02e2","line":532,"in_reply_to":"1673f319_650fa1d2","updated":"2024-03-28 02:02:09.000000000","message":"Hi, I have changed the option to mfa-totp-enabled so it can be shorter.","commit_id":"f9cc25307e2db2819844951617201c758b3c86f3"},{"author":{"_account_id":36909,"name":"Carlos Bravo","display_name":"Carlos Bravo","email":"cbravo@itcservicios.com","username":"cbravo"},"change_message_id":"7e6820d4028a8a9246e150e353d27f2591a78548","unresolved":false,"context_lines":[{"line_number":529,"context_line":"          \"another cluster\": \"https://another.example.com/identity/v3\""},{"line_number":530,"context_line":"        }"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"  openstack-keystone-mfa-totp-enabled:"},{"line_number":533,"context_line":"    type: boolean"},{"line_number":534,"context_line":"    default: False"},{"line_number":535,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d9a283bc_43d5590e","line":532,"in_reply_to":"1fb731a7_199e02e2","updated":"2024-03-28 02:02:21.000000000","message":"Acknowledged","commit_id":"f9cc25307e2db2819844951617201c758b3c86f3"}]}