)]}'
{"charms_ceph/crush_utils.py":[{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"7adfa970d00f30b9fa3fcdf9912b5e3a0d5a7630","unresolved":true,"context_lines":[{"line_number":81,"context_line":"        except CalledProcessError as e:"},{"line_number":82,"context_line":"            log(\"Error occurred while loading and decompiling CRUSH map:\""},{"line_number":83,"context_line":"                \"{}\".format(e), ERROR)"},{"line_number":84,"context_line":"            raise ValueError(\"Failed to read CRUSH map\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def ensure_bucket_is_present(self, bucket_name):"},{"line_number":87,"context_line":"        if bucket_name not in [bucket.name for bucket in self.buckets()]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"36281491_5fe556d1","line":84,"updated":"2021-03-31 18:15:39.000000000","message":"This would effectively hide the real error condition in the Traceback. Since we are at a point where the program no longer knows how to proceed, why not just raise the CalledProcessError after logging so that the underlying issue will be evident in the Traceback as well as the log?","commit_id":"683f820c601cc6fd768b27f899564bd3589abc1a"},{"author":{"_account_id":32363,"name":"Robert Gildein","email":"robert.gildein@canonical.com","username":"rgildein"},"change_message_id":"536006bf7596b17cc53829c882b112778160deae","unresolved":true,"context_lines":[{"line_number":81,"context_line":"        except CalledProcessError as e:"},{"line_number":82,"context_line":"            log(\"Error occurred while loading and decompiling CRUSH map:\""},{"line_number":83,"context_line":"                \"{}\".format(e), ERROR)"},{"line_number":84,"context_line":"            raise ValueError(\"Failed to read CRUSH map\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def ensure_bucket_is_present(self, bucket_name):"},{"line_number":87,"context_line":"        if bucket_name not in [bucket.name for bucket in self.buckets()]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"0c15f8f5_0dead7aa","line":84,"in_reply_to":"36281491_5fe556d1","updated":"2021-03-31 19:27:22.000000000","message":"That\u0027s a good point.","commit_id":"683f820c601cc6fd768b27f899564bd3589abc1a"}],"tox.ini":[{"author":{"_account_id":20870,"name":"Alex Kavanagh","email":"alex@ajkavanagh.co.uk","username":"ajkavanagh"},"change_message_id":"b84c43861d657ab4298ed464ed7989fb24bcec8e","unresolved":true,"context_lines":[{"line_number":42,"context_line":"commands \u003d {posargs}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[flake8]"},{"line_number":45,"context_line":"ignore \u003d E402,E226,W504"}],"source_content_type":"text/x-properties","patch_set":1,"id":"6164649f_fdefe1c2","side":"PARENT","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":23},"updated":"2021-03-31 10:36:22.000000000","message":"I don\u0027t think all of these should be removed.  E402 and W504,W503 are standard ignores across all the charms.  They should be retained.  I\u0027m fine with losing E226","commit_id":"d0d002cacf89d12e687bdc7be602924ef1ffe57c"},{"author":{"_account_id":32363,"name":"Robert Gildein","email":"robert.gildein@canonical.com","username":"rgildein"},"change_message_id":"86fbcd461c1e46877190ec90f3f2ef22cefff415","unresolved":true,"context_lines":[{"line_number":42,"context_line":"commands \u003d {posargs}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[flake8]"},{"line_number":45,"context_line":"ignore \u003d E402,E226,W504"}],"source_content_type":"text/x-properties","patch_set":1,"id":"d4daa3af_366ec9d9","side":"PARENT","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":23},"in_reply_to":"6164649f_fdefe1c2","updated":"2021-03-31 15:14:16.000000000","message":"I didn\u0027t know they are standard ignores across all the charms, I just saw that they weren\u0027t used, so I deleted them.\nThank you for the information, I will put E402 and W504, W503 there.","commit_id":"d0d002cacf89d12e687bdc7be602924ef1ffe57c"}]}