)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"9ee9137fc207295a1c6c51ef1df9e9ae99217a25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6446c1ec_d4b2a980","updated":"2021-12-01 07:20:09.000000000","message":"recheck","commit_id":"7787c8957f783a52308bd368589ca34147e7becd"}],"ansible/roles/loggearman/README.rst":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3c930f8a47ef296e7ce06a3c6f3e6614c0e89eb5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Openstack Log Processor Tools"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"The goal of that role is to setup and configure service related"},{"line_number":5,"context_line":"to `log-gearman-client` and `log-gearman-worker` scripts, that"},{"line_number":6,"context_line":"were ported to this project repository from `puppet-log_processor repository"},{"line_number":7,"context_line":"\u003chttps://opendev.org/opendev/puppet-log_processor\u003e`__."}],"source_content_type":"text/x-rst","patch_set":4,"id":"d9f2d125_b5b731b0","line":4,"range":{"start_line":4,"start_character":12,"end_line":4,"end_character":16},"updated":"2021-11-29 08:36:05.000000000","message":"this (at least you are consistent with your use of \u0027that\u0027 ;) )","commit_id":"c319aeef50167d3a031dbd531858722a5d4f8342"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3c930f8a47ef296e7ce06a3c6f3e6614c0e89eb5","unresolved":true,"context_lines":[{"line_number":4,"context_line":"The goal of that role is to setup and configure service related"},{"line_number":5,"context_line":"to `log-gearman-client` and `log-gearman-worker` scripts, that"},{"line_number":6,"context_line":"were ported to this project repository from `puppet-log_processor repository"},{"line_number":7,"context_line":"\u003chttps://opendev.org/opendev/puppet-log_processor\u003e`__."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Configuration"},{"line_number":10,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"e5ce2aea_50a4af93","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":49},"updated":"2021-11-29 08:36:05.000000000","message":"might be nicer to point to the actual scripts? https://opendev.org/opendev/puppet-log_processor/src/branch/master/files","commit_id":"c319aeef50167d3a031dbd531858722a5d4f8342"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"89c841413ee1c9bbbb89f6b08ea657169d4f9ac3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"The goal of that role is to setup and configure service related"},{"line_number":5,"context_line":"to `log-gearman-client` and `log-gearman-worker` scripts, that"},{"line_number":6,"context_line":"were ported to this project repository from `puppet-log_processor repository"},{"line_number":7,"context_line":"\u003chttps://opendev.org/opendev/puppet-log_processor\u003e`__."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Configuration"},{"line_number":10,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ad3507a1_e281fd24","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":49},"in_reply_to":"e5ce2aea_50a4af93","updated":"2021-11-30 07:07:09.000000000","message":"Done","commit_id":"c319aeef50167d3a031dbd531858722a5d4f8342"}],"ansible/roles/loggearman/tasks/main.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3c930f8a47ef296e7ce06a3c6f3e6614c0e89eb5","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    state: touch"},{"line_number":30,"context_line":"    owner: \"{{ loggearman_user }}\""},{"line_number":31,"context_line":"    group: \"{{ loggearman_group }}\""},{"line_number":32,"context_line":"    mode: \"0666\""},{"line_number":33,"context_line":"  loop:"},{"line_number":34,"context_line":"    - client"},{"line_number":35,"context_line":"    - worker"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bc248e98_2c425a2d","line":32,"range":{"start_line":32,"start_character":12,"end_line":32,"end_character":15},"updated":"2021-11-29 08:36:05.000000000","message":"sanity check we want this read\u0026writeable by all?","commit_id":"c319aeef50167d3a031dbd531858722a5d4f8342"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bf664cfb836c67bc43b40003aee3d816a32e888e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    state: touch"},{"line_number":30,"context_line":"    owner: \"{{ loggearman_user }}\""},{"line_number":31,"context_line":"    group: \"{{ loggearman_group }}\""},{"line_number":32,"context_line":"    mode: \"0666\""},{"line_number":33,"context_line":"  loop:"},{"line_number":34,"context_line":"    - client"},{"line_number":35,"context_line":"    - worker"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c2e56317_635fe820","line":32,"range":{"start_line":32,"start_character":12,"end_line":32,"end_character":15},"in_reply_to":"16ae1f48_b7a19ad4","updated":"2021-11-30 07:30:36.000000000","message":"thanks for checking so I guess the answer is \u0027yes we do\u0027?\n\nhttps://review.opendev.org/c/openstack/ci-log-processing/+/817759/4..7/ansible/roles/loggearman/tasks/main.yml","commit_id":"c319aeef50167d3a031dbd531858722a5d4f8342"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"89c841413ee1c9bbbb89f6b08ea657169d4f9ac3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    state: touch"},{"line_number":30,"context_line":"    owner: \"{{ loggearman_user }}\""},{"line_number":31,"context_line":"    group: \"{{ loggearman_group }}\""},{"line_number":32,"context_line":"    mode: \"0666\""},{"line_number":33,"context_line":"  loop:"},{"line_number":34,"context_line":"    - client"},{"line_number":35,"context_line":"    - worker"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"16ae1f48_b7a19ad4","line":32,"range":{"start_line":32,"start_character":12,"end_line":32,"end_character":15},"in_reply_to":"bc248e98_2c425a2d","updated":"2021-11-30 07:07:09.000000000","message":"Done","commit_id":"c319aeef50167d3a031dbd531858722a5d4f8342"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"d8f38406a86138cff25dfcb17d2c58f52584244e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    state: touch"},{"line_number":30,"context_line":"    owner: \"{{ loggearman_user }}\""},{"line_number":31,"context_line":"    group: \"{{ loggearman_group }}\""},{"line_number":32,"context_line":"    mode: \"0666\""},{"line_number":33,"context_line":"  loop:"},{"line_number":34,"context_line":"    - client"},{"line_number":35,"context_line":"    - worker"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"756424c7_e2e3b3c9","line":32,"range":{"start_line":32,"start_character":12,"end_line":32,"end_character":15},"in_reply_to":"c2e56317_635fe820","updated":"2021-11-30 13:18:34.000000000","message":"ay! On pushing related change it update partially this one. I will change the mode in other PS, if it is ok","commit_id":"c319aeef50167d3a031dbd531858722a5d4f8342"}],"ansible/roles/loggearman/templates/loggearman.sh.j2":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3c930f8a47ef296e7ce06a3c6f3e6614c0e89eb5","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    --network host \\"},{"line_number":6,"context_line":"    --rm \\"},{"line_number":7,"context_line":"    --name loggearman-{{ item }} \\"},{"line_number":8,"context_line":"    --volume {{ loggearman_dir }}:{{ loggearman_dir }}:Z \\"},{"line_number":9,"context_line":"    --volume {{ loggearman_log_dir }}:{{ loggearman_log_dir }}:z \\"},{"line_number":10,"context_line":"    {{ container_images[\u0027loggearman\u0027] }} \\"},{"line_number":11,"context_line":"    log-gearman-{{ item }} \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"1df0d699_6a771b20","line":8,"range":{"start_line":8,"start_character":54,"end_line":8,"end_character":56},"updated":"2021-11-29 08:36:05.000000000","message":"sanity check this is intentional? (:Z vs :z) https://docs.docker.com/storage/bind-mounts/#configure-the-selinux-label","commit_id":"c319aeef50167d3a031dbd531858722a5d4f8342"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"401bb1372f43f5707fa69abedcbfbcfe0496be24","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    --network host \\"},{"line_number":6,"context_line":"    --rm \\"},{"line_number":7,"context_line":"    --name loggearman-{{ item }} \\"},{"line_number":8,"context_line":"    --volume {{ loggearman_dir }}:{{ loggearman_dir }}:Z \\"},{"line_number":9,"context_line":"    --volume {{ loggearman_log_dir }}:{{ loggearman_log_dir }}:z \\"},{"line_number":10,"context_line":"    {{ container_images[\u0027loggearman\u0027] }} \\"},{"line_number":11,"context_line":"    log-gearman-{{ item }} \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"2df8ae54_51de499d","line":8,"range":{"start_line":8,"start_character":54,"end_line":8,"end_character":56},"in_reply_to":"1df0d699_6a771b20","updated":"2021-11-29 14:39:33.000000000","message":"IIUC, `:Z` is to label folder from the host for the container, while `:z` is to label folder from a container to another container.","commit_id":"c319aeef50167d3a031dbd531858722a5d4f8342"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"834f195ae3411c081d0e71e046851433c1f10322","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    --network host \\"},{"line_number":6,"context_line":"    --rm \\"},{"line_number":7,"context_line":"    --name loggearman-{{ item }} \\"},{"line_number":8,"context_line":"    --volume {{ loggearman_dir }}:{{ loggearman_dir }}:Z \\"},{"line_number":9,"context_line":"    --volume {{ loggearman_log_dir }}:{{ loggearman_log_dir }}:z \\"},{"line_number":10,"context_line":"    {{ container_images[\u0027loggearman\u0027] }} \\"},{"line_number":11,"context_line":"    log-gearman-{{ item }} \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"90f72e92_bf682ccc","line":8,"range":{"start_line":8,"start_character":54,"end_line":8,"end_character":56},"in_reply_to":"2df8ae54_51de499d","updated":"2021-11-29 16:26:01.000000000","message":"in that case it should not affect current service setup.\nI can change the volume mount point from {{ loggearman_dir }} to {{ loggearman_dir }}/{{ item }}.yml:Z and it will be more correct","commit_id":"c319aeef50167d3a031dbd531858722a5d4f8342"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"89c841413ee1c9bbbb89f6b08ea657169d4f9ac3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    --network host \\"},{"line_number":6,"context_line":"    --rm \\"},{"line_number":7,"context_line":"    --name loggearman-{{ item }} \\"},{"line_number":8,"context_line":"    --volume {{ loggearman_dir }}:{{ loggearman_dir }}:Z \\"},{"line_number":9,"context_line":"    --volume {{ loggearman_log_dir }}:{{ loggearman_log_dir }}:z \\"},{"line_number":10,"context_line":"    {{ container_images[\u0027loggearman\u0027] }} \\"},{"line_number":11,"context_line":"    log-gearman-{{ item }} \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"c0607d14_35ecc516","line":8,"range":{"start_line":8,"start_character":54,"end_line":8,"end_character":56},"in_reply_to":"90f72e92_bf682ccc","updated":"2021-11-30 07:07:09.000000000","message":"Done","commit_id":"c319aeef50167d3a031dbd531858722a5d4f8342"}]}