)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6889,"name":"Fabien Boucher","email":"fboucher@redhat.com","username":"fabien-boucher"},"change_message_id":"2132f281d36f17f79016e9b66353adf9c70de921","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5d5ce92e_bb17fcf8","updated":"2021-12-09 09:08:57.000000000","message":"Se my comment inline; Also don\u0027t you want to use type annotation to avoid such type mistake ? and enable mypy in tox ?","commit_id":"64849ca52d8e17a8de2a6d381033f0f1b5fbd321"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"36665c436b45e1af8d503637e564d20a2ea1c866","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"38630756_c838a9c6","updated":"2021-12-09 07:39:23.000000000","message":"makes sense","commit_id":"64849ca52d8e17a8de2a6d381033f0f1b5fbd321"}],"logscraper/logscraper.py":[{"author":{"_account_id":6889,"name":"Fabien Boucher","email":"fboucher@redhat.com","username":"fabien-boucher"},"change_message_id":"2132f281d36f17f79016e9b66353adf9c70de921","unresolved":true,"context_lines":[{"line_number":161,"context_line":"    parser.add_argument(\"--max-skipped\", help\u003d\"How many job results should be \""},{"line_number":162,"context_line":"                        \"checked until last uuid written in checkpoint file \""},{"line_number":163,"context_line":"                        \"is founded\","},{"line_number":164,"context_line":"                        default\u003d500)"},{"line_number":165,"context_line":"    parser.add_argument(\"--debug\", help\u003d\"Print more information\","},{"line_number":166,"context_line":"                        action\u003d\"store_true\")"},{"line_number":167,"context_line":"    args \u003d parser.parse_args()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7bc269ca_357fa879","line":164,"updated":"2021-12-09 09:08:57.000000000","message":"Why not specifying the right type here instead ? https://docs.python.org/3/library/argparse.html#type","commit_id":"64849ca52d8e17a8de2a6d381033f0f1b5fbd321"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"63415bfbac9bd52330daccea136626946731f037","unresolved":true,"context_lines":[{"line_number":161,"context_line":"    parser.add_argument(\"--max-skipped\", help\u003d\"How many job results should be \""},{"line_number":162,"context_line":"                        \"checked until last uuid written in checkpoint file \""},{"line_number":163,"context_line":"                        \"is founded\","},{"line_number":164,"context_line":"                        default\u003d500)"},{"line_number":165,"context_line":"    parser.add_argument(\"--debug\", help\u003d\"Print more information\","},{"line_number":166,"context_line":"                        action\u003d\"store_true\")"},{"line_number":167,"context_line":"    args \u003d parser.parse_args()"}],"source_content_type":"text/x-python","patch_set":2,"id":"a639089f_79f50f77","line":164,"in_reply_to":"1a07f066_67c70e75","updated":"2021-12-13 14:53:38.000000000","message":"good idea. I will change it in the future when the param will be used in few places.","commit_id":"64849ca52d8e17a8de2a6d381033f0f1b5fbd321"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"263dc5face3e37e25a360c6383ef45bcc6094796","unresolved":true,"context_lines":[{"line_number":161,"context_line":"    parser.add_argument(\"--max-skipped\", help\u003d\"How many job results should be \""},{"line_number":162,"context_line":"                        \"checked until last uuid written in checkpoint file \""},{"line_number":163,"context_line":"                        \"is founded\","},{"line_number":164,"context_line":"                        default\u003d500)"},{"line_number":165,"context_line":"    parser.add_argument(\"--debug\", help\u003d\"Print more information\","},{"line_number":166,"context_line":"                        action\u003d\"store_true\")"},{"line_number":167,"context_line":"    args \u003d parser.parse_args()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a07f066_67c70e75","line":164,"in_reply_to":"7bc269ca_357fa879","updated":"2021-12-09 14:22:16.000000000","message":"+1","commit_id":"64849ca52d8e17a8de2a6d381033f0f1b5fbd321"}],"logscraper/tests/test_logscraper.py":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"263dc5face3e37e25a360c6383ef45bcc6094796","unresolved":true,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @mock.patch(\u0027logscraper.logscraper.get_builds\u0027,"},{"line_number":167,"context_line":"                return_value\u003diter([{\u0027uuid\u0027: \u00271234\u0027}]))"},{"line_number":168,"context_line":"    def test_get_last_job_results_wrong_max_skipped(self, mock_get_builds):"},{"line_number":169,"context_line":"        def make_fake_list(x):"},{"line_number":170,"context_line":"            return list(x)"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2a8490fb_a7d2716a","line":168,"updated":"2021-12-09 14:22:16.000000000","message":"Note that\u0027s the kind of test we can do statically with mypy.","commit_id":"64849ca52d8e17a8de2a6d381033f0f1b5fbd321"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"36665c436b45e1af8d503637e564d20a2ea1c866","unresolved":true,"context_lines":[{"line_number":170,"context_line":"            return list(x)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        job_result \u003d logscraper.get_last_job_results("},{"line_number":173,"context_line":"            \u0027http://somehost.com/api/tenant/tenant1\u0027, False, \u0027somevalue\u0027,"},{"line_number":174,"context_line":"            \u0027someuuid\u0027)"},{"line_number":175,"context_line":"        self.assertRaises(ValueError, make_fake_list, job_result)"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b2b7e180_4366353a","line":173,"range":{"start_line":173,"start_character":62,"end_line":173,"end_character":71},"updated":"2021-12-09 07:39:23.000000000","message":"ack","commit_id":"64849ca52d8e17a8de2a6d381033f0f1b5fbd321"}]}