)]}'
{"logscraper/logscraper.py":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"500fdf04dfe9dba88f8b2a283507b9e78bd04e0a","unresolved":true,"context_lines":[{"line_number":496,"context_line":"    # check if directory exists on logserver"},{"line_number":497,"context_line":"    for directory in directories:"},{"line_number":498,"context_line":"        url \u003d \u0027%s%s\u0027 % (log_url, directory)"},{"line_number":499,"context_line":"        response \u003d requests.get(url, verify\u003dinsecure)"},{"line_number":500,"context_line":"        if response.status_code \u003d\u003d 200:"},{"line_number":501,"context_line":"            existing_dirs.append(directory)"},{"line_number":502,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"365c5c5f_a74c7c20","line":499,"updated":"2022-04-25 14:32:08.000000000","message":"Shouldn\u0027t this be `requests.head` ?","commit_id":"4fb4592c939ece6130364f74245eb71a0daaa02f"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"da69173a1ed5f767500a3e117a9f52764dd4ee28","unresolved":false,"context_lines":[{"line_number":496,"context_line":"    # check if directory exists on logserver"},{"line_number":497,"context_line":"    for directory in directories:"},{"line_number":498,"context_line":"        url \u003d \u0027%s%s\u0027 % (log_url, directory)"},{"line_number":499,"context_line":"        response \u003d requests.get(url, verify\u003dinsecure)"},{"line_number":500,"context_line":"        if response.status_code \u003d\u003d 200:"},{"line_number":501,"context_line":"            existing_dirs.append(directory)"},{"line_number":502,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff5ceb66_025cfc2e","line":499,"in_reply_to":"365c5c5f_a74c7c20","updated":"2022-05-04 08:12:35.000000000","message":"Done","commit_id":"4fb4592c939ece6130364f74245eb71a0daaa02f"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"500fdf04dfe9dba88f8b2a283507b9e78bd04e0a","unresolved":true,"context_lines":[{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    # remove directories, that does not exists on log server"},{"line_number":504,"context_line":"    for config_file in config_files:"},{"line_number":505,"context_line":"        if config_file.split(\u0027/\u0027)[0] in existing_dirs:"},{"line_number":506,"context_line":"            filtered_config_files.append(config_file)"},{"line_number":507,"context_line":"    return filtered_config_files"},{"line_number":508,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c90366ac_cbddb11a","line":505,"updated":"2022-04-25 14:32:08.000000000","message":"What about files that has more than one \u0027/\u0027. Would be it safer to do `Path(config_file).parent`  (from pathlib import Path)","commit_id":"4fb4592c939ece6130364f74245eb71a0daaa02f"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"da69173a1ed5f767500a3e117a9f52764dd4ee28","unresolved":false,"context_lines":[{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    # remove directories, that does not exists on log server"},{"line_number":504,"context_line":"    for config_file in config_files:"},{"line_number":505,"context_line":"        if config_file.split(\u0027/\u0027)[0] in existing_dirs:"},{"line_number":506,"context_line":"            filtered_config_files.append(config_file)"},{"line_number":507,"context_line":"    return filtered_config_files"},{"line_number":508,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"4d3dcde3_72fd838b","line":505,"in_reply_to":"c90366ac_cbddb11a","updated":"2022-05-04 08:12:35.000000000","message":"good point","commit_id":"4fb4592c939ece6130364f74245eb71a0daaa02f"},{"author":{"_account_id":6889,"name":"Fabien Boucher","email":"fboucher@redhat.com","username":"fabien-boucher"},"change_message_id":"7c9a20539ecf98803a384baa428c13f260a5b8d3","unresolved":true,"context_lines":[{"line_number":496,"context_line":"    # check if directory exists on logserver"},{"line_number":497,"context_line":"    for directory in directories:"},{"line_number":498,"context_line":"        # job-results.txt doesn\u0027t contain dirname, so it will be an empty value"},{"line_number":499,"context_line":"        if not directory:"},{"line_number":500,"context_line":"            continue"},{"line_number":501,"context_line":"        url \u003d \u0027%s%s\u0027 % (log_url, directory)"},{"line_number":502,"context_line":"        response \u003d requests.head(url, verify\u003dinsecure)"}],"source_content_type":"text/x-python","patch_set":4,"id":"e7413216_624662f8","line":499,"updated":"2022-05-18 07:31:09.000000000","message":"Perhaps do that check line 494 to not add empty value in the set.","commit_id":"6ff20c9aa8bffee430c34c17cd0b0065d1280902"}]}