)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34460,"name":"Enrique Vallespí Gil","email":"evallesp@redhat.com","username":"evallesp"},"change_message_id":"a7040bccf06ce5bf98309510908b33f29d8c0eb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e214892e_b08a379c","updated":"2022-06-21 13:42:09.000000000","message":"LGTM","commit_id":"87e765022bab9bb450f214dc66cbecb730ef2d03"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"5d20655a2f30a81cfe3f29596afa04ed4db6aad3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9dda1074_15bfbb6f","updated":"2022-06-24 06:15:28.000000000","message":"recheck","commit_id":"87e765022bab9bb450f214dc66cbecb730ef2d03"}],"logscraper/logscraper.py":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"b68c785467aea5dae259849944953811b0fa73e1","unresolved":true,"context_lines":[{"line_number":385,"context_line":"        jobs_result \u003d requests_get_json(url, verify\u003dinsecure)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        if not jobs_result:"},{"line_number":388,"context_line":"            return iter([])"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        for job in jobs_result:"},{"line_number":391,"context_line":"            # It is important here to check we didn\u0027t yield builds twice,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e94b1e2c_55072be1","line":388,"updated":"2022-06-21 14:17:52.000000000","message":"Should this be `iter(())` ?","commit_id":"87e765022bab9bb450f214dc66cbecb730ef2d03"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"b68c785467aea5dae259849944953811b0fa73e1","unresolved":true,"context_lines":[{"line_number":387,"context_line":"        if not jobs_result:"},{"line_number":388,"context_line":"            return iter([])"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        for job in jobs_result:"},{"line_number":391,"context_line":"            # It is important here to check we didn\u0027t yield builds twice,"},{"line_number":392,"context_line":"            # as this can happen when using skip if new build get reported"},{"line_number":393,"context_line":"            # between the two requests."}],"source_content_type":"text/x-python","patch_set":2,"id":"d44b1279_c0d670e6","line":390,"updated":"2022-06-21 14:17:52.000000000","message":"Why isn\u0027t the iterator not already empty. It seems like an issue with `requests_get_json`. Could you make it return an empty iterator when there is no result?","commit_id":"87e765022bab9bb450f214dc66cbecb730ef2d03"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"cf5c29e570a822b6bf6cbd63bcebe06538f6b15f","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        if not jobs_result:"},{"line_number":388,"context_line":"            return iter([])"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        for job in jobs_result:"},{"line_number":391,"context_line":"            # It is important here to check we didn\u0027t yield builds twice,"},{"line_number":392,"context_line":"            # as this can happen when using skip if new build get reported"},{"line_number":393,"context_line":"            # between the two requests."}],"source_content_type":"text/x-python","patch_set":2,"id":"9af605b6_874dad22","line":390,"in_reply_to":"d44b1279_c0d670e6","updated":"2022-06-22 10:26:06.000000000","message":"requests_get_json returns an empty list,so in the for loop in L390 is not starting, but it comes back to the while loop in L382, make new requests which is empty and over and over again.\nThen the next function is waiting for a generator, so it needs to be iter, no metter if iter(()) or iter([])","commit_id":"87e765022bab9bb450f214dc66cbecb730ef2d03"}]}