)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"17fbfdb88b1194a45cf131f903d0d39bc9f089f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"813144e4_46d5e25e","updated":"2023-04-05 13:47:52.000000000","message":"Looks good to me!\nI just added two comments.","commit_id":"4be52761216bb1788b6123f3d98d793b860acadd"}],"logscraper/logsender.py":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"17fbfdb88b1194a45cf131f903d0d39bc9f089f5","unresolved":true,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"def subunit_iter(file_name, index, es_fields):"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    try:"},{"line_number":375,"context_line":"        with open(file_name) as f:"},{"line_number":376,"context_line":"            subunit \u003d ReadSubunit(f)"},{"line_number":377,"context_line":"            parsed_subunit \u003d subunit.get_results()"}],"source_content_type":"text/x-python","patch_set":3,"id":"c2ea1a0b_127403ea","line":374,"range":{"start_line":374,"start_character":4,"end_line":374,"end_character":8},"updated":"2023-04-05 13:47:52.000000000","message":"nit: new line at beginning of function.","commit_id":"4be52761216bb1788b6123f3d98d793b860acadd"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"17fbfdb88b1194a45cf131f903d0d39bc9f089f5","unresolved":true,"context_lines":[{"line_number":379,"context_line":"        if \u0027Non subunit content\u0027 in e.args:"},{"line_number":380,"context_line":"            logging.info(\"The %s file does not contain any subunit \""},{"line_number":381,"context_line":"                         \"content. Skipping...\" % file_name)"},{"line_number":382,"context_line":"            return"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    if not parsed_subunit:"},{"line_number":385,"context_line":"        logging.info(\"Parsed subunit file is empty. Skipping...\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"4198feb7_17a59a53","line":382,"range":{"start_line":382,"start_character":12,"end_line":382,"end_character":18},"updated":"2023-04-05 13:47:52.000000000","message":"I would reraise the exception if it is not the one we expected (\"Non subunit content\") or at least print it. We might lose info for example when the file with file_name does not exist as Exception catches everything.\n```\nif \u0027Non subunit content\u0027 in e.args:\n    logging.info(\"The %s file does not contain any subunit \"\n                 \"content. Skipping...\" % file_name)\n    return\nelse:\n    raise e\n\n```","commit_id":"4be52761216bb1788b6123f3d98d793b860acadd"}]}