)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"0bd1ac1cef94a4d01d7f170e2f81f1096d102bf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e9eec824_c04e8528","updated":"2026-10-30 13:58:17.000000000","message":"A few inline commnets that need to be addressed","commit_id":"2b513640853f7057dd808b64661eab788dd722f8"}],"specs/2027.1/cinder-user-specified-encryption-key.rst":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"be7c6d8c342bcee87730f15ae09258dcda1b2a0a","unresolved":true,"context_lines":[{"line_number":36,"context_line":"* An end user has created a symmetric key in Barbican and wants to create an"},{"line_number":37,"context_line":"  encrypted volume that uses exactly that key."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* An end user wants to retain control of a key\u0027s lifecycle (for example"},{"line_number":40,"context_line":"  revoking access by deleting the key) independently of the volume."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* A deployer wants to let users bring their own keys while keeping the existing"},{"line_number":43,"context_line":"  behaviour for users who do not specify one."}],"source_content_type":"text/x-rst","patch_set":1,"id":"58b2561c_85c92f15","line":40,"range":{"start_line":39,"start_character":1,"end_line":40,"end_character":67},"updated":"2026-11-05 15:27:50.000000000","message":"This use case gets problematic because revoking the Barbican key doesn\u0027t really guarantee that you\u0027ve revoked access to the volume.\n\nThere is a scenario such as:\n  1. User creates volume with a key\n  2. User attaches volume\n  3. User records LUKS keys from Barbican and the volume attachment (which they have access to)\n  4. User detaches volume\n  5. User deletes the key from Barbican\n  6. User reattaches the volume and reconstructs how to open the LUKS layer with the previously recorded encryption key\n\nThe implication here is that we want to support revoking access to volumes, we need to have Cinder rekey the volume with a new LUKS key as well. This is definitely possible, but will be an additional piece to implement.","commit_id":"2b513640853f7057dd808b64661eab788dd722f8"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"0bd1ac1cef94a4d01d7f170e2f81f1096d102bf9","unresolved":true,"context_lines":[{"line_number":53,"context_line":"* The volume type of the request must be an encrypted volume type. Otherwise"},{"line_number":54,"context_line":"  the request is rejected with 400."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* Cinder validates the key with the Key Manager using the request context"},{"line_number":57,"context_line":"  before creating the volume:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  * the key exists and is accessible to the requesting user,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e5e7c01d_6d915654","line":56,"updated":"2026-10-30 13:58:17.000000000","message":"Validation should fetch metadata only. State the comparison rule, since `aes-xts` has `key_size` 512.","commit_id":"2b513640853f7057dd808b64661eab788dd722f8"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"0bd1ac1cef94a4d01d7f170e2f81f1096d102bf9","unresolved":true,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"When ``key_id`` is not specified the behaviour is unchanged."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"``key_id`` is only accepted for creating a new volume from scratch or from an"},{"line_number":76,"context_line":"image. For ``snapshot_id``, ``source_volid`` and ``backup_id`` the existing"},{"line_number":77,"context_line":"key handling (cloning or re-using the source\u0027s key) is unchanged, and"},{"line_number":78,"context_line":"combining them with ``key_id`` is rejected with 400."}],"source_content_type":"text/x-rst","patch_set":1,"id":"033f132f_6c2aede6","line":75,"updated":"2026-10-30 13:58:17.000000000","message":"Create-from-image with `key_id` collides with the image\u0027s `cinder_encryption_key_id`. Define precedence (400 is simplest). For snapshot and `source_volid`, master always clones the key and never reuses it. Confirm the same for backups.","commit_id":"2b513640853f7057dd808b64661eab788dd722f8"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"0bd1ac1cef94a4d01d7f170e2f81f1096d102bf9","unresolved":true,"context_lines":[{"line_number":77,"context_line":"key handling (cloning or re-using the source\u0027s key) is unchanged, and"},{"line_number":78,"context_line":"combining them with ``key_id`` is rejected with 400."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"When a volume is deleted, Cinder checks the metadata of its key in the Key"},{"line_number":81,"context_line":"Manager. If the key is marked as user-specified, Cinder does not delete it,"},{"line_number":82,"context_line":"because the key is user-owned and its lifecycle remains with the user. Keys"},{"line_number":83,"context_line":"without the mark (all keys created by Cinder, including those of existing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3240fa38_18de4567","line":80,"updated":"2026-10-30 13:58:17.000000000","message":"Rolling upgrade: an old API node deletes the user\u0027s key. An unreadable mark must fail closed. A transient Key Manager error must not turn into deletion.","commit_id":"2b513640853f7057dd808b64661eab788dd722f8"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"0bd1ac1cef94a4d01d7f170e2f81f1096d102bf9","unresolved":true,"context_lines":[{"line_number":77,"context_line":"key handling (cloning or re-using the source\u0027s key) is unchanged, and"},{"line_number":78,"context_line":"combining them with ``key_id`` is rejected with 400."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"When a volume is deleted, Cinder checks the metadata of its key in the Key"},{"line_number":81,"context_line":"Manager. If the key is marked as user-specified, Cinder does not delete it,"},{"line_number":82,"context_line":"because the key is user-owned and its lifecycle remains with the user. Keys"},{"line_number":83,"context_line":"without the mark (all keys created by Cinder, including those of existing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"34f62f73_56850c47","line":80,"updated":"2026-10-30 13:58:17.000000000","message":"Volume delete isn\u0027t the only place the key is deleted. Backup restore deletes the original key (`backup/manager.py`). Transfer copies the key and deletes the source (`keymgr/transfer.py`). Retype and migration also need auditing. List every site and decide what each does. Centralising the check in `delete_encryption_key` is an option.","commit_id":"2b513640853f7057dd808b64661eab788dd722f8"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"be7c6d8c342bcee87730f15ae09258dcda1b2a0a","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Scope of this spec ends at volume creation. Changing the key of an existing"},{"line_number":87,"context_line":"volume (re-keying) is out of scope."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Alternatives"},{"line_number":90,"context_line":"------------"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"daf7e485_ca3e9825","line":88,"updated":"2026-11-05 15:27:50.000000000","message":"Exactly how volume clone work needs to be described -- if we are using the Barbican secret consumer API we could potentially reuse keys between volumes when they are cloned.","commit_id":"2b513640853f7057dd808b64661eab788dd722f8"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"be7c6d8c342bcee87730f15ae09258dcda1b2a0a","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Scope of this spec ends at volume creation. Changing the key of an existing"},{"line_number":87,"context_line":"volume (re-keying) is out of scope."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Alternatives"},{"line_number":90,"context_line":"------------"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"377a8ecb_217c3d57","line":88,"updated":"2026-11-05 15:27:50.000000000","message":"One thing we discussed at the PTG is that doing this likely means we need to use the Barbican secret consumer API from Cinder.","commit_id":"2b513640853f7057dd808b64661eab788dd722f8"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"0bd1ac1cef94a4d01d7f170e2f81f1096d102bf9","unresolved":true,"context_lines":[{"line_number":139,"context_line":"         }"},{"line_number":140,"context_line":"     }"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"* Response body: unchanged. The ``encryption_key_id`` of the volume is not"},{"line_number":143,"context_line":"  exposed in the response today and this spec does not change that."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"* Policy: no new policy is needed since this extends the existing volume"}],"source_content_type":"text/x-rst","patch_set":1,"id":"84b2e845_5f159af4","line":142,"updated":"2026-10-30 13:58:17.000000000","message":"\"encryption_key_id is not exposed in the response\" is wrong. Since microversion 3.64 the detail view includes it.","commit_id":"2b513640853f7057dd808b64661eab788dd722f8"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"0bd1ac1cef94a4d01d7f170e2f81f1096d102bf9","unresolved":true,"context_lines":[{"line_number":238,"context_line":"Dependencies"},{"line_number":239,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"* A Key Manager that supports retrieving key metadata and reading and"},{"line_number":242,"context_line":"  updating user metadata on a key, such as Barbican."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3b2a929e_3df1bcdf","line":241,"updated":"2026-10-30 13:58:17.000000000","message":"The ownership mark needs Barbican user metadata, which castellan doesn\u0027t expose. Propose a castellan change as an explicit dependency, or store the flag in the Cinder DB. The spec doesn\u0027t say why a DB flag was rejected, and it\u0027s missing from Alternatives. A hard failure on the metadata write also excludes shared read-only keys.","commit_id":"2b513640853f7057dd808b64661eab788dd722f8"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"0bd1ac1cef94a4d01d7f170e2f81f1096d102bf9","unresolved":true,"context_lines":[{"line_number":244,"context_line":"Testing"},{"line_number":245,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"* Unit tests for schema validation, key validation failures and for key"},{"line_number":248,"context_line":"  deletion behaviour."},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"* Tempest scenario: create a key in Barbican, create an encrypted volume with"}],"source_content_type":"text/x-rst","patch_set":1,"id":"953fb967_e81da6a5","line":247,"updated":"2026-10-30 13:58:17.000000000","message":"Testing covers only delete. Add transfer, retype/migration, clone and restore, image plus `key_id`, a failed mark write, mixed versions, and Tempest cleanup.","commit_id":"2b513640853f7057dd808b64661eab788dd722f8"}]}
