)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"837db8ec08e6595385faef97bda2e2ffccc88f41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7bb7c990_be5398a7","updated":"2026-11-11 20:14:10.000000000","message":"-1 for a PS2, with my answer to the microversion question given inline.\n\nBrian asked for a short spec modelled on the 2026.1 openapi spec, which is 260 lines; this is 455, and a spec this long does not get read. The design is sound and matches 1012421, and about 300 lines is reachable by turning the REST API impact bullets into one table and stating each cross-cutting rule once; specific cuts are at 177, 259, 286, 334, 390 and 416. An approved spec also records decisions, and this one asks the reviewers for three (265, 394, 433). The `connection_info` sentence at 117 contradicts 294.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"3f4ff7472239d5d335f4c102e12d2047cda0630a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4cc20a9e_f330b762","updated":"2026-11-11 22:24:42.000000000","message":"Forgot to add the -1","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"0430136104531cb65d4e70a09b2016068ac1e1cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"28776486_825a2595","updated":"2026-11-12 16:59:19.000000000","message":"The compression left eight sentences in REST API impact that no longer match the code or 1012421 PS4; each fix is one sentence, inline. The one that matters most is 80-81, which states a 404 for a denial that is a 403 on two of the three resources.\nGet these done and I thik we will be ready for a +2","commit_id":"785dbdafc0d18d0496fe4557213a993d77945e10"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"1742ad602ecd7c745656ef5c57b7ef5f43ba3b03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5e1f92a5_ae2eb465","updated":"2026-11-13 14:39:47.000000000","message":"All issues addressed. One cosmetic nit below, not worth another patchset on its own.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cff61e0c70c25165990b4b9fb98672b2364b8aba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"586e3e9c_0c794804","updated":"2026-11-14 15:18:48.000000000","message":"Haven\u0027t completed my review, but two questions inline.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"07356205dca422ac7e02ea520cb2c7277f7f4f91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f4c1c4ea_2edb68a9","updated":"2026-11-16 15:40:50.000000000","message":"More comments inline.  Overall I\u0027m ok with the proposal, but I do think you need to pull out the bugs to be filed and fixed separately.  They may impact tempest tests, and it would be good to get those sorted out as bugs so that it\u0027s clear that we\u0027re not making an API change.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"735dd57eeb6f8494266377ef5772446d38df9d2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"feceb75a_ddc05da2","in_reply_to":"f4c1c4ea_2edb68a9","updated":"2026-11-18 02:43:41.000000000","message":"Thanks. Filed bugs 2174795, 2174796, 2174799 and 2174798 for the repeated key, the non-boolean values, the false value and with_count. PS4 points at them and expects a 400 for a bad or repeated value.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"}],"specs/2027.1/allow-all-tenants-query.rst":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"837db8ec08e6595385faef97bda2e2ffccc88f41","unresolved":true,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Allow all_tenants query to non-admin role"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/cinder/+spec/allow-all-tenants-query"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d3c2c043_636b96bc","line":8,"updated":"2026-11-11 20:14:10.000000000","message":"Brian asked in the IRC channel for a short spec modelled on the 2026.1 openapi spec (260 lines); this is 455, and a spec this long does not get read. REST API impact alone is 106 lines, and three rules are stated more than once: default unchanged until granted (16-17, 177-178, 352), denied caller gets its own project (80-81, 253-254, 259), the admin group/attachment list case (219-225, 334-337). About 300 lines is reachable without losing a decision: fold the endpoint list at 180-201 into one sentence, replace the bullets at 217-254 with one table (resource by value: true, false, non-boolean, repeated; admin today and after), and state each rule once. Keep the transfer, group, group snapshot and attachment rows, since this spec is the only place the second change is written down.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"afdd237339e158cb9022aa3286cf4fdafc4a97ca","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Allow all_tenants query to non-admin role"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/cinder/+spec/allow-all-tenants-query"}],"source_content_type":"text/x-rst","patch_set":1,"id":"75d96d30_126ab08f","line":8,"in_reply_to":"d3c2c043_636b96bc","updated":"2026-11-12 02:19:44.000000000","message":"Done in PS2: 333 lines, the value bullets are one table and each rule is stated once. The rows for the second change are kept.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"837db8ec08e6595385faef97bda2e2ffccc88f41","unresolved":true,"context_lines":[{"line_number":103,"context_line":"Show gets a fallback for volumes, snapshots and backups only. If the"},{"line_number":104,"context_line":"project-scoped lookup returns not found, the controller checks the resource\u0027s"},{"line_number":105,"context_line":"policy. If the policy denies, the caller gets the same 404 as before. If it"},{"line_number":106,"context_line":"allows, the controller runs a one-row list across projects."},{"line_number":107,"context_line":"``volume_api.get()`` also returns not found when ``volume:get`` denies a volume"},{"line_number":108,"context_line":"the caller can see, so an admin and a row in the caller\u0027s own project stay a"},{"line_number":109,"context_line":"404."}],"source_content_type":"text/x-rst","patch_set":1,"id":"b51b5875_79398dad","line":106,"updated":"2026-11-11 20:14:10.000000000","message":"One sentence would close the complement of 107-109: the fallback is decided by the list policy and the all_tenants policy only, and `volume:get`, `volume:get_snapshot` and `backup:get` are never checked against the row it returns. In 1012421 that is v3/volumes.py:123-124 plus volume/api.py:638. An operator who tightens volume:get to role:member and grants the all_tenants policy to a reader gets a 404 for the reader\u0027s own volume and a 200 for another project\u0027s; consistent with lists, but worth stating.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"afdd237339e158cb9022aa3286cf4fdafc4a97ca","unresolved":false,"context_lines":[{"line_number":103,"context_line":"Show gets a fallback for volumes, snapshots and backups only. If the"},{"line_number":104,"context_line":"project-scoped lookup returns not found, the controller checks the resource\u0027s"},{"line_number":105,"context_line":"policy. If the policy denies, the caller gets the same 404 as before. If it"},{"line_number":106,"context_line":"allows, the controller runs a one-row list across projects."},{"line_number":107,"context_line":"``volume_api.get()`` also returns not found when ``volume:get`` denies a volume"},{"line_number":108,"context_line":"the caller can see, so an admin and a row in the caller\u0027s own project stay a"},{"line_number":109,"context_line":"404."}],"source_content_type":"text/x-rst","patch_set":1,"id":"a4a59f96_f924cc75","line":106,"in_reply_to":"b51b5875_79398dad","updated":"2026-11-12 02:19:44.000000000","message":"Done. PS2 says the fallback checks the list policy and the all_tenants policy only.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"837db8ec08e6595385faef97bda2e2ffccc88f41","unresolved":true,"context_lines":[{"line_number":114,"context_line":"and is up for review as `change 1012421`_. The second covers transfers, groups,"},{"line_number":115,"context_line":"group snapshots and attachments, without the show fallback."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"``connection_info`` can hold driver credentials, such as a CHAP password. A"},{"line_number":118,"context_line":"cross-project attachment list returns that field as null to a caller that is"},{"line_number":119,"context_line":"not an admin."},{"line_number":120,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"2f2d937e_18ad152c","line":117,"updated":"2026-11-11 20:14:10.000000000","message":"This is the one place a granted role gets a different value from a project member, nothing pushed implements it (`views/attachments.py:35` returns `connection_info` unconditionally and 1012421 does not touch attachments), and it contradicts 294, which says a granted role sees everything the detail view shows a project member. Add the exception at 294 and a line under REST API impact. Does the null apply to the caller\u0027s own attachments in that list too, or only to other projects\u0027 rows?","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"afdd237339e158cb9022aa3286cf4fdafc4a97ca","unresolved":false,"context_lines":[{"line_number":114,"context_line":"and is up for review as `change 1012421`_. The second covers transfers, groups,"},{"line_number":115,"context_line":"group snapshots and attachments, without the show fallback."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"``connection_info`` can hold driver credentials, such as a CHAP password. A"},{"line_number":118,"context_line":"cross-project attachment list returns that field as null to a caller that is"},{"line_number":119,"context_line":"not an admin."},{"line_number":120,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"99acb0c4_76c006ca","line":117,"in_reply_to":"2f2d937e_18ad152c","updated":"2026-11-12 02:19:44.000000000","message":"Done. Every row of a cross-project list is nulled for a non-admin, the caller\u0027s own included. A list without all_tenants is unchanged. It is in the second change, not pushed yet.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"837db8ec08e6595385faef97bda2e2ffccc88f41","unresolved":true,"context_lines":[{"line_number":174,"context_line":"---------------"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"No new method, parameter or response field. The request and response schemas"},{"line_number":177,"context_line":"do not change. With default policy, who can read across projects does not"},{"line_number":178,"context_line":"change. The value handling listed below does change."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"With a policy granted, these methods return other projects\u0027 resources to the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"05eb53e6_03b98ffa","line":177,"updated":"2026-11-11 20:14:10.000000000","message":"Same sentence as 16-17 and 352; delete it here.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"afdd237339e158cb9022aa3286cf4fdafc4a97ca","unresolved":false,"context_lines":[{"line_number":174,"context_line":"---------------"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"No new method, parameter or response field. The request and response schemas"},{"line_number":177,"context_line":"do not change. With default policy, who can read across projects does not"},{"line_number":178,"context_line":"change. The value handling listed below does change."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"With a policy granted, these methods return other projects\u0027 resources to the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"509c0327_f8591d3e","line":177,"in_reply_to":"05eb53e6_03b98ffa","updated":"2026-11-12 02:19:44.000000000","message":"Done.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"837db8ec08e6595385faef97bda2e2ffccc88f41","unresolved":true,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"A granted role keeps the filter rules of a non-admin. On volumes, snapshots,"},{"line_number":206,"context_line":"backups and attachments, a filter outside ``resource_filters.json``, such as"},{"line_number":207,"context_line":"``project_id``, returns HTTP 400 from 3.31 and is ignored below it. Below 3.31"},{"line_number":208,"context_line":"that means ``--project`` or ``--tenant`` returns every project. Transfers and"},{"line_number":209,"context_line":"consistency groups apply ``project_id`` as a filter at every microversion."},{"line_number":210,"context_line":"Groups and group snapshots apply it below 3.31 and return HTTP 400 from 3.31."}],"source_content_type":"text/x-rst","patch_set":1,"id":"aca0f2ed_477de1b0","line":207,"updated":"2026-11-11 20:14:10.000000000","message":"A granted role cannot narrow a cross-project list to one project at 3.31+, but a deployer can fix that without code: resource_filters.json is deployer-editable (`resource_query_filters_file`), and adding `project_id` to the volume, snapshot or backup entry lets `all_tenants\u003d1\u0026project_id\u003dX` through `reject_invalid_filters` to the DB, which accepts the column, while a member just ANDs it with their own project. One sentence telling deployers that is more useful than describing the 400.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"afdd237339e158cb9022aa3286cf4fdafc4a97ca","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"A granted role keeps the filter rules of a non-admin. On volumes, snapshots,"},{"line_number":206,"context_line":"backups and attachments, a filter outside ``resource_filters.json``, such as"},{"line_number":207,"context_line":"``project_id``, returns HTTP 400 from 3.31 and is ignored below it. Below 3.31"},{"line_number":208,"context_line":"that means ``--project`` or ``--tenant`` returns every project. Transfers and"},{"line_number":209,"context_line":"consistency groups apply ``project_id`` as a filter at every microversion."},{"line_number":210,"context_line":"Groups and group snapshots apply it below 3.31 and return HTTP 400 from 3.31."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3e9862dd_cdd5b3a9","line":207,"in_reply_to":"aca0f2ed_477de1b0","updated":"2026-11-12 02:19:44.000000000","message":"Done, thanks. I read the path in the code and have not run it yet.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"837db8ec08e6595385faef97bda2e2ffccc88f41","unresolved":true,"context_lines":[{"line_number":207,"context_line":"``project_id``, returns HTTP 400 from 3.31 and is ignored below it. Below 3.31"},{"line_number":208,"context_line":"that means ``--project`` or ``--tenant`` returns every project. Transfers and"},{"line_number":209,"context_line":"consistency groups apply ``project_id`` as a filter at every microversion."},{"line_number":210,"context_line":"Groups and group snapshots apply it below 3.31 and return HTTP 400 from 3.31."},{"line_number":211,"context_line":"Name lookups by ``python-cinderclient`` also span every project for a granted"},{"line_number":212,"context_line":"role, except ``cgsnapshot-show``, because ``/cgsnapshots`` ignores"},{"line_number":213,"context_line":"``all_tenants``. ``openstackclient`` name lookups do not send ``all_tenants``"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7fc56dfa_072a217f","line":210,"updated":"2026-11-11 20:14:10.000000000","message":"Below 3.29 the group snapshot controller does not read the query string at all (group_snapshots.py:112-116 leaves filters None), so project_id is applied only at 3.29 and 3.30. Suggest \"Groups apply it below 3.31, group snapshots at 3.29 and 3.30, and both return HTTP 400 from 3.31\", matching 252-253.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"afdd237339e158cb9022aa3286cf4fdafc4a97ca","unresolved":false,"context_lines":[{"line_number":207,"context_line":"``project_id``, returns HTTP 400 from 3.31 and is ignored below it. Below 3.31"},{"line_number":208,"context_line":"that means ``--project`` or ``--tenant`` returns every project. Transfers and"},{"line_number":209,"context_line":"consistency groups apply ``project_id`` as a filter at every microversion."},{"line_number":210,"context_line":"Groups and group snapshots apply it below 3.31 and return HTTP 400 from 3.31."},{"line_number":211,"context_line":"Name lookups by ``python-cinderclient`` also span every project for a granted"},{"line_number":212,"context_line":"role, except ``cgsnapshot-show``, because ``/cgsnapshots`` ignores"},{"line_number":213,"context_line":"``all_tenants``. ``openstackclient`` name lookups do not send ``all_tenants``"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6835dede_5c0e2359","line":210,"in_reply_to":"7fc56dfa_072a217f","updated":"2026-11-12 02:19:44.000000000","message":"Done, you are right.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"837db8ec08e6595385faef97bda2e2ffccc88f41","unresolved":true,"context_lines":[{"line_number":256,"context_line":"A volume whose group cannot be read no longer turns a list or show into"},{"line_number":257,"context_line":"HTTP 404."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"A caller the policy denies gets its own project and HTTP 200 for any value."},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"This spec proposes no new microversion. The result for a token changes only"},{"line_number":262,"context_line":"after an operator edits the policy file, except for the cases listed above. The"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7c41b069_033bbe22","line":259,"updated":"2026-11-11 20:14:10.000000000","message":"Third statement of the denied-caller rule (80-81, 253-254). Fold it into 261-263 if it is the premise for the microversion argument, otherwise drop it.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"afdd237339e158cb9022aa3286cf4fdafc4a97ca","unresolved":false,"context_lines":[{"line_number":256,"context_line":"A volume whose group cannot be read no longer turns a list or show into"},{"line_number":257,"context_line":"HTTP 404."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"A caller the policy denies gets its own project and HTTP 200 for any value."},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"This spec proposes no new microversion. The result for a token changes only"},{"line_number":262,"context_line":"after an operator edits the policy file, except for the cases listed above. The"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1226a180_852c218b","line":259,"in_reply_to":"7c41b069_033bbe22","updated":"2026-11-12 02:19:44.000000000","message":"Done.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"837db8ec08e6595385faef97bda2e2ffccc88f41","unresolved":true,"context_lines":[{"line_number":262,"context_line":"after an operator edits the policy file, except for the cases listed above. The"},{"line_number":263,"context_line":"HTTP 400 for a granted role is on a path that did not exist before. A false"},{"line_number":264,"context_line":"value that returned the wrong projects fits the \"silently fail\" case in the"},{"line_number":265,"context_line":"microversion guide. Reviewers need to decide whether the snapshot and backup"},{"line_number":266,"context_line":"``with_count`` changes from HTTP 400 to HTTP 200 need a microversion, or should"},{"line_number":267,"context_line":"keep their HTTP 400."},{"line_number":268,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3797f4eb_3567257d","line":265,"updated":"2026-11-11 20:14:10.000000000","message":"An approved spec records decisions, so this sentence has to become one. My answer is no microversion: the 400 exists only because `calculate_resource_count` parsed `all_tenants` strictly while the list it counts parsed it loosely, so one request gave two answers to one parameter, and line 203 already says the count follows its list. Suggested replacement for 265-267: \"The snapshot and backup `with_count` requests that return HTTP 400 today for a malformed or repeated `all_tenants` are a bug, since the list they count accepts the same value; the count now returns what its list returns and needs no microversion.\" The \"false value\" sentence at 263-265 should also cover the repeated-key case at 245-247, which is the same silent failure. Same for 390-394 and 432-433: write what was agreed, not \"asks the team to confirm\" or \"if the team wants one\".","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"afdd237339e158cb9022aa3286cf4fdafc4a97ca","unresolved":false,"context_lines":[{"line_number":262,"context_line":"after an operator edits the policy file, except for the cases listed above. The"},{"line_number":263,"context_line":"HTTP 400 for a granted role is on a path that did not exist before. A false"},{"line_number":264,"context_line":"value that returned the wrong projects fits the \"silently fail\" case in the"},{"line_number":265,"context_line":"microversion guide. Reviewers need to decide whether the snapshot and backup"},{"line_number":266,"context_line":"``with_count`` changes from HTTP 400 to HTTP 200 need a microversion, or should"},{"line_number":267,"context_line":"keep their HTTP 400."},{"line_number":268,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"019f82d9_186bbef3","line":265,"in_reply_to":"3797f4eb_3567257d","updated":"2026-11-12 02:19:44.000000000","message":"Done. PS2 states the with_count 400 is a bug and needs no microversion, and the silent-fail sentence covers the repeated key.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"837db8ec08e6595385faef97bda2e2ffccc88f41","unresolved":true,"context_lines":[{"line_number":283,"context_line":"This change creates a new way to read data across projects, and a deployer has"},{"line_number":284,"context_line":"to turn it on."},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"``read_scope()`` returns an elevated context to the caller\u0027s code, after the"},{"line_number":287,"context_line":"policy passed. The objects read with it stay bound to it. Views and extensions"},{"line_number":288,"context_line":"decide what to show with the caller\u0027s context, and the list and show paths do"},{"line_number":289,"context_line":"not save those objects. A future site that called ``save()`` on one, or passed"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1eab0a73_0b519470","line":286,"updated":"2026-11-11 20:14:10.000000000","message":"286-287 and 290-292 restate 82-84 and 96-101. Two sentences suffice: \"The elevated copy from read_scope() goes only to the DB read; the list and show paths do not save the objects, and a future site that called save() on one or passed it to a write path would run that write as an admin. The unit tests check that read_scope() leaves the caller\u0027s context unchanged and that the DB listers still raise AdminRequired.\" 309-311 is a manual-test anecdote; keep 308 and drop them.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"afdd237339e158cb9022aa3286cf4fdafc4a97ca","unresolved":false,"context_lines":[{"line_number":283,"context_line":"This change creates a new way to read data across projects, and a deployer has"},{"line_number":284,"context_line":"to turn it on."},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"``read_scope()`` returns an elevated context to the caller\u0027s code, after the"},{"line_number":287,"context_line":"policy passed. The objects read with it stay bound to it. Views and extensions"},{"line_number":288,"context_line":"decide what to show with the caller\u0027s context, and the list and show paths do"},{"line_number":289,"context_line":"not save those objects. A future site that called ``save()`` on one, or passed"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f3dddcf_0967cbf4","line":286,"in_reply_to":"1eab0a73_0b519470","updated":"2026-11-12 02:19:44.000000000","message":"Done.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"837db8ec08e6595385faef97bda2e2ffccc88f41","unresolved":true,"context_lines":[{"line_number":331,"context_line":"an SDK fix to use this. ``consistency group snapshot list --all-projects`` also"},{"line_number":332,"context_line":"sends nothing, and ``/cgsnapshots`` ignores the parameter."},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"An admin who runs ``openstack volume group list``, ``volume group snapshot"},{"line_number":335,"context_line":"list``, ``volume attachment list`` or ``cinder consisgroup-list`` without an"},{"line_number":336,"context_line":"all-projects flag now gets their own project, as described in the REST API"},{"line_number":337,"context_line":"impact."}],"source_content_type":"text/x-rst","patch_set":1,"id":"f3445295_0f2fc8de","line":334,"updated":"2026-11-11 20:14:10.000000000","message":"Restates 222-225 and says so. Keep one copy.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"afdd237339e158cb9022aa3286cf4fdafc4a97ca","unresolved":false,"context_lines":[{"line_number":331,"context_line":"an SDK fix to use this. ``consistency group snapshot list --all-projects`` also"},{"line_number":332,"context_line":"sends nothing, and ``/cgsnapshots`` ignores the parameter."},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"An admin who runs ``openstack volume group list``, ``volume group snapshot"},{"line_number":335,"context_line":"list``, ``volume attachment list`` or ``cinder consisgroup-list`` without an"},{"line_number":336,"context_line":"all-projects flag now gets their own project, as described in the REST API"},{"line_number":337,"context_line":"impact."}],"source_content_type":"text/x-rst","patch_set":1,"id":"0b095819_e08a61e2","line":334,"in_reply_to":"f3445295_0f2fc8de","updated":"2026-11-12 02:19:44.000000000","message":"Done.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"837db8ec08e6595385faef97bda2e2ffccc88f41","unresolved":true,"context_lines":[{"line_number":387,"context_line":"Dependencies"},{"line_number":388,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"None in code. In the channel after the 2026-11-04 meeting, rosmaita said good"},{"line_number":391,"context_line":"progress on the most closely related tempest tests would be enough, once the"},{"line_number":392,"context_line":"patch has been read closely. This spec reads that as the reader tests for"},{"line_number":393,"context_line":"volumes, snapshots and backups in ``cinder_tempest_plugin/rbac/v3/``, and asks"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9439aa31_0f58c5e0","line":390,"updated":"2026-11-11 20:14:10.000000000","message":"396-403 is the CI investigation for change 1014269 (which skips it removes, which job fails and why), not a dependency of this design, and it goes stale as soon as that change moves. Suggest replacing 390-403 with: \"None in code. Merging change 1012421 waits on progress on the open secure-RBAC tempest tests (rosmaita, channel 2026-11-04): the reader tests for volumes, snapshots and backups in cinder_tempest_plugin/rbac/v3/, which change 1014269 shows already pass on master in cinder-tempest-plugin-protection-functional.\" If the team confirms that reading on this review, drop the hedge.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"afdd237339e158cb9022aa3286cf4fdafc4a97ca","unresolved":false,"context_lines":[{"line_number":387,"context_line":"Dependencies"},{"line_number":388,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"None in code. In the channel after the 2026-11-04 meeting, rosmaita said good"},{"line_number":391,"context_line":"progress on the most closely related tempest tests would be enough, once the"},{"line_number":392,"context_line":"patch has been read closely. This spec reads that as the reader tests for"},{"line_number":393,"context_line":"volumes, snapshots and backups in ``cinder_tempest_plugin/rbac/v3/``, and asks"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c9b0e24b_7834dd53","line":390,"in_reply_to":"9439aa31_0f58c5e0","updated":"2026-11-12 02:19:44.000000000","message":"Done. 1014269 is now the real patch, so the text says it removes the skips.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"837db8ec08e6595385faef97bda2e2ffccc88f41","unresolved":true,"context_lines":[{"line_number":408,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"Unit tests in ``cinder/tests/unit/policies/test_all_tenants.py`` cover the list"},{"line_number":411,"context_line":"path of all seven resources, the count and show paths of volumes, snapshots and"},{"line_number":412,"context_line":"backups, and the summary path of volumes, with the policy granted and denied."},{"line_number":413,"context_line":"They also check that the DB listers still raise ``AdminRequired``. They run"},{"line_number":414,"context_line":"with ``enforce_new_defaults`` both true and false."}],"source_content_type":"text/x-rst","patch_set":1,"id":"a506db9e_3cf02efb","line":411,"updated":"2026-11-11 20:14:10.000000000","message":"The pushed test file parametrises every list test over volume, snapshot and backup; transfers, groups and attachments appear only in the DB-gate test. Fine as the end state of both changes, but say so: \"...cover the list, count and show paths of volumes, snapshots and backups and the summary path of volumes; the second change adds the list path of the other four.\"","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"afdd237339e158cb9022aa3286cf4fdafc4a97ca","unresolved":false,"context_lines":[{"line_number":408,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"Unit tests in ``cinder/tests/unit/policies/test_all_tenants.py`` cover the list"},{"line_number":411,"context_line":"path of all seven resources, the count and show paths of volumes, snapshots and"},{"line_number":412,"context_line":"backups, and the summary path of volumes, with the policy granted and denied."},{"line_number":413,"context_line":"They also check that the DB listers still raise ``AdminRequired``. They run"},{"line_number":414,"context_line":"with ``enforce_new_defaults`` both true and false."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3b472ceb_588db11c","line":411,"in_reply_to":"a506db9e_3cf02efb","updated":"2026-11-12 02:19:44.000000000","message":"Done.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"837db8ec08e6595385faef97bda2e2ffccc88f41","unresolved":true,"context_lines":[{"line_number":413,"context_line":"They also check that the DB listers still raise ``AdminRequired``. They run"},{"line_number":414,"context_line":"with ``enforce_new_defaults`` both true and false."},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"No test in ``cinder_tempest_plugin/rbac/v3/`` checks what a persona gets back"},{"line_number":417,"context_line":"from ``all_tenants``. The only use is a setup check through the"},{"line_number":418,"context_line":"``project_admin`` client in ``test_snapshots.py``. A new module in"},{"line_number":419,"context_line":"``cinder_tempest_plugin/rbac/v3/`` will create a volume, a snapshot and a"}],"source_content_type":"text/x-rst","patch_set":1,"id":"66854897_97513f3a","line":416,"updated":"2026-11-11 20:14:10.000000000","message":"Three sentences carry this section: a new module in cinder_tempest_plugin/rbac/v3/ creates a volume, a snapshot and a backup as project_alt_member, then lists each with all_tenants\u003d1 and shows each by id as project_admin (sees them) and as project_member and project_reader (list returns 200 with their own project, show returns 404); it runs with default policy in cinder-tempest-plugin-protection-functional and also passes on master, so it guards against regression rather than proving the feature; a granted role needs a policy override and is covered by the unit tests, and no tempest job for it is planned. That last clause is the third undecided point; decide it here.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"afdd237339e158cb9022aa3286cf4fdafc4a97ca","unresolved":false,"context_lines":[{"line_number":413,"context_line":"They also check that the DB listers still raise ``AdminRequired``. They run"},{"line_number":414,"context_line":"with ``enforce_new_defaults`` both true and false."},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"No test in ``cinder_tempest_plugin/rbac/v3/`` checks what a persona gets back"},{"line_number":417,"context_line":"from ``all_tenants``. The only use is a setup check through the"},{"line_number":418,"context_line":"``project_admin`` client in ``test_snapshots.py``. A new module in"},{"line_number":419,"context_line":"``cinder_tempest_plugin/rbac/v3/`` will create a volume, a snapshot and a"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dd6967f6_60b40b86","line":416,"in_reply_to":"66854897_97513f3a","updated":"2026-11-12 02:19:44.000000000","message":"Done. PS2 says no tempest job is planned for the granted case.","commit_id":"7c99d2f337347d6a9b6c5f65fa96a308e0a237a6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"0430136104531cb65d4e70a09b2016068ac1e1cd","unresolved":true,"context_lines":[{"line_number":77,"context_line":"``all_tenants`` policy, the controller runs a one-row list across projects."},{"line_number":78,"context_line":"The fallback checks the list policy and the ``all_tenants`` policy. It does not"},{"line_number":79,"context_line":"check ``volume:get``, ``volume:get_snapshot`` or ``backup:get`` against the row"},{"line_number":80,"context_line":"it returns. A denial by one of those policies on a row in the caller\u0027s own"},{"line_number":81,"context_line":"project stays a 404. ``volume_api.get()``, ``get_snapshot()`` and"},{"line_number":82,"context_line":"``backup_api.get()`` stay project scoped, because write paths fetch their"},{"line_number":83,"context_line":"target through them."}],"source_content_type":"text/x-rst","patch_set":2,"id":"57e431e8_b76b5410","line":80,"updated":"2026-11-12 16:59:19.000000000","message":"True for volumes only: `volume_api.get()` turns a `volume:get` denial into `VolumeNotFound` (`volume/api.py:601-606`), but `get_snapshot()` and `backup_api.get()` raise `PolicyNotAuthorized`, which the fallback does not catch, so those are a 403 today and after; 1012421 PS4\u0027s own test asserts that split. PS1 said it for volumes only and was right. Suggest: \"A denial by one of those policies on the caller\u0027s own row keeps today\u0027s status, a 404 for a volume and a 403 for a snapshot or backup.\" Also at 76, PS4 skips the fallback for an admin before the policy check, so make it \"and the caller is not an admin but passes the resource\u0027s all_tenants policy\".","commit_id":"785dbdafc0d18d0496fe4557213a993d77945e10"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"7153a08b25d1afed5cbf38a511e160735039679f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"``all_tenants`` policy, the controller runs a one-row list across projects."},{"line_number":78,"context_line":"The fallback checks the list policy and the ``all_tenants`` policy. It does not"},{"line_number":79,"context_line":"check ``volume:get``, ``volume:get_snapshot`` or ``backup:get`` against the row"},{"line_number":80,"context_line":"it returns. A denial by one of those policies on a row in the caller\u0027s own"},{"line_number":81,"context_line":"project stays a 404. ``volume_api.get()``, ``get_snapshot()`` and"},{"line_number":82,"context_line":"``backup_api.get()`` stay project scoped, because write paths fetch their"},{"line_number":83,"context_line":"target through them."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9dd1c69a_3510db3c","line":80,"in_reply_to":"57e431e8_b76b5410","updated":"2026-11-13 03:58:47.000000000","message":"Done in PS3, 404 for a volume and 403 for a snapshot or backup, and the admin skip at 76.","commit_id":"785dbdafc0d18d0496fe4557213a993d77945e10"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"0430136104531cb65d4e70a09b2016068ac1e1cd","unresolved":true,"context_lines":[{"line_number":152,"context_line":"not boolean  volumes, backups              HTTP 400      HTTP 400"},{"line_number":153,"context_line":"not boolean  snapshots, transfers          own project   own project"},{"line_number":154,"context_line":"not boolean  groups and attachments        every project every project"},{"line_number":155,"context_line":"repeated key snapshots, backups, transfers empty list    first value"},{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Volumes read the last value of a repeated key, as they do today."}],"source_content_type":"text/x-rst","patch_set":2,"id":"f85acabe_d957eee9","line":155,"updated":"2026-11-12 16:59:19.000000000","message":"Groups and attachments have no repeated-key row, yet an admin\u0027s result changes there: today `\u0027all_tenants\u0027 in filters` plus `del` (`group/api.py:824-825`, `v3/attachments.py:97-98`) gives every project for any repeated value, and `read_scope()` reads the first value for every resource but volumes, so `all_tenants\u003d0\u0026all_tenants\u003d1` moves an admin from every project to its own. Add the row `repeated key | groups and attachments | every project | first value`; 142-143 already extends it to consistency groups and group snapshots.","commit_id":"785dbdafc0d18d0496fe4557213a993d77945e10"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"7153a08b25d1afed5cbf38a511e160735039679f","unresolved":false,"context_lines":[{"line_number":152,"context_line":"not boolean  volumes, backups              HTTP 400      HTTP 400"},{"line_number":153,"context_line":"not boolean  snapshots, transfers          own project   own project"},{"line_number":154,"context_line":"not boolean  groups and attachments        every project every project"},{"line_number":155,"context_line":"repeated key snapshots, backups, transfers empty list    first value"},{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Volumes read the last value of a repeated key, as they do today."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7c23e867_612c5a10","line":155,"in_reply_to":"f85acabe_d957eee9","updated":"2026-11-13 03:58:47.000000000","message":"Done, added the row.","commit_id":"785dbdafc0d18d0496fe4557213a993d77945e10"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"0430136104531cb65d4e70a09b2016068ac1e1cd","unresolved":true,"context_lines":[{"line_number":155,"context_line":"repeated key snapshots, backups, transfers empty list    first value"},{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Volumes read the last value of a repeated key, as they do today."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"A granted role gets every project for a true value, its own project for a"},{"line_number":161,"context_line":"false value, and HTTP 400 for a value that is not a boolean. A caller the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"6e9c38b7_961108f8","line":158,"updated":"2026-11-12 16:59:19.000000000","message":"`check_volume_filters` runs `ast.literal_eval` on each repeated value before read_scope() sees it, so `1\u0026bogus` reads every project today and after for an admin and a granted role alike, where \"last value\" with row 152 predicts a 400; 1012421\u0027s policy-personas.rst says \"the last value that parses\". Suggest: \"For a repeated key, volumes read the last value that parses, as they do today, and a value such as 0x1 that literal_eval reads as a number counts as true.\"","commit_id":"785dbdafc0d18d0496fe4557213a993d77945e10"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"7153a08b25d1afed5cbf38a511e160735039679f","unresolved":false,"context_lines":[{"line_number":155,"context_line":"repeated key snapshots, backups, transfers empty list    first value"},{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Volumes read the last value of a repeated key, as they do today."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"A granted role gets every project for a true value, its own project for a"},{"line_number":161,"context_line":"false value, and HTTP 400 for a value that is not a boolean. A caller the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e8fc360b_1bddba57","line":158,"in_reply_to":"6e9c38b7_961108f8","updated":"2026-11-13 03:58:47.000000000","message":"Done, used your sentence.","commit_id":"785dbdafc0d18d0496fe4557213a993d77945e10"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"0430136104531cb65d4e70a09b2016068ac1e1cd","unresolved":true,"context_lines":[{"line_number":160,"context_line":"A granted role gets every project for a true value, its own project for a"},{"line_number":161,"context_line":"false value, and HTTP 400 for a value that is not a boolean. A caller the"},{"line_number":162,"context_line":"policy denies gets its own project. Today that caller gets an empty list on"},{"line_number":163,"context_line":"consistency groups, and on groups and group snapshots below 3.31. For a"},{"line_number":164,"context_line":"repeated key it gets HTTP 500, HTTP 400 or an empty list today."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"``with_count`` returns what its list returns. Today a snapshot count returns"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e1b65b00_f133e4cf","line":163,"updated":"2026-11-12 16:59:19.000000000","message":"Below 3.29 the group snapshot controller does not read the query string (group_snapshots.py:112-116), so a denied caller gets its own project there, not an empty list. Say \"on groups below 3.31 and on group snapshots at 3.29 and 3.30\", as 178 already does for project_id.","commit_id":"785dbdafc0d18d0496fe4557213a993d77945e10"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"7153a08b25d1afed5cbf38a511e160735039679f","unresolved":false,"context_lines":[{"line_number":160,"context_line":"A granted role gets every project for a true value, its own project for a"},{"line_number":161,"context_line":"false value, and HTTP 400 for a value that is not a boolean. A caller the"},{"line_number":162,"context_line":"policy denies gets its own project. Today that caller gets an empty list on"},{"line_number":163,"context_line":"consistency groups, and on groups and group snapshots below 3.31. For a"},{"line_number":164,"context_line":"repeated key it gets HTTP 500, HTTP 400 or an empty list today."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"``with_count`` returns what its list returns. Today a snapshot count returns"}],"source_content_type":"text/x-rst","patch_set":2,"id":"a82e9286_db43e030","line":163,"in_reply_to":"e1b65b00_f133e4cf","updated":"2026-11-13 03:58:47.000000000","message":"Done.","commit_id":"785dbdafc0d18d0496fe4557213a993d77945e10"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"0430136104531cb65d4e70a09b2016068ac1e1cd","unresolved":true,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"``with_count`` returns what its list returns. Today a snapshot count returns"},{"line_number":167,"context_line":"HTTP 400 to an admin for a value that is not a boolean, and a snapshot or"},{"line_number":168,"context_line":"backup count does the same for a repeated key, while the list they count"},{"line_number":169,"context_line":"accepts the value. That is a bug, and the fix needs no microversion. A count"},{"line_number":170,"context_line":"for a false value returns 0 today on volumes, snapshots and backups, and"},{"line_number":171,"context_line":"becomes the real count."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1d2077c3_627f8d87","line":168,"updated":"2026-11-12 16:59:19.000000000","message":"Only a repeated key whose last value is not a boolean gives the count a 400 today: `calculate_resource_count` reads the last value with `get_bool_param` (`volume/api.py:623`), so `all_tenants\u003d1\u0026all_tenants\u003d1\u0026with_count\u003dtrue` returns 200 with an empty list and a count of every project (probed on master). Suggest \"does the same for a repeated key whose last value is not a boolean\"; the 1\u00261 mismatch is covered by \"with_count returns what its list returns\".","commit_id":"785dbdafc0d18d0496fe4557213a993d77945e10"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"7153a08b25d1afed5cbf38a511e160735039679f","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"``with_count`` returns what its list returns. Today a snapshot count returns"},{"line_number":167,"context_line":"HTTP 400 to an admin for a value that is not a boolean, and a snapshot or"},{"line_number":168,"context_line":"backup count does the same for a repeated key, while the list they count"},{"line_number":169,"context_line":"accepts the value. That is a bug, and the fix needs no microversion. A count"},{"line_number":170,"context_line":"for a false value returns 0 today on volumes, snapshots and backups, and"},{"line_number":171,"context_line":"becomes the real count."}],"source_content_type":"text/x-rst","patch_set":2,"id":"6f28b5d5_cc351780","line":168,"in_reply_to":"1d2077c3_627f8d87","updated":"2026-11-13 03:58:47.000000000","message":"Done.","commit_id":"785dbdafc0d18d0496fe4557213a993d77945e10"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"0430136104531cb65d4e70a09b2016068ac1e1cd","unresolved":true,"context_lines":[{"line_number":168,"context_line":"backup count does the same for a repeated key, while the list they count"},{"line_number":169,"context_line":"accepts the value. That is a bug, and the fix needs no microversion. A count"},{"line_number":170,"context_line":"for a false value returns 0 today on volumes, snapshots and backups, and"},{"line_number":171,"context_line":"becomes the real count."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"A granted role keeps the filter rules of a non-admin. From microversion 3.31,"},{"line_number":174,"context_line":"``project_id`` returns HTTP 400 unless the deployer adds it to the resource\u0027s"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b6a7cda1_6905bd8d","line":171,"updated":"2026-11-12 16:59:19.000000000","message":"The cut dropped PS1\u0027s \"A volume whose group cannot be read no longer turns a list or show into HTTP 404.\" 1012421 PS4 still makes that change (views/volumes.py reads volume.group under a GroupNotFound catch), tests it, and lists it as a fix in its release note, and this spec is the design record for that status change. Restore the one sentence after this paragraph.","commit_id":"785dbdafc0d18d0496fe4557213a993d77945e10"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"7153a08b25d1afed5cbf38a511e160735039679f","unresolved":false,"context_lines":[{"line_number":168,"context_line":"backup count does the same for a repeated key, while the list they count"},{"line_number":169,"context_line":"accepts the value. That is a bug, and the fix needs no microversion. A count"},{"line_number":170,"context_line":"for a false value returns 0 today on volumes, snapshots and backups, and"},{"line_number":171,"context_line":"becomes the real count."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"A granted role keeps the filter rules of a non-admin. From microversion 3.31,"},{"line_number":174,"context_line":"``project_id`` returns HTTP 400 unless the deployer adds it to the resource\u0027s"}],"source_content_type":"text/x-rst","patch_set":2,"id":"a4dda281_fe4fff08","line":171,"in_reply_to":"b6a7cda1_6905bd8d","updated":"2026-11-13 03:58:47.000000000","message":"Restored, now with 403 too, since 1012421 PS5 also drops the group:get check for the alias.","commit_id":"785dbdafc0d18d0496fe4557213a993d77945e10"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"0430136104531cb65d4e70a09b2016068ac1e1cd","unresolved":true,"context_lines":[{"line_number":174,"context_line":"``project_id`` returns HTTP 400 unless the deployer adds it to the resource\u0027s"},{"line_number":175,"context_line":"entry in ``resource_filters.json``. With that entry, a granted role can narrow"},{"line_number":176,"context_line":"a cross-project list of volumes, snapshots or backups to one project. Below"},{"line_number":177,"context_line":"3.31 those lists and attachments ignore ``project_id``. Groups apply it below"},{"line_number":178,"context_line":"3.31 and group snapshots at 3.29 and 3.30. Transfers and consistency groups"},{"line_number":179,"context_line":"apply it at every microversion."},{"line_number":180,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf56fddc_dbb0b2f1","line":177,"updated":"2026-11-12 16:59:19.000000000","message":"Volumes read resource_filters.json below 3.31 as well (v3/volumes.py:109-111 feeds the legacy validator), so with the entry the previous sentence recommends, the volume list applies project_id at every microversion; only snapshots, backups and attachments use hardcoded tuples there. Suggest: \"Below 3.31, snapshots, backups and attachments ignore project_id; with that entry volumes apply it at every microversion.\"","commit_id":"785dbdafc0d18d0496fe4557213a993d77945e10"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"7153a08b25d1afed5cbf38a511e160735039679f","unresolved":false,"context_lines":[{"line_number":174,"context_line":"``project_id`` returns HTTP 400 unless the deployer adds it to the resource\u0027s"},{"line_number":175,"context_line":"entry in ``resource_filters.json``. With that entry, a granted role can narrow"},{"line_number":176,"context_line":"a cross-project list of volumes, snapshots or backups to one project. Below"},{"line_number":177,"context_line":"3.31 those lists and attachments ignore ``project_id``. Groups apply it below"},{"line_number":178,"context_line":"3.31 and group snapshots at 3.29 and 3.30. Transfers and consistency groups"},{"line_number":179,"context_line":"apply it at every microversion."},{"line_number":180,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5c64797c_c9b2f712","line":177,"in_reply_to":"bf56fddc_dbb0b2f1","updated":"2026-11-13 03:58:47.000000000","message":"Done.","commit_id":"785dbdafc0d18d0496fe4557213a993d77945e10"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"0430136104531cb65d4e70a09b2016068ac1e1cd","unresolved":true,"context_lines":[{"line_number":183,"context_line":"The second change implements this."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"This spec proposes no new microversion. The result for a token changes only"},{"line_number":186,"context_line":"after an operator edits the policy file, except for the rows of the table"},{"line_number":187,"context_line":"where the two columns differ. A false value or a repeated key that returned"},{"line_number":188,"context_line":"the wrong projects fits the \"silently fail\" case in the microversion guide."},{"line_number":189,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dda5730d_72455a65","line":186,"updated":"2026-11-12 16:59:19.000000000","message":"The table shows an admin only, so \"except for the rows of the table where the two columns differ\" omits changes that also need no policy edit and that this section lists: the denied caller\u0027s results at 162-164 (empty list, HTTP 500 or HTTP 400 today, own project after) and the with_count fix at 166-171. Suggest: \"The result for a token changes only after an operator edits the policy file, except for the table rows where the two columns differ, the denied caller\u0027s results above, and the with_count fix.\" Then 187-188 should say the HTTP 500 and 400 for a repeated key came from a validator that removed one copy of the key, so they are bugs too.","commit_id":"785dbdafc0d18d0496fe4557213a993d77945e10"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"7153a08b25d1afed5cbf38a511e160735039679f","unresolved":false,"context_lines":[{"line_number":183,"context_line":"The second change implements this."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"This spec proposes no new microversion. The result for a token changes only"},{"line_number":186,"context_line":"after an operator edits the policy file, except for the rows of the table"},{"line_number":187,"context_line":"where the two columns differ. A false value or a repeated key that returned"},{"line_number":188,"context_line":"the wrong projects fits the \"silently fail\" case in the microversion guide."},{"line_number":189,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ca80e0ff_ec0e00d2","line":186,"in_reply_to":"dda5730d_72455a65","updated":"2026-11-13 03:58:47.000000000","message":"Done, both sentences.","commit_id":"785dbdafc0d18d0496fe4557213a993d77945e10"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cff61e0c70c25165990b4b9fb98672b2364b8aba","unresolved":true,"context_lines":[{"line_number":65,"context_line":"* A caller that passes the policy and sends a true value gets an elevated copy"},{"line_number":66,"context_line":"  of the context, and the site reads every project with that copy."},{"line_number":67,"context_line":"* A caller that passes the policy and sends a false value gets its own project."},{"line_number":68,"context_line":"* A value that is not a boolean returns HTTP 400. The exception is an admin on"},{"line_number":69,"context_line":"  a resource that accepts such a value today. The admin keeps today\u0027s result."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"The DB layer does not change. The listers keep ``@require_admin_context``, so"},{"line_number":72,"context_line":"a list path that skips ``read_scope()`` fails with ``AdminRequired``."}],"source_content_type":"text/x-rst","patch_set":3,"id":"2309e52c_07fa2138","line":69,"range":{"start_line":68,"start_character":50,"end_line":69,"end_character":77},"updated":"2026-11-14 15:18:48.000000000","message":"What exactly are you referring to here?  Note that what counts as a \"boolean\" value in the REST API is kind of loose:\nhttps://docs.openstack.org/api-ref/block-storage/v3/#valid-boolean-values\n\nIs that what you mean, or are you talking about something else?","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"b81a8cb14ce6c3e271768e5d26bc57a8175e7ca4","unresolved":true,"context_lines":[{"line_number":66,"context_line":"  of the context, and the site reads every project with that copy."},{"line_number":67,"context_line":"* A caller that passes the policy and sends a false value gets its own project."},{"line_number":68,"context_line":"* A value that is not a boolean returns HTTP 400. The exception is an admin on"},{"line_number":69,"context_line":"  a resource that accepts such a value today. The admin keeps today\u0027s result."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"The DB layer does not change. The listers keep ``@require_admin_context``, so"},{"line_number":72,"context_line":"a list path that skips ``read_scope()`` fails with ``AdminRequired``."}],"source_content_type":"text/x-rst","patch_set":3,"id":"2b7f597b_5dae450c","line":69,"in_reply_to":"2309e52c_07fa2138","updated":"2026-11-16 02:05:39.000000000","message":"Yes, that list. The value goes through utils.get_bool_param, so strutils.bool_from_string with strict\u003dTrue: 1, t, true, on, y, yes and 0, f, false, off, n, no, in any case. Anything else is what the spec calls not a boolean. I\u0027ll link that api-ref section in the next patch set.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cff61e0c70c25165990b4b9fb98672b2364b8aba","unresolved":true,"context_lines":[{"line_number":72,"context_line":"a list path that skips ``read_scope()`` fails with ``AdminRequired``."},{"line_number":73,"context_line":"``context.is_admin`` of the caller does not change."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Show gets a fallback for volumes, snapshots and backups only. If the"},{"line_number":76,"context_line":"project-scoped lookup returns not found and the caller is not an admin but"},{"line_number":77,"context_line":"passes the resource\u0027s ``all_tenants`` policy, the controller runs a one-row"},{"line_number":78,"context_line":"list across projects."}],"source_content_type":"text/x-rst","patch_set":3,"id":"39388179_d77a556d","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":20},"updated":"2026-11-14 15:18:48.000000000","message":"I don\u0027t understand what you are talking about here.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"b81a8cb14ce6c3e271768e5d26bc57a8175e7ca4","unresolved":true,"context_lines":[{"line_number":72,"context_line":"a list path that skips ``read_scope()`` fails with ``AdminRequired``."},{"line_number":73,"context_line":"``context.is_admin`` of the caller does not change."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Show gets a fallback for volumes, snapshots and backups only. If the"},{"line_number":76,"context_line":"project-scoped lookup returns not found and the caller is not an admin but"},{"line_number":77,"context_line":"passes the resource\u0027s ``all_tenants`` policy, the controller runs a one-row"},{"line_number":78,"context_line":"list across projects."}],"source_content_type":"text/x-rst","patch_set":3,"id":"4409ed2c_17621c51","line":75,"in_reply_to":"39388179_d77a556d","updated":"2026-11-16 02:05:39.000000000","message":"Sorry, that got too terse when I cut the spec down. Today GET /volumes/{id} only looks in the caller\u0027s project, so a reader that is allowed to list every project sees another project\u0027s volume in the list and then gets a 404 when it shows it. The fallback closes that gap. If the project-scoped lookup misses and the caller passes the all_tenants rule, the controller reads that one row across projects. I\u0027ll reword the paragraph in the next patch set.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"07356205dca422ac7e02ea520cb2c7277f7f4f91","unresolved":true,"context_lines":[{"line_number":133,"context_line":"---------------"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"No new method, parameter or response field. The request and response schemas"},{"line_number":136,"context_line":"do not change."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"With a policy granted, the list and detail methods of the seven resources and"},{"line_number":139,"context_line":"of consistency groups return other projects\u0027 resources to the granted role. So"}],"source_content_type":"text/x-rst","patch_set":3,"id":"89bcfe74_92153375","line":136,"updated":"2026-11-16 15:40:50.000000000","message":"add: Hence, this change does not require a new microversion.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"735dd57eeb6f8494266377ef5772446d38df9d2a","unresolved":false,"context_lines":[{"line_number":133,"context_line":"---------------"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"No new method, parameter or response field. The request and response schemas"},{"line_number":136,"context_line":"do not change."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"With a policy granted, the list and detail methods of the seven resources and"},{"line_number":139,"context_line":"of consistency groups return other projects\u0027 resources to the granted role. So"}],"source_content_type":"text/x-rst","patch_set":3,"id":"db2b3b7d_4a816914","line":136,"in_reply_to":"89bcfe74_92153375","updated":"2026-11-18 02:43:41.000000000","message":"Done.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"07356205dca422ac7e02ea520cb2c7277f7f4f91","unresolved":true,"context_lines":[{"line_number":150,"context_line":"true         all                           every project every project"},{"line_number":151,"context_line":"false        volumes                       empty list    own project"},{"line_number":152,"context_line":"false        snapshots, backups, transfers own project   own project"},{"line_number":153,"context_line":"false        groups and attachments        every project own project"},{"line_number":154,"context_line":"not boolean  volumes, backups              HTTP 400      HTTP 400"},{"line_number":155,"context_line":"not boolean  snapshots, transfers          own project   own project"},{"line_number":156,"context_line":"not boolean  groups and attachments        every project every project"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9d4423ef_caebe25d","line":153,"range":{"start_line":153,"start_character":43,"end_line":153,"end_character":56},"updated":"2026-11-16 15:40:50.000000000","message":"I think you need to file a bug for this, otherwise you are changing API behavior which would require a microversion.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"735dd57eeb6f8494266377ef5772446d38df9d2a","unresolved":false,"context_lines":[{"line_number":150,"context_line":"true         all                           every project every project"},{"line_number":151,"context_line":"false        volumes                       empty list    own project"},{"line_number":152,"context_line":"false        snapshots, backups, transfers own project   own project"},{"line_number":153,"context_line":"false        groups and attachments        every project own project"},{"line_number":154,"context_line":"not boolean  volumes, backups              HTTP 400      HTTP 400"},{"line_number":155,"context_line":"not boolean  snapshots, transfers          own project   own project"},{"line_number":156,"context_line":"not boolean  groups and attachments        every project every project"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5ef9a57d_99e307be","line":153,"in_reply_to":"9d4423ef_caebe25d","updated":"2026-11-18 02:43:41.000000000","message":"Done, bug 2174799.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"07356205dca422ac7e02ea520cb2c7277f7f4f91","unresolved":true,"context_lines":[{"line_number":151,"context_line":"false        volumes                       empty list    own project"},{"line_number":152,"context_line":"false        snapshots, backups, transfers own project   own project"},{"line_number":153,"context_line":"false        groups and attachments        every project own project"},{"line_number":154,"context_line":"not boolean  volumes, backups              HTTP 400      HTTP 400"},{"line_number":155,"context_line":"not boolean  snapshots, transfers          own project   own project"},{"line_number":156,"context_line":"not boolean  groups and attachments        every project every project"},{"line_number":157,"context_line":"repeated key snapshots, backups, transfers empty list    first value"},{"line_number":158,"context_line":"repeated key groups and attachments        every project first value"},{"line_number":159,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c882b3c2_93de1198","line":156,"range":{"start_line":154,"start_character":0,"end_line":156,"end_character":70},"updated":"2026-11-16 15:40:50.000000000","message":"These should all be returning 400s.  I particularly don\u0027t like the current inconsistent behavior.  I suggest we file bugs and then fix it to return 400s in these cases.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"735dd57eeb6f8494266377ef5772446d38df9d2a","unresolved":false,"context_lines":[{"line_number":153,"context_line":"false        groups and attachments        every project own project"},{"line_number":154,"context_line":"not boolean  volumes, backups              HTTP 400      HTTP 400"},{"line_number":155,"context_line":"not boolean  snapshots, transfers          own project   own project"},{"line_number":156,"context_line":"not boolean  groups and attachments        every project every project"},{"line_number":157,"context_line":"repeated key snapshots, backups, transfers empty list    first value"},{"line_number":158,"context_line":"repeated key groups and attachments        every project first value"},{"line_number":159,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"a290f516_3d9de080","line":156,"in_reply_to":"c882b3c2_93de1198","updated":"2026-11-18 02:43:41.000000000","message":"Agreed. Bugs 2174795 and 2174796, both asking for a 400.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"07356205dca422ac7e02ea520cb2c7277f7f4f91","unresolved":true,"context_lines":[{"line_number":159,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"For a repeated key, volumes read the last value that parses, as they do today,"},{"line_number":162,"context_line":"and a value such as ``0x1`` that ``literal_eval`` reads as a number counts as"},{"line_number":163,"context_line":"true."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"A granted role gets every project for a true value, its own project for a"},{"line_number":166,"context_line":"false value, and HTTP 400 for a value that is not a boolean. A caller the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3904d39d_e4f5225f","line":163,"range":{"start_line":162,"start_character":6,"end_line":163,"end_character":5},"updated":"2026-11-16 15:40:50.000000000","message":"We\u0027re talking REST API here, so Ox1 would be a literal string of three characters zero, \u0027x\u0027, one, and that would not meet the REST API definition of what counts as a boolean.  So please remove this phrase.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"735dd57eeb6f8494266377ef5772446d38df9d2a","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"For a repeated key, volumes read the last value that parses, as they do today,"},{"line_number":162,"context_line":"and a value such as ``0x1`` that ``literal_eval`` reads as a number counts as"},{"line_number":163,"context_line":"true."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"A granted role gets every project for a true value, its own project for a"},{"line_number":166,"context_line":"false value, and HTTP 400 for a value that is not a boolean. A caller the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"504c1298_ba08d989","line":163,"in_reply_to":"3904d39d_e4f5225f","updated":"2026-11-18 02:43:41.000000000","message":"Done, removed.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"1742ad602ecd7c745656ef5c57b7ef5f43ba3b03","unresolved":true,"context_lines":[{"line_number":166,"context_line":"false value, and HTTP 400 for a value that is not a boolean. A caller the"},{"line_number":167,"context_line":"policy denies gets its own project. Today that caller gets an empty list on"},{"line_number":168,"context_line":"consistency groups, on groups below 3.31 and on group snapshots at 3.29 and"},{"line_number":169,"context_line":"3.30. For a"},{"line_number":170,"context_line":"repeated key it gets HTTP 500, HTTP 400 or an empty list today."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"``with_count`` returns what its list returns. Today a snapshot count returns"}],"source_content_type":"text/x-rst","patch_set":3,"id":"0851ad4f_7153801a","line":169,"updated":"2026-11-13 14:39:47.000000000","message":"nit: The edits left short lines mid-paragraph here, at 78 and at 83. Rendering is unaffected; rewrap at 79 columns if you touch the file again.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"07356205dca422ac7e02ea520cb2c7277f7f4f91","unresolved":true,"context_lines":[{"line_number":169,"context_line":"3.30. For a"},{"line_number":170,"context_line":"repeated key it gets HTTP 500, HTTP 400 or an empty list today."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"``with_count`` returns what its list returns. Today a snapshot count returns"},{"line_number":173,"context_line":"HTTP 400 to an admin for a value that is not a boolean, and a snapshot or"},{"line_number":174,"context_line":"backup count does the same for a repeated key whose last value is not a"},{"line_number":175,"context_line":"boolean, while the list they count accepts the value. That is a bug, and the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"40e9d496_022ef757","line":172,"range":{"start_line":172,"start_character":1,"end_line":172,"end_character":45},"updated":"2026-11-16 15:40:50.000000000","message":"Please be precise. It\u0027s supposed to return the resource count before pagination is applied","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"1496e0d5ada6f74af8a143c1b213875aa72035b3","unresolved":false,"context_lines":[{"line_number":169,"context_line":"3.30. For a"},{"line_number":170,"context_line":"repeated key it gets HTTP 500, HTTP 400 or an empty list today."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"``with_count`` returns what its list returns. Today a snapshot count returns"},{"line_number":173,"context_line":"HTTP 400 to an admin for a value that is not a boolean, and a snapshot or"},{"line_number":174,"context_line":"backup count does the same for a repeated key whose last value is not a"},{"line_number":175,"context_line":"boolean, while the list they count accepts the value. That is a bug, and the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"2574295b_030b247e","line":172,"in_reply_to":"40e9d496_022ef757","updated":"2026-11-18 02:47:36.000000000","message":"Done.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"07356205dca422ac7e02ea520cb2c7277f7f4f91","unresolved":true,"context_lines":[{"line_number":173,"context_line":"HTTP 400 to an admin for a value that is not a boolean, and a snapshot or"},{"line_number":174,"context_line":"backup count does the same for a repeated key whose last value is not a"},{"line_number":175,"context_line":"boolean, while the list they count accepts the value. That is a bug, and the"},{"line_number":176,"context_line":"fix needs no microversion. A count for a false value returns 0 today on"},{"line_number":177,"context_line":"volumes, snapshots and backups, and becomes the real count."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"A volume whose group cannot be read no longer turns a list or show into"},{"line_number":180,"context_line":"HTTP 404 or HTTP 403."}],"source_content_type":"text/x-rst","patch_set":3,"id":"4d09807d_7259f215","line":177,"range":{"start_line":176,"start_character":26,"end_line":177,"end_character":59},"updated":"2026-11-16 15:40:50.000000000","message":"This certainly does not seem correct.  If you say with_count\u003dfalse, then you should not get a count in the response.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"1496e0d5ada6f74af8a143c1b213875aa72035b3","unresolved":false,"context_lines":[{"line_number":174,"context_line":"backup count does the same for a repeated key whose last value is not a"},{"line_number":175,"context_line":"boolean, while the list they count accepts the value. That is a bug, and the"},{"line_number":176,"context_line":"fix needs no microversion. A count for a false value returns 0 today on"},{"line_number":177,"context_line":"volumes, snapshots and backups, and becomes the real count."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"A volume whose group cannot be read no longer turns a list or show into"},{"line_number":180,"context_line":"HTTP 404 or HTTP 403."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ac2c23b7_7f55e085","line":177,"in_reply_to":"4d09807d_7259f215","updated":"2026-11-18 02:47:36.000000000","message":"Sorry, that was unclear. It is with_count\u003dtrue with all_tenants\u003dfalse: an admin gets their own rows and \"count\": 0. That is bug 2174798 now.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"07356205dca422ac7e02ea520cb2c7277f7f4f91","unresolved":true,"context_lines":[{"line_number":176,"context_line":"fix needs no microversion. A count for a false value returns 0 today on"},{"line_number":177,"context_line":"volumes, snapshots and backups, and becomes the real count."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"A volume whose group cannot be read no longer turns a list or show into"},{"line_number":180,"context_line":"HTTP 404 or HTTP 403."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"A granted role keeps the filter rules of a non-admin. From microversion 3.31,"},{"line_number":183,"context_line":"``project_id`` returns HTTP 400 unless the deployer adds it to the resource\u0027s"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c04872e0_973473ee","line":180,"range":{"start_line":179,"start_character":0,"end_line":180,"end_character":20},"updated":"2026-11-16 15:40:50.000000000","message":"Either this is a bug or intended behavior.  In either case, it shouldn\u0027t be buried in this section as something that is just going to happen.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"1496e0d5ada6f74af8a143c1b213875aa72035b3","unresolved":false,"context_lines":[{"line_number":177,"context_line":"volumes, snapshots and backups, and becomes the real count."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"A volume whose group cannot be read no longer turns a list or show into"},{"line_number":180,"context_line":"HTTP 404 or HTTP 403."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"A granted role keeps the filter rules of a non-admin. From microversion 3.31,"},{"line_number":183,"context_line":"``project_id`` returns HTTP 400 unless the deployer adds it to the resource\u0027s"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c73cc571_bfc1d846","line":180,"in_reply_to":"c04872e0_973473ee","updated":"2026-11-18 02:47:36.000000000","message":"Intended. Without it a cross-project list fails with a 404 on the first volume whose group is in another project. It is in Proposed change now.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"07356205dca422ac7e02ea520cb2c7277f7f4f91","unresolved":true,"context_lines":[{"line_number":179,"context_line":"A volume whose group cannot be read no longer turns a list or show into"},{"line_number":180,"context_line":"HTTP 404 or HTTP 403."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"A granted role keeps the filter rules of a non-admin. From microversion 3.31,"},{"line_number":183,"context_line":"``project_id`` returns HTTP 400 unless the deployer adds it to the resource\u0027s"},{"line_number":184,"context_line":"entry in ``resource_filters.json``. With that entry, a granted role can narrow"},{"line_number":185,"context_line":"a cross-project list of volumes, snapshots or backups to one project. Below"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d07c885d_4d4cc278","line":182,"range":{"start_line":182,"start_character":2,"end_line":182,"end_character":14},"updated":"2026-11-16 15:40:50.000000000","message":"All this \"granted role\" talk is misleading.  You are introducing a policy, so we are talking about any user that satisfies the policy.  One way to do that is to grant a specific role, but there are other ways.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"1496e0d5ada6f74af8a143c1b213875aa72035b3","unresolved":false,"context_lines":[{"line_number":179,"context_line":"A volume whose group cannot be read no longer turns a list or show into"},{"line_number":180,"context_line":"HTTP 404 or HTTP 403."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"A granted role keeps the filter rules of a non-admin. From microversion 3.31,"},{"line_number":183,"context_line":"``project_id`` returns HTTP 400 unless the deployer adds it to the resource\u0027s"},{"line_number":184,"context_line":"entry in ``resource_filters.json``. With that entry, a granted role can narrow"},{"line_number":185,"context_line":"a cross-project list of volumes, snapshots or backups to one project. Below"}],"source_content_type":"text/x-rst","patch_set":3,"id":"4d2c9ec5_5fd481cc","line":182,"in_reply_to":"d07c885d_4d4cc278","updated":"2026-11-18 02:47:36.000000000","message":"Done, the spec says a user who passes the policy.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"07356205dca422ac7e02ea520cb2c7277f7f4f91","unresolved":true,"context_lines":[{"line_number":180,"context_line":"HTTP 404 or HTTP 403."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"A granted role keeps the filter rules of a non-admin. From microversion 3.31,"},{"line_number":183,"context_line":"``project_id`` returns HTTP 400 unless the deployer adds it to the resource\u0027s"},{"line_number":184,"context_line":"entry in ``resource_filters.json``. With that entry, a granted role can narrow"},{"line_number":185,"context_line":"a cross-project list of volumes, snapshots or backups to one project. Below"},{"line_number":186,"context_line":"3.31, snapshots, backups and attachments ignore ``project_id``. With that"},{"line_number":187,"context_line":"entry volumes apply it at every microversion. Groups apply it below"},{"line_number":188,"context_line":"3.31 and group snapshots at 3.29 and 3.30. Transfers and consistency groups"},{"line_number":189,"context_line":"apply it at every microversion."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"A cross-project attachment list returns ``connection_info`` as null in every"},{"line_number":192,"context_line":"row to a caller that is not an admin, the caller\u0027s own attachments included."}],"source_content_type":"text/x-rst","patch_set":3,"id":"0f945a67_e9b9323f","line":189,"range":{"start_line":183,"start_character":0,"end_line":189,"end_character":31},"updated":"2026-11-16 15:40:50.000000000","message":"This should be moved to the \"deployer impact\" section as a reminder that some changes will need to be made to resource_filters.json","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"b976479b53022f61189c61490e6dad3a81574f52","unresolved":false,"context_lines":[{"line_number":186,"context_line":"3.31, snapshots, backups and attachments ignore ``project_id``. With that"},{"line_number":187,"context_line":"entry volumes apply it at every microversion. Groups apply it below"},{"line_number":188,"context_line":"3.31 and group snapshots at 3.29 and 3.30. Transfers and consistency groups"},{"line_number":189,"context_line":"apply it at every microversion."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"A cross-project attachment list returns ``connection_info`` as null in every"},{"line_number":192,"context_line":"row to a caller that is not an admin, the caller\u0027s own attachments included."}],"source_content_type":"text/x-rst","patch_set":3,"id":"010475ad_a0dff56c","line":189,"in_reply_to":"0f945a67_e9b9323f","updated":"2026-11-18 02:51:07.000000000","message":"Moved to Other deployer impact.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"07356205dca422ac7e02ea520cb2c7277f7f4f91","unresolved":true,"context_lines":[{"line_number":188,"context_line":"3.31 and group snapshots at 3.29 and 3.30. Transfers and consistency groups"},{"line_number":189,"context_line":"apply it at every microversion."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"A cross-project attachment list returns ``connection_info`` as null in every"},{"line_number":192,"context_line":"row to a caller that is not an admin, the caller\u0027s own attachments included."},{"line_number":193,"context_line":"The second change implements this."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"This spec proposes no new microversion. The result for a token changes only"},{"line_number":196,"context_line":"after an operator edits the policy file, except for the table rows where the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f73aee7_6acc5d71","line":193,"range":{"start_line":191,"start_character":0,"end_line":193,"end_character":34},"updated":"2026-11-16 15:40:50.000000000","message":"This is an extremely important point; you should mention it near the beginning of this section.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"b976479b53022f61189c61490e6dad3a81574f52","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"A cross-project attachment list returns ``connection_info`` as null in every"},{"line_number":192,"context_line":"row to a caller that is not an admin, the caller\u0027s own attachments included."},{"line_number":193,"context_line":"The second change implements this."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"This spec proposes no new microversion. The result for a token changes only"},{"line_number":196,"context_line":"after an operator edits the policy file, except for the table rows where the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"a7dd71d5_eb92746f","line":193,"in_reply_to":"1f73aee7_6acc5d71","updated":"2026-11-18 02:51:07.000000000","message":"Moved to the top of the section.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"07356205dca422ac7e02ea520cb2c7277f7f4f91","unresolved":true,"context_lines":[{"line_number":193,"context_line":"The second change implements this."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"This spec proposes no new microversion. The result for a token changes only"},{"line_number":196,"context_line":"after an operator edits the policy file, except for the table rows where the"},{"line_number":197,"context_line":"two columns differ, the denied caller\u0027s results above, and the ``with_count``"},{"line_number":198,"context_line":"fix. A false value or a repeated key that returned the wrong projects fits the"},{"line_number":199,"context_line":"\"silently fail\" case in the microversion guide. The HTTP 500 and HTTP 400 for"},{"line_number":200,"context_line":"a repeated key came from a validator that removed only one copy of the key,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c273c628_14fef8a4","line":197,"range":{"start_line":196,"start_character":41,"end_line":197,"end_character":19},"updated":"2026-11-16 15:40:50.000000000","message":"what are you talking about here?  But more to the point, remove this entire paragraph and file a bug about the repeated-key issue.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"b976479b53022f61189c61490e6dad3a81574f52","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"This spec proposes no new microversion. The result for a token changes only"},{"line_number":196,"context_line":"after an operator edits the policy file, except for the table rows where the"},{"line_number":197,"context_line":"two columns differ, the denied caller\u0027s results above, and the ``with_count``"},{"line_number":198,"context_line":"fix. A false value or a repeated key that returned the wrong projects fits the"},{"line_number":199,"context_line":"\"silently fail\" case in the microversion guide. The HTTP 500 and HTTP 400 for"},{"line_number":200,"context_line":"a repeated key came from a validator that removed only one copy of the key,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"e5d2996a_10ac10d0","line":197,"in_reply_to":"c273c628_14fef8a4","updated":"2026-11-18 02:51:07.000000000","message":"The repeated-key paragraph. Removed, bug 2174795.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"07356205dca422ac7e02ea520cb2c7277f7f4f91","unresolved":true,"context_lines":[{"line_number":200,"context_line":"a repeated key came from a validator that removed only one copy of the key,"},{"line_number":201,"context_line":"so they are bugs too."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"A deployer grants the policies as follows. The role must also pass the list"},{"line_number":204,"context_line":"policy of the resource, where one exists. Without"},{"line_number":205,"context_line":"``backup:backup_project_attribute``, backups show no owner:"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":".. code-block:: yaml"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"   \"volume:get_all:all_tenants\": \"role:auditor\""},{"line_number":210,"context_line":"   \"volume:get_all_snapshots:all_tenants\": \"role:auditor\""},{"line_number":211,"context_line":"   \"backup:get_all:all_tenants\": \"role:auditor\""},{"line_number":212,"context_line":"   \"backup:backup_project_attribute\": \"role:auditor\""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"Security impact"},{"line_number":215,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"a65dd7f7_d633bd8c","line":212,"range":{"start_line":203,"start_character":0,"end_line":212,"end_character":52},"updated":"2026-11-16 15:40:50.000000000","message":"you don\u0027t need this, the deployer grants the policies in the usual way.  There are several of the _attribute policies; you can add something to the deployer impact section about this, and then document at some point the _attribute policies that deployers will probably want to grant to an \"auditor\".","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"},{"author":{"_account_id":39583,"name":"Noppakorn Kaewsalabnil","email":"noppakorn@nipa.cloud","username":"PunGrumpy"},"change_message_id":"b976479b53022f61189c61490e6dad3a81574f52","unresolved":false,"context_lines":[{"line_number":209,"context_line":"   \"volume:get_all:all_tenants\": \"role:auditor\""},{"line_number":210,"context_line":"   \"volume:get_all_snapshots:all_tenants\": \"role:auditor\""},{"line_number":211,"context_line":"   \"backup:get_all:all_tenants\": \"role:auditor\""},{"line_number":212,"context_line":"   \"backup:backup_project_attribute\": \"role:auditor\""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"Security impact"},{"line_number":215,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c844d27e_ab518695","line":212,"in_reply_to":"a65dd7f7_d633bd8c","updated":"2026-11-18 02:51:07.000000000","message":"Done. Deployer impact names the project attribute policies.","commit_id":"06a9df04f0c2b65cc19aa1fb87629d2bf2820622"}]}
