)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b6e9a326c853ffe06a9d4bd7ed97f5831eaed0ef","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Julie Gravel \u003cjulie.gravel@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-10 01:16:29 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add specs for volume type extra specs enhancements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0aa874bff02a5e86eb8237260aafaeffd7408afd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa201ad_de19bf7a","line":7,"updated":"2014-10-10 20:44:57.000000000","message":"Should add a better commit message that details the overall user experience changes that you are trying to affect here with these 3 specs.","commit_id":"41d4f63419578263964b7bcb60057a9b59401846"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"0b3fa8fa8db5871f2254917f73ca384a22671150","unresolved":false,"context_lines":[{"line_number":16,"context_line":"   volume type. The current process in Horizon is a two separate tasks"},{"line_number":17,"context_line":"   that are not coherent. Combinig the two tasks into one clean process"},{"line_number":18,"context_line":"   and allowing users to set the backend name while creating a new"},{"line_number":19,"context_line":"   volume type will vastly improve the user experience of this process."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"2. Providing a list of possible volume type extra specs keys for users"},{"line_number":22,"context_line":"   to choose from when creating or editing extra specs. The current"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baa201ad_48b20a07","line":19,"updated":"2014-10-15 15:55:38.000000000","message":"Note that a volume type does not have to be assigned to any backend name, or might have several.","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b67415f28825530f84145c2a16f89303d6e6d329","unresolved":false,"context_lines":[{"line_number":16,"context_line":"   volume type. The current process in Horizon is a two separate tasks"},{"line_number":17,"context_line":"   that are not coherent. Combinig the two tasks into one clean process"},{"line_number":18,"context_line":"   and allowing users to set the backend name while creating a new"},{"line_number":19,"context_line":"   volume type will vastly improve the user experience of this process."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"2. Providing a list of possible volume type extra specs keys for users"},{"line_number":22,"context_line":"   to choose from when creating or editing extra specs. The current"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baa201ad_423abbe7","line":19,"in_reply_to":"baa201ad_48b20a07","updated":"2014-10-16 23:16:36.000000000","message":"We\u0027ll have to account for both of these scenarios, where \n1) volume_backend_name is not specified or has no value\n2) volume_backend_name is a CSV of values.","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"69228365d1107a01e7e2ca8f1498cc99cfc0ccf7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"   to choose from when creating or editing extra specs. The current"},{"line_number":23,"context_line":"   process in Horizon provides no useful help in terms of what the"},{"line_number":24,"context_line":"   possible extra specs keys and values might be. Users have to know"},{"line_number":25,"context_line":"   the exact spellings ahead of time. Having a list of possible keys"},{"line_number":26,"context_line":"   for users to choose from will help lessen the time users spend on"},{"line_number":27,"context_line":"   this task."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baa201ad_cd48ba2f","line":25,"updated":"2014-10-16 05:13:22.000000000","message":"The best place for user to figure out what extra specs they should use is the documentation from storage vendor.  The correct flow for user (admin here) is 1) read the documentation/maunal from storage vendor to understand what extra specs the driver supports and what values make sense in the environment (this is the part Horizon can\u0027t help).  Documentation is the single source of truth, not Horizon, not driver.  If user doesn\u0027t read the doc, there is high chance he would crew up something, because Horizon may present all extra specs key/value pairs but it can\u0027t tell user what those terminologies mean and how to determine the right value, especially when multiple backend/driver can use same term but with totally different meaning.\n\nSo my take for this proposal is, Horizon can be helpful for those users who knows what they are looking for but can remember how to spell certain key.  We should educate user to read the doc rather than relies on the information provided by driver/Horizon.","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b67415f28825530f84145c2a16f89303d6e6d329","unresolved":false,"context_lines":[{"line_number":22,"context_line":"   to choose from when creating or editing extra specs. The current"},{"line_number":23,"context_line":"   process in Horizon provides no useful help in terms of what the"},{"line_number":24,"context_line":"   possible extra specs keys and values might be. Users have to know"},{"line_number":25,"context_line":"   the exact spellings ahead of time. Having a list of possible keys"},{"line_number":26,"context_line":"   for users to choose from will help lessen the time users spend on"},{"line_number":27,"context_line":"   this task."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baa201ad_c22dcba9","line":25,"in_reply_to":"baa201ad_cd48ba2f","updated":"2014-10-16 23:16:36.000000000","message":"This is exactly the terrible user experience we are trying to overcome here.  \n\nJust because this is the current workflow for admins, doesn\u0027t mean we can\u0027t make it MUCH better.   \n\nThe single source of truth of what a driver supports is the driver itself.   \nWe want to expose a new driver method that returns a dictionary of it\u0027s list of extra spec keys it looks for.   \n\nYour argument for \u0027determining the right value\u0027 exists today.   The other part of this spec is to allow the driver associated with the key a chance to actually validate the values.   This way an admin doesn\u0027t setup a bogus set of values, and then have to test it by creating a volume, and looking at the logs for failures.   Thats very bad IMO.","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"69228365d1107a01e7e2ca8f1498cc99cfc0ccf7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"   users. Having a validation done right away while users are still"},{"line_number":32,"context_line":"   in the process of creating or editing extra specs will eliminate"},{"line_number":33,"context_line":"   problems that could happen at volume creation time which is much"},{"line_number":34,"context_line":"   harder to troubleshoot."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Change-Id: I0aa874bff02a5e86eb8237260aafaeffd7408afd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baa201ad_ed51fed9","line":34,"updated":"2014-10-16 05:13:22.000000000","message":"Agree with Duncan.  Only some capabilities can be verified, but to get this right and useful can really take some effort.  I doubt if it is worth doing.","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"0b3fa8fa8db5871f2254917f73ca384a22671150","unresolved":false,"context_lines":[{"line_number":31,"context_line":"   users. Having a validation done right away while users are still"},{"line_number":32,"context_line":"   in the process of creating or editing extra specs will eliminate"},{"line_number":33,"context_line":"   problems that could happen at volume creation time which is much"},{"line_number":34,"context_line":"   harder to troubleshoot."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Change-Id: I0aa874bff02a5e86eb8237260aafaeffd7408afd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baa201ad_c846fabf","line":34,"updated":"2014-10-15 15:55:38.000000000","message":"This is really hard to get right, since you don\u0027t know which backends will be valid candidates until you\u0027ve defined all of the type, so you don\u0027t know what options are valid... and even after the type is defined the status of various backends can change.","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b67415f28825530f84145c2a16f89303d6e6d329","unresolved":false,"context_lines":[{"line_number":31,"context_line":"   users. Having a validation done right away while users are still"},{"line_number":32,"context_line":"   in the process of creating or editing extra specs will eliminate"},{"line_number":33,"context_line":"   problems that could happen at volume creation time which is much"},{"line_number":34,"context_line":"   harder to troubleshoot."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Change-Id: I0aa874bff02a5e86eb8237260aafaeffd7408afd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baa201ad_e2ff2f00","line":34,"in_reply_to":"baa201ad_c846fabf","updated":"2014-10-16 23:16:36.000000000","message":"Cinder can\u0027t account for the backends changing over time.  this problem exists today and will always exist.  What we are trying to do at a minimum here is a simple validation at the time the volume type (and extra spec values) are saved from horizon.   If they are valid at that time, it\u0027s far better than what we have today, which is no validation at all.\n\nAn admin has to create a volume, then scour the logs for any exceptions, and then try and decipher why that exception happened and how it relates to the keys and values.   This really sucks.","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"}],"specs/kilo/get-vol-backends.rst":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"575e2d31317dcd561da2b742eaefa618d04ad272","unresolved":false,"context_lines":[{"line_number":13,"context_line":"The purpose of this spec is to add a Cinder API to obtain a list of volume"},{"line_number":14,"context_line":"backend names of all instances currently running. The list will be used to"},{"line_number":15,"context_line":"improve the volume type creation process in Horizon."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_04821852","line":16,"updated":"2014-10-10 22:52:39.000000000","message":"Need to be able to get pools too, for exactly the same reason","commit_id":"41d4f63419578263964b7bcb60057a9b59401846"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"998113cc767974819394fa1b018b3edb21ded101","unresolved":false,"context_lines":[{"line_number":13,"context_line":"The purpose of this spec is to add a Cinder API to obtain a list of volume"},{"line_number":14,"context_line":"backend names of all instances currently running. The list will be used to"},{"line_number":15,"context_line":"improve the volume type creation process in Horizon."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_e48fd4ca","line":16,"in_reply_to":"baa201ad_04821852","updated":"2014-10-10 23:38:39.000000000","message":"We could do this as a follow on proposal after we get this one in.","commit_id":"41d4f63419578263964b7bcb60057a9b59401846"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b6e9a326c853ffe06a9d4bd7ed97f5831eaed0ef","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Security impact"},{"line_number":63,"context_line":"---------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"None"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Notifications impact"},{"line_number":68,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_b8cb321d","line":65,"updated":"2014-10-10 20:44:57.000000000","message":"We definitely want to make sure that only admins can make this call.  We don\u0027t want to expose to users what backends are running.","commit_id":"41d4f63419578263964b7bcb60057a9b59401846"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"9e593f898bd8ea5f6e6abca7ba7bd1c888526156","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"A new API will be added to retrieve a list of volume backend names of all"},{"line_number":35,"context_line":"instances currently running."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa201ad_47692dbd","line":35,"updated":"2014-10-15 01:46:51.000000000","message":"How are you getting the volume backend names and know which driver they\u0027re associated with? How do you know they\u0027re currently running?","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"69228365d1107a01e7e2ca8f1498cc99cfc0ccf7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"A new API will be added to retrieve a list of volume backend names of all"},{"line_number":35,"context_line":"instances currently running."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa201ad_0d4f2235","line":35,"updated":"2014-10-16 05:13:22.000000000","message":"Mike, such info is already available because driver reports \u0027driver version\u0027 and \u0027volume backend name\u0027 to scheduler, we can add \u0027driver name\u0027 if needed.","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e585a3b3e4d39cce76a7779d7cd54d580cc5adb0","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"A new API will be added to retrieve a list of volume backend names of all"},{"line_number":35,"context_line":"instances currently running."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa201ad_ed71100d","line":35,"in_reply_to":"baa201ad_47692dbd","updated":"2014-10-15 15:24:30.000000000","message":"This is something we will have to investigate to find out how to get this info.   I presume the scheduler knows which hosts are currently running?   We should be able to save/store a list of discovered volume_backend_name entries at startup time.","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"4ead4b76b3b505346224c586ba6e09692506e8b5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"A new API will be added to retrieve a list of volume backend names of all"},{"line_number":35,"context_line":"instances currently running."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa201ad_887872c5","line":35,"in_reply_to":"baa201ad_ed71100d","updated":"2014-10-15 15:58:42.000000000","message":"To make these specs useful, I think it\u0027s good to have a planned approach to this. Also (see NFS sec enhancement patch) you\u0027re going to get a -1 every patch posted because someone doesn\u0027t agree with the approach. As oppose to us agreeing on a approach here to reference in the review.","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"0b3fa8fa8db5871f2254917f73ca384a22671150","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"* Horizon will be updated to combine the setting of volume backend name into"},{"line_number":76,"context_line":"  the \"Create Volume Type\" process, instead of having the setting of volume"},{"line_number":77,"context_line":"  backend name as a separate process as it is currently."},{"line_number":78,"context_line":"* python-cinderclient will be updated to allow the use of this new API."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Proposed python-cinderclient shell interface::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa201ad_08f00266","line":77,"updated":"2014-10-15 15:55:38.000000000","message":"Note that a type need not have a volume backend, or it might have many","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b67415f28825530f84145c2a16f89303d6e6d329","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"* Horizon will be updated to combine the setting of volume backend name into"},{"line_number":76,"context_line":"  the \"Create Volume Type\" process, instead of having the setting of volume"},{"line_number":77,"context_line":"  backend name as a separate process as it is currently."},{"line_number":78,"context_line":"* python-cinderclient will be updated to allow the use of this new API."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Proposed python-cinderclient shell interface::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa201ad_d5166348","line":77,"in_reply_to":"baa201ad_08f00266","updated":"2014-10-16 23:16:36.000000000","message":"If an admin doesn\u0027t specify a volume_backend_name, we can do 1 of 2 things as I see it.\n\n1) do what we do now, which is nothing.\n2) or, ask cinder about all the running instances and then fetch all of the supported extra spec keys from each of them, and allow the user to pick and choose.","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"fee2785e03c836ebd8619048eeed6ebd4a8aaef8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"manually set the volume backend name for a volume type through the extra specs"},{"line_number":22,"context_line":"management process. The current extra specs management process is very"},{"line_number":23,"context_line":"error-prone. Users have no way to see what possible key/value pairs for extra"},{"line_number":24,"context_line":"specs are. In this case, the extra specs key should be \"volume_backend_name\"."},{"line_number":25,"context_line":"Then the extra specs value would be one of the volume backend names of all"},{"line_number":26,"context_line":"instances currently running. This means that users have to type in the key and"},{"line_number":27,"context_line":"the value with the exact spellings. Having a list of available volume backend"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_a6f22d98","line":24,"updated":"2014-10-21 08:39:28.000000000","message":"With pool introduced into Cinder, pool name must be retrieved instead.","commit_id":"700f6de0607efd6b83d41065d6cf9a5e4e59cf2f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"5c9cb523ac511111e6c872eb62c670328c0d0090","unresolved":false,"context_lines":[{"line_number":21,"context_line":"manually set the volume backend name for a volume type through the extra specs"},{"line_number":22,"context_line":"management process. The current extra specs management process is very"},{"line_number":23,"context_line":"error-prone. Users have no way to see what possible key/value pairs for extra"},{"line_number":24,"context_line":"specs are. In this case, the extra specs key should be \"volume_backend_name\"."},{"line_number":25,"context_line":"Then the extra specs value would be one of the volume backend names of all"},{"line_number":26,"context_line":"instances currently running. This means that users have to type in the key and"},{"line_number":27,"context_line":"the value with the exact spellings. Having a list of available volume backend"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_80915b54","line":24,"in_reply_to":"9aa7fdbe_a6f22d98","updated":"2014-10-22 16:00:50.000000000","message":"we don\u0027t use pools in volume_backend_name values for volume types.   I don\u0027t understand what pools have to do with specifying a volume_backend_name in a volume type?","commit_id":"700f6de0607efd6b83d41065d6cf9a5e4e59cf2f"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"fee2785e03c836ebd8619048eeed6ebd4a8aaef8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"enhance the services table at specs/kilo/get-vol-type-extra-specs.rst."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Alternatives"},{"line_number":40,"context_line":"------------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"None"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_c6ef31af","line":40,"updated":"2014-10-21 08:39:28.000000000","message":"The \u0027scheduler_stats\u0027 API extension should be mentioned here at least.  And please state why \u0027scheduler_stats\u0027 isn\u0027t enough to solve this problem.","commit_id":"700f6de0607efd6b83d41065d6cf9a5e4e59cf2f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"5c9cb523ac511111e6c872eb62c670328c0d0090","unresolved":false,"context_lines":[{"line_number":37,"context_line":"enhance the services table at specs/kilo/get-vol-type-extra-specs.rst."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Alternatives"},{"line_number":40,"context_line":"------------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"None"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_e0894727","line":40,"in_reply_to":"9aa7fdbe_c6ef31af","updated":"2014-10-22 16:00:50.000000000","message":"because this has nothing to do with volume stats being reported by drivers.","commit_id":"700f6de0607efd6b83d41065d6cf9a5e4e59cf2f"}],"specs/kilo/get-vol-type-extra-specs.rst":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b6e9a326c853ffe06a9d4bd7ed97f5831eaed0ef","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The current implementation of volume type extra specs management process in"},{"line_number":21,"context_line":"Horizon is error-prone. Users usually manage extra specs through the \"View"},{"line_number":22,"context_line":"Extra Specs\" action of the Admin Volumes\u0027 Volume Types table. This action"},{"line_number":23,"context_line":"allows users to create, edit, and delete extra specs associated to a volume"},{"line_number":24,"context_line":"type via a simple table and dialog mechanism that has no meaningful help."},{"line_number":25,"context_line":"Users have no way to see what possible key/value pairs for extra specs are."}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_58e406ac","line":22,"updated":"2014-10-10 20:44:57.000000000","message":"looks like you have an unmatched \u0027 char here.","commit_id":"41d4f63419578263964b7bcb60057a9b59401846"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"575e2d31317dcd561da2b742eaefa618d04ad272","unresolved":false,"context_lines":[{"line_number":35,"context_line":"specs keys for each driver. The list should also include the information about"},{"line_number":36,"context_line":"those keys, such as key description, possible values, value range, and value"},{"line_number":37,"context_line":"type."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Alternatives"},{"line_number":40,"context_line":"------------"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_8495288a","line":38,"updated":"2014-10-10 22:52:39.000000000","message":"Where is this info going to come from? I assume you\u0027ll add a driver call?","commit_id":"41d4f63419578263964b7bcb60057a9b59401846"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"998113cc767974819394fa1b018b3edb21ded101","unresolved":false,"context_lines":[{"line_number":35,"context_line":"specs keys for each driver. The list should also include the information about"},{"line_number":36,"context_line":"those keys, such as key description, possible values, value range, and value"},{"line_number":37,"context_line":"type."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Alternatives"},{"line_number":40,"context_line":"------------"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_0463f81a","line":38,"in_reply_to":"baa201ad_8495288a","updated":"2014-10-10 23:38:39.000000000","message":"Exactly.   If no volume_backend_name is passed, then we\u0027d have to provide the information for all running instances.   \n\nWe will add a paragraph here about the needed changes in the drivers to support this.","commit_id":"41d4f63419578263964b7bcb60057a9b59401846"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b6e9a326c853ffe06a9d4bd7ed97f5831eaed0ef","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Alternatives"},{"line_number":40,"context_line":"------------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"None"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Data model impact"},{"line_number":45,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_589246f7","line":42,"updated":"2014-10-10 20:44:57.000000000","message":"Should talk about the current mechanism, which is entirely manual and difficult.","commit_id":"41d4f63419578263964b7bcb60057a9b59401846"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c31356e0dbafe227ac373353fb45725cbad77364","unresolved":false,"context_lines":[{"line_number":50,"context_line":"---------------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Add a new REST API to retrieve volume backend names:"},{"line_number":53,"context_line":"  * GET /v2/{backend_id}/extra_specs"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"JSON response example::"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_cd8e45d0","line":53,"updated":"2014-10-14 02:25:48.000000000","message":"This assumes that one backend will  only have one volume type, but you can actually have multiple volume types per backend.  How are you going to show it if there are multiple volume types for the specified backend_id?","commit_id":"41d4f63419578263964b7bcb60057a9b59401846"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"45b47d24b6e9dc47697c74cb196db949863a0353","unresolved":false,"context_lines":[{"line_number":50,"context_line":"---------------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Add a new REST API to retrieve volume backend names:"},{"line_number":53,"context_line":"  * GET /v2/{backend_id}/extra_specs"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"JSON response example::"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_43f768d3","line":53,"in_reply_to":"baa201ad_a0eaca0c","updated":"2014-10-14 19:51:13.000000000","message":"Discussed with Walt about this. This will only display \"keys\", not \"values\" of the extra specs.  So even if there are multiple volume types for the same backend, keys from all volume types will be shown (duplicate keys won\u0027t be shown).  So it should be fine.","commit_id":"41d4f63419578263964b7bcb60057a9b59401846"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"0a338b700201567cb699664f08f500341fbcd52d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"---------------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Add a new REST API to retrieve volume backend names:"},{"line_number":53,"context_line":"  * GET /v2/{backend_id}/extra_specs"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"JSON response example::"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_a0eaca0c","line":53,"in_reply_to":"baa201ad_c0050e12","updated":"2014-10-14 19:13:17.000000000","message":"xing, this isn\u0027t really a problem here.   the purpose of the call is to drill down to the driver to fetch the supported keys and metadata about the keys.  So it doesn\u0027t really matter if it\u0027s on volume type A, or B.","commit_id":"41d4f63419578263964b7bcb60057a9b59401846"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a9d3137b4fad7562ab83cd684a66bd41872ed157","unresolved":false,"context_lines":[{"line_number":50,"context_line":"---------------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Add a new REST API to retrieve volume backend names:"},{"line_number":53,"context_line":"  * GET /v2/{backend_id}/extra_specs"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"JSON response example::"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_c0050e12","line":53,"in_reply_to":"baa201ad_cd8e45d0","updated":"2014-10-14 19:06:54.000000000","message":"xing is right here.   A backend can be assigned to more than 1 volume type.","commit_id":"41d4f63419578263964b7bcb60057a9b59401846"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b6e9a326c853ffe06a9d4bd7ed97f5831eaed0ef","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Security impact"},{"line_number":73,"context_line":"---------------"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"None"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Notifications impact"},{"line_number":78,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_d8b5567f","line":75,"updated":"2014-10-10 20:44:57.000000000","message":"Again, we want to make sure this is an admin only API.  We don\u0027t want to expose to end users what backends are running and their extra spec keys.","commit_id":"41d4f63419578263964b7bcb60057a9b59401846"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b6e9a326c853ffe06a9d4bd7ed97f5831eaed0ef","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Developer impact"},{"line_number":106,"context_line":"----------------"},{"line_number":107,"context_line":"None"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_582ec6a6","line":107,"updated":"2014-10-10 20:44:57.000000000","message":"This definitely affects driver developers.  They will need to write a new driver method that returns the list of extra spec keys in the json format that you expect.","commit_id":"41d4f63419578263964b7bcb60057a9b59401846"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"69228365d1107a01e7e2ca8f1498cc99cfc0ccf7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Horizon is error-prone. Users usually manage extra specs through the \u0027View"},{"line_number":22,"context_line":"Extra Specs\u0027 action of the Admin Volumes Volume Types table. This action"},{"line_number":23,"context_line":"allows users to create, edit, and delete extra specs associated to a volume"},{"line_number":24,"context_line":"type via a simple table and dialog mechanism that has no meaningful help."},{"line_number":25,"context_line":"Users have no way to see what possible key/value pairs for extra specs are."},{"line_number":26,"context_line":"This means that users have to type in the key and the value with the exact"},{"line_number":27,"context_line":"spellings that drivers can use. Having a list of possible volume type extra"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa201ad_2d5f86e6","line":24,"updated":"2014-10-16 05:13:22.000000000","message":"The only meaningful help can reduce possible failure is the documentation.  For example, for a key named \u0027burst_iops\u0027, any value from 0 to 10,000,000 is totally valid from the driver point of view but user(admin) will have to know other limitations like the cluster IOPS capacity, single lun limit of the backend to determine a meaningful setting for a type.  I really don\u0027t expect Horizon or any cinder API extensions to help in such cases.","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b67415f28825530f84145c2a16f89303d6e6d329","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Horizon is error-prone. Users usually manage extra specs through the \u0027View"},{"line_number":22,"context_line":"Extra Specs\u0027 action of the Admin Volumes Volume Types table. This action"},{"line_number":23,"context_line":"allows users to create, edit, and delete extra specs associated to a volume"},{"line_number":24,"context_line":"type via a simple table and dialog mechanism that has no meaningful help."},{"line_number":25,"context_line":"Users have no way to see what possible key/value pairs for extra specs are."},{"line_number":26,"context_line":"This means that users have to type in the key and the value with the exact"},{"line_number":27,"context_line":"spellings that drivers can use. Having a list of possible volume type extra"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa201ad_b532bfef","line":24,"in_reply_to":"baa201ad_2d5f86e6","updated":"2014-10-16 23:16:36.000000000","message":"It\u0027s completely up to the driver to decide what to do with validating the values for the keys it supports.   It can decide to do nothing and report it perfectly fine and then rely on docs.   It\u0027s better than what we have today, which is validate nothing and scour the logs for exceptions and figure out how to relay those exceptions to the extra spec key and value that cause the exception.\n\nIn the case of our drivers, we have specific values we can actually validate against the array to ensure that things exist.   In the case of general purpose values like the one you mentioned above, we would simply not validate the value other than ensure that it\u0027s an int.","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"9e593f898bd8ea5f6e6abca7ba7bd1c888526156","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Proposed python-cinderclient shell interface::"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":" extra-specs-support-list \u003cvolume_backend\u003e"},{"line_number":105,"context_line":"    Lists supported volume type extra specs keys for a volume backend."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa201ad_27cd09b8","line":104,"updated":"2014-10-15 01:46:51.000000000","message":"This is going to be confusing with the existing command extra-specs-list. Maybe this is a filter to the existing command.","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e585a3b3e4d39cce76a7779d7cd54d580cc5adb0","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Proposed python-cinderclient shell interface::"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":" extra-specs-support-list \u003cvolume_backend\u003e"},{"line_number":105,"context_line":"    Lists supported volume type extra specs keys for a volume backend."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa201ad_ed703042","line":104,"in_reply_to":"baa201ad_27cd09b8","updated":"2014-10-15 15:24:30.000000000","message":"So, the issue here is that extra-specs-list dumps out the existing extra-specs for volume type.  \n\nWhat we are trying to accomplish is finding the list of extra spec keys that drivers recognize and the keys metadata (type, list of allowed values for enums, description, etc).\n\nThey aren\u0027t really the same thing.   Any suggestions as to what we should name this, if it\u0027s confusing?","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"87359f4a2fb4323f30c378582d59bfeb53a3bdc4","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Proposed python-cinderclient shell interface::"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":" extra-specs-support-list \u003cvolume_backend\u003e"},{"line_number":105,"context_line":"    Lists supported volume type extra specs keys for a volume backend."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa201ad_22523e35","line":104,"in_reply_to":"baa201ad_888a32bd","updated":"2014-10-15 21:33:48.000000000","message":"I kinda like extra-specs-describe","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"4ead4b76b3b505346224c586ba6e09692506e8b5","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Proposed python-cinderclient shell interface::"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":" extra-specs-support-list \u003cvolume_backend\u003e"},{"line_number":105,"context_line":"    Lists supported volume type extra specs keys for a volume backend."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa201ad_c31a5b6e","line":104,"in_reply_to":"baa201ad_ed703042","updated":"2014-10-15 15:58:42.000000000","message":"I don\u0027t have a suggestion yet, but just imagining these two commands in the help usage isn\u0027t going to be intuitive.","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"0b3fa8fa8db5871f2254917f73ca384a22671150","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Proposed python-cinderclient shell interface::"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":" extra-specs-support-list \u003cvolume_backend\u003e"},{"line_number":105,"context_line":"    Lists supported volume type extra specs keys for a volume backend."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa201ad_888a32bd","line":104,"in_reply_to":"baa201ad_ed703042","updated":"2014-10-15 15:55:38.000000000","message":"extra-specs-describe maybe? extra-specs-schema?","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"fee2785e03c836ebd8619048eeed6ebd4a8aaef8","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Alternatives"},{"line_number":84,"context_line":"------------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"An alternative of this proposal is the current Horizon process of managing"},{"line_number":87,"context_line":"the volume type extra specs which does not provide any helpful information to"},{"line_number":88,"context_line":"users regarding possible extra specs keys and values. Users have to know the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_0631395a","line":85,"updated":"2014-10-21 08:39:28.000000000","message":"\u0027scheduler_stats\u0027 extension should be mentioned here for a comparison.","commit_id":"700f6de0607efd6b83d41065d6cf9a5e4e59cf2f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"99162f7e54881b84ec1344a53869c94bcc48a63a","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Alternatives"},{"line_number":84,"context_line":"------------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"An alternative of this proposal is the current Horizon process of managing"},{"line_number":87,"context_line":"the volume type extra specs which does not provide any helpful information to"},{"line_number":88,"context_line":"users regarding possible extra specs keys and values. Users have to know the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_392f8140","line":85,"in_reply_to":"9aa7fdbe_0631395a","updated":"2014-10-28 16:01:38.000000000","message":"I don\u0027t really see that as a viable reasonable alternative, hence the lack of mention here.   It doesn\u0027t make any sense to fetch the values at get_volume_stats time as the keys will be the same every single call.    Why do that every 30 seconds when this data is only needed at volume type creation time?  Doesn\u0027t make sense to me.","commit_id":"700f6de0607efd6b83d41065d6cf9a5e4e59cf2f"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"fee2785e03c836ebd8619048eeed6ebd4a8aaef8","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  | disabled          | tinyint(1)   | YES  |     | NULL    |                |"},{"line_number":121,"context_line":"  | availability_zone | varchar(255) | YES  |     | NULL    |                |"},{"line_number":122,"context_line":"  | disabled_reason   | varchar(255) | YES  |     | NULL    |                |"},{"line_number":123,"context_line":"  | vol_backend_name  | varchar(255) | YES  |     | NULL    |                |"},{"line_number":124,"context_line":"  | vol_driver_class  | varchar(255) | YES  |     | NULL    |                |"},{"line_number":125,"context_line":"  +-------------------+--------------+------+-----+---------+----------------+"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_26363d53","line":123,"updated":"2014-10-21 08:39:28.000000000","message":"For those backends have multiple pools (e.g. 3Par), service table change here barely help user to find correct value for volume backend name for each pool.","commit_id":"700f6de0607efd6b83d41065d6cf9a5e4e59cf2f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"99162f7e54881b84ec1344a53869c94bcc48a63a","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  | disabled          | tinyint(1)   | YES  |     | NULL    |                |"},{"line_number":121,"context_line":"  | availability_zone | varchar(255) | YES  |     | NULL    |                |"},{"line_number":122,"context_line":"  | disabled_reason   | varchar(255) | YES  |     | NULL    |                |"},{"line_number":123,"context_line":"  | vol_backend_name  | varchar(255) | YES  |     | NULL    |                |"},{"line_number":124,"context_line":"  | vol_driver_class  | varchar(255) | YES  |     | NULL    |                |"},{"line_number":125,"context_line":"  +-------------------+--------------+------+-----+---------+----------------+"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_d96f5590","line":123,"in_reply_to":"9aa7fdbe_26363d53","updated":"2014-10-28 16:01:38.000000000","message":"The pools don\u0027t even come into play here.   We simply need the volume_backend_name to find the unique volume driver classes to call to fetch the supported extra spec keys by the driver.   The keys supported by each driver don\u0027t change depending on the config of each instance of that driver.","commit_id":"700f6de0607efd6b83d41065d6cf9a5e4e59cf2f"},{"author":{"_account_id":9067,"name":"Nilesh Bhosale","email":"nilesh.bhosale@in.ibm.com","username":"nileshbhosale"},"change_message_id":"2959997f4521a683dde9136e0297bf6b5d182b2d","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"In this case the result from the API for the volume backend name of \u0027foo\u0027 will"},{"line_number":73,"context_line":"include two sets of extra specs keys: one from driverA and another one from"},{"line_number":74,"context_line":"driverB, since the first two entries point to the same volume driver class"},{"line_number":75,"context_line":"name. The result for the volume backend names of \u0027foo\u0027 and \u0027bar\u0027 will include"},{"line_number":76,"context_line":"three sets of extra specs keys: one from driverA, one from driverB, and one"},{"line_number":77,"context_line":"from driverC."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_c83693e7","line":74,"updated":"2014-10-30 05:05:47.000000000","message":"Do you mean to say \u0027the volume backend name of \u0027foo\u0027 will\tinclude two sets of extra specs keys: one from driverA and another one from driverC\u0027 ? since driverB in your example has \u0027volume_backend_name \u003d bar\u0027","commit_id":"763749e42a2b9fa88a51b73da73a2f71aef659fe"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ab4b5f4a2ddef161c5de033ce4fbe98d71def92a","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"In this case the result from the API for the volume backend name of \u0027foo\u0027 will"},{"line_number":73,"context_line":"include two sets of extra specs keys: one from driverA and another one from"},{"line_number":74,"context_line":"driverB, since the first two entries point to the same volume driver class"},{"line_number":75,"context_line":"name. The result for the volume backend names of \u0027foo\u0027 and \u0027bar\u0027 will include"},{"line_number":76,"context_line":"three sets of extra specs keys: one from driverA, one from driverB, and one"},{"line_number":77,"context_line":"from driverC."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_c30ca397","line":74,"in_reply_to":"7a8c0949_c83693e7","updated":"2014-10-30 17:12:12.000000000","message":"yes I believe that is correct.    Should correct this one.","commit_id":"763749e42a2b9fa88a51b73da73a2f71aef659fe"},{"author":{"_account_id":9067,"name":"Nilesh Bhosale","email":"nilesh.bhosale@in.ibm.com","username":"nileshbhosale"},"change_message_id":"2959997f4521a683dde9136e0297bf6b5d182b2d","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Add a new REST API to retrieve possible extra specs for a volume backend name:"},{"line_number":102,"context_line":"  * GET /v2/extra_specs?volume_backend_name\u003dname1,name2,..."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"JSON response example::"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_4852a314","line":103,"updated":"2014-10-30 05:05:47.000000000","message":"Probably, it would be better to have a REST API syntax here first and then an example REST API as:\nSyntax:\n* GET /v2/extra_specs?volume_backend_name\u003dname1,name2,...\n\nOR better way:\n\n* GET /v2/extra_specs?\u003cvolume_backend_name\u003e\u003d\u003cname1[,name2,name3,...]\u003e\n\nExample REST API:\n* GET /v2/extra_specs?volume_backend_name\u003d3parfc,lefthand","commit_id":"763749e42a2b9fa88a51b73da73a2f71aef659fe"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ab4b5f4a2ddef161c5de033ce4fbe98d71def92a","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Add a new REST API to retrieve possible extra specs for a volume backend name:"},{"line_number":102,"context_line":"  * GET /v2/extra_specs?volume_backend_name\u003dname1,name2,..."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"JSON response example::"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_c383c3ca","line":103,"in_reply_to":"7a8c0949_4852a314","updated":"2014-10-30 17:12:12.000000000","message":"sure this is saying the same thing, but probably a little more clear.  Thanks for the catch Nilesh.","commit_id":"763749e42a2b9fa88a51b73da73a2f71aef659fe"},{"author":{"_account_id":9067,"name":"Nilesh Bhosale","email":"nilesh.bhosale@in.ibm.com","username":"nileshbhosale"},"change_message_id":"2959997f4521a683dde9136e0297bf6b5d182b2d","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":" extra-specs-describe \u003cvolume_backend\u003e"},{"line_number":185,"context_line":"    Lists supported volume type extra specs keys for a volume backend."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Performance Impact"},{"line_number":188,"context_line":"------------------"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_88aacbd2","line":186,"updated":"2014-10-30 05:05:47.000000000","message":"As the REST API supports querying for the extra-specs for multiple volume_backends at once, would the python cinder client shell CLI also support the same way? Like:\n $ cinder extra-spec-describe \u003cvolume_backend1[,volume_backend2,...]\u003e","commit_id":"763749e42a2b9fa88a51b73da73a2f71aef659fe"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ab4b5f4a2ddef161c5de033ce4fbe98d71def92a","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":" extra-specs-describe \u003cvolume_backend\u003e"},{"line_number":185,"context_line":"    Lists supported volume type extra specs keys for a volume backend."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Performance Impact"},{"line_number":188,"context_line":"------------------"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_6374cffd","line":186,"in_reply_to":"7a8c0949_88aacbd2","updated":"2014-10-30 17:12:12.000000000","message":"yes, it would also have to support this as well.","commit_id":"763749e42a2b9fa88a51b73da73a2f71aef659fe"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"31fe527b0006e3ee19ce8a3d74021cdb5801fa2b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"The driver\u0027s ``get_volume_stats`` method will be modified to also return a"},{"line_number":31,"context_line":"dictionary of supported volume type extra spec keys. The dictionary will include"},{"line_number":32,"context_line":"information about those keys such as key description, possible values, value"},{"line_number":33,"context_line":"range, and value type. Horizon can call this API to get the dictionary and use"},{"line_number":34,"context_line":"it in the extra specs creating or editing process.  The new ``extra_specs``"},{"line_number":35,"context_line":"dictionary will be included within the existing ``capabilities`` dictionary:"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a890539_2d8eb22e","line":33,"updated":"2014-12-03 02:13:23.000000000","message":"Horizon won\u0027t call this API directly.  Horizon will call the scheduler-stats cinder API which will include the new extra_specs dictionary for drivers that include it in their get_volume_stats methods.","commit_id":"7cc8a1e3389fc3d91b19d90c8d10715f6ad4a41a"},{"author":{"_account_id":11592,"name":"Julie Gravel","email":"julie.gravel@suse.com","username":"jgravel"},"change_message_id":"b035404a66f51f4a2680e515bea0739377a1aff6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"The driver\u0027s ``get_volume_stats`` method will be modified to also return a"},{"line_number":31,"context_line":"dictionary of supported volume type extra spec keys. The dictionary will include"},{"line_number":32,"context_line":"information about those keys such as key description, possible values, value"},{"line_number":33,"context_line":"range, and value type. Horizon can call this API to get the dictionary and use"},{"line_number":34,"context_line":"it in the extra specs creating or editing process.  The new ``extra_specs``"},{"line_number":35,"context_line":"dictionary will be included within the existing ``capabilities`` dictionary:"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a890539_a1b54aee","line":33,"in_reply_to":"5a890539_2d8eb22e","updated":"2014-12-03 06:55:58.000000000","message":"updated","commit_id":"7cc8a1e3389fc3d91b19d90c8d10715f6ad4a41a"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"31fe527b0006e3ee19ce8a3d74021cdb5801fa2b","unresolved":false,"context_lines":[{"line_number":128,"context_line":"know the exact spellings of the key/value pair that they want to set for each"},{"line_number":129,"context_line":"volume type ahead of time. Most of the time they have to look through the"},{"line_number":130,"context_line":"driver documentation or even the code to see what keys could be used in their"},{"line_number":131,"context_line":"situation."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Data model impact"},{"line_number":134,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a890539_cd728e49","line":131,"updated":"2014-12-03 02:13:23.000000000","message":"Probably should mention what happens when a driver(s) that doesn\u0027t add the extra_specs dictionary to their get_volume_stats.","commit_id":"7cc8a1e3389fc3d91b19d90c8d10715f6ad4a41a"},{"author":{"_account_id":11592,"name":"Julie Gravel","email":"julie.gravel@suse.com","username":"jgravel"},"change_message_id":"b035404a66f51f4a2680e515bea0739377a1aff6","unresolved":false,"context_lines":[{"line_number":128,"context_line":"know the exact spellings of the key/value pair that they want to set for each"},{"line_number":129,"context_line":"volume type ahead of time. Most of the time they have to look through the"},{"line_number":130,"context_line":"driver documentation or even the code to see what keys could be used in their"},{"line_number":131,"context_line":"situation."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Data model impact"},{"line_number":134,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a890539_41a106a8","line":131,"in_reply_to":"5a890539_cd728e49","updated":"2014-12-03 06:55:58.000000000","message":"I added the case you suggested to the Developer impact section which I think is more relevant.","commit_id":"7cc8a1e3389fc3d91b19d90c8d10715f6ad4a41a"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"b1d5121e29baf176a4f1d76297f891609f02758d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"value range, and value type. Once the get_volume_stats() method was modified,"},{"line_number":35,"context_line":"Horizon could call the existing ``scheduler_stats`` API call to get the"},{"line_number":36,"context_line":"dictionary and use it in the extra specs creating or editing process. The new"},{"line_number":37,"context_line":"``extra_specs`` dictionary will be included within the existing"},{"line_number":38,"context_line":"``capabilities`` dictionary:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Current json response of the ``scheduler_stats`` API call::"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_c24aeb26","line":37,"updated":"2014-12-08 01:43:51.000000000","message":"Looks like this change will impact scheduler\u0027s CapabilitiesFilter, which used to look for capabilities under \u0027capabilities\u0027 key, now they\u0027re moved to \u0027extra_specs\u0027 keys under \u0027capabilities\u0027.  Can we come up with a less invasive change so that it\u0027s backwards compatible?","commit_id":"99668b79ed559f4099a19cbb3ab931d7763e2bdb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a5371563449fffd1d64bc4e4a05d4235ead8904c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"value range, and value type. Once the get_volume_stats() method was modified,"},{"line_number":35,"context_line":"Horizon could call the existing ``scheduler_stats`` API call to get the"},{"line_number":36,"context_line":"dictionary and use it in the extra specs creating or editing process. The new"},{"line_number":37,"context_line":"``extra_specs`` dictionary will be included within the existing"},{"line_number":38,"context_line":"``capabilities`` dictionary:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Current json response of the ``scheduler_stats`` API call::"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_f30fa6df","line":37,"in_reply_to":"3a961159_c24aeb26","updated":"2014-12-08 16:17:16.000000000","message":"I don\u0027t see this.   I see the capabilities in the same place below.  They live under the capabilities key.\n\ndata[\"pools\"][0][\"capabilities\"][\"free_capacity_gb\"]\nin both cases gets you to do the data.\n\nOr are you saying that the Capabilities Filter will fail because the extra_specs are in the capabilities?    \n\nIf that is the case, then I don\u0027t see why we couldn\u0027t move the extra_specs list to the same level as capabilities, so they don\u0027t pollute the capabilities fields.","commit_id":"99668b79ed559f4099a19cbb3ab931d7763e2bdb"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"dd5cf975c863a189626dc6d1bae9d98e161d8550","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                }"},{"line_number":128,"context_line":"              }"},{"line_number":129,"context_line":"            }"},{"line_number":130,"context_line":"          ],"},{"line_number":131,"context_line":"          \"free_capacity_gb\": 7.01,"},{"line_number":132,"context_line":"          \"location_info\": \"LVMVolumeDriver:ubuntu:stack-volumes:default:0\","},{"line_number":133,"context_line":"          \"pool_name\": \"backend_name\","}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_4b24e1c4","line":130,"updated":"2014-12-11 00:09:30.000000000","message":"But before this change, things above (e.g. hplh:provisioning: thin) was part of capabilities below.","commit_id":"99668b79ed559f4099a19cbb3ab931d7763e2bdb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a5371563449fffd1d64bc4e4a05d4235ead8904c","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                }"},{"line_number":128,"context_line":"              }"},{"line_number":129,"context_line":"            }"},{"line_number":130,"context_line":"          ],"},{"line_number":131,"context_line":"          \"free_capacity_gb\": 7.01,"},{"line_number":132,"context_line":"          \"location_info\": \"LVMVolumeDriver:ubuntu:stack-volumes:default:0\","},{"line_number":133,"context_line":"          \"pool_name\": \"backend_name\","}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_7303b6b8","line":130,"updated":"2014-12-08 16:17:16.000000000","message":"This is the end of the extra_specs list.  \n\nThe capabilities are below still under the \"capabilities\" key as they should be.","commit_id":"99668b79ed559f4099a19cbb3ab931d7763e2bdb"}],"specs/kilo/validate-vol-type-extra-specs-key-value.rst":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b6e9a326c853ffe06a9d4bd7ed97f5831eaed0ef","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/cinder/+spec/validate-volume-type-extra-specs"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The purpose of this spec is to add a Cinder API to validate a volume type"},{"line_number":14,"context_line":"extra specs key/value pair that a specific driver supports. This validation"},{"line_number":15,"context_line":"will be used to improve the volume type extra spec management process in"},{"line_number":16,"context_line":"Horizon."}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_1876fed8","line":13,"updated":"2014-10-10 20:44:57.000000000","message":"We aren\u0027t actually changing the Cinder API in this case right?  We are just injecting validation in the workflow for setting extra spec keys if we can.  This all happens behind the current set API call.","commit_id":"41d4f63419578263964b7bcb60057a9b59401846"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b6e9a326c853ffe06a9d4bd7ed97f5831eaed0ef","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Alternatives"},{"line_number":39,"context_line":"------------"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"None"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Data model impact"},{"line_number":44,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_78546a21","line":41,"updated":"2014-10-10 20:44:57.000000000","message":"List out the steps that you have to do now in order to accomplish this, including the filtering of the logs to find problems.","commit_id":"41d4f63419578263964b7bcb60057a9b59401846"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"575e2d31317dcd561da2b742eaefa618d04ad272","unresolved":false,"context_lines":[{"line_number":48,"context_line":"REST API impact"},{"line_number":49,"context_line":"---------------"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"None"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Security impact"},{"line_number":54,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_c48f3074","line":51,"updated":"2014-10-10 22:52:39.000000000","message":"New return values for set is a rest api change","commit_id":"41d4f63419578263964b7bcb60057a9b59401846"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b6e9a326c853ffe06a9d4bd7ed97f5831eaed0ef","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Developer impact"},{"line_number":80,"context_line":"----------------"},{"line_number":81,"context_line":"None"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_d83ab6e6","line":81,"updated":"2014-10-10 20:44:57.000000000","message":"Driver developers can be impacted by this.   They should implement the new driver method that does the key/value validation.","commit_id":"41d4f63419578263964b7bcb60057a9b59401846"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"0b3fa8fa8db5871f2254917f73ca384a22671150","unresolved":false,"context_lines":[{"line_number":34,"context_line":"perform the validation of the new key/value pair before adding the pair to the"},{"line_number":35,"context_line":"extra specs. If the validation succeeds, the API will behave exactly as it was"},{"line_number":36,"context_line":"before. Otherwise, the API will report the failed validation with a reasonable"},{"line_number":37,"context_line":"explanation."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Alternatives"},{"line_number":40,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa201ad_48812ac2","line":37,"updated":"2014-10-15 15:55:38.000000000","message":"The information for this is simply not known in many cases. Maybe provide a dry run of the type to get gross errors, but without adding a bunch of calls to the scheduler and drivers, doing this completely is going to be hard.\n\nI guess we can add the API, have it catch the errors it can and add more checks later","commit_id":"e9c9ffee355d13034a5e9ed283a1eda09175de21"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"fee2785e03c836ebd8619048eeed6ebd4a8aaef8","unresolved":false,"context_lines":[{"line_number":58,"context_line":"---------------"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Current REST API to be enhanced:"},{"line_number":61,"context_line":"  * POST /v2/{tenant_id}/types/{type_id}/extra_specs"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Security impact"},{"line_number":64,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_e62b55e9","line":61,"updated":"2014-10-21 08:39:28.000000000","message":"Can you provide an example that explains the key/value pair validation workflow in a case where: there are 2 cinder-volume services running, 1st c-vol service has 2 pools (1st-A, 1st-B) and 2nd c-vol service has 2 pools (2nd-A, 2nd-B); and all 4 pools have different capabilities (extra specs).\n\n               extra spec key     valid value\n  pool: 1st-A   \n        |____   QoS support         True\n        |____   QoS setting       High/Medium/Low\n        |____   High QoS IOPS      100 ~ 150,000\n        |____   Medium QoS IOPS    100 ~ 100,000\n        |____   Low QoS IOPS       100 ~ 50,000\n        |____  replica count       (1,2,3,4)\n\n  pool: 1st-B\n        |____   QoS support         True\n        |____   QoS setting       High/Medium/Low\n        |____   High QoS IOPS      100 ~ 100,000\n        |____   Medium QoS IOPS    100 ~ 50,000\n        |____   Low QoS IOPS       100 ~ 25,000\n        |____  replica count       (1,2)\n\n  pool: 2nd-A\n        |____   QoS support         rate_limit/guarantee\n        |____   qos_rate_limit          100 ~ 100,000\n        |____   qos_guarantee           100 ~ 100,000\n\n  pool: 2nd-B\n        |____   QoS support         rate_limit\n        |____   qos_rate_limit          100 ~ 50,000\n\nThe admin user wants to create two volume types A and B. Type A will have 2 replicas and has upper IOPS limit of 25,000.  Type B will be have graranteed 5,000 IOPS.\n\nI\u0027d like to understand how this blueprint helps in such case.  Thanks.","commit_id":"700f6de0607efd6b83d41065d6cf9a5e4e59cf2f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e1debef0b59fdd1313b5a170ee9571be3efce334","unresolved":false,"context_lines":[{"line_number":58,"context_line":"---------------"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Current REST API to be enhanced:"},{"line_number":61,"context_line":"  * POST /v2/{tenant_id}/types/{type_id}/extra_specs"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Security impact"},{"line_number":64,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_3285f706","line":61,"in_reply_to":"9aa7fdbe_e62b55e9","updated":"2014-10-27 18:59:56.000000000","message":"First off, the validation of the values for the supported keys, is completely and entirely up to the driver to implement, or not. \nIf your driver doesn\u0027t want to validate any values, and say they are all good (which is how it is today), then great, that will be the fall back.\n\nThe entire point of this spec is to allow the driver to have a chance to do something with the values the admin user is setting, prior to the settings being saved in the db.   If all of those values are fine with driver X, Y and Z, then great.   If they want to limit the qos_rate_limit to \u003c 100k, then they have the option of validating that and returning an error.\n\nRight now, there is no mechanism for drivers to provide any feedback for the values they set for the supported extra spec keys.   Drivers can choose to be smart and validate the values the best they can, or they can choose to do nothing at all.   \n\nThe overall idea here is to try and provide a better experience for the create volume type workflow for admins.   This really doesn\u0027t have anything to do with pools at all.   It\u0027s simply a new mechanism for drivers to provide feedback at the time of volume type creation.","commit_id":"700f6de0607efd6b83d41065d6cf9a5e4e59cf2f"}]}
