)]}'
{"specs/kilo/linux-systemz.rst":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"429184d07a7e5b6e3f2fdd9fb7925bd9522efada","unresolved":false,"context_lines":[{"line_number":1,"context_line":"..\r"},{"line_number":2,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported\r"},{"line_number":3,"context_line":" License.\r"},{"line_number":4,"context_line":"\r"},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_e1865eda","line":2,"updated":"2014-12-12 05:46:30.000000000","message":"Please remove all the \"\\r\".  Seems to be carriage return on windows?","commit_id":"2db7d493f9bd25baed2e48adddaa2c890c5a17bd"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"bdf05fa7980512a70b9653e249de3791e38453c6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"..\r"},{"line_number":2,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported\r"},{"line_number":3,"context_line":" License.\r"},{"line_number":4,"context_line":"\r"},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_3ce5e837","line":2,"in_reply_to":"3a961159_e1865eda","updated":"2014-12-12 14:20:04.000000000","message":"Sorry about that... I will remove them","commit_id":"2db7d493f9bd25baed2e48adddaa2c890c5a17bd"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"429184d07a7e5b6e3f2fdd9fb7925bd9522efada","unresolved":false,"context_lines":[{"line_number":28,"context_line":"\r"},{"line_number":29,"context_line":"* Auto-discovery for fibre-channel devices can be configured online, or\r"},{"line_number":30,"context_line":"  offline. In case auto-discovery is turned off, devices need to be\r"},{"line_number":31,"context_line":"  added, and removed explicitly by OpenStack (unit_add, unit_remove)\r"},{"line_number":32,"context_line":"\r"},{"line_number":33,"context_line":"\r"},{"line_number":34,"context_line":"Proposed change\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_41e3b2a3","line":31,"updated":"2014-12-12 05:46:30.000000000","message":"Is iSCSi supported other than FC?","commit_id":"2db7d493f9bd25baed2e48adddaa2c890c5a17bd"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"bdf05fa7980512a70b9653e249de3791e38453c6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"\r"},{"line_number":29,"context_line":"* Auto-discovery for fibre-channel devices can be configured online, or\r"},{"line_number":30,"context_line":"  offline. In case auto-discovery is turned off, devices need to be\r"},{"line_number":31,"context_line":"  added, and removed explicitly by OpenStack (unit_add, unit_remove)\r"},{"line_number":32,"context_line":"\r"},{"line_number":33,"context_line":"\r"},{"line_number":34,"context_line":"Proposed change\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_7c3930a3","line":31,"in_reply_to":"3a961159_41e3b2a3","updated":"2014-12-12 14:20:04.000000000","message":"Our plan was to release support for iSCSI later. But I will check again. Required changes should be small. I will update the Blueprint accordingly","commit_id":"2db7d493f9bd25baed2e48adddaa2c890c5a17bd"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"431341350fbdd82193ee46fcf2748d2e348cbd6c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"\r"},{"line_number":29,"context_line":"* Auto-discovery for fibre-channel devices can be configured online, or\r"},{"line_number":30,"context_line":"  offline. In case auto-discovery is turned off, devices need to be\r"},{"line_number":31,"context_line":"  added, and removed explicitly by OpenStack (unit_add, unit_remove)\r"},{"line_number":32,"context_line":"\r"},{"line_number":33,"context_line":"\r"},{"line_number":34,"context_line":"Proposed change\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_04cc1f88","line":31,"in_reply_to":"3a961159_7c3930a3","updated":"2014-12-15 09:24:51.000000000","message":"we tried OpenStack with iSCSI on System z. It ran without requiring any modifications","commit_id":"2db7d493f9bd25baed2e48adddaa2c890c5a17bd"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"429184d07a7e5b6e3f2fdd9fb7925bd9522efada","unresolved":false,"context_lines":[{"line_number":38,"context_line":"capabilities indicating a CPU architecture of ``arch.S390X``, and\r"},{"line_number":39,"context_line":"``arch.S390``.\r"},{"line_number":40,"context_line":"For details, see section `Work Items`_.\r"},{"line_number":41,"context_line":"\r"},{"line_number":42,"context_line":"Alternatives\r"},{"line_number":43,"context_line":"------------\r"},{"line_number":44,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_e1ebbe75","line":41,"updated":"2014-12-12 05:46:30.000000000","message":"The proposed change section needs more details.","commit_id":"2db7d493f9bd25baed2e48adddaa2c890c5a17bd"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"bdf05fa7980512a70b9653e249de3791e38453c6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"capabilities indicating a CPU architecture of ``arch.S390X``, and\r"},{"line_number":39,"context_line":"``arch.S390``.\r"},{"line_number":40,"context_line":"For details, see section `Work Items`_.\r"},{"line_number":41,"context_line":"\r"},{"line_number":42,"context_line":"Alternatives\r"},{"line_number":43,"context_line":"------------\r"},{"line_number":44,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_bcb47882","line":41,"in_reply_to":"3a961159_210b062b","updated":"2014-12-12 14:20:04.000000000","message":"The Nova changes are covered by the blueprint referenced below as a dependency: https://blueprints.launchpad.net/nova/+spec/libvirt-kvm-systemz\nI can add a comment and copy further details. Do you think this is sufficient?\n\nFor Cinder, we have made the following changes so far:\n\nconnector.py\n-------------\n\nconnect_volume, and disconnect_volume:\n\nif (platform.machine() \u003d\u003d \u0027s390x\u0027:\n    host_device \u003d (\"/dev/disk/by-path/ccw-%s-zfcp-%s:%s\"...\n    self._linuxfc.configure_scsi_device(...)\nelse:\n    host_device \u003d ...\n\nlinuxfc.py\n-----------\n\nnew functions:\n\ndef configure_scsi_device(..)\n    zfcp_device_command \u003d \n        (\"/sys/bus/ccw/drivers/zfcp/%s/%s/unit_add\"...\n\ndef deconfigure_scsi_device(..)\n    zfcp_device_command \u003d \n        (\"/sys/bus/ccw/drivers/zfcp/%s/%s/unit_remove\"...\n\nchanged functions (vHBAs might be turned offline on a System z machine. Cinder should only consider those turned online):\n\ndef get_fc_hbas_info():\n    for hba in hbas:\n         if (platform.machine() !\u003d \u0027s390x\u0027) or \n             (hba[\u0027port_state\u0027] \u003d\u003d \u0027Online\u0027):","commit_id":"2db7d493f9bd25baed2e48adddaa2c890c5a17bd"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"bde63e338735117a2b187ee8bf7a0111dbe6a9e7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"capabilities indicating a CPU architecture of ``arch.S390X``, and\r"},{"line_number":39,"context_line":"``arch.S390``.\r"},{"line_number":40,"context_line":"For details, see section `Work Items`_.\r"},{"line_number":41,"context_line":"\r"},{"line_number":42,"context_line":"Alternatives\r"},{"line_number":43,"context_line":"------------\r"},{"line_number":44,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_210b062b","line":41,"in_reply_to":"3a961159_e1ebbe75","updated":"2014-12-12 05:53:58.000000000","message":"This has large ramifications including nova.  If the device paths are different, then the brick connector code for discovering volumes showing up in /dev/disk/by-path needs to change, which also means changes in Nova\u0027s libvirt volume drivers.\n\nPlease go into more detail about the exact proposed changes.","commit_id":"2db7d493f9bd25baed2e48adddaa2c890c5a17bd"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"429184d07a7e5b6e3f2fdd9fb7925bd9522efada","unresolved":false,"context_lines":[{"line_number":106,"context_line":"* connect_volume and disconnect_volume need to support the System z\r"},{"line_number":107,"context_line":"  specific format of the device file paths.\r"},{"line_number":108,"context_line":"* in connect_volume: issue unit_add command when adding a multipath\r"},{"line_number":109,"context_line":"  device to the configuration.\r"},{"line_number":110,"context_line":"* in disconnect_volume: issue unit_remove command when removing a\r"},{"line_number":111,"context_line":"  multipath device from the configuration.\r"},{"line_number":112,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_61a50e46","line":109,"updated":"2014-12-12 05:46:30.000000000","message":"Do multipathd commands still work?","commit_id":"2db7d493f9bd25baed2e48adddaa2c890c5a17bd"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"bdf05fa7980512a70b9653e249de3791e38453c6","unresolved":false,"context_lines":[{"line_number":106,"context_line":"* connect_volume and disconnect_volume need to support the System z\r"},{"line_number":107,"context_line":"  specific format of the device file paths.\r"},{"line_number":108,"context_line":"* in connect_volume: issue unit_add command when adding a multipath\r"},{"line_number":109,"context_line":"  device to the configuration.\r"},{"line_number":110,"context_line":"* in disconnect_volume: issue unit_remove command when removing a\r"},{"line_number":111,"context_line":"  multipath device from the configuration.\r"},{"line_number":112,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_fcb1a08f","line":109,"in_reply_to":"3a961159_61a50e46","updated":"2014-12-12 14:20:04.000000000","message":"yes. The unit_add / unit_remove is required in addition.","commit_id":"2db7d493f9bd25baed2e48adddaa2c890c5a17bd"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"bde63e338735117a2b187ee8bf7a0111dbe6a9e7","unresolved":false,"context_lines":[{"line_number":111,"context_line":"  multipath device from the configuration.\r"},{"line_number":112,"context_line":"\r"},{"line_number":113,"context_line":"\r"},{"line_number":114,"context_line":"In ``cinder/brick/initiator/linuxfc.py``:\r"},{"line_number":115,"context_line":"\r"},{"line_number":116,"context_line":"* Utility functions for the FCP support issues described above.\r"},{"line_number":117,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_0c15613f","line":114,"updated":"2014-12-12 05:53:58.000000000","message":"This shouldn\u0027t just be a change to linuxfc as there is iSCSI as well.","commit_id":"2db7d493f9bd25baed2e48adddaa2c890c5a17bd"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"bdf05fa7980512a70b9653e249de3791e38453c6","unresolved":false,"context_lines":[{"line_number":111,"context_line":"  multipath device from the configuration.\r"},{"line_number":112,"context_line":"\r"},{"line_number":113,"context_line":"\r"},{"line_number":114,"context_line":"In ``cinder/brick/initiator/linuxfc.py``:\r"},{"line_number":115,"context_line":"\r"},{"line_number":116,"context_line":"* Utility functions for the FCP support issues described above.\r"},{"line_number":117,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_5c7c74b5","line":114,"in_reply_to":"3a961159_0c15613f","updated":"2014-12-12 14:20:04.000000000","message":"The changes we did are fibre-channel specific. iSCSI does not require the unit_add/unit_remove. Nor the check which vHBAs are enabled. \nAs said above, I will check what it takes to also enable support for iSCSI. And then decide if this blueprint will be fibre-channel only.","commit_id":"2db7d493f9bd25baed2e48adddaa2c890c5a17bd"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"bde63e338735117a2b187ee8bf7a0111dbe6a9e7","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"\r"},{"line_number":126,"context_line":"Testing\r"},{"line_number":127,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\r"},{"line_number":128,"context_line":"\r"},{"line_number":129,"context_line":"Unit test:\r"},{"line_number":130,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_2c121d57","line":127,"updated":"2014-12-12 05:53:58.000000000","message":"Not only do we need unit tests, but how do we add CI testing and gating on these changes as well?","commit_id":"2db7d493f9bd25baed2e48adddaa2c890c5a17bd"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"bdf05fa7980512a70b9653e249de3791e38453c6","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"\r"},{"line_number":126,"context_line":"Testing\r"},{"line_number":127,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\r"},{"line_number":128,"context_line":"\r"},{"line_number":129,"context_line":"Unit test:\r"},{"line_number":130,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_5c539438","line":127,"in_reply_to":"3a961159_2c121d57","updated":"2014-12-12 14:20:04.000000000","message":"CI testing is described by the nova blueprint. I can mention it here again, if you think it is required.\nI was assuming we were covered since we list the nova blueprint as a dependency","commit_id":"2db7d493f9bd25baed2e48adddaa2c890c5a17bd"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"429184d07a7e5b6e3f2fdd9fb7925bd9522efada","unresolved":false,"context_lines":[{"line_number":128,"context_line":"\r"},{"line_number":129,"context_line":"Unit test:\r"},{"line_number":130,"context_line":"\r"},{"line_number":131,"context_line":"* Existing unit tests should suffice since no API changes are expected\r"},{"line_number":132,"context_line":"\r"},{"line_number":133,"context_line":"\r"},{"line_number":134,"context_line":"Documentation Impact\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_414c92c8","line":131,"updated":"2014-12-12 05:46:30.000000000","message":"You\u0027ll need to add new unit tests for a change like this.","commit_id":"2db7d493f9bd25baed2e48adddaa2c890c5a17bd"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"bdf05fa7980512a70b9653e249de3791e38453c6","unresolved":false,"context_lines":[{"line_number":128,"context_line":"\r"},{"line_number":129,"context_line":"Unit test:\r"},{"line_number":130,"context_line":"\r"},{"line_number":131,"context_line":"* Existing unit tests should suffice since no API changes are expected\r"},{"line_number":132,"context_line":"\r"},{"line_number":133,"context_line":"\r"},{"line_number":134,"context_line":"Documentation Impact\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_cf0c283e","line":131,"in_reply_to":"3a961159_414c92c8","updated":"2014-12-12 14:20:04.000000000","message":"Ok, even though we do not provide any new functionality and the code is (only) executed as part of the \u0027normal\u0027 initialize_connection/connect_volume sequence?","commit_id":"2db7d493f9bd25baed2e48adddaa2c890c5a17bd"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"45913e811f9582ebaca44d858b0a7a9dd8fd920b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Linux on System z differs from other Linux platforms in two respects:"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* System z uses a different format for device file paths (ccw-based, rather"},{"line_number":32,"context_line":"  than pci-based)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Auto-discovery for fibre-channel devices can be configured online, or"},{"line_number":35,"context_line":"  offline. In case auto-discovery is turned off, devices need to be"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_6d987175","line":32,"updated":"2014-12-23 20:22:10.000000000","message":"I would still like more of an explaination of what is needed.   I see the work items below, but it\u0027t not sufficient.   please provide some details and examples of why the existing code doesn\u0027t work.","commit_id":"e3a9c6422fbd974c891c139443609df41a2fcc76"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6f65b1f9353920ebc9b0ed639bc8a9485f918bd8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Linux on System z differs from other Linux platforms in two respects:"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* System z uses a different format for device file paths (ccw-based, rather"},{"line_number":32,"context_line":"  than pci-based)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Auto-discovery for fibre-channel devices can be configured online, or"},{"line_number":35,"context_line":"  offline. In case auto-discovery is turned off, devices need to be"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_6d8cf1d7","line":32,"in_reply_to":"3a961159_6d987175","updated":"2014-12-23 20:46:48.000000000","message":"Agree with Walt that we need more details here.","commit_id":"e3a9c6422fbd974c891c139443609df41a2fcc76"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"45913e811f9582ebaca44d858b0a7a9dd8fd920b","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"* Existing unit tests should suffice since no API changes are expected."},{"line_number":139,"context_line":"  Above code changes will be executed as part of main code execution"},{"line_number":140,"context_line":"  paths, such as the initialize_connection/connect_volume sequence."},{"line_number":141,"context_line":"* We will provide an environment for CI testing. This is described by"},{"line_number":142,"context_line":"  the Nova blueprint which is listed as a dependency."},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_8da3ddb0","line":140,"updated":"2014-12-23 20:22:10.000000000","message":"any new code added into cinder needs unit tests.   you will need to unit test the new paths that this is looking for to make sure it\u0027s correct for system z and non system z","commit_id":"e3a9c6422fbd974c891c139443609df41a2fcc76"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6f65b1f9353920ebc9b0ed639bc8a9485f918bd8","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"* Existing unit tests should suffice since no API changes are expected."},{"line_number":139,"context_line":"  Above code changes will be executed as part of main code execution"},{"line_number":140,"context_line":"  paths, such as the initialize_connection/connect_volume sequence."},{"line_number":141,"context_line":"* We will provide an environment for CI testing. This is described by"},{"line_number":142,"context_line":"  the Nova blueprint which is listed as a dependency."},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_2d5bc954","line":140,"in_reply_to":"3a961159_8da3ddb0","updated":"2014-12-23 20:46:48.000000000","message":"+1","commit_id":"e3a9c6422fbd974c891c139443609df41a2fcc76"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6f65b1f9353920ebc9b0ed639bc8a9485f918bd8","unresolved":false,"context_lines":[{"line_number":138,"context_line":"* Existing unit tests should suffice since no API changes are expected."},{"line_number":139,"context_line":"  Above code changes will be executed as part of main code execution"},{"line_number":140,"context_line":"  paths, such as the initialize_connection/connect_volume sequence."},{"line_number":141,"context_line":"* We will provide an environment for CI testing. This is described by"},{"line_number":142,"context_line":"  the Nova blueprint which is listed as a dependency."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_ed45416f","line":141,"updated":"2014-12-23 20:46:48.000000000","message":"So you mean a Nova CI.  Will you be using system z in any of your Cinder CI setup?","commit_id":"e3a9c6422fbd974c891c139443609df41a2fcc76"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ec8171ac045e6b7788f2c7f1a778a1849e0c4ee4","unresolved":false,"context_lines":[{"line_number":138,"context_line":"* Existing unit tests should suffice since no API changes are expected."},{"line_number":139,"context_line":"  Above code changes will be executed as part of main code execution"},{"line_number":140,"context_line":"  paths, such as the initialize_connection/connect_volume sequence."},{"line_number":141,"context_line":"* We will provide an environment for CI testing. This is described by"},{"line_number":142,"context_line":"  the Nova blueprint which is listed as a dependency."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_c0085c93","line":141,"in_reply_to":"3a961159_ed45416f","updated":"2015-01-08 03:49:36.000000000","message":"Can you please answer my question? Thanks.","commit_id":"e3a9c6422fbd974c891c139443609df41a2fcc76"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a4aab7d09e841045e8b12f9ed18e4584d3e2b616","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"* Unit tests will be added and performed on System z, as well as"},{"line_number":230,"context_line":"  Intel-based machines."},{"line_number":231,"context_line":"* We will provide an environment for Nova CI testing on System z."},{"line_number":232,"context_line":"  This is described by the Nova blueprint which is listed as a dependency."},{"line_number":233,"context_line":""},{"line_number":234,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_c02f7cf4","line":231,"updated":"2015-01-08 03:51:14.000000000","message":"I have a question on this in patch set 3. Can you please provide an answer?  I was asking whether you are planning to use System z on any of your Cinder CI setup.","commit_id":"d3656e1bb63a833f041195985323b62707116c2a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"77bde07745074c4d87e13a05e0a5bb6d7c2a2caf","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/cinder/+spec/linux-systemz"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There are some platform-specific changes needed in order to allow Cinder"},{"line_number":14,"context_line":"manage FCP-based block storage on Linux on System z."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Additional OpenStack functionality beyond initial Cinder support is not part of"},{"line_number":17,"context_line":"this blueprint; we will have specific additional blueprints for that, as"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a930d6b_18b732f6","line":14,"updated":"2015-01-27 13:59:42.000000000","message":"/allow Cinder manage/allow Cinder to manage/","commit_id":"e7731f7be83ec5d2d81a3d01b12d8f4ea06cbfd1"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"0b2e5785749c8fca7b5ed0094b30f1195abf4033","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Change code in Cinder to address these issues, dependent on the host"},{"line_number":46,"context_line":"capabilities indicating a CPU architecture of ``arch.S390X``, and"},{"line_number":47,"context_line":"``arch.S390``."},{"line_number":48,"context_line":"For details, see section `Work Items`_."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da86d52c_98d1ca59","line":47,"updated":"2015-02-03 19:25:34.000000000","message":"I only saw S90X in the code.  Is this comment accurate?","commit_id":"e7731f7be83ec5d2d81a3d01b12d8f4ea06cbfd1"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"ec3e42068636763ae601dad7837bee87820e8ea4","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Change code in Cinder to address these issues, dependent on the host"},{"line_number":46,"context_line":"capabilities indicating a CPU architecture of ``arch.S390X``, and"},{"line_number":47,"context_line":"``arch.S390``."},{"line_number":48,"context_line":"For details, see section `Work Items`_."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da86d52c_ce6ff8c3","line":47,"in_reply_to":"da86d52c_98d1ca59","updated":"2015-02-03 20:09:21.000000000","message":"I remember s390 is 32 and s390x is 64 bit system :)","commit_id":"e7731f7be83ec5d2d81a3d01b12d8f4ea06cbfd1"}]}