)]}'
{"specs/kilo/driver-private-data.rst":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"0a354688ef2f5532a474e6c322d717e0bddcf1ab","unresolved":false,"context_lines":[{"line_number":27,"context_line":"drivers storing information on the backend which works for some but not all"},{"line_number":28,"context_line":"backends have this capability."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"A use case for this is for storing CHAP secrets for iSCSI initiators for"},{"line_number":31,"context_line":"backends which cannot store/retrive the credentials and that do not have per-"},{"line_number":32,"context_line":"volume credentials."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_693a1c9a","line":30,"updated":"2015-02-06 04:15:34.000000000","message":"I think we should be careful here with the use of initiator in this context.   \n\niSCSI can have 2 way CHAP, one for targets and one for initiators.   \n\nIn this case what you are actually storing is the CHAP credentials that are requried to auth the Target side.   We aren\u0027t storing initiator CHAP credentials (CHAP needed for a target to auth against the initiator).  We are storing target CHAP credentials (what\u0027s needed to auth against the target).","commit_id":"a67faf030045a33003cf8379465c0379ccb1aa01"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"4bb1349c2ed59d5c4518c8f1aa5259d0cfd8e9b8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"drivers storing information on the backend which works for some but not all"},{"line_number":28,"context_line":"backends have this capability."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"A use case for this is for storing CHAP secrets for iSCSI initiators for"},{"line_number":31,"context_line":"backends which cannot store/retrive the credentials and that do not have per-"},{"line_number":32,"context_line":"volume credentials."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_ddabab73","line":30,"in_reply_to":"da86d52c_693a1c9a","updated":"2015-02-06 18:52:46.000000000","message":"Hmm yea the naming makes this confusing, my intention is to store the credentials the initiator uses to authenticate with the target, but in the future I don\u0027t see why we wouldn\u0027t want to do 2 way CHAP (I know the Pure Storage FlashArray\u0027s can do that). \n\nIf we want to make this table very specific to iSCSI CHAP we could make it more like:\n\ninitiator_iqn, target_iqn, initiator_secret, initiator_username, target_secret, target_username\n\nwhere the unique constraint in the initiator_iqn and target_iqn\n\nWith what I have proposed we would have to do something like:\n\n\u0027initiator\u0027 maps to initiator iqn\nkey maps to target iqn\nvalue maps to a json string that has the info like:\n\n{\n    \"initiator_username\":\"foo\",\n    \"initiator_secret\":\"bar\",\n    \"target_username\":\"foo2\",\n    \"target_secret\":\"bar2\"\n}","commit_id":"a67faf030045a33003cf8379465c0379ccb1aa01"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cb06f13c6afb7f1fb0edb8b8bb93d0e13183722a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"drivers storing information on the backend which works for some but not all"},{"line_number":28,"context_line":"backends have this capability."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"A use case for this is for storing CHAP secrets for iSCSI initiators for"},{"line_number":31,"context_line":"backends which cannot store/retrive the credentials and that do not have per-"},{"line_number":32,"context_line":"volume credentials."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_8c9763eb","line":30,"in_reply_to":"da86d52c_ddabab73","updated":"2015-02-12 18:22:59.000000000","message":"for the record, I wasn\u0027t really saying change the spec to support 2 way chap.  I was more concerned with the fact that you are storing target CHAP credentials, and yet calling them initiator.","commit_id":"a67faf030045a33003cf8379465c0379ccb1aa01"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"5d5db255b50d0322eeb618348d41cddae396dcdf","unresolved":false,"context_lines":[{"line_number":27,"context_line":"drivers storing information on the backend which works for some but not all"},{"line_number":28,"context_line":"backends have this capability."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"A use case for this is for storing CHAP secrets for iSCSI initiators for"},{"line_number":31,"context_line":"backends which cannot store/retrive the credentials and that do not have per-"},{"line_number":32,"context_line":"volume credentials."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_05214fb4","line":30,"in_reply_to":"da86d52c_ddabab73","updated":"2015-02-08 22:23:12.000000000","message":"ok I think that makes more sense.","commit_id":"a67faf030045a33003cf8379465c0379ccb1aa01"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"3ad2773725241820c15d6c3ff46ae78c10324b3f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"backends have this capability."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"A use case for this is for storing CHAP secrets for iSCSI initiators for"},{"line_number":31,"context_line":"backends which cannot store/retrive the credentials and that do not have per-"},{"line_number":32,"context_line":"volume credentials."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_d9939f4d","line":31,"updated":"2015-02-09 05:19:23.000000000","message":"retrieve","commit_id":"a67faf030045a33003cf8379465c0379ccb1aa01"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"8016bce78cafe78958a3fc9ada8b3f494b80b0e5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"backends have this capability."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"A use case for this is for storing CHAP secrets for iSCSI initiators for"},{"line_number":31,"context_line":"backends which cannot store/retrive the credentials and that do not have per-"},{"line_number":32,"context_line":"volume credentials."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_455de214","line":31,"in_reply_to":"da86d52c_d9939f4d","updated":"2015-02-09 18:41:05.000000000","message":"Done","commit_id":"a67faf030045a33003cf8379465c0379ccb1aa01"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"3ad2773725241820c15d6c3ff46ae78c10324b3f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  | created_at | datetime     |                                          |"},{"line_number":47,"context_line":"  | updated_at | datetime     |                                          |"},{"line_number":48,"context_line":"  | deleted_at | datetime     |                                          |"},{"line_number":49,"context_line":"  | delted     | tinyint(1)   |                                          |"},{"line_number":50,"context_line":"  | id         | int(11)      | Auto incremented ID                      |"},{"line_number":51,"context_line":"  | initiator  | varchar(255) | Unique constraint with \"key\"             |"},{"line_number":52,"context_line":"  | key        | varchar(255) | Unique constraint with \"initiator\"       |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_b9b50bd2","line":49,"updated":"2015-02-09 05:19:23.000000000","message":"deleted","commit_id":"a67faf030045a33003cf8379465c0379ccb1aa01"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"8016bce78cafe78958a3fc9ada8b3f494b80b0e5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  | created_at | datetime     |                                          |"},{"line_number":47,"context_line":"  | updated_at | datetime     |                                          |"},{"line_number":48,"context_line":"  | deleted_at | datetime     |                                          |"},{"line_number":49,"context_line":"  | delted     | tinyint(1)   |                                          |"},{"line_number":50,"context_line":"  | id         | int(11)      | Auto incremented ID                      |"},{"line_number":51,"context_line":"  | initiator  | varchar(255) | Unique constraint with \"key\"             |"},{"line_number":52,"context_line":"  | key        | varchar(255) | Unique constraint with \"initiator\"       |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_859efab6","line":49,"in_reply_to":"da86d52c_b9b50bd2","updated":"2015-02-09 18:41:05.000000000","message":"Done","commit_id":"a67faf030045a33003cf8379465c0379ccb1aa01"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"0a354688ef2f5532a474e6c322d717e0bddcf1ab","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  | deleted_at | datetime     |                                          |"},{"line_number":49,"context_line":"  | delted     | tinyint(1)   |                                          |"},{"line_number":50,"context_line":"  | id         | int(11)      | Auto incremented ID                      |"},{"line_number":51,"context_line":"  | initiator  | varchar(255) | Unique constraint with \"key\"             |"},{"line_number":52,"context_line":"  | key        | varchar(255) | Unique constraint with \"initiator\"       |"},{"line_number":53,"context_line":"  | value      | varchar(255) | This could be anything a driver wants to |"},{"line_number":54,"context_line":"  |            |              | keep track of for this initiator. In the |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_c95a28f1","line":51,"updated":"2015-02-06 04:15:34.000000000","message":"shoudn\u0027t we be storing the target_iqn here as the unique?\n\nwhat we are storing here is the CHAP credentials associated with the target iqn, not the initiator iqn.","commit_id":"a67faf030045a33003cf8379465c0379ccb1aa01"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"3798559e57441dba5b2d3337543012afcf60ba7c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  | deleted_at | datetime     |                                          |"},{"line_number":49,"context_line":"  | delted     | tinyint(1)   |                                          |"},{"line_number":50,"context_line":"  | id         | int(11)      | Auto incremented ID                      |"},{"line_number":51,"context_line":"  | initiator  | varchar(255) | Unique constraint with \"key\"             |"},{"line_number":52,"context_line":"  | key        | varchar(255) | Unique constraint with \"initiator\"       |"},{"line_number":53,"context_line":"  | value      | varchar(255) | This could be anything a driver wants to |"},{"line_number":54,"context_line":"  |            |              | keep track of for this initiator. In the |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_48f43b87","line":51,"in_reply_to":"da86d52c_452b4794","updated":"2015-02-09 01:58:55.000000000","message":"As-is we would have to put more of the smarts in the driver code. It would probably work, but it isn\u0027t very clean... an example entry in the db could be like:\n\ninitiator \u003d \"someInitiatorIQN\"\nkey \u003d \"someTargetIQN\"\nvalue \u003d \u0027{\n    \"initiator_username\":\"foo\",\n    \"initiator_secret\":\"bar\",\n    \"target_username\":\"foo2\",\n    \"target_secret\":\"bar2\"\n}\u0027\n\nSo the driver implementing initialize_connection() would get a bunch of these entries that are for the initiator being connected to, it would then have to iterate through looking for one with a key that matches up with the target iqn, and then pull out he info for the keys to return in the connection info.\n\nTo make things nicer we could use a more specialized table for iSCSI CHAP credentials and maybe let the manager code go and look them up. The potential downside being that this table isn\u0027t open ended and limits any other uses (although that could be viewed as a bonus too).\n\nI think either approach can provide everything we need for 2 way chap.\n\nWhat would you prefer? Specialized or open not-meta-data-but-kinda-still-meta-data table?","commit_id":"a67faf030045a33003cf8379465c0379ccb1aa01"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"5d5db255b50d0322eeb618348d41cddae396dcdf","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  | deleted_at | datetime     |                                          |"},{"line_number":49,"context_line":"  | delted     | tinyint(1)   |                                          |"},{"line_number":50,"context_line":"  | id         | int(11)      | Auto incremented ID                      |"},{"line_number":51,"context_line":"  | initiator  | varchar(255) | Unique constraint with \"key\"             |"},{"line_number":52,"context_line":"  | key        | varchar(255) | Unique constraint with \"initiator\"       |"},{"line_number":53,"context_line":"  | value      | varchar(255) | This could be anything a driver wants to |"},{"line_number":54,"context_line":"  |            |              | keep track of for this initiator. In the |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_452b4794","line":51,"in_reply_to":"da86d52c_7deb9fb0","updated":"2015-02-08 22:23:12.000000000","message":"How do you intend in combining the above discussion about possible 2 way chap with this table schema?","commit_id":"a67faf030045a33003cf8379465c0379ccb1aa01"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"4bb1349c2ed59d5c4518c8f1aa5259d0cfd8e9b8","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  | deleted_at | datetime     |                                          |"},{"line_number":49,"context_line":"  | delted     | tinyint(1)   |                                          |"},{"line_number":50,"context_line":"  | id         | int(11)      | Auto incremented ID                      |"},{"line_number":51,"context_line":"  | initiator  | varchar(255) | Unique constraint with \"key\"             |"},{"line_number":52,"context_line":"  | key        | varchar(255) | Unique constraint with \"initiator\"       |"},{"line_number":53,"context_line":"  | value      | varchar(255) | This could be anything a driver wants to |"},{"line_number":54,"context_line":"  |            |              | keep track of for this initiator. In the |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_7deb9fb0","line":51,"in_reply_to":"da86d52c_c95a28f1","updated":"2015-02-06 18:52:46.000000000","message":"I was thinking the initiator iqn was part of the constraint so that it could be looked up by the manager before being passed into a driver, I don\u0027t think we would know the target iqn at that time.","commit_id":"a67faf030045a33003cf8379465c0379ccb1aa01"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"3ad2773725241820c15d6c3ff46ae78c10324b3f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"  somewhere. Some drawbacks to this approach include having different"},{"line_number":107,"context_line":"  databases to maintain, update, and keep in sync which would be a less than"},{"line_number":108,"context_line":"  desireable user experience for a cloud admin, having multiple ways of doing"},{"line_number":109,"context_line":"  synchronization/locking in drivers can and will introduce bugs and maintence"},{"line_number":110,"context_line":"  problems, and makes it more difficult for new driver developers to make a"},{"line_number":111,"context_line":"  good choice on where to store data."},{"line_number":112,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_39d03bf7","line":109,"updated":"2015-02-09 05:19:23.000000000","message":"maintenance","commit_id":"a67faf030045a33003cf8379465c0379ccb1aa01"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"8016bce78cafe78958a3fc9ada8b3f494b80b0e5","unresolved":false,"context_lines":[{"line_number":106,"context_line":"  somewhere. Some drawbacks to this approach include having different"},{"line_number":107,"context_line":"  databases to maintain, update, and keep in sync which would be a less than"},{"line_number":108,"context_line":"  desireable user experience for a cloud admin, having multiple ways of doing"},{"line_number":109,"context_line":"  synchronization/locking in drivers can and will introduce bugs and maintence"},{"line_number":110,"context_line":"  problems, and makes it more difficult for new driver developers to make a"},{"line_number":111,"context_line":"  good choice on where to store data."},{"line_number":112,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_65e9061a","line":109,"in_reply_to":"da86d52c_39d03bf7","updated":"2015-02-09 18:41:05.000000000","message":"Done","commit_id":"a67faf030045a33003cf8379465c0379ccb1aa01"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"3ad2773725241820c15d6c3ff46ae78c10324b3f","unresolved":false,"context_lines":[{"line_number":144,"context_line":"-----------------"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"The proposed solution will be adding in a new database table named"},{"line_number":147,"context_line":"driver_private_data and associated model DriverPrivateData. There will be a"},{"line_number":148,"context_line":"migration to add and remove the table but will not seed or modify any data."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Access to the database will be used through api\u0027s outlined in the Proposed"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_d9163fa7","line":147,"updated":"2015-02-09 05:19:23.000000000","message":"\u0027driver_private_data\u0027 suggests this table can be used for any purpose, but the table is designed very specifically for CHAP.","commit_id":"a67faf030045a33003cf8379465c0379ccb1aa01"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"8016bce78cafe78958a3fc9ada8b3f494b80b0e5","unresolved":false,"context_lines":[{"line_number":144,"context_line":"-----------------"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"The proposed solution will be adding in a new database table named"},{"line_number":147,"context_line":"driver_private_data and associated model DriverPrivateData. There will be a"},{"line_number":148,"context_line":"migration to add and remove the table but will not seed or modify any data."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Access to the database will be used through api\u0027s outlined in the Proposed"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_45b96214","line":147,"in_reply_to":"da86d52c_d9163fa7","updated":"2015-02-09 18:41:05.000000000","message":"With what is proposed right now it is available for any purpose, I think what we need to decide (or what I need guidance on) is whether or not it should be limited to only CHAP.","commit_id":"a67faf030045a33003cf8379465c0379ccb1aa01"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ace2e6eea588b7b82172960828ffcb31d55bdd17","unresolved":false,"context_lines":[{"line_number":27,"context_line":"drivers storing information on the backend which works for some but not all"},{"line_number":28,"context_line":"backends have this capability."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"A use case for this is for storing CHAP secrets for iSCSI initiators for"},{"line_number":31,"context_line":"backends which cannot store/retrieve the credentials and that do not have per-"},{"line_number":32,"context_line":"volume credentials."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_ac68a7f5","line":30,"updated":"2015-02-12 18:23:04.000000000","message":"A use case for this is storing target CHAP secrets so iSCSI initiators can do CHAP authentication against targets.","commit_id":"790b1b183e033b429d57af2e1f30a7ed5b364022"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"e36442c3f6f39c82998ef510ed55e261865019cf","unresolved":false,"context_lines":[{"line_number":27,"context_line":"drivers storing information on the backend which works for some but not all"},{"line_number":28,"context_line":"backends have this capability."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"A use case for this is for storing CHAP secrets for iSCSI initiators for"},{"line_number":31,"context_line":"backends which cannot store/retrieve the credentials and that do not have per-"},{"line_number":32,"context_line":"volume credentials."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_976050a6","line":30,"in_reply_to":"da86d52c_ac68a7f5","updated":"2015-02-12 18:30:24.000000000","message":"Done","commit_id":"790b1b183e033b429d57af2e1f30a7ed5b364022"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d8d8b563711b368eb70c53a938ddedf444edefb3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  | deleted_at | datetime     |                                          |"},{"line_number":48,"context_line":"  | deleted    | tinyint(1)   |                                          |"},{"line_number":49,"context_line":"  | id         | int(11)      | Auto incremented ID                      |"},{"line_number":50,"context_line":"  | initiator  | varchar(255) | Unique constraint with \"key\"             |"},{"line_number":51,"context_line":"  | key        | varchar(255) | Unique constraint with \"initiator\"       |"},{"line_number":52,"context_line":"  | value      | varchar(255) | This could be anything a driver wants to |"},{"line_number":53,"context_line":"  |            |              | keep track of for this initiator. In the |"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da86d52c_74f0fa91","line":50,"updated":"2015-02-14 01:18:25.000000000","message":"Do we want to limit this to initiator related data? That restricts the goal of it being \"generic enough\".\n\nThough honestly I can\u0027t think of anything one would need to store not related to an initiator at this point. Maybe replication or snapshot data?","commit_id":"049ac6c95e346bc31f4e0dc039ac609b6eb3cf7a"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"70b53f2ff245b6c080ed47dccdafc0d14048f752","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  | deleted_at | datetime     |                                          |"},{"line_number":48,"context_line":"  | deleted    | tinyint(1)   |                                          |"},{"line_number":49,"context_line":"  | id         | int(11)      | Auto incremented ID                      |"},{"line_number":50,"context_line":"  | initiator  | varchar(255) | Unique constraint with \"key\"             |"},{"line_number":51,"context_line":"  | key        | varchar(255) | Unique constraint with \"initiator\"       |"},{"line_number":52,"context_line":"  | value      | varchar(255) | This could be anything a driver wants to |"},{"line_number":53,"context_line":"  |            |              | keep track of for this initiator. In the |"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da86d52c_b3b99fcd","line":50,"in_reply_to":"da86d52c_18528868","updated":"2015-02-15 02:14:10.000000000","message":"I definitely prefer to limit this to initiator related data for the same reason.","commit_id":"049ac6c95e346bc31f4e0dc039ac609b6eb3cf7a"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"9d318fb026dfd2d9fed16f99398f1cc4b6637b96","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  | deleted_at | datetime     |                                          |"},{"line_number":48,"context_line":"  | deleted    | tinyint(1)   |                                          |"},{"line_number":49,"context_line":"  | id         | int(11)      | Auto incremented ID                      |"},{"line_number":50,"context_line":"  | initiator  | varchar(255) | Unique constraint with \"key\"             |"},{"line_number":51,"context_line":"  | key        | varchar(255) | Unique constraint with \"initiator\"       |"},{"line_number":52,"context_line":"  | value      | varchar(255) | This could be anything a driver wants to |"},{"line_number":53,"context_line":"  |            |              | keep track of for this initiator. In the |"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da86d52c_18528868","line":50,"in_reply_to":"da86d52c_74f0fa91","updated":"2015-02-15 00:04:38.000000000","message":"I would be opposed to that. Mostly because I don\u0027t want to encourage drivers to store state information in Cinder that\u0027s just random key/value that we account for in future decisions.","commit_id":"049ac6c95e346bc31f4e0dc039ac609b6eb3cf7a"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"9d318fb026dfd2d9fed16f99398f1cc4b6637b96","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      },"},{"line_number":78,"context_line":"      \"initiator_updates\": ["},{"line_number":79,"context_line":"          {"},{"line_number":80,"context_line":"              \"key\": \"purearray1ChapSecretId\","},{"line_number":81,"context_line":"              \"value\": \"9248cab1-bb08-4fb0-9fd7-b4328ab852d3\""},{"line_number":82,"context_line":"          },"},{"line_number":83,"context_line":"          {"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da86d52c_384f4cc0","line":80,"updated":"2015-02-15 00:04:38.000000000","message":"What does nova do with this information? Is there anything in K in Nova to do something with this?","commit_id":"049ac6c95e346bc31f4e0dc039ac609b6eb3cf7a"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"dcf36ef606304323b746a898afb8e0d360e0a9ee","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      },"},{"line_number":78,"context_line":"      \"initiator_updates\": ["},{"line_number":79,"context_line":"          {"},{"line_number":80,"context_line":"              \"key\": \"purearray1ChapSecretId\","},{"line_number":81,"context_line":"              \"value\": \"9248cab1-bb08-4fb0-9fd7-b4328ab852d3\""},{"line_number":82,"context_line":"          },"},{"line_number":83,"context_line":"          {"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da86d52c_45d5e2e3","line":80,"in_reply_to":"da86d52c_33c92f7a","updated":"2015-02-16 11:20:18.000000000","message":"I think that a tuple would be cleaner than this, and we have that style of return value elsewhere in the driver IIRC.","commit_id":"049ac6c95e346bc31f4e0dc039ac609b6eb3cf7a"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"70b53f2ff245b6c080ed47dccdafc0d14048f752","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      },"},{"line_number":78,"context_line":"      \"initiator_updates\": ["},{"line_number":79,"context_line":"          {"},{"line_number":80,"context_line":"              \"key\": \"purearray1ChapSecretId\","},{"line_number":81,"context_line":"              \"value\": \"9248cab1-bb08-4fb0-9fd7-b4328ab852d3\""},{"line_number":82,"context_line":"          },"},{"line_number":83,"context_line":"          {"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da86d52c_33c92f7a","line":80,"in_reply_to":"da86d52c_384f4cc0","updated":"2015-02-15 02:14:10.000000000","message":"I don\u0027t have any plans to make nova aware of this \"initiator_updates\" info. We could if there was a good use case for it, but I think the ship has sailed to try and do anything in K for nova with it.\n\nIn my mind this is more for the driver to get info, and only the cinder manager code would know about it to save/retrieve it for the driver. I was kind of hoping to limit its scope so we aren\u0027t passing around this stuff all over the place.\n\nNow that I think about it more, maybe we should change the drivers initialize_connection to return a tuple instead of cramming this into the connection_info and spreading it further/into nova? Or go to a get/set on the driver instead of the model update approach? Going that way would let drivers who don\u0027t utilize this feature avoid any extra database operations, but then kind of goes further towards basically letting the driver access the db directly(ish)....Any preference? Or leave it as-is?","commit_id":"049ac6c95e346bc31f4e0dc039ac609b6eb3cf7a"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"339e66b5dace67366ca10ffb5920f8af12813b9c","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      },"},{"line_number":78,"context_line":"      \"initiator_updates\": ["},{"line_number":79,"context_line":"          {"},{"line_number":80,"context_line":"              \"key\": \"purearray1ChapSecretId\","},{"line_number":81,"context_line":"              \"value\": \"9248cab1-bb08-4fb0-9fd7-b4328ab852d3\""},{"line_number":82,"context_line":"          },"},{"line_number":83,"context_line":"          {"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da86d52c_3f61d2d3","line":80,"in_reply_to":"da86d52c_45d5e2e3","updated":"2015-02-16 15:30:03.000000000","message":"Ok, cool, I\u0027ll update the spec for that approach.","commit_id":"049ac6c95e346bc31f4e0dc039ac609b6eb3cf7a"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"8817d443f6d0ca828b69c2e9297f5bb711beef17","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  | deleted    | tinyint(1)   |                                          |"},{"line_number":49,"context_line":"  | id         | int(11)      | Auto incremented ID                      |"},{"line_number":50,"context_line":"  | initiator  | varchar(255) | Unique constraint with \"key\"             |"},{"line_number":51,"context_line":"  | key        | varchar(255) | Unique constraint with \"initiator\"       |"},{"line_number":52,"context_line":"  | value      | varchar(255) | This could be anything a driver wants to |"},{"line_number":53,"context_line":"  |            |              | keep track of for this initiator. In the |"},{"line_number":54,"context_line":"  |            |              | CHAP credential usecase this could be a  |"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da86d52c_3e4c6a76","line":51,"updated":"2015-02-16 19:58:47.000000000","message":"Do we really need key-value storage? Is storing \u0027{\u0027initiator\u0027: {json_data}}\u0027 option for our case?","commit_id":"8d97a9aa81aaf41a9044ca58e1039aa7fedb14d6"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"2639e4298181743c1e874d653d6a09bc55b7156e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  | deleted    | tinyint(1)   |                                          |"},{"line_number":49,"context_line":"  | id         | int(11)      | Auto incremented ID                      |"},{"line_number":50,"context_line":"  | initiator  | varchar(255) | Unique constraint with \"key\"             |"},{"line_number":51,"context_line":"  | key        | varchar(255) | Unique constraint with \"initiator\"       |"},{"line_number":52,"context_line":"  | value      | varchar(255) | This could be anything a driver wants to |"},{"line_number":53,"context_line":"  |            |              | keep track of for this initiator. In the |"},{"line_number":54,"context_line":"  |            |              | CHAP credential usecase this could be a  |"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da86d52c_c1c8cf58","line":51,"in_reply_to":"da86d52c_3e4c6a76","updated":"2015-02-16 20:52:17.000000000","message":"Hmm yea, I\u0027m not sure. I considered that originally but convinced myself key/values might work better.\n\nMy reasoning was to help with issues with adding new values later/changing the formats.\n\nFor example, if we don\u0027t have a \u0027key\u0027 column, and I naively just put a uuid string in as my value, 6 months from now if I want to add another one i\u0027m screwed. I will have to pull the value out, test if its json, parse it for values, or not, maybe migrate to a newer format, etc etc.\n\nIf there was a key and I wanted to add a new field for the initiator, no problem... just use a different key.\n\nNow, that being said, maybe I should have not been naiveand just stored a json string in the first place. This means we would encourage everyone to store structured key/value pairs in a varchar field in a database, which seems kind of weird since sql is pretty good at doing that for us.","commit_id":"8d97a9aa81aaf41a9044ca58e1039aa7fedb14d6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"8817d443f6d0ca828b69c2e9297f5bb711beef17","unresolved":false,"context_lines":[{"line_number":213,"context_line":"* DB migration tests"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"* DB API unit tests"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"* BaseDriver unit tests"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"* No new tempest tests"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da86d52c_eb7052dc","line":216,"updated":"2015-02-16 19:58:47.000000000","message":"Actually, it will be functional tests","commit_id":"8d97a9aa81aaf41a9044ca58e1039aa7fedb14d6"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"2639e4298181743c1e874d653d6a09bc55b7156e","unresolved":false,"context_lines":[{"line_number":213,"context_line":"* DB migration tests"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"* DB API unit tests"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"* BaseDriver unit tests"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"* No new tempest tests"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da86d52c_c13d2f2e","line":216,"in_reply_to":"da86d52c_eb7052dc","updated":"2015-02-16 20:52:17.000000000","message":"I\u0027ll update in the newest patch set","commit_id":"8d97a9aa81aaf41a9044ca58e1039aa7fedb14d6"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7c3357cea9bb85de05cbf0d65706962ea9db7dec","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  | created_at   | datetime     |                                            |"},{"line_number":46,"context_line":"  | updated_at   | datetime     |                                            |"},{"line_number":47,"context_line":"  | deleted_at   | datetime     |                                            |"},{"line_number":48,"context_line":"  | deleted      | tinyint(1)   |                                            |"},{"line_number":49,"context_line":"  | id           | int(11)      | Auto incremented ID                        |"},{"line_number":50,"context_line":"  | initiator    | varchar(255) | Unique constraint with \"key\" +             |"},{"line_number":51,"context_line":"  |              |              | \"namespace\"                                |"}],"source_content_type":"text/x-rst","patch_set":10,"id":"ba7be1f8_a0ae35e4","line":48,"updated":"2015-02-24 22:10:45.000000000","message":"I\u0027m not sure we want to do soft deletes on rows from this table, since it can contain driver/array sensitive data.   I think we would be better off with hard deletes that actually remove the row from the db table.   \n\nThis is especially a concern with the new shadow (archive) tables about to land, where soft deleted rows are migrated to a shadow table and left around.","commit_id":"2c7949d1d1c4a85f7cdceb99d8a84ff16a3e00ae"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"0ca49c107ce8bc49e72ef99e1ba9297fbe15849f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  | created_at   | datetime     |                                            |"},{"line_number":46,"context_line":"  | updated_at   | datetime     |                                            |"},{"line_number":47,"context_line":"  | deleted_at   | datetime     |                                            |"},{"line_number":48,"context_line":"  | deleted      | tinyint(1)   |                                            |"},{"line_number":49,"context_line":"  | id           | int(11)      | Auto incremented ID                        |"},{"line_number":50,"context_line":"  | initiator    | varchar(255) | Unique constraint with \"key\" +             |"},{"line_number":51,"context_line":"  |              |              | \"namespace\"                                |"}],"source_content_type":"text/x-rst","patch_set":10,"id":"ba7be1f8_00d38160","line":48,"in_reply_to":"ba7be1f8_a0ae35e4","updated":"2015-02-24 22:20:38.000000000","message":"I agree, i\u0027ll take this out and we will hard delete them.","commit_id":"2c7949d1d1c4a85f7cdceb99d8a84ff16a3e00ae"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f29f889217f01ba3759dadd412652790fe5cad35","unresolved":false,"context_lines":[{"line_number":117,"context_line":"  backends that are configured in active/active HA, but there is a risk of two"},{"line_number":118,"context_line":"  different vendors being used by the same initiator and having key"},{"line_number":119,"context_line":"  collisions. We could introduce a vendor-prefix field to use as part of the"},{"line_number":120,"context_line":"  key as well to avoid that."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  * We could also use the cinder host to scope these instead of a vendor"},{"line_number":123,"context_line":"    prefix"}],"source_content_type":"text/x-rst","patch_set":10,"id":"ba7be1f8_b556aed0","line":120,"updated":"2015-02-23 20:13:46.000000000","message":"This does concern me a little, but can certainly be addressed in the future if it really is a problem.","commit_id":"2c7949d1d1c4a85f7cdceb99d8a84ff16a3e00ae"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d579b88c00aca7dc84f834b1cd878efb4bd9ee97","unresolved":false,"context_lines":[{"line_number":74,"context_line":"field on the connection info. These changes will then be applied to the"},{"line_number":75,"context_line":"initiator table."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"The initiator_update dictionary can contain \"set_values\" ditctionary and/or"},{"line_number":78,"context_line":"\"remove_values\" list. The set_values are key value pairs which are to"},{"line_number":79,"context_line":"be set or updated in the database. The remove_values is a list of keys to be"},{"line_number":80,"context_line":"deleted from the database. They will be \"hard\" deleted so the data will not"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba7be1f8_a06c7536","line":77,"updated":"2015-02-24 22:29:01.000000000","message":"/ditctionary/dictionary/","commit_id":"7574266216bc8c74feaa6880ee50139a5d45671e"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"3a676a4dda51d3bfcbaedaaab8d93bf091f685f2","unresolved":false,"context_lines":[{"line_number":74,"context_line":"field on the connection info. These changes will then be applied to the"},{"line_number":75,"context_line":"initiator table."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"The initiator_update dictionary can contain \"set_values\" ditctionary and/or"},{"line_number":78,"context_line":"\"remove_values\" list. The set_values are key value pairs which are to"},{"line_number":79,"context_line":"be set or updated in the database. The remove_values is a list of keys to be"},{"line_number":80,"context_line":"deleted from the database. They will be \"hard\" deleted so the data will not"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba7be1f8_bb32e6ef","line":77,"in_reply_to":"ba7be1f8_a06c7536","updated":"2015-02-24 22:36:36.000000000","message":"Done","commit_id":"7574266216bc8c74feaa6880ee50139a5d45671e"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"33f6e53034dfee019f84948598c3093f65b7bf64","unresolved":false,"context_lines":[{"line_number":179,"context_line":"a migration to add and remove the table but will not seed or modify any data."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Access to the database will be used through api\u0027s outlined in the Proposed"},{"line_number":182,"context_line":"Change."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"REST API impact"},{"line_number":185,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba7be1f8_4043b96b","line":182,"updated":"2015-02-24 22:33:59.000000000","message":"Table rows will be hard deleted, so we don\u0027t keep around potentially sensitive credentials/information.","commit_id":"7574266216bc8c74feaa6880ee50139a5d45671e"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"3a676a4dda51d3bfcbaedaaab8d93bf091f685f2","unresolved":false,"context_lines":[{"line_number":179,"context_line":"a migration to add and remove the table but will not seed or modify any data."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Access to the database will be used through api\u0027s outlined in the Proposed"},{"line_number":182,"context_line":"Change."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"REST API impact"},{"line_number":185,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba7be1f8_9b39a2d9","line":182,"in_reply_to":"ba7be1f8_4043b96b","updated":"2015-02-24 22:36:36.000000000","message":"Done","commit_id":"7574266216bc8c74feaa6880ee50139a5d45671e"}]}
