)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"3ef4a33149753f28ba8a3fd6e0f96f86ee58fbe5","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This work aims to handle these files of various formats safely and"},{"line_number":14,"context_line":"in a more robust manner."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"blueprint add-support-store-volume-format-info"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Co-Author: Trump Zhang \u003czhangleiqiang@huawei.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_fd7e1de3","line":15,"updated":"2015-03-19 10:11:13.000000000","message":"It would be good to state that this bp is dep on the \u0027volume snap improvement\u0027 bps of cinder and nova, unless there is a better way to put these specs as dep of each other ? At the least we can indicate that this spec makes more sense once we have Nova return the format info and Cinder ack it ?","commit_id":"a730f1c54c1be4f5099ed8ab3adf690ea4422fa2"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"bc9a6343858d35e6dcec66276e6ed7c76c7abc27","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This work aims to handle these files of various formats safely and"},{"line_number":14,"context_line":"in a more robust manner."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"blueprint add-support-store-volume-format-info"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Co-Author: Trump Zhang \u003czhangleiqiang@huawei.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a0c5dc1_842257b8","line":15,"in_reply_to":"9a80dd14_fd7e1de3","updated":"2015-05-12 09:43:32.000000000","message":"Inside the spec, add the cinder and nova BPs as deps","commit_id":"a730f1c54c1be4f5099ed8ab3adf690ea4422fa2"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"3ef4a33149753f28ba8a3fd6e0f96f86ee58fbe5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"blueprint add-support-store-volume-format-info"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Co-Author: Trump Zhang \u003czhangleiqiang@huawei.com\u003e"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I8b66af1d6b41f02a870d95cd9dddab83c34a9ded"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_9d4a81ab","line":19,"updated":"2015-03-19 10:11:13.000000000","message":"Per https://wiki.openstack.org/wiki/GitCommitMessages the field should be Co-Authored-By: \n\n\u003csnip\u003e\nWe encourage the use of Co-Authored-By: name \u003cname@example.com\u003e in commit messages to indicate people who worked on a particular patch. It\u0027s a convention for recognizing multiple authors, and our projects would encourage the stats tools to observe it when collecting statistics. \n\u003c/snip\u003e","commit_id":"a730f1c54c1be4f5099ed8ab3adf690ea4422fa2"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"bc9a6343858d35e6dcec66276e6ed7c76c7abc27","unresolved":false,"context_lines":[{"line_number":16,"context_line":"blueprint add-support-store-volume-format-info"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Co-Author: Trump Zhang \u003czhangleiqiang@huawei.com\u003e"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I8b66af1d6b41f02a870d95cd9dddab83c34a9ded"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a0c5dc1_24316b0c","line":19,"in_reply_to":"9a80dd14_9d4a81ab","updated":"2015-05-12 09:43:32.000000000","message":"Done","commit_id":"a730f1c54c1be4f5099ed8ab3adf690ea4422fa2"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"87b0d144a4877c9d8e72bb0f7ed7ab0d7cdae411","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support storing volume format info"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, there are several filesystem-based drivers in Cinder, such as"},{"line_number":10,"context_line":"nfs, glusterfs, smbfs, etc. Multiple formats of volume other than \"raw\" can be"},{"line_number":11,"context_line":"potentially supported in these drivers, such as qcow2, raw, vhd, etc."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This work aims to handle these files of various formats safely and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7aa08908_bbfa4575","line":10,"range":{"start_line":10,"start_character":72,"end_line":10,"end_character":78},"updated":"2016-06-17 15:45:02.000000000","message":"Could get wrapped if you upload a new patchset. No big deal though.","commit_id":"0dc30f05812179999556edf8cb730d9e17807a01"}],"specs/liberty/store-volume-format-info.rst":[{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"3ef4a33149753f28ba8a3fd6e0f96f86ee58fbe5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  Cinder states that the volume\u0027s format is \"raw\" other than \"qcow2\""},{"line_number":30,"context_line":"* For volume backup, the backup driver also supposes that src volumes are"},{"line_number":31,"context_line":"  \"raw\" format, other format will not be supported"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a80dd14_7d5b0d54","line":32,"updated":"2015-03-19 10:11:13.000000000","message":"A reference to https://bugs.launchpad.net/cinder/+bug/1350504 highlighting the unsafe\u0027ness should also help as part of problem desc ?","commit_id":"a730f1c54c1be4f5099ed8ab3adf690ea4422fa2"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"bc9a6343858d35e6dcec66276e6ed7c76c7abc27","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  Cinder states that the volume\u0027s format is \"raw\" other than \"qcow2\""},{"line_number":30,"context_line":"* For volume backup, the backup driver also supposes that src volumes are"},{"line_number":31,"context_line":"  \"raw\" format, other format will not be supported"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_442c5fab","line":32,"in_reply_to":"9a80dd14_7d5b0d54","updated":"2015-05-12 09:43:32.000000000","message":"Done","commit_id":"a730f1c54c1be4f5099ed8ab3adf690ea4422fa2"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"3ef4a33149753f28ba8a3fd6e0f96f86ee58fbe5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"have a default \"raw\" format."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"When a snapshot is deleted, the format of the volume file may change from"},{"line_number":44,"context_line":"raw to qcow2.  The metadata will be updated accordingly in this case.  It"},{"line_number":45,"context_line":"does not presently ever change from qcow2 back to raw."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"When a snapshot is deleted by Cinder (volume is available):"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a80dd14_78f5db81","line":44,"updated":"2015-03-19 10:11:13.000000000","message":"snapshots are always qcow2, thus s/raw to qcow2/qcow2 to raw/","commit_id":"a730f1c54c1be4f5099ed8ab3adf690ea4422fa2"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"bc9a6343858d35e6dcec66276e6ed7c76c7abc27","unresolved":false,"context_lines":[{"line_number":41,"context_line":"have a default \"raw\" format."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"When a snapshot is deleted, the format of the volume file may change from"},{"line_number":44,"context_line":"raw to qcow2.  The metadata will be updated accordingly in this case.  It"},{"line_number":45,"context_line":"does not presently ever change from qcow2 back to raw."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"When a snapshot is deleted by Cinder (volume is available):"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_041d4773","line":44,"in_reply_to":"9a80dd14_78f5db81","updated":"2015-05-12 09:43:32.000000000","message":"ignore this","commit_id":"a730f1c54c1be4f5099ed8ab3adf690ea4422fa2"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"3ef4a33149753f28ba8a3fd6e0f96f86ee58fbe5","unresolved":false,"context_lines":[{"line_number":62,"context_line":"the format explicitly for a volume being imported.  (TBD: where is this"},{"line_number":63,"context_line":"process and checked?  Some drivers require it as a metadata kwarg or fail"},{"line_number":64,"context_line":"the operation?)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Alternatives"},{"line_number":67,"context_line":"------------"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a80dd14_5ecabf4f","line":65,"updated":"2015-03-19 10:11:13.000000000","message":"This still doesn\u0027t give the complete picture of the format field\u0027s lifecycle.\nFor eg: We don\u0027t talk about vol create/delete and other flows, esp how cinder gets to know of the file format in the first place ? The above only covers snap related flows, but bp talks about create/copy/migrate/retype too, should we add them as well here ?","commit_id":"a730f1c54c1be4f5099ed8ab3adf690ea4422fa2"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"bc9a6343858d35e6dcec66276e6ed7c76c7abc27","unresolved":false,"context_lines":[{"line_number":62,"context_line":"the format explicitly for a volume being imported.  (TBD: where is this"},{"line_number":63,"context_line":"process and checked?  Some drivers require it as a metadata kwarg or fail"},{"line_number":64,"context_line":"the operation?)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Alternatives"},{"line_number":67,"context_line":"------------"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_bf2442af","line":65,"in_reply_to":"9a80dd14_5ecabf4f","updated":"2015-05-12 09:43:32.000000000","message":"I think vol create will use the file format as specified by the driver\u0027s default file format from the CONF settings, so we should be able to track the volume\u0027s file format since the time of creation.","commit_id":"a730f1c54c1be4f5099ed8ab3adf690ea4422fa2"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"3ef4a33149753f28ba8a3fd6e0f96f86ee58fbe5","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"(TODO: move libvirt details etc. to Nova spec. Most of these details are not"},{"line_number":202,"context_line":"relevant for the volume service.)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Testing"},{"line_number":205,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a80dd14_bec1fb4f","line":203,"updated":"2015-03-19 10:11:13.000000000","message":"Is this TODO still needed ?","commit_id":"a730f1c54c1be4f5099ed8ab3adf690ea4422fa2"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"bc9a6343858d35e6dcec66276e6ed7c76c7abc27","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"(TODO: move libvirt details etc. to Nova spec. Most of these details are not"},{"line_number":202,"context_line":"relevant for the volume service.)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Testing"},{"line_number":205,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_5f3426dd","line":203,"in_reply_to":"9a80dd14_bec1fb4f","updated":"2015-05-12 09:43:32.000000000","message":"removed the TODO. Added nova and cinder volume-snap-impr BPs as deps, since this work really depends on the ability in Cinder and Nova to be able to exchange file format successfully","commit_id":"a730f1c54c1be4f5099ed8ab3adf690ea4422fa2"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"6329091d7f002771b5e1598ab1c9e20b859afa21","unresolved":false,"context_lines":[{"line_number":55,"context_line":"we can ignore this since it is not about the base volume file.  (Or"},{"line_number":56,"context_line":"Nova can not return it, but it may be simpler to just always return it.)"},{"line_number":57,"context_line":"When committing the \"oldest\" snapshot (immediately above the base) we will"},{"line_number":58,"context_line":"update the metadata accordingly."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"When cloning a volume, this field will be updated in the new volume\u0027s metadata."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a016987_c39c65c2","line":58,"updated":"2015-05-18 08:43:50.000000000","message":"A question about this: How nova know what format passing to cinder? I mean, if the volume file should be \u0027qcow2\u0027, but nova passed \u0027raw\u0027 through update_snapshot_status API. Cinder will update the metadata correctly?","commit_id":"7ef4b078710144c638801fee0e0cbd662aa29ed8"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"7f0a5386e48f6b807e7ddaaa25bc8a904acebbc8","unresolved":false,"context_lines":[{"line_number":55,"context_line":"we can ignore this since it is not about the base volume file.  (Or"},{"line_number":56,"context_line":"Nova can not return it, but it may be simpler to just always return it.)"},{"line_number":57,"context_line":"When committing the \"oldest\" snapshot (immediately above the base) we will"},{"line_number":58,"context_line":"update the metadata accordingly."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"When cloning a volume, this field will be updated in the new volume\u0027s metadata."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a016987_7960b3a5","line":58,"in_reply_to":"7a016987_03e71db1","updated":"2015-05-19 01:53:43.000000000","message":"OK,got it. Thanks for answer.","commit_id":"7ef4b078710144c638801fee0e0cbd662aa29ed8"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"8b6f5c2ee89d70407c696d524c3fe29280d38091","unresolved":false,"context_lines":[{"line_number":55,"context_line":"we can ignore this since it is not about the base volume file.  (Or"},{"line_number":56,"context_line":"Nova can not return it, but it may be simpler to just always return it.)"},{"line_number":57,"context_line":"When committing the \"oldest\" snapshot (immediately above the base) we will"},{"line_number":58,"context_line":"update the metadata accordingly."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"When cloning a volume, this field will be updated in the new volume\u0027s metadata."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a016987_03e71db1","line":58,"in_reply_to":"7a016987_c39c65c2","updated":"2015-05-18 09:09:53.000000000","message":"Look at BPs [3] and [4] that deal with how Nova and Cinder work together to track the volume format. Patches for [3] and [4] are @ https://review.openstack.org/172808 and https://review.openstack.org/172813 respectively.\n\nThe short answer is that Nova knows whether its doing blockCommit or blockRebase and accordingly it sends back the active format back to the cinder.","commit_id":"7ef4b078710144c638801fee0e0cbd662aa29ed8"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"3abb7321ab558a3ed3077aeb708d0df2c78fb518","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        }"},{"line_number":104,"context_line":"    }"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"The snapshot_actions update_snapshot_status API will recieve format updates"},{"line_number":107,"context_line":"from Nova when snapshots are deleted by Nova.  This is done by adding a"},{"line_number":108,"context_line":"\"file_format\" field to this API call, i.e.::"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_b8ba23e0","line":106,"updated":"2015-08-27 13:28:48.000000000","message":"s/recieve/receive/","commit_id":"7ef4b078710144c638801fee0e0cbd662aa29ed8"}],"specs/mitaka/store-volume-format-info.rst":[{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"506d54fba2aea6b1c5e108e6f58b119c11a047ee","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"The Cinder \"manage volume\" operation also needs to allow the user to input"},{"line_number":63,"context_line":"the format explicitly for a volume being imported.  (TBD: where is this"},{"line_number":64,"context_line":"process and checked?  Some drivers require it as a metadata kwarg or fail"},{"line_number":65,"context_line":"the operation?)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a26ad4f_318889e7","line":64,"updated":"2015-10-27 23:55:27.000000000","message":"How about let the driver to set the format by itself? I\u0027m concerned about that users may input error format info.","commit_id":"0dc30f05812179999556edf8cb730d9e17807a01"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"f614c32c2c566a15171192cae3dd7ff41f3c33fa","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"The Cinder \"manage volume\" operation also needs to allow the user to input"},{"line_number":63,"context_line":"the format explicitly for a volume being imported.  (TBD: where is this"},{"line_number":64,"context_line":"process and checked?  Some drivers require it as a metadata kwarg or fail"},{"line_number":65,"context_line":"the operation?)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da85f559_d3e7d6aa","line":64,"in_reply_to":"1a26ad4f_318889e7","updated":"2015-11-08 12:13:47.000000000","message":"We\u0027d need to do validation on any auto-detected format, otherwise it becomes (an admittedly weird and highly site specific) attach vector. I guess we could apply the current rules (no backing files outside of the current user\u0027s volume tree)?","commit_id":"0dc30f05812179999556edf8cb730d9e17807a01"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6b6b36f9e77d54c9dcccccfe0fee872ad1deffe3","unresolved":false,"context_lines":[{"line_number":89,"context_line":"REST API impact"},{"line_number":90,"context_line":"---------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"The \"format\" info will returned within \"metadata\" in volume show API::"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    /v1/{tenant_id}/volumes/{volume_id}"},{"line_number":95,"context_line":"    /v2/{tenant_id}/volumes/{volume_id}"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_9704494a","line":92,"updated":"2015-09-30 01:36:03.000000000","message":"will be returned","commit_id":"0dc30f05812179999556edf8cb730d9e17807a01"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6b6b36f9e77d54c9dcccccfe0fee872ad1deffe3","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"The \"format\" info will returned within \"metadata\" in volume show API::"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    /v1/{tenant_id}/volumes/{volume_id}"},{"line_number":95,"context_line":"    /v2/{tenant_id}/volumes/{volume_id}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_778e55d1","line":94,"updated":"2015-09-30 01:36:03.000000000","message":"Do we still update V1 API with new feature?","commit_id":"0dc30f05812179999556edf8cb730d9e17807a01"},{"author":{"_account_id":17789,"name":"Zhao Lei","email":"zhaolei@cn.fujitsu.com","username":"zhaolei"},"change_message_id":"c5e6b648c974518e4c479bb90ebfefc6562ff5ba","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        }"},{"line_number":104,"context_line":"    }"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"The snapshot_actions update_snapshot_status API will recieve format updates"},{"line_number":107,"context_line":"from Nova when snapshots are deleted by Nova.  This is done by adding a"},{"line_number":108,"context_line":"\"file_format\" field to this API call, i.e.::"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_f2ea7373","line":106,"updated":"2015-09-30 02:20:09.000000000","message":"receive","commit_id":"0dc30f05812179999556edf8cb730d9e17807a01"},{"author":{"_account_id":17789,"name":"Zhao Lei","email":"zhaolei@cn.fujitsu.com","username":"zhaolei"},"change_message_id":"b2f653cefe59cb96f07220ade95a5326af2d6f76","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        }"},{"line_number":104,"context_line":"    }"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"The snapshot_actions update_snapshot_status API will recieve format updates"},{"line_number":107,"context_line":"from Nova when snapshots are deleted by Nova.  This is done by adding a"},{"line_number":108,"context_line":"\"file_format\" field to this API call, i.e.::"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_88df4868","line":106,"in_reply_to":"9a1a9d01_12336715","updated":"2015-09-30 03:41:44.000000000","message":"The -1 will be auto-removed by a new \"git review\".\n\nAnd maybe better to make all spelling fixed in initial version,\ninstead of in additional patch.","commit_id":"0dc30f05812179999556edf8cb730d9e17807a01"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"e734f563f5c81b7386a51ba72e88bccf9f767dd9","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        }"},{"line_number":104,"context_line":"    }"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"The snapshot_actions update_snapshot_status API will recieve format updates"},{"line_number":107,"context_line":"from Nova when snapshots are deleted by Nova.  This is done by adding a"},{"line_number":108,"context_line":"\"file_format\" field to this API call, i.e.::"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_350bf02b","line":106,"in_reply_to":"9a1a9d01_88df4868","updated":"2015-09-30 07:24:48.000000000","message":"The general advice for reviewers now is to put a zero review for minor spelling errors, rather than -1. This is a) more friendly b) means there is no -1 on the patch that might cause the review to be treated as lower priority by other reviewers.\n\nReview guidelines are available on the wiki and are regularly discussed on the mailing list.","commit_id":"0dc30f05812179999556edf8cb730d9e17807a01"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"ef79f10b3c36e6f8ed87b46a9f7021997dc35026","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        }"},{"line_number":104,"context_line":"    }"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"The snapshot_actions update_snapshot_status API will recieve format updates"},{"line_number":107,"context_line":"from Nova when snapshots are deleted by Nova.  This is done by adding a"},{"line_number":108,"context_line":"\"file_format\" field to this API call, i.e.::"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_12336715","line":106,"in_reply_to":"9a1a9d01_f2ea7373","updated":"2015-09-30 02:27:38.000000000","message":"Please don\u0027t -1 just for spelling errors","commit_id":"0dc30f05812179999556edf8cb730d9e17807a01"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"506d54fba2aea6b1c5e108e6f58b119c11a047ee","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        \"progress\": \"90%\","},{"line_number":114,"context_line":"        \"file_format\": {"},{"line_number":115,"context_line":"            \"volume-1234\": \"raw\","},{"line_number":116,"context_line":"            \"volume-1234.snapshot1\": \"qcow2\""},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"    }"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a26ad4f_b1e2599e","line":116,"updated":"2015-10-27 23:55:27.000000000","message":"So you mean the snapshot1 is the oldest snapshot, right?","commit_id":"0dc30f05812179999556edf8cb730d9e17807a01"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6b6b36f9e77d54c9dcccccfe0fee872ad1deffe3","unresolved":false,"context_lines":[{"line_number":131,"context_line":"Other end user impact"},{"line_number":132,"context_line":"---------------------"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Additional arguments likely required for \"cinder manage\" with these"},{"line_number":135,"context_line":"drivers."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_f7b82577","line":134,"updated":"2015-09-30 01:36:03.000000000","message":"Will \"cinder manage\" be updated as part of this proposal?","commit_id":"0dc30f05812179999556edf8cb730d9e17807a01"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"f5827aee65842e0c842be14ca07a2a95d3f7b872","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  of remotefs driver, then the driver can store the format info into db"},{"line_number":179,"context_line":"* Add \"format\" info within \"data\" key in return value of method"},{"line_number":180,"context_line":"  cinder.volume.manager.VolumeManager:initialize_connection"},{"line_number":181,"context_line":"* Set \"format\" as visible admin metadata in show API (v1 and v2) and return"},{"line_number":182,"context_line":"  \"format\" info within \"metadata\" in its response body"},{"line_number":183,"context_line":"* Update the dest volume\u0027s \"format\" info after migrating the volume. It is a"},{"line_number":184,"context_line":"  temporary method, and will be removed and fixed as a bug after introducing"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_1d231bbf","line":181,"updated":"2015-10-06 07:56:39.000000000","message":"Visible to whom? Admins fine, normal tenants definitely not","commit_id":"0dc30f05812179999556edf8cb730d9e17807a01"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"e734f563f5c81b7386a51ba72e88bccf9f767dd9","unresolved":false,"context_lines":[{"line_number":183,"context_line":"* Update the dest volume\u0027s \"format\" info after migrating the volume. It is a"},{"line_number":184,"context_line":"  temporary method, and will be removed and fixed as a bug after introducing"},{"line_number":185,"context_line":"  qemu-nbd support for qcow2 in blueprint [1]"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Dependencies"},{"line_number":189,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_18170149","line":186,"updated":"2015-09-30 07:24:48.000000000","message":"Update \u0027cinder manage\u0027 driver entries and manager code as needed","commit_id":"0dc30f05812179999556edf8cb730d9e17807a01"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"f5827aee65842e0c842be14ca07a2a95d3f7b872","unresolved":false,"context_lines":[{"line_number":199,"context_line":"Testing"},{"line_number":200,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"None"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_7d31ef0a","line":202,"updated":"2015-10-06 07:56:39.000000000","message":"Definitely this will need testing. I suspect specific scenarios designed to transition from raw to qcow and back should be written.","commit_id":"0dc30f05812179999556edf8cb730d9e17807a01"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6b6b36f9e77d54c9dcccccfe0fee872ad1deffe3","unresolved":false,"context_lines":[{"line_number":205,"context_line":"Documentation Impact"},{"line_number":206,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"None"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_b724edc4","line":208,"updated":"2015-09-30 01:36:03.000000000","message":"I would assume this should have doc impact?","commit_id":"0dc30f05812179999556edf8cb730d9e17807a01"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"f614c32c2c566a15171192cae3dd7ff41f3c33fa","unresolved":false,"context_lines":[{"line_number":205,"context_line":"Documentation Impact"},{"line_number":206,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"None"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da85f559_13bc7e6b","line":208,"in_reply_to":"9a1a9d01_b724edc4","updated":"2015-11-08 12:13:47.000000000","message":"At least documenting any new options added, and probably behaviour changes too (e.g. changes in what you can and can\u0027t manage)","commit_id":"0dc30f05812179999556edf8cb730d9e17807a01"}]}
