)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7915a1e7637657cb585a293f67d662f1d424bfb6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"a non-disruptive backup while the volume is still attached:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- Take a temporary snapshot"},{"line_number":14,"context_line":"- Map snapshot"},{"line_number":15,"context_line":"- Do backup from the snapshot"},{"line_number":16,"context_line":"- Cleanup temporary snapshot"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5afe65bd_855b1e2e","line":14,"updated":"2015-06-03 15:21:38.000000000","message":"- Attach snapshot","commit_id":"f6a95ca307cb4f3a144fe1afb9c71dc4f1d9ecd7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d05d9b8af86d798390834cd5060215be71368408","unresolved":false,"context_lines":[{"line_number":11,"context_line":"a non-disruptive backup while the volume is still attached:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- Take a temporary snapshot"},{"line_number":14,"context_line":"- Map snapshot"},{"line_number":15,"context_line":"- Do backup from the snapshot"},{"line_number":16,"context_line":"- Cleanup temporary snapshot"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5afe65bd_20dd780e","line":14,"in_reply_to":"5afe65bd_855b1e2e","updated":"2015-06-03 15:49:02.000000000","message":"Done","commit_id":"f6a95ca307cb4f3a144fe1afb9c71dc4f1d9ecd7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f31b7cf04188d19863d9af162d1b05a58bf98dfc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"- Do backup from the snapshot"},{"line_number":16,"context_line":"- Cleanup temporary snapshot"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"If a driver has not implemented the attch snapshot function, a temporary"},{"line_number":19,"context_line":"volume will be created from the temporary snapshot, and backup will be"},{"line_number":20,"context_line":"performed on the temporary volume."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5afe65bd_bd750e99","line":18,"updated":"2015-06-03 17:29:54.000000000","message":"s/attch/attach","commit_id":"dd8f8da86466fa991c46740d4153a61d89cfa158"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2ee504463478bc0d9ac241e8d50a6c19a832a08a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"- Do backup from the snapshot"},{"line_number":16,"context_line":"- Cleanup temporary snapshot"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"If a driver has not implemented the attch snapshot function, a temporary"},{"line_number":19,"context_line":"volume will be created from the temporary snapshot, and backup will be"},{"line_number":20,"context_line":"performed on the temporary volume."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5afe65bd_d0c43160","line":18,"in_reply_to":"5afe65bd_bd750e99","updated":"2015-06-04 19:39:33.000000000","message":"Done.  I can\u0027t type :(.","commit_id":"dd8f8da86466fa991c46740d4153a61d89cfa158"}],"specs/liberty/non-disruptive-backup.rst":[{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"57155345c54199b3a521e37b9ac5137909bda036","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Note: For local, we just need to read from the local_path."},{"line_number":49,"context_line":"map_snapshot is only needed if it is remote."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"A default implementation will also be provided in driver.py to"},{"line_number":52,"context_line":"create a temporary volume from the temporary snapshot for drivers"},{"line_number":53,"context_line":"that have not implemented the \"map snapshot\" interface."},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_851747ed","line":51,"updated":"2015-05-29 22:53:51.000000000","message":"Maybe I\u0027m missing something, but wouldn\u0027t it make more sense to have a default implementation in driver.py that raises a NotImplemented or something and then have the higher level backup code for map_snapshot catch the driver not impl exception and then do the temp volume, attach volume etc?\n\nMaybe thats what you intended, but from this paragraph it sounds like the driver would do all of those steps.","commit_id":"56271fc9660100d2aea3f65cf64e8d013b216273"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a08c7201c1efa28104dc12940059ad64e6ddb375","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Note: For local, we just need to read from the local_path."},{"line_number":49,"context_line":"map_snapshot is only needed if it is remote."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"A default implementation will also be provided in driver.py to"},{"line_number":52,"context_line":"create a temporary volume from the temporary snapshot for drivers"},{"line_number":53,"context_line":"that have not implemented the \"map snapshot\" interface."},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_24f76ed4","line":51,"in_reply_to":"7a016987_851747ed","updated":"2015-05-30 14:01:26.000000000","message":"The backup_volume method is already implemented in driver.py. That is why every cinder volume driver today gets backup function for free. It is just that the current implementation expects the volume to be detached.  I\u0027ll be modifying the existing method to enable backup for an attached volume.  The implementation in driver.py will create a volume from snapshot and backup the volume.\n\nThe LVM driver will override this and map snapshot and backup the snapshot.","commit_id":"56271fc9660100d2aea3f65cf64e8d013b216273"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"436e24826590c6cd6d70a88211a27087f401a3fa","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"If a volume is attached, it has to be detached first before it can"},{"line_number":23,"context_line":"be backed up. This is not efficient."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Use Cases"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a016987_ad046114","line":23,"updated":"2015-05-30 21:02:47.000000000","message":"And it disrupts normal operations by cloud users just to get a backup.","commit_id":"1fc5e4e7db64e447a75834088f8abfda9055f57b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c7dc91ee9af25aa888b1a7553b5246ec7fb6aba4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"If a volume is attached, it has to be detached first before it can"},{"line_number":23,"context_line":"be backed up. This is not efficient."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Use Cases"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5afe65bd_7a020171","line":23,"in_reply_to":"7a016987_ad046114","updated":"2015-06-03 15:18:56.000000000","message":"Done","commit_id":"1fc5e4e7db64e447a75834088f8abfda9055f57b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"436e24826590c6cd6d70a88211a27087f401a3fa","unresolved":false,"context_lines":[{"line_number":34,"context_line":"The proposed change is to take a temporary snapshot and backup"},{"line_number":35,"context_line":"the snapshot:"},{"line_number":36,"context_line":"* Take a temporary snapshot"},{"line_number":37,"context_line":"* Map snapshot"},{"line_number":38,"context_line":"* Do backup from the snapshot"},{"line_number":39,"context_line":"* Cleanup temporary snapshot"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a016987_8d076517","line":37,"updated":"2015-05-30 21:02:47.000000000","message":"* Attach the snapshot","commit_id":"1fc5e4e7db64e447a75834088f8abfda9055f57b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c7dc91ee9af25aa888b1a7553b5246ec7fb6aba4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"The proposed change is to take a temporary snapshot and backup"},{"line_number":35,"context_line":"the snapshot:"},{"line_number":36,"context_line":"* Take a temporary snapshot"},{"line_number":37,"context_line":"* Map snapshot"},{"line_number":38,"context_line":"* Do backup from the snapshot"},{"line_number":39,"context_line":"* Cleanup temporary snapshot"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5afe65bd_5a6f452b","line":37,"in_reply_to":"7a016987_8d076517","updated":"2015-06-03 15:18:56.000000000","message":"Done","commit_id":"1fc5e4e7db64e447a75834088f8abfda9055f57b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"436e24826590c6cd6d70a88211a27087f401a3fa","unresolved":false,"context_lines":[{"line_number":39,"context_line":"* Cleanup temporary snapshot"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Add a function in Cinder volume manager to map a snapshot:"},{"line_number":42,"context_line":"Manager API: map_snapshot(snapshot, connection_info)"},{"line_number":43,"context_line":"This will leverage the existing code for attach volume."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Add a Cinder driver API to map a snapshot:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a016987_6d0ae921","line":42,"updated":"2015-05-30 21:02:47.000000000","message":"attach_snapshot","commit_id":"1fc5e4e7db64e447a75834088f8abfda9055f57b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c7dc91ee9af25aa888b1a7553b5246ec7fb6aba4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"* Cleanup temporary snapshot"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Add a function in Cinder volume manager to map a snapshot:"},{"line_number":42,"context_line":"Manager API: map_snapshot(snapshot, connection_info)"},{"line_number":43,"context_line":"This will leverage the existing code for attach volume."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Add a Cinder driver API to map a snapshot:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5afe65bd_1a79cdf6","line":42,"in_reply_to":"7a016987_6d0ae921","updated":"2015-06-03 15:18:56.000000000","message":"Done","commit_id":"1fc5e4e7db64e447a75834088f8abfda9055f57b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"436e24826590c6cd6d70a88211a27087f401a3fa","unresolved":false,"context_lines":[{"line_number":43,"context_line":"This will leverage the existing code for attach volume."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Add a Cinder driver API to map a snapshot:"},{"line_number":46,"context_line":"Driver API: map_snapshot(snapshot, connection_info)"},{"line_number":47,"context_line":"Implement the driver API for the LVM driver."},{"line_number":48,"context_line":"Note: For local, we just need to read from the local_path."},{"line_number":49,"context_line":"map_snapshot is only needed if it is remote."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a016987_2d119152","line":46,"updated":"2015-05-30 21:02:47.000000000","message":"attach_snapshot","commit_id":"1fc5e4e7db64e447a75834088f8abfda9055f57b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c7dc91ee9af25aa888b1a7553b5246ec7fb6aba4","unresolved":false,"context_lines":[{"line_number":43,"context_line":"This will leverage the existing code for attach volume."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Add a Cinder driver API to map a snapshot:"},{"line_number":46,"context_line":"Driver API: map_snapshot(snapshot, connection_info)"},{"line_number":47,"context_line":"Implement the driver API for the LVM driver."},{"line_number":48,"context_line":"Note: For local, we just need to read from the local_path."},{"line_number":49,"context_line":"map_snapshot is only needed if it is remote."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5afe65bd_fa739113","line":46,"in_reply_to":"7a016987_2d119152","updated":"2015-06-03 15:18:56.000000000","message":"Done","commit_id":"1fc5e4e7db64e447a75834088f8abfda9055f57b"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"6e61d1de77baceaf3f45959352d7fa98c7f45291","unresolved":false,"context_lines":[{"line_number":106,"context_line":"Other deployer impact"},{"line_number":107,"context_line":"---------------------"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The deployer will be able to backup an attached volume."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Developer impact"},{"line_number":112,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5afe65bd_2ac9e578","line":109,"updated":"2015-06-03 10:21:31.000000000","message":"IMO, it\u0027s not deployer impact. It\u0027s user\u0027s or operator\u0027s impact","commit_id":"1fc5e4e7db64e447a75834088f8abfda9055f57b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c7dc91ee9af25aa888b1a7553b5246ec7fb6aba4","unresolved":false,"context_lines":[{"line_number":106,"context_line":"Other deployer impact"},{"line_number":107,"context_line":"---------------------"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The deployer will be able to backup an attached volume."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Developer impact"},{"line_number":112,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5afe65bd_3a512963","line":109,"in_reply_to":"5afe65bd_2ac9e578","updated":"2015-06-03 15:18:56.000000000","message":"Removed it.","commit_id":"1fc5e4e7db64e447a75834088f8abfda9055f57b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f31b7cf04188d19863d9af162d1b05a58bf98dfc","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"A default implementation will also be provided in driver.py to"},{"line_number":53,"context_line":"create a temporary volume from the temporary snapshot for drivers"},{"line_number":54,"context_line":"that have not implemented the \"attach snapshot\" interface. The"},{"line_number":55,"context_line":"existing backup_volume function in driver.py will be modified"},{"line_number":56,"context_line":"to support backup for attached volume in addition to detached"},{"line_number":57,"context_line":"volume."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5afe65bd_3a048448","line":54,"updated":"2015-06-03 17:29:54.000000000","message":"Really obvious to need specifying it, but good to remember in this case the backup will keep original volume\u0027s ID as backed up volume_id.","commit_id":"dd8f8da86466fa991c46740d4153a61d89cfa158"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2ee504463478bc0d9ac241e8d50a6c19a832a08a","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"A default implementation will also be provided in driver.py to"},{"line_number":53,"context_line":"create a temporary volume from the temporary snapshot for drivers"},{"line_number":54,"context_line":"that have not implemented the \"attach snapshot\" interface. The"},{"line_number":55,"context_line":"existing backup_volume function in driver.py will be modified"},{"line_number":56,"context_line":"to support backup for attached volume in addition to detached"},{"line_number":57,"context_line":"volume."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afb71cf_a7e684e6","line":54,"in_reply_to":"5afe65bd_3a048448","updated":"2015-06-04 19:39:33.000000000","message":"Done","commit_id":"dd8f8da86466fa991c46740d4153a61d89cfa158"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f31b7cf04188d19863d9af162d1b05a58bf98dfc","unresolved":false,"context_lines":[{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"In order to hide the temporary snapshot and volume created during the"},{"line_number":145,"context_line":"non-disruptive backup so that a regular tenant cannot operate on them,"},{"line_number":146,"context_line":"we can use Cinder internal tenant to manage them. Cinder internal tenant"},{"line_number":147,"context_line":"is proposed by the following spec:"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5afe65bd_4b3775e3","line":145,"updated":"2015-06-03 17:29:54.000000000","message":"or his quota is affected by them","commit_id":"dd8f8da86466fa991c46740d4153a61d89cfa158"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2ee504463478bc0d9ac241e8d50a6c19a832a08a","unresolved":false,"context_lines":[{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"In order to hide the temporary snapshot and volume created during the"},{"line_number":145,"context_line":"non-disruptive backup so that a regular tenant cannot operate on them,"},{"line_number":146,"context_line":"we can use Cinder internal tenant to manage them. Cinder internal tenant"},{"line_number":147,"context_line":"is proposed by the following spec:"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afb71cf_07d8b81c","line":145,"in_reply_to":"5afe65bd_4b3775e3","updated":"2015-06-04 19:39:33.000000000","message":"Done","commit_id":"dd8f8da86466fa991c46740d4153a61d89cfa158"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"6b39b4694e76e6d128cbb529bcc46b23751358bb","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Non Disruptive Backup"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/cinder/+spec/non-disruptive-backup"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_d79490e9","line":11,"updated":"2015-07-06 16:16:49.000000000","message":"This line could be removed if you\u0027ll make one more patch","commit_id":"add0f8c30426238d1c0f982e60720a6c7c6def62"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"1a9eb9772ab7849acd28c3e46de201cbaf9c8e5a","unresolved":false,"context_lines":[{"line_number":134,"context_line":"Work Items"},{"line_number":135,"context_line":"----------"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"* Add a \"attach_snapshot\" driver API."},{"line_number":138,"context_line":"* Add a \"attach_snapshot\" manager API."},{"line_number":139,"context_line":"* Backup using temporary snapshot in lvm.py."},{"line_number":140,"context_line":"* Provide a default implementation using a temporary volume in driver.py."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a41bdd9_d9a577b5","line":137,"updated":"2015-07-14 00:09:30.000000000","message":"Why are these needed? Aren\u0027t we just creating a temporary volume from the snapshot we\u0027re using? Why can\u0027t we just do this for the existing backup code?","commit_id":"add0f8c30426238d1c0f982e60720a6c7c6def62"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2a1d634005da28575543d39cb4d4701541188ef3","unresolved":false,"context_lines":[{"line_number":134,"context_line":"Work Items"},{"line_number":135,"context_line":"----------"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"* Add a \"attach_snapshot\" driver API."},{"line_number":138,"context_line":"* Add a \"attach_snapshot\" manager API."},{"line_number":139,"context_line":"* Backup using temporary snapshot in lvm.py."},{"line_number":140,"context_line":"* Provide a default implementation using a temporary volume in driver.py."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a41bdd9_1c00ada9","line":137,"in_reply_to":"9a41bdd9_d9a577b5","updated":"2015-07-14 01:39:36.000000000","message":"Hi Mike,\n\nI think I need to update this spec because there are some changes in the code after I wrote the spec, but there are still different comments coming up in the code review, so that\u0027s why I haven\u0027t updated this yet.\n\nFor an attached volume, taking a temp snapshot is usually less expensive than creating a whole temp volume. If we can attach the snapshot and read it directly, we don\u0027t have to create another temp volume. It is quicker to complete the backup this way.\n\nIf a driver hasn\u0027t implemented attach snapshot, we can create a temp volume from the attached source volume, and backup the temp volume.\n\nFor the LVM driver, because the backup service is on the same node as the volume driver, we can just read the local path of the temp snapshot after it is created from the attached source volume.  We\u0027ll create a temp snapshot, but there\u0027s no need to attach snapshot for LVM.\n\nIn the future, if the backup service can be on a different node than the volume driver, then we can look into whether to do attach snapshot for LVM as well, however, there are concerns that introducing the attach snapshot logic will complicate the LVM code.  This is for the future, so it can be decided later.","commit_id":"add0f8c30426238d1c0f982e60720a6c7c6def62"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d82554cadca5929e1f2bf6604f1028650c6a681d","unresolved":false,"context_lines":[{"line_number":146,"context_line":"non-disruptive backup so that a regular tenant cannot operate on them"},{"line_number":147,"context_line":"and his quota will not be affected by them, we can use Cinder internal"},{"line_number":148,"context_line":"tenant to manage them. Cinder internal tenant is proposed by the"},{"line_number":149,"context_line":"following spec:"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"https://review.openstack.org/#/c/186232/"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_261045a8","line":149,"updated":"2015-06-19 18:52:24.000000000","message":"If a volume snapshot is owned by the Cinder internal tenant, does this lead to a state where a failed snapshot means the user can\u0027t delete the snapshot or volume w/o admin intervention?  (More something to consider in the implementation than here.)","commit_id":"add0f8c30426238d1c0f982e60720a6c7c6def62"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"17a99517f3a4514a012851e2fbeee404bbd17698","unresolved":false,"context_lines":[{"line_number":146,"context_line":"non-disruptive backup so that a regular tenant cannot operate on them"},{"line_number":147,"context_line":"and his quota will not be affected by them, we can use Cinder internal"},{"line_number":148,"context_line":"tenant to manage them. Cinder internal tenant is proposed by the"},{"line_number":149,"context_line":"following spec:"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"https://review.openstack.org/#/c/186232/"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_806c8009","line":149,"in_reply_to":"fa32b979_261045a8","updated":"2015-06-21 19:02:02.000000000","message":"I think so.  Admin should be able to delete the snapshot.  During implementation, we should also do cleanup using the internal tenant when error occurs.","commit_id":"add0f8c30426238d1c0f982e60720a6c7c6def62"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"a9e6a91473095c6884698347737d2971ad461c4a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"Alternatives"},{"line_number":98,"context_line":"------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"The alternative will be detaching the volume and backing it up."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Data model impact"},{"line_number":103,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a50d1a3_ff7a57f0","line":100,"updated":"2015-07-22 13:28:52.000000000","message":"Or snap the live volume, create a vol from the snap then back that up...","commit_id":"a35d2122ede4aaf867fd49af27f8a4816918965f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e7222e1b6a270a7a29af39307a35a926ece0ea59","unresolved":false,"context_lines":[{"line_number":97,"context_line":"Alternatives"},{"line_number":98,"context_line":"------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"The alternative will be detaching the volume and backing it up."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Data model impact"},{"line_number":103,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a50d1a3_d6a2d698","line":100,"in_reply_to":"3a50d1a3_ff7a57f0","updated":"2015-07-22 17:24:30.000000000","message":"Done","commit_id":"a35d2122ede4aaf867fd49af27f8a4816918965f"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"a9e6a91473095c6884698347737d2971ad461c4a","unresolved":false,"context_lines":[{"line_number":195,"context_line":"------------------"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"If we can map the snapshot and back it up, it will be much faster than"},{"line_number":198,"context_line":"detaching it and backing it up and attaching it again."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Other deployer impact"},{"line_number":201,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a50d1a3_ff96d7ee","line":198,"updated":"2015-07-22 13:28:52.000000000","message":"You can manually snap, vol from snap then backup then delete vol \u0026 snap now, performance should be identical, pretty much, new interface is just cleaner \u0026 easier. (also should work even if you are at max vol/snap quota)","commit_id":"a35d2122ede4aaf867fd49af27f8a4816918965f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e7222e1b6a270a7a29af39307a35a926ece0ea59","unresolved":false,"context_lines":[{"line_number":195,"context_line":"------------------"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"If we can map the snapshot and back it up, it will be much faster than"},{"line_number":198,"context_line":"detaching it and backing it up and attaching it again."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Other deployer impact"},{"line_number":201,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a50d1a3_117fe866","line":198,"in_reply_to":"3a50d1a3_ff96d7ee","updated":"2015-07-22 17:24:30.000000000","message":"Addressed your comments.  Changed to \"No obvious performance impact\".","commit_id":"a35d2122ede4aaf867fd49af27f8a4816918965f"}]}
