)]}'
{"specs/liberty/get-vol-type-extra-specs.rst":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3ab4fc2668fffd59b808236126dc9083089f3c22","unresolved":false,"context_lines":[{"line_number":163,"context_line":"These are fairly standard base keys for Cinder backends. We expect most"},{"line_number":164,"context_line":"devices to report at least a boolean True/False for these keys."},{"line_number":165,"context_line":"The ``vendor unique`` keys are optional and are indicated with a prefix"},{"line_number":166,"context_line":"of \"vendor name\" + \"_\". (ex. abc_minIOPS)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Let\u0027s look at compression here:"},{"line_number":169,"context_line":"  This is a ``well defined`` key, we expect devices to report True or False"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa1b9901_2d7e896a","line":166,"updated":"2015-08-25 14:00:52.000000000","message":"?-1: Should vendor name be the same as reported key `vendor_name` or can it be anything the driver wants?\n\nIf we use vendor_name we may end up with things like \"Open Source_fireproof\", but if we let it use whatever it wants they could change it to \"lvm_fireproof\" which is more readable.\n\nIt should be explicitly stated in the spec.","commit_id":"09e96d93d30fe0f38f6667cea46e70f14b3054af"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"d793212cd2042e647d2eae9d1164b95e6721bf11","unresolved":false,"context_lines":[{"line_number":163,"context_line":"These are fairly standard base keys for Cinder backends. We expect most"},{"line_number":164,"context_line":"devices to report at least a boolean True/False for these keys."},{"line_number":165,"context_line":"The ``vendor unique`` keys are optional and are indicated with a prefix"},{"line_number":166,"context_line":"of \"vendor name\" + \"_\". (ex. abc_minIOPS)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Let\u0027s look at compression here:"},{"line_number":169,"context_line":"  This is a ``well defined`` key, we expect devices to report True or False"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_d85b3bf5","line":166,"in_reply_to":"fa1b9901_2d7e896a","updated":"2015-08-27 22:40:05.000000000","message":"Thank you for your review. Based on the discussion at Cinder meeting, we decided that vendor can use anything for vendor name expect colon.\n\nPlease visit latest update and give your opinion. Thanks.","commit_id":"09e96d93d30fe0f38f6667cea46e70f14b3054af"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3ab4fc2668fffd59b808236126dc9083089f3c22","unresolved":false,"context_lines":[{"line_number":389,"context_line":"Dependencies"},{"line_number":390,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"The decision on what the ``well defined`` capabilities will be:"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"[2] https://review.openstack.org/#/c/150511"},{"line_number":395,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa1b9901_6a3227a9","line":392,"range":{"start_line":392,"start_character":55,"end_line":392,"end_character":59},"updated":"2015-08-25 14:00:52.000000000","message":"nit: s/will be:/will be [2]","commit_id":"09e96d93d30fe0f38f6667cea46e70f14b3054af"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"d793212cd2042e647d2eae9d1164b95e6721bf11","unresolved":false,"context_lines":[{"line_number":389,"context_line":"Dependencies"},{"line_number":390,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"The decision on what the ``well defined`` capabilities will be:"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"[2] https://review.openstack.org/#/c/150511"},{"line_number":395,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_78deaf6e","line":392,"in_reply_to":"fa1b9901_6a3227a9","updated":"2015-08-27 22:40:05.000000000","message":"Done","commit_id":"09e96d93d30fe0f38f6667cea46e70f14b3054af"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3ab4fc2668fffd59b808236126dc9083089f3c22","unresolved":false,"context_lines":[{"line_number":391,"context_line":""},{"line_number":392,"context_line":"The decision on what the ``well defined`` capabilities will be:"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"[2] https://review.openstack.org/#/c/150511"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"Testing"},{"line_number":397,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa1b9901_4abba3e5","line":394,"updated":"2015-08-25 14:00:52.000000000","message":"nit: move this to line 412","commit_id":"09e96d93d30fe0f38f6667cea46e70f14b3054af"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"d793212cd2042e647d2eae9d1164b95e6721bf11","unresolved":false,"context_lines":[{"line_number":391,"context_line":""},{"line_number":392,"context_line":"The decision on what the ``well defined`` capabilities will be:"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"[2] https://review.openstack.org/#/c/150511"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"Testing"},{"line_number":397,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_98d94386","line":394,"in_reply_to":"fa1b9901_4abba3e5","updated":"2015-08-27 22:40:05.000000000","message":"Done","commit_id":"09e96d93d30fe0f38f6667cea46e70f14b3054af"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ac9050dca59f0c7c4a0aa5f1266b9583158c0c17","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"If a driver does not publish the ``extra specs`` dictionary, which will be the"},{"line_number":308,"context_line":"case for any drivers that do not get updated, then no client-side filtering"},{"line_number":309,"context_line":"will be performed, and the behaviour will basically revert to the current"},{"line_number":310,"context_line":"situation where the administrator in horizon will need to know and enter the"},{"line_number":311,"context_line":"key/value pairs without any additional guidance."},{"line_number":312,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_4583a004","line":309,"updated":"2015-08-28 13:54:49.000000000","message":"You proper English people and all your extra u\u0027s. :)","commit_id":"6c1595f061ffaf3a6f839e4acc5f4160d18b44ec"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"78a3ebb72b634787cbe0e58503fcce9d01edcfab","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"If a driver does not publish the ``extra specs`` dictionary, which will be the"},{"line_number":308,"context_line":"case for any drivers that do not get updated, then no client-side filtering"},{"line_number":309,"context_line":"will be performed, and the behaviour will basically revert to the current"},{"line_number":310,"context_line":"situation where the administrator in horizon will need to know and enter the"},{"line_number":311,"context_line":"key/value pairs without any additional guidance."},{"line_number":312,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_b8b41535","line":309,"in_reply_to":"da20952f_4583a004","updated":"2015-08-28 18:43:42.000000000","message":"I didn\u0027t know that behaviour is English style...","commit_id":"6c1595f061ffaf3a6f839e4acc5f4160d18b44ec"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b20f758b15613f3d5b79fd5b2b172ab823ed4fe0","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"If a driver does not publish the ``extra specs`` dictionary, which will be the"},{"line_number":308,"context_line":"case for any drivers that do not get updated, then no client-side filtering"},{"line_number":309,"context_line":"will be performed, and the behaviour will basically revert to the current"},{"line_number":310,"context_line":"situation where the administrator in horizon will need to know and enter the"},{"line_number":311,"context_line":"key/value pairs without any additional guidance."},{"line_number":312,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_7833ddab","line":309,"in_reply_to":"da20952f_b8b41535","updated":"2015-08-28 18:46:13.000000000","message":"Hah, sorry, I didn\u0027t mean you necessarily needed to change that. I just found it a little funny. Oh well, thanks!","commit_id":"6c1595f061ffaf3a6f839e4acc5f4160d18b44ec"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"34f00f5485c2853681ce0bab54da1c230b096d05","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"The ``vendor unique`` keys are optional and are indicated with a prefix"},{"line_number":167,"context_line":"of vendor name + colon(:). (ex. abcd:minIOPS)"},{"line_number":168,"context_line":"Vendor driver can use anything for the vendor name, but the vendor name"},{"line_number":169,"context_line":"only shouldn\u0027t contain colon because of the separator and it will be"},{"line_number":170,"context_line":"automatically replaced by underscore(_). (abc:d -\u003e abc_d)"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da20952f_82bcf2bb","line":168,"updated":"2015-08-31 17:39:05.000000000","message":"-1: s/for the vendor name/for the vendor ``unique keys``","commit_id":"adb22d17dd62918f8fecf5003b0911ef016e810c"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"7d4e35c97cc01f127ec2ecc74396480586f9bd94","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"The ``vendor unique`` keys are optional and are indicated with a prefix"},{"line_number":167,"context_line":"of vendor name + colon(:). (ex. abcd:minIOPS)"},{"line_number":168,"context_line":"Vendor driver can use anything for the vendor name, but the vendor name"},{"line_number":169,"context_line":"only shouldn\u0027t contain colon because of the separator and it will be"},{"line_number":170,"context_line":"automatically replaced by underscore(_). (abc:d -\u003e abc_d)"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da20952f_253ad0e7","line":168,"in_reply_to":"da20952f_82bcf2bb","updated":"2015-08-31 18:08:28.000000000","message":"Done","commit_id":"adb22d17dd62918f8fecf5003b0911ef016e810c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"34f00f5485c2853681ce0bab54da1c230b096d05","unresolved":false,"context_lines":[{"line_number":166,"context_line":"The ``vendor unique`` keys are optional and are indicated with a prefix"},{"line_number":167,"context_line":"of vendor name + colon(:). (ex. abcd:minIOPS)"},{"line_number":168,"context_line":"Vendor driver can use anything for the vendor name, but the vendor name"},{"line_number":169,"context_line":"only shouldn\u0027t contain colon because of the separator and it will be"},{"line_number":170,"context_line":"automatically replaced by underscore(_). (abc:d -\u003e abc_d)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Let\u0027s look at compression here:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da20952f_02c9c258","line":169,"updated":"2015-08-31 17:39:05.000000000","message":"nit: s/only shouldn\u0027t/prefix shouldn\u0027t/","commit_id":"adb22d17dd62918f8fecf5003b0911ef016e810c"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"7d4e35c97cc01f127ec2ecc74396480586f9bd94","unresolved":false,"context_lines":[{"line_number":166,"context_line":"The ``vendor unique`` keys are optional and are indicated with a prefix"},{"line_number":167,"context_line":"of vendor name + colon(:). (ex. abcd:minIOPS)"},{"line_number":168,"context_line":"Vendor driver can use anything for the vendor name, but the vendor name"},{"line_number":169,"context_line":"only shouldn\u0027t contain colon because of the separator and it will be"},{"line_number":170,"context_line":"automatically replaced by underscore(_). (abc:d -\u003e abc_d)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Let\u0027s look at compression here:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da20952f_e528589c","line":169,"in_reply_to":"da20952f_02c9c258","updated":"2015-08-31 18:08:28.000000000","message":"Done","commit_id":"adb22d17dd62918f8fecf5003b0911ef016e810c"}]}