)]}'
{"specs/mitaka/api-microversions.rst":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"88992b19df2e04dbf6cc53ef542bf0fca5b6ca1f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"especially important to introduce backwards incompatible changes to the"},{"line_number":15,"context_line":"Nova - Cinder API."},{"line_number":16,"context_line":"Credit and thanks to the authors of the Nova spec upon which this is based,"},{"line_number":17,"context_line":"especially Christopeher Yeoh and Sean Dague, and to the Manila team, "},{"line_number":18,"context_line":"especially Clinton Knight."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Include the URL of your launchpad blueprint:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_04228501","line":17,"updated":"2015-09-22 23:03:57.000000000","message":"the trailing white space virus.....","commit_id":"3990816f326f8d44d3772302b1587102bbd144e0"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"b682785007bd61591a90062ae833b6f2472a6249","unresolved":false,"context_lines":[{"line_number":14,"context_line":"especially important to introduce backwards incompatible changes to the"},{"line_number":15,"context_line":"Nova - Cinder API."},{"line_number":16,"context_line":"Credit and thanks to the authors of the Nova spec upon which this is based,"},{"line_number":17,"context_line":"especially Christopeher Yeoh and Sean Dague, and to the Manila team, "},{"line_number":18,"context_line":"especially Clinton Knight."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Include the URL of your launchpad blueprint:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_3528f5e1","line":17,"in_reply_to":"ba15a1d1_04228501","updated":"2015-09-23 14:47:44.000000000","message":"Done","commit_id":"3990816f326f8d44d3772302b1587102bbd144e0"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"88992b19df2e04dbf6cc53ef542bf0fca5b6ca1f","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Many changes to the Cinder REST API require changes to the consumers of the API."},{"line_number":29,"context_line":"For example, If we need to add a required parameter to a method that is called"},{"line_number":30,"context_line":" by Nova, we\u0027d need both the Nova calling code and the cinderclient that"},{"line_number":31,"context_line":"Nova uses to change. But newer Cinder versions with the change must work with"},{"line_number":32,"context_line":"older Nova versions, and there is no mechanism for this at the moment. Adding"},{"line_number":33,"context_line":"microversions will solve this problem."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_8463f540","line":30,"updated":"2015-09-22 23:03:57.000000000","message":"leading space","commit_id":"3990816f326f8d44d3772302b1587102bbd144e0"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"b682785007bd61591a90062ae833b6f2472a6249","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Many changes to the Cinder REST API require changes to the consumers of the API."},{"line_number":29,"context_line":"For example, If we need to add a required parameter to a method that is called"},{"line_number":30,"context_line":" by Nova, we\u0027d need both the Nova calling code and the cinderclient that"},{"line_number":31,"context_line":"Nova uses to change. But newer Cinder versions with the change must work with"},{"line_number":32,"context_line":"older Nova versions, and there is no mechanism for this at the moment. Adding"},{"line_number":33,"context_line":"microversions will solve this problem."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_f51d9dbe","line":30,"in_reply_to":"ba15a1d1_8463f540","updated":"2015-09-23 14:47:44.000000000","message":"Done","commit_id":"3990816f326f8d44d3772302b1587102bbd144e0"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"88992b19df2e04dbf6cc53ef542bf0fca5b6ca1f","unresolved":false,"context_lines":[{"line_number":418,"context_line":"----------------"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"This will affect how Cinder developers modify the REST API code and add new"},{"line_number":421,"context_line":"extensions."},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"Implementation"},{"line_number":424,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_dfdd3671","line":421,"updated":"2015-09-22 23:03:57.000000000","message":"It also might affect the volume manager as well.  In the case of removing the local file locks, which requires \u0027ING\u0027 checks....","commit_id":"3990816f326f8d44d3772302b1587102bbd144e0"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"b682785007bd61591a90062ae833b6f2472a6249","unresolved":false,"context_lines":[{"line_number":418,"context_line":"----------------"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"This will affect how Cinder developers modify the REST API code and add new"},{"line_number":421,"context_line":"extensions."},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"Implementation"},{"line_number":424,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_75098d83","line":421,"in_reply_to":"ba15a1d1_dfdd3671","updated":"2015-09-23 14:47:44.000000000","message":"Will update next patch.","commit_id":"3990816f326f8d44d3772302b1587102bbd144e0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c217dd7844db7dfcaa4ad8d873a42a36cd4632b6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Cinder API v2 would be the default, and consumers of the API that wished to"},{"line_number":41,"context_line":"use a newer version could do so."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Not in Scope: Experimental APIs. This will be done separately"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Use Cases"},{"line_number":46,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a29b11f_c7bdcc03","line":43,"updated":"2015-10-26 06:02:46.000000000","message":"Can you elaborate on how experimental APIs are different?","commit_id":"8d8684b9bca5003203798789482841c22d9de05d"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"e2576cb7977231b8e51aa18ff538b454fc140a52","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Cinder API v2 would be the default, and consumers of the API that wished to"},{"line_number":41,"context_line":"use a newer version could do so."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Not in Scope: Experimental APIs. This will be done separately"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Use Cases"},{"line_number":46,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_2138aeee","line":43,"in_reply_to":"1a26ad4f_44b757d8","updated":"2015-11-02 16:39:38.000000000","message":"Done","commit_id":"8d8684b9bca5003203798789482841c22d9de05d"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"d683bbc435340c3cc6b870bc4fe8362b78c95331","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Cinder API v2 would be the default, and consumers of the API that wished to"},{"line_number":41,"context_line":"use a newer version could do so."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Not in Scope: Experimental APIs. This will be done separately"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Use Cases"},{"line_number":46,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_44b757d8","line":43,"in_reply_to":"3a29b11f_c7bdcc03","updated":"2015-10-29 08:22:16.000000000","message":"In actuality, the only real difference is another HTTP header that must be used to indicate the client is aware that this API call is experimental and subject to change or removal.\nI believe that Nova uses a policy that microversions can be changed or removed, so the real difference might only be semantic.","commit_id":"8d8684b9bca5003203798789482841c22d9de05d"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"18cb25564620c414f4b2750db03b5af9b614dabe","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* Users of the REST API are able to, on a per request basis, decide"},{"line_number":61,"context_line":"  which version of the API they want to use (assuming the deployer"},{"line_number":62,"context_line":"  supports the version they want)."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Proposed change"},{"line_number":65,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_2ac0464f","line":62,"updated":"2015-09-30 21:44:11.000000000","message":"So the notes about making non backward compatible changes being possible are good, but I think the real value is in stressing that we never break compatibility or usability for those that don\u0027t upgrade things.\n\nYou say the same thing, but I think the positive there should be highlighted.","commit_id":"8d8684b9bca5003203798789482841c22d9de05d"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"19c5dc0e69ece31df87249e5edaf494ae6c74e06","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* Users of the REST API are able to, on a per request basis, decide"},{"line_number":61,"context_line":"  which version of the API they want to use (assuming the deployer"},{"line_number":62,"context_line":"  supports the version they want)."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Proposed change"},{"line_number":65,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_f4198823","line":62,"in_reply_to":"9a1a9d01_2ac0464f","updated":"2015-10-02 12:59:19.000000000","message":"Sounds good. I\u0027ll update next patch.","commit_id":"8d8684b9bca5003203798789482841c22d9de05d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"f71011aec2b44850ff87fc028ef9a087bb6ad91f","unresolved":false,"context_lines":[{"line_number":109,"context_line":"{"},{"line_number":110,"context_line":"    \"versions\": ["},{"line_number":111,"context_line":"        {"},{"line_number":112,"context_line":"            \"id\": \"v2.0\", "},{"line_number":113,"context_line":"            \"links\": ["},{"line_number":114,"context_line":"                {"},{"line_number":115,"context_line":"                    \"href\": \"http://docs.openstack.org/\", "}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_7d91c298","line":112,"updated":"2015-10-29 09:39:55.000000000","message":"whitespace in the next rev","commit_id":"8d8684b9bca5003203798789482841c22d9de05d"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"e2576cb7977231b8e51aa18ff538b454fc140a52","unresolved":false,"context_lines":[{"line_number":109,"context_line":"{"},{"line_number":110,"context_line":"    \"versions\": ["},{"line_number":111,"context_line":"        {"},{"line_number":112,"context_line":"            \"id\": \"v2.0\", "},{"line_number":113,"context_line":"            \"links\": ["},{"line_number":114,"context_line":"                {"},{"line_number":115,"context_line":"                    \"href\": \"http://docs.openstack.org/\", "}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_9c400536","line":112,"in_reply_to":"1a26ad4f_7d91c298","updated":"2015-11-02 16:39:38.000000000","message":"Done","commit_id":"8d8684b9bca5003203798789482841c22d9de05d"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"2bf268310beb0b502ff44d9e59bb543fcfc03d44","unresolved":false,"context_lines":[{"line_number":213,"context_line":"executed."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"The second header is used as a hint to caching proxies that the"},{"line_number":216,"context_line":"response is also dependent on the X-Openstack-Compute-API-Version and"},{"line_number":217,"context_line":"not just the body and query parameters. See RFC 2616 section 14.44 for"},{"line_number":218,"context_line":"details."},{"line_number":219,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_e2675c23","line":216,"updated":"2015-10-30 01:42:33.000000000","message":"I am not sure why are we adding compute API version dependency. Is it a typo? If not could you please elaborate.\n\nAlso s/Openstack/OpenStack","commit_id":"8d8684b9bca5003203798789482841c22d9de05d"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"e2576cb7977231b8e51aa18ff538b454fc140a52","unresolved":false,"context_lines":[{"line_number":213,"context_line":"executed."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"The second header is used as a hint to caching proxies that the"},{"line_number":216,"context_line":"response is also dependent on the X-Openstack-Compute-API-Version and"},{"line_number":217,"context_line":"not just the body and query parameters. See RFC 2616 section 14.44 for"},{"line_number":218,"context_line":"details."},{"line_number":219,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_5c5d8d13","line":216,"in_reply_to":"1a26ad4f_e2675c23","updated":"2015-11-02 16:39:38.000000000","message":"That was a typo. I\u0027ll fix.","commit_id":"8d8684b9bca5003203798789482841c22d9de05d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"6d531ba5d7ca828fbced44bd3f8e2346be50804a","unresolved":false,"context_lines":[{"line_number":393,"context_line":"Notifications impact"},{"line_number":394,"context_line":"--------------------"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"TODO: determine Notification Impact"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"Other end user impact"},{"line_number":399,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_aacb9752","line":396,"updated":"2015-10-29 06:21:37.000000000","message":"There is a topic of versioning of notifications in Nova, but I don\u0027t feel it\u0027s related to this change for now.","commit_id":"8d8684b9bca5003203798789482841c22d9de05d"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"e2576cb7977231b8e51aa18ff538b454fc140a52","unresolved":false,"context_lines":[{"line_number":393,"context_line":"Notifications impact"},{"line_number":394,"context_line":"--------------------"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"TODO: determine Notification Impact"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"Other end user impact"},{"line_number":399,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_1c895575","line":396,"in_reply_to":"1a26ad4f_a472eb47","updated":"2015-11-02 16:39:38.000000000","message":"OK, I\u0027ll assume you meant that this can be removed, as there is not any notification impact.","commit_id":"8d8684b9bca5003203798789482841c22d9de05d"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"d683bbc435340c3cc6b870bc4fe8362b78c95331","unresolved":false,"context_lines":[{"line_number":393,"context_line":"Notifications impact"},{"line_number":394,"context_line":"--------------------"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"TODO: determine Notification Impact"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"Other end user impact"},{"line_number":399,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_a472eb47","line":396,"in_reply_to":"1a26ad4f_aacb9752","updated":"2015-10-29 08:22:16.000000000","message":"It\u0027s not clear what you mean. Does that mean you are recommending that this line is changed to NONE?","commit_id":"8d8684b9bca5003203798789482841c22d9de05d"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"bf05de894e435494dc391e44b565a3a55bdd529f","unresolved":false,"context_lines":[{"line_number":438,"context_line":"----------"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"Port Manila code for api-microversions"},{"line_number":441,"context_line":"  Status: Done (see https://review.openstack.org/#/c/223803)"},{"line_number":442,"context_line":"Add examples of increments and decorators (scottda)"},{"line_number":443,"context_line":"Add additional unit tests (scottda)"},{"line_number":444,"context_line":"test with python-cinderclient changes (scottda)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_45609a01","line":441,"updated":"2015-10-30 01:47:23.000000000","message":"Is this supposed to be a link to this review, or https://review.openstack.org/#/c/224910/","commit_id":"8d8684b9bca5003203798789482841c22d9de05d"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"e2576cb7977231b8e51aa18ff538b454fc140a52","unresolved":false,"context_lines":[{"line_number":438,"context_line":"----------"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"Port Manila code for api-microversions"},{"line_number":441,"context_line":"  Status: Done (see https://review.openstack.org/#/c/223803)"},{"line_number":442,"context_line":"Add examples of increments and decorators (scottda)"},{"line_number":443,"context_line":"Add additional unit tests (scottda)"},{"line_number":444,"context_line":"test with python-cinderclient changes (scottda)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_5c67cdb6","line":441,"in_reply_to":"1a26ad4f_45609a01","updated":"2015-11-02 16:39:38.000000000","message":"Yes, you have the correct link. I\u0027ll change.","commit_id":"8d8684b9bca5003203798789482841c22d9de05d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"6d531ba5d7ca828fbced44bd3f8e2346be50804a","unresolved":false,"context_lines":[{"line_number":465,"context_line":"Documentation Impact"},{"line_number":466,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"Documents concerning the API will need to reflect these changes."},{"line_number":469,"context_line":""},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_0ab40bcf","line":468,"updated":"2015-10-29 06:21:37.000000000","message":"We should also signal a hard requirement to document any microversion bump as Nova is doing (nova/api/openstack/rest_api_version_history.rst). Only this makes it possible to find a compatible version. Also we\u0027ll have all the information in one place instead of having it distributed.","commit_id":"8d8684b9bca5003203798789482841c22d9de05d"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"072c11f0f27be28f4b0a384cce14c22c6a2592d6","unresolved":false,"context_lines":[{"line_number":465,"context_line":"Documentation Impact"},{"line_number":466,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"Documents concerning the API will need to reflect these changes."},{"line_number":469,"context_line":""},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_871b311b","line":468,"in_reply_to":"1a26ad4f_0ab40bcf","updated":"2015-10-29 08:48:44.000000000","message":"Yes, that\u0027s right and WIP code already has this. I\u0027ll add to the spec.","commit_id":"8d8684b9bca5003203798789482841c22d9de05d"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"e2576cb7977231b8e51aa18ff538b454fc140a52","unresolved":false,"context_lines":[{"line_number":465,"context_line":"Documentation Impact"},{"line_number":466,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"Documents concerning the API will need to reflect these changes."},{"line_number":469,"context_line":""},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_fc89f926","line":468,"in_reply_to":"1a26ad4f_871b311b","updated":"2015-11-02 16:39:38.000000000","message":"Done","commit_id":"8d8684b9bca5003203798789482841c22d9de05d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f82b5c0a8c164afe51068fe15fd448b82858726a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"especially Clinton Knight."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":21,"context_line":"https://blueprints.launchpad.net/cinder/+spec/example"},{"line_number":22,"context_line":"WIP implementation code:"},{"line_number":23,"context_line":"https://review.openstack.org/#/c/224910/"},{"line_number":24,"context_line":"Test Cases and code:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a26ad4f_e475df97","line":21,"updated":"2015-11-02 19:24:26.000000000","message":"Should this point to example instead of https://blueprints.launchpad.net/cinder/+spec/cinder-api-microversions ?\n\nAlso cinder-api-microversions BP is Approved. Should it be even if this spec is not merged?","commit_id":"d1474da7e94c4036ab3feeaf5833541c8adf2be6"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"f2ea796482f013eb332ed54dcf7de2c0c2cc95c8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"especially Clinton Knight."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":21,"context_line":"https://blueprints.launchpad.net/cinder/+spec/example"},{"line_number":22,"context_line":"WIP implementation code:"},{"line_number":23,"context_line":"https://review.openstack.org/#/c/224910/"},{"line_number":24,"context_line":"Test Cases and code:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a26ad4f_da2c3804","line":21,"in_reply_to":"1a26ad4f_e475df97","updated":"2015-11-02 20:27:05.000000000","message":"I changed the URL for the BP.\nI think BP can get approved independently of spec, but I\u0027m not sure. You\u0027d have to ask Sean about that. In the meantime, there\u0027s nothing I can change in this spec for that.","commit_id":"d1474da7e94c4036ab3feeaf5833541c8adf2be6"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f82b5c0a8c164afe51068fe15fd448b82858726a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":21,"context_line":"https://blueprints.launchpad.net/cinder/+spec/example"},{"line_number":22,"context_line":"WIP implementation code:"},{"line_number":23,"context_line":"https://review.openstack.org/#/c/224910/"},{"line_number":24,"context_line":"Test Cases and code:"},{"line_number":25,"context_line":"https://github.com/scottdangelo/TestCinderAPImicroversions"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a26ad4f_2460b7ce","line":23,"updated":"2015-11-02 19:24:26.000000000","message":"I would move these to references - this looks awful when rendered: http://docs-draft.openstack.org/03/223803/6/check/gate-cinder-specs-docs/2065c76//doc/build/html/specs/mitaka/api-microversions.html","commit_id":"d1474da7e94c4036ab3feeaf5833541c8adf2be6"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"f2ea796482f013eb332ed54dcf7de2c0c2cc95c8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":21,"context_line":"https://blueprints.launchpad.net/cinder/+spec/example"},{"line_number":22,"context_line":"WIP implementation code:"},{"line_number":23,"context_line":"https://review.openstack.org/#/c/224910/"},{"line_number":24,"context_line":"Test Cases and code:"},{"line_number":25,"context_line":"https://github.com/scottdangelo/TestCinderAPImicroversions"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a26ad4f_5a2828e2","line":23,"in_reply_to":"1a26ad4f_2460b7ce","updated":"2015-11-02 20:27:05.000000000","message":"Done","commit_id":"d1474da7e94c4036ab3feeaf5833541c8adf2be6"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f82b5c0a8c164afe51068fe15fd448b82858726a","unresolved":false,"context_lines":[{"line_number":112,"context_line":"A backwards compatible change is defined as one which would be allowed"},{"line_number":113,"context_line":"under the OpenStack API Change Guidelines"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"http://wiki.openstack.org/wiki/APIChangeGuidelines"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"A version response would look as follows for GET http://\u003ccinder_URL\u003e:8776"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a26ad4f_e432bf0f","line":115,"updated":"2015-11-02 19:24:26.000000000","message":"You can add this as rst link with something like this:\n\n    `OpenStack API Change Guidelines`_\n\nAnd in References section:\n\n    ..  _OpenStack API Change Guidelines: \thttp://wiki.openstack.org/wiki/APIChangeGuidelines\n\nAlso the link redirects now to: http://specs.openstack.org/openstack/api-wg/guidelines/evaluating_api_changes.html","commit_id":"d1474da7e94c4036ab3feeaf5833541c8adf2be6"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"f2ea796482f013eb332ed54dcf7de2c0c2cc95c8","unresolved":false,"context_lines":[{"line_number":112,"context_line":"A backwards compatible change is defined as one which would be allowed"},{"line_number":113,"context_line":"under the OpenStack API Change Guidelines"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"http://wiki.openstack.org/wiki/APIChangeGuidelines"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"A version response would look as follows for GET http://\u003ccinder_URL\u003e:8776"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a26ad4f_baea9c72","line":115,"in_reply_to":"1a26ad4f_e432bf0f","updated":"2015-11-02 20:27:05.000000000","message":"OK. I didn\u0027t change the link since that\u0027s \u003e80 chars and might not pass pylint","commit_id":"d1474da7e94c4036ab3feeaf5833541c8adf2be6"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f82b5c0a8c164afe51068fe15fd448b82858726a","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"Two extra headers are always returned in the response:"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"X-OpenStack-Cinder-API-Version: version_number"},{"line_number":222,"context_line":"Vary: X-OpenStack-Cinder-API-Version"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"The first header specifies the version number of the API which was"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a26ad4f_9f5472fe","line":221,"updated":"2015-11-02 19:24:26.000000000","message":"This should be a list or line block to render correctly.","commit_id":"d1474da7e94c4036ab3feeaf5833541c8adf2be6"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"f2ea796482f013eb332ed54dcf7de2c0c2cc95c8","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"Two extra headers are always returned in the response:"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"X-OpenStack-Cinder-API-Version: version_number"},{"line_number":222,"context_line":"Vary: X-OpenStack-Cinder-API-Version"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"The first header specifies the version number of the API which was"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a26ad4f_5a8b48c3","line":221,"in_reply_to":"1a26ad4f_9f5472fe","updated":"2015-11-02 20:27:05.000000000","message":"Done","commit_id":"d1474da7e94c4036ab3feeaf5833541c8adf2be6"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f82b5c0a8c164afe51068fe15fd448b82858726a","unresolved":false,"context_lines":[{"line_number":328,"context_line":"itself could then be removed."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"The minimum version of the API as a whole would only be increased by a"},{"line_number":331,"context_line":"consensus decision between Cinder developers who have the ovehead of"},{"line_number":332,"context_line":"maintaining backwards compatibility and deployers and users who want"},{"line_number":333,"context_line":"backwards compatibility forever."},{"line_number":334,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a26ad4f_3f467e4f","line":331,"updated":"2015-11-02 19:24:26.000000000","message":"ovehead?","commit_id":"d1474da7e94c4036ab3feeaf5833541c8adf2be6"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"f2ea796482f013eb332ed54dcf7de2c0c2cc95c8","unresolved":false,"context_lines":[{"line_number":328,"context_line":"itself could then be removed."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"The minimum version of the API as a whole would only be increased by a"},{"line_number":331,"context_line":"consensus decision between Cinder developers who have the ovehead of"},{"line_number":332,"context_line":"maintaining backwards compatibility and deployers and users who want"},{"line_number":333,"context_line":"backwards compatibility forever."},{"line_number":334,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a26ad4f_1a9150f1","line":331,"in_reply_to":"1a26ad4f_3f467e4f","updated":"2015-11-02 20:27:05.000000000","message":"Done","commit_id":"d1474da7e94c4036ab3feeaf5833541c8adf2be6"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"40c6642ba056b640356e38a09414d11f7a361cfa","unresolved":false,"context_lines":[{"line_number":486,"context_line":"* Manila code for api-microversions: https://review.openstack.org/#/c/207228/8"},{"line_number":487,"context_line":"* WIP implementation code: https://review.openstack.org/#/c/224910/"},{"line_number":488,"context_line":"* Test Cases and code: https://github.com/scottdangelo/TestCinderAPImicroversions"},{"line_number":489,"context_line":"** _OpenStack API Change Guidelines: http://wiki.openstack.org/wiki/APIChangeGuidelines"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a26ad4f_95a213fb","line":489,"updated":"2015-11-02 20:23:31.000000000","message":"This line should start with .. instead of ** to create a link correctly. \n\nAlso the wiki page redirects to http://specs.openstack.org/openstack/api-wg/guidelines/evaluating_api_changes.html - why not link this document directly?","commit_id":"3dc41c2ccf5fa30ab9112900de2082db301a7e52"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"0209d3e0541ce8a09c5d96bae49f94518063fdbf","unresolved":false,"context_lines":[{"line_number":486,"context_line":"* Manila code for api-microversions: https://review.openstack.org/#/c/207228/8"},{"line_number":487,"context_line":"* WIP implementation code: https://review.openstack.org/#/c/224910/"},{"line_number":488,"context_line":"* Test Cases and code: https://github.com/scottdangelo/TestCinderAPImicroversions"},{"line_number":489,"context_line":"** _OpenStack API Change Guidelines: http://wiki.openstack.org/wiki/APIChangeGuidelines"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a26ad4f_7595f784","line":489,"in_reply_to":"1a26ad4f_95a213fb","updated":"2015-11-02 20:26:29.000000000","message":"OK. You had said \u0027..\u0027 but I thought you\u0027d had a typo and changed it .\nI\u0027ll fix now before anyone else reviews.","commit_id":"3dc41c2ccf5fa30ab9112900de2082db301a7e52"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1974200708fa080c49e407ab7d1a159a2415b8e3","unresolved":false,"context_lines":[{"line_number":108,"context_line":"A backwards compatible change is defined as one which would be allowed"},{"line_number":109,"context_line":"under the `OpenStack API Change Guidelines`_"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"http://wiki.openstack.org/wiki/APIChangeGuidelines"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"A version response would look as follows for GET http://\u003ccinder_URL\u003e:8776"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa80f949_06f3ea74","line":111,"updated":"2015-11-03 11:46:55.000000000","message":"I think you don\u0027t need this link now here.","commit_id":"55259998b87411656dd755d45b8b91b06cd0d672"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"37ef000eab9ddf3825ebb0532d63414ab19d544a","unresolved":false,"context_lines":[{"line_number":108,"context_line":"A backwards compatible change is defined as one which would be allowed"},{"line_number":109,"context_line":"under the `OpenStack API Change Guidelines`_"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"http://wiki.openstack.org/wiki/APIChangeGuidelines"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"A version response would look as follows for GET http://\u003ccinder_URL\u003e:8776"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"da85f559_69cfeeb0","line":111,"in_reply_to":"fa80f949_06f3ea74","updated":"2015-11-09 16:38:01.000000000","message":"Done","commit_id":"55259998b87411656dd755d45b8b91b06cd0d672"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"91009390911ea7b46a7fbccc371e325381a830cb","unresolved":false,"context_lines":[{"line_number":221,"context_line":"executed."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"The second header is used as a hint to caching proxies that the"},{"line_number":224,"context_line":"response is also dependent on the X-Openstack-Cinder-API-Version and"},{"line_number":225,"context_line":"not just the body and query parameters. See RFC 2616 section 14.44 for"},{"line_number":226,"context_line":"details."},{"line_number":227,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a26ad4f_bc15b740","line":224,"updated":"2015-11-02 21:38:46.000000000","message":"s/Openstack/OpenStack","commit_id":"55259998b87411656dd755d45b8b91b06cd0d672"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"37ef000eab9ddf3825ebb0532d63414ab19d544a","unresolved":false,"context_lines":[{"line_number":221,"context_line":"executed."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"The second header is used as a hint to caching proxies that the"},{"line_number":224,"context_line":"response is also dependent on the X-Openstack-Cinder-API-Version and"},{"line_number":225,"context_line":"not just the body and query parameters. See RFC 2616 section 14.44 for"},{"line_number":226,"context_line":"details."},{"line_number":227,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"da85f559_29c24686","line":224,"in_reply_to":"1a26ad4f_3c84475c","updated":"2015-11-09 16:38:01.000000000","message":"Done","commit_id":"55259998b87411656dd755d45b8b91b06cd0d672"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"7bee74dd64062314faee0f8cc7da0df5e8d16af7","unresolved":false,"context_lines":[{"line_number":221,"context_line":"executed."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"The second header is used as a hint to caching proxies that the"},{"line_number":224,"context_line":"response is also dependent on the X-Openstack-Cinder-API-Version and"},{"line_number":225,"context_line":"not just the body and query parameters. See RFC 2616 section 14.44 for"},{"line_number":226,"context_line":"details."},{"line_number":227,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a26ad4f_3c84475c","line":224,"in_reply_to":"1a26ad4f_bc15b740","updated":"2015-11-02 21:42:31.000000000","message":"Yes, I\u0027ll change if/when I upload next patch set. Please note that it is correct in the code.","commit_id":"55259998b87411656dd755d45b8b91b06cd0d672"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"efd31bff8d77283b8f8d3c64c28d602d27228a8c","unresolved":false,"context_lines":[{"line_number":278,"context_line":"     self._version_specific_func(req, \"foo\")"},{"line_number":279,"context_line":"        .... common stuff ...."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"Reducing the duplicated code to a minimum minimises maintenance"},{"line_number":282,"context_line":"overhead. So the technique we use would depend on individual"},{"line_number":283,"context_line":"circumstances of what code is common/different and where in the method"},{"line_number":284,"context_line":"it is."}],"source_content_type":"text/x-rst","patch_set":8,"id":"da85f559_48d00c54","line":281,"updated":"2015-11-08 17:53:01.000000000","message":"to minimiz(s)e maintenance","commit_id":"55259998b87411656dd755d45b8b91b06cd0d672"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"37ef000eab9ddf3825ebb0532d63414ab19d544a","unresolved":false,"context_lines":[{"line_number":278,"context_line":"     self._version_specific_func(req, \"foo\")"},{"line_number":279,"context_line":"        .... common stuff ...."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"Reducing the duplicated code to a minimum minimises maintenance"},{"line_number":282,"context_line":"overhead. So the technique we use would depend on individual"},{"line_number":283,"context_line":"circumstances of what code is common/different and where in the method"},{"line_number":284,"context_line":"it is."}],"source_content_type":"text/x-rst","patch_set":8,"id":"da85f559_29f7a6d4","line":281,"in_reply_to":"da85f559_48d00c54","updated":"2015-11-09 16:38:01.000000000","message":"Done","commit_id":"55259998b87411656dd755d45b8b91b06cd0d672"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"efd31bff8d77283b8f8d3c64c28d602d27228a8c","unresolved":false,"context_lines":[{"line_number":301,"context_line":"Some prototype code which explains how this work is available here:"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"TODO: scott-dangelo replace with cinder-specific examples"},{"line_number":304,"context_line":"https://github.com/cyeoh/microversions_poc"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"The validation schema decorator would also need to be extended to support"},{"line_number":307,"context_line":"versioning"}],"source_content_type":"text/x-rst","patch_set":8,"id":"da85f559_2846e823","line":304,"updated":"2015-11-08 17:53:01.000000000","message":"Isn\u0027t this a work item?","commit_id":"55259998b87411656dd755d45b8b91b06cd0d672"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"37ef000eab9ddf3825ebb0532d63414ab19d544a","unresolved":false,"context_lines":[{"line_number":301,"context_line":"Some prototype code which explains how this work is available here:"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"TODO: scott-dangelo replace with cinder-specific examples"},{"line_number":304,"context_line":"https://github.com/cyeoh/microversions_poc"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"The validation schema decorator would also need to be extended to support"},{"line_number":307,"context_line":"versioning"}],"source_content_type":"text/x-rst","patch_set":8,"id":"da85f559_a9bb96c3","line":304,"in_reply_to":"da85f559_2846e823","updated":"2015-11-09 16:38:01.000000000","message":"I just changed the link to cinder test code on Git hub, since the work is done.","commit_id":"55259998b87411656dd755d45b8b91b06cd0d672"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"efd31bff8d77283b8f8d3c64c28d602d27228a8c","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"Because we have a monotonically increasing version number across the"},{"line_number":332,"context_line":"whole of the API rather than versioning individual plugins we will have"},{"line_number":333,"context_line":"potential merge conflicts like we currenty have with DB migration"},{"line_number":334,"context_line":"changesets. Sorry, I don\u0027t believe there is any way around this, but"},{"line_number":335,"context_line":"welcome any suggestions!"},{"line_number":336,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"da85f559_c8dddc71","line":333,"updated":"2015-11-08 17:53:01.000000000","message":"currenty -\u003e currently","commit_id":"55259998b87411656dd755d45b8b91b06cd0d672"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"37ef000eab9ddf3825ebb0532d63414ab19d544a","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"Because we have a monotonically increasing version number across the"},{"line_number":332,"context_line":"whole of the API rather than versioning individual plugins we will have"},{"line_number":333,"context_line":"potential merge conflicts like we currenty have with DB migration"},{"line_number":334,"context_line":"changesets. Sorry, I don\u0027t believe there is any way around this, but"},{"line_number":335,"context_line":"welcome any suggestions!"},{"line_number":336,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"da85f559_69b5aecb","line":333,"in_reply_to":"da85f559_c8dddc71","updated":"2015-11-09 16:38:01.000000000","message":"Done","commit_id":"55259998b87411656dd755d45b8b91b06cd0d672"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"efd31bff8d77283b8f8d3c64c28d602d27228a8c","unresolved":false,"context_lines":[{"line_number":376,"context_line":"One alternative is to make all the backwards incompatible changes at"},{"line_number":377,"context_line":"once and do a major API release. For example, change the url prefix to"},{"line_number":378,"context_line":"/v3 instead of /v2. And then support both implementations for a long"},{"line_number":379,"context_line":"period of time. This approach has been dificult in the past and has"},{"line_number":380,"context_line":"cause long periods of time before adoption by various users."},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"da85f559_28f828e5","line":379,"updated":"2015-11-08 17:53:01.000000000","message":"dificult -\u003edifficult","commit_id":"55259998b87411656dd755d45b8b91b06cd0d672"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"37ef000eab9ddf3825ebb0532d63414ab19d544a","unresolved":false,"context_lines":[{"line_number":376,"context_line":"One alternative is to make all the backwards incompatible changes at"},{"line_number":377,"context_line":"once and do a major API release. For example, change the url prefix to"},{"line_number":378,"context_line":"/v3 instead of /v2. And then support both implementations for a long"},{"line_number":379,"context_line":"period of time. This approach has been dificult in the past and has"},{"line_number":380,"context_line":"cause long periods of time before adoption by various users."},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"da85f559_29cfa657","line":379,"in_reply_to":"da85f559_28f828e5","updated":"2015-11-09 16:38:01.000000000","message":"Done","commit_id":"55259998b87411656dd755d45b8b91b06cd0d672"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b2f9fb5a019c8ec0e4bab8297c37459051ecf8cb","unresolved":false,"context_lines":[{"line_number":84,"context_line":"currently 2.0 and is expected to remain so for quite a long time."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"For the purposes of this discussion, \"the API\" is all core and"},{"line_number":87,"context_line":"optional extensions in the Cinder tree."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Versioning of the API should be a single monotonic counter. It will be"},{"line_number":90,"context_line":"of the form X.Y where it follows the following convention:"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da85f559_2c547d1f","line":87,"updated":"2015-11-10 03:12:25.000000000","message":"Manila is moving all API extensions from api/contrib to core APIs. The reason is that the API extensions can\u0027t be versioned.  Are you intending to do the same in Cinder?\n\nEither way, please add a note for that.","commit_id":"0f3cd11f901e760550a6e4162ca07d0570475fcb"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"ed5898d326d1bf0bde1b747162e1a32d37b08d13","unresolved":false,"context_lines":[{"line_number":84,"context_line":"currently 2.0 and is expected to remain so for quite a long time."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"For the purposes of this discussion, \"the API\" is all core and"},{"line_number":87,"context_line":"optional extensions in the Cinder tree."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Versioning of the API should be a single monotonic counter. It will be"},{"line_number":90,"context_line":"of the form X.Y where it follows the following convention:"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da85f559_993b519c","line":87,"in_reply_to":"da85f559_2c547d1f","updated":"2015-11-10 14:21:20.000000000","message":"Great point. I\u0027d seen that in the code, and should have addressed it earlier. This and your other point should probably be discussed at the next Cinder meeting.","commit_id":"0f3cd11f901e760550a6e4162ca07d0570475fcb"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b2f9fb5a019c8ec0e4bab8297c37459051ecf8cb","unresolved":false,"context_lines":[{"line_number":202,"context_line":"  version. If that\u0027s outside of the range of versions supported,"},{"line_number":203,"context_line":"  return 406 Not Acceptable."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"* If X-OpenStack-Cinder-API-Version: latest (special keyword) return"},{"line_number":206,"context_line":"  max_version of the API."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"This means out of the box, with an old client, an OpenStack"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da85f559_a092b19d","line":205,"updated":"2015-11-10 03:12:25.000000000","message":"Are you sure we should support \"latest\"?  See the Manila patch to remove this support:\n\nhttps://review.openstack.org/#/c/222677/\n\nIf we want to support it, please add note that this could cause problems when a client tries to talk to a server that is newer than it.","commit_id":"0f3cd11f901e760550a6e4162ca07d0570475fcb"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"ed5898d326d1bf0bde1b747162e1a32d37b08d13","unresolved":false,"context_lines":[{"line_number":202,"context_line":"  version. If that\u0027s outside of the range of versions supported,"},{"line_number":203,"context_line":"  return 406 Not Acceptable."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"* If X-OpenStack-Cinder-API-Version: latest (special keyword) return"},{"line_number":206,"context_line":"  max_version of the API."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"This means out of the box, with an old client, an OpenStack"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da85f559_390d8590","line":205,"in_reply_to":"da85f559_a092b19d","updated":"2015-11-10 14:21:20.000000000","message":"I believe latest is required to run Tempest tests. Manila Tempest tests are in tree, and for some reason that I don\u0027t recall, that enables you to do without the \"latest\" support. \nBut Nova, like Cinder, has Tempest out-of-tree, and therefore needs to support latest for the Tests. This was discussed at a session on running Nova Tempest tests for microversions at the Tokyo summit.\nAnyway, I\u0027ll also bring this up at the Cinder meeting.","commit_id":"0f3cd11f901e760550a6e4162ca07d0570475fcb"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b8d044530b03e647e6187af39c47455ffbadffb7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"optional extensions in the Cinder tree."},{"line_number":88,"context_line":"Please note that extensions cannot be versioned. It has been discussed that"},{"line_number":89,"context_line":"the Cinder team should therefore move the API extensions into core, and that"},{"line_number":90,"context_line":"this should/must be done before making any changes to the API in order to"},{"line_number":91,"context_line":"take advantage of microversions. This will be adressed separately from this"},{"line_number":92,"context_line":"spec."},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"da85f559_b1a13348","line":90,"updated":"2015-11-12 03:38:15.000000000","message":"In Manila, microversion was introduced in Liberty.  The moving of extensions to core is happening in Mitaka now and it is going to take a while.  There were changes to API extensions in Liberty in Manila so they were not blocked because of microversion.  I think we should consider the same.  There are so many API extensions and we cannot bump microversion and rename API until all are moved.  I don\u0027t know if we can get all done in Mitaka.  I don\u0027t think other work on API extensions should be blocked for so long.","commit_id":"54ba73ff95989413806fdaa2978c88807044c088"}]}
