)]}'
{"specs/mitaka/backup-snapshots.rst":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"41268df19d0ab66a26f2a4eb286bafc8d4ffebd4","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Notifications impact"},{"line_number":115,"context_line":"--------------------"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"None"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Other end user impact"},{"line_number":120,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a2fa921_80e6f714","line":117,"updated":"2015-10-12 08:26:54.000000000","message":"We currently emit notifications when a backup is created, restored and deleted. These will need updating with the snapshot ID as necessary. Currently our notifications are not versioned and do not have fixed schema, so this is easy to do","commit_id":"b3e0f70fb7fc0ed427cd8691aac692366ce52660"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"af4e36c3421147b0a9199a6bd6ccdcb0bd11c04b","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Notifications impact"},{"line_number":115,"context_line":"--------------------"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"None"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Other end user impact"},{"line_number":120,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a2fa921_dc083394","line":117,"in_reply_to":"7a2fa921_80e6f714","updated":"2015-10-13 03:21:50.000000000","message":"Good point.  Added this.","commit_id":"b3e0f70fb7fc0ed427cd8691aac692366ce52660"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"71f4c633a968c254255de5eab5d9b5e614d95981","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Currently we can backup a volume, but not a snapshot, though backing"},{"line_number":14,"context_line":"up an in-use volume may be achieved by backing up a temporary snapshot."},{"line_number":15,"context_line":"This blueprint proposes to provide a way to backup snapshots."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_3fd115fc","line":15,"updated":"2015-10-26 18:50:44.000000000","message":"blueprint -\u003e spec?","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"63ec040b00653f8ed2718905830e1ae2292f3581","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Currently we can backup a volume, but not a snapshot, though backing"},{"line_number":14,"context_line":"up an in-use volume may be achieved by backing up a temporary snapshot."},{"line_number":15,"context_line":"This blueprint proposes to provide a way to backup snapshots."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa80f949_c779c083","line":15,"in_reply_to":"3a29b11f_3fd115fc","updated":"2015-11-06 15:47:10.000000000","message":"Done","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"75e941a782551cb6b72e4844a9c11b622decd42e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"For the default implementation, it can be achieved as follows:"},{"line_number":37,"context_line":"* Create a temporary volume from the snapshot"},{"line_number":38,"context_line":"* Attach the temporary volume"},{"line_number":39,"context_line":"* Do backup from the temporary volume"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a26ad4f_48faef76","line":36,"updated":"2015-10-30 02:24:33.000000000","message":"There should be an explicit mention here that internal tenant will be used for the default implementation like we do with the in-use volumes.","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f51d3c2b759320362e151f1a779c787a36da0a34","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"For the default implementation, it can be achieved as follows:"},{"line_number":37,"context_line":"* Create a temporary volume from the snapshot"},{"line_number":38,"context_line":"* Attach the temporary volume"},{"line_number":39,"context_line":"* Do backup from the temporary volume"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa80f949_981ab616","line":36,"in_reply_to":"1a26ad4f_48faef76","updated":"2015-11-04 04:05:43.000000000","message":"Sure.","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"75e941a782551cb6b72e4844a9c11b622decd42e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"* Do backup from the snapshot"},{"line_number":47,"context_line":"* Detach the snapshot"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"For incremental backups, because the latest parent is calculated"},{"line_number":50,"context_line":"automatically by looking at the timestamps, the logic has to be"},{"line_number":51,"context_line":"changed to accommodate backups from snapshots. For backups from"},{"line_number":52,"context_line":"snapshots, we need to look at the timestamps of the snapshots;"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a26ad4f_28f9b34d","line":49,"updated":"2015-10-30 02:24:33.000000000","message":"Are snapshot incremental backups only allowed to have another snapshot backup as the parent or can they also have a volume backup as the parent?","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"1a7ab0a0d20b457601d14349cf73ce09453fb970","unresolved":false,"context_lines":[{"line_number":46,"context_line":"* Do backup from the snapshot"},{"line_number":47,"context_line":"* Detach the snapshot"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"For incremental backups, because the latest parent is calculated"},{"line_number":50,"context_line":"automatically by looking at the timestamps, the logic has to be"},{"line_number":51,"context_line":"changed to accommodate backups from snapshots. For backups from"},{"line_number":52,"context_line":"snapshots, we need to look at the timestamps of the snapshots;"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a26ad4f_f4bab2bf","line":49,"in_reply_to":"1a26ad4f_28f9b34d","updated":"2015-10-30 04:54:51.000000000","message":"They can have either as a parent. We try to guess which is likely to have the smallest diff","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f51d3c2b759320362e151f1a779c787a36da0a34","unresolved":false,"context_lines":[{"line_number":46,"context_line":"* Do backup from the snapshot"},{"line_number":47,"context_line":"* Detach the snapshot"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"For incremental backups, because the latest parent is calculated"},{"line_number":50,"context_line":"automatically by looking at the timestamps, the logic has to be"},{"line_number":51,"context_line":"changed to accommodate backups from snapshots. For backups from"},{"line_number":52,"context_line":"snapshots, we need to look at the timestamps of the snapshots;"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa80f949_385cea24","line":49,"in_reply_to":"1a26ad4f_f4bab2bf","updated":"2015-11-04 04:05:43.000000000","message":"When we do incremental backup of a volume, we just specify the volume_id; do we want to support incremental backup specifying a snapshot_id?  I guess we can.  I just didn\u0027t think about it before.","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"75e941a782551cb6b72e4844a9c11b622decd42e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* Detach the snapshot"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"For incremental backups, because the latest parent is calculated"},{"line_number":50,"context_line":"automatically by looking at the timestamps, the logic has to be"},{"line_number":51,"context_line":"changed to accommodate backups from snapshots. For backups from"},{"line_number":52,"context_line":"snapshots, we need to look at the timestamps of the snapshots;"},{"line_number":53,"context_line":"For backups from volumes, we still look at the timestamps of the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a26ad4f_085ab74f","line":50,"updated":"2015-10-30 02:24:33.000000000","message":"Lets say we have:\n\n Initial Full backup of a Snapshot from Vol V from day +1\n Incremental backup of a Snapshot from Vol V from day +3\n\nAnd we request an incremental backup of a Snapshot from Vol V from day +2.  Will it use the Initial Full backup now that we have another incremental backup?","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"1a7ab0a0d20b457601d14349cf73ce09453fb970","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* Detach the snapshot"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"For incremental backups, because the latest parent is calculated"},{"line_number":50,"context_line":"automatically by looking at the timestamps, the logic has to be"},{"line_number":51,"context_line":"changed to accommodate backups from snapshots. For backups from"},{"line_number":52,"context_line":"snapshots, we need to look at the timestamps of the snapshots;"},{"line_number":53,"context_line":"For backups from volumes, we still look at the timestamps of the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a26ad4f_b4b43ad1","line":50,"in_reply_to":"1a26ad4f_085ab74f","updated":"2015-10-30 04:54:51.000000000","message":"I should use the initial full backup, though picking the wrong one is harmless, just less efficient","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"75e941a782551cb6b72e4844a9c11b622decd42e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"changed to accommodate backups from snapshots. For backups from"},{"line_number":52,"context_line":"snapshots, we need to look at the timestamps of the snapshots;"},{"line_number":53,"context_line":"For backups from volumes, we still look at the timestamps of the"},{"line_number":54,"context_line":"backups as before."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Alternatives"},{"line_number":57,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a26ad4f_88e807b6","line":54,"updated":"2015-10-30 02:24:33.000000000","message":"This means that for incremental backups instead of having a linear backup dependency chain we could have a tree dependency where multiple backups depend on the same partent.\n\nI think we have a problem here, since the \"created_at\" from a snapshot backup should match the snapshot creation time and not the time when the backup was actually done.\n\nBut if we do that we don\u0027t have the time when the backup was actually done.","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"63ec040b00653f8ed2718905830e1ae2292f3581","unresolved":false,"context_lines":[{"line_number":51,"context_line":"changed to accommodate backups from snapshots. For backups from"},{"line_number":52,"context_line":"snapshots, we need to look at the timestamps of the snapshots;"},{"line_number":53,"context_line":"For backups from volumes, we still look at the timestamps of the"},{"line_number":54,"context_line":"backups as before."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Alternatives"},{"line_number":57,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa80f949_87b17849","line":54,"in_reply_to":"1a26ad4f_88a9e2e1","updated":"2015-11-06 15:47:10.000000000","message":"Added some text here about incremental backups for snapshot.","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f51d3c2b759320362e151f1a779c787a36da0a34","unresolved":false,"context_lines":[{"line_number":51,"context_line":"changed to accommodate backups from snapshots. For backups from"},{"line_number":52,"context_line":"snapshots, we need to look at the timestamps of the snapshots;"},{"line_number":53,"context_line":"For backups from volumes, we still look at the timestamps of the"},{"line_number":54,"context_line":"backups as before."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Alternatives"},{"line_number":57,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a26ad4f_88a9e2e1","line":54,"in_reply_to":"1a26ad4f_88e807b6","updated":"2015-11-04 04:05:43.000000000","message":"I don\u0027t see a problem here.  When we compare, we look at timestamp of the snapshot if backup is taken from the snapshot.  We still record the time of the backup in created_at column.  I think we already have a tree today even without snapshot backup because you can take a full backup after you take an incremental backup.","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"75e941a782551cb6b72e4844a9c11b622decd42e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"Alternatives"},{"line_number":57,"context_line":"------------"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Here is an alternative:"},{"line_number":60,"context_line":"* Create a volume from the snapshot."},{"line_number":61,"context_line":"* Backup the volume."},{"line_number":62,"context_line":"* Delete the volume."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a26ad4f_c82cbf04","line":59,"updated":"2015-10-30 02:24:33.000000000","message":"s/an alternative/a manual alternative","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"63ec040b00653f8ed2718905830e1ae2292f3581","unresolved":false,"context_lines":[{"line_number":56,"context_line":"Alternatives"},{"line_number":57,"context_line":"------------"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Here is an alternative:"},{"line_number":60,"context_line":"* Create a volume from the snapshot."},{"line_number":61,"context_line":"* Backup the volume."},{"line_number":62,"context_line":"* Delete the volume."}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa80f949_876ad8b1","line":59,"in_reply_to":"1a26ad4f_c82cbf04","updated":"2015-11-06 15:47:10.000000000","message":"Done","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"75e941a782551cb6b72e4844a9c11b622decd42e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Add the following new column to the backups table for snapshot id."},{"line_number":68,"context_line":"This field will be null if the backup is from a volume."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"snapshot_id \u003d Column(String(36))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Note that the following column will still be required for a backup"},{"line_number":73,"context_line":"from snapshot:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a26ad4f_d39c70c2","line":70,"updated":"2015-10-30 02:24:33.000000000","message":"Has this field have any other use besides leting the customer know this is a backup from a specific snapshot?\n\nIf that\u0027s the case we may consider adding a metadata field instead so future backup features can use that for user information only.","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"1a7ab0a0d20b457601d14349cf73ce09453fb970","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Add the following new column to the backups table for snapshot id."},{"line_number":68,"context_line":"This field will be null if the backup is from a volume."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"snapshot_id \u003d Column(String(36))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Note that the following column will still be required for a backup"},{"line_number":73,"context_line":"from snapshot:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a26ad4f_14c64e48","line":70,"in_reply_to":"1a26ad4f_d39c70c2","updated":"2015-10-30 04:54:51.000000000","message":"No more metadata! Please! It has been confusing every single time!","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2c4f6015553d06966d796df3985e10cf35912db1","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Driver developers can override the default backup_snapshot"},{"line_number":140,"context_line":"implementation if their driver can support attach_snapshot."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Implementation"},{"line_number":144,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_67eb98b1","line":141,"updated":"2015-10-26 06:13:56.000000000","message":"Could we get a little more detail of what is expected of the drivers, as far as functional behavior, when backup_snapshot is called?","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f51d3c2b759320362e151f1a779c787a36da0a34","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Driver developers can override the default backup_snapshot"},{"line_number":140,"context_line":"implementation if their driver can support attach_snapshot."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Implementation"},{"line_number":144,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa80f949_180fa6e2","line":141,"in_reply_to":"3a29b11f_67eb98b1","updated":"2015-11-04 04:05:43.000000000","message":"Sure.  I kind of took this for granted thinking that this was covered in the previous spec on non-disruptive backup.  I can certainly add more details here.","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"63ec040b00653f8ed2718905830e1ae2292f3581","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Driver developers can override the default backup_snapshot"},{"line_number":140,"context_line":"implementation if their driver can support attach_snapshot."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Implementation"},{"line_number":144,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa80f949_07282885","line":141,"in_reply_to":"fa80f949_180fa6e2","updated":"2015-11-06 15:47:10.000000000","message":"Done","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"75e941a782551cb6b72e4844a9c11b622decd42e","unresolved":false,"context_lines":[{"line_number":171,"context_line":"Testing"},{"line_number":172,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Unit tests will be provided."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Documentation Impact"},{"line_number":177,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a26ad4f_73da3c7a","line":174,"updated":"2015-10-30 02:24:33.000000000","message":"Wouldn\u0027t we want Tempest tests as well?","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f51d3c2b759320362e151f1a779c787a36da0a34","unresolved":false,"context_lines":[{"line_number":171,"context_line":"Testing"},{"line_number":172,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Unit tests will be provided."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Documentation Impact"},{"line_number":177,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa80f949_b800daab","line":174,"in_reply_to":"1a26ad4f_73da3c7a","updated":"2015-11-04 04:05:43.000000000","message":"Sure, will add that.","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"63ec040b00653f8ed2718905830e1ae2292f3581","unresolved":false,"context_lines":[{"line_number":171,"context_line":"Testing"},{"line_number":172,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Unit tests will be provided."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Documentation Impact"},{"line_number":177,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa80f949_277bec8d","line":174,"in_reply_to":"fa80f949_b800daab","updated":"2015-11-06 15:47:10.000000000","message":"Done","commit_id":"dba8d8dc1797187b55e0dfaf169db9f568abaadc"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"ad65d7109999a46b28e1551cd7415901c2792f89","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Currently we can backup a volume, but not a snapshot, though backing"},{"line_number":14,"context_line":"up an in-use volume may be achieved by backing up a temporary snapshot."},{"line_number":15,"context_line":"This spec proposes to provide a way to backup snapshots."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_fce334d7","line":15,"updated":"2015-11-11 14:37:38.000000000","message":"Maybe we should\u0027ve started with this and not exposed the online backup of a volume at all :(","commit_id":"38c13573a2565d1f938ae269fb1707ceee28e22d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"86ae7a64d58385dae55cdaf9d2ef4bacff702202","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Currently we can backup a volume, but not a snapshot, though backing"},{"line_number":14,"context_line":"up an in-use volume may be achieved by backing up a temporary snapshot."},{"line_number":15,"context_line":"This spec proposes to provide a way to backup snapshots."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_977c35b6","line":15,"in_reply_to":"da85f559_fce334d7","updated":"2015-11-11 18:57:43.000000000","message":"I think online backup of a volume is still valuable because that allows backing up a volume in one step.  This spec is for backing up snapshots already taken and user wants to protect them as well.","commit_id":"38c13573a2565d1f938ae269fb1707ceee28e22d"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"ad65d7109999a46b28e1551cd7415901c2792f89","unresolved":false,"context_lines":[{"line_number":21,"context_line":"snapshot. The process of backing up an in-use volume may involve"},{"line_number":22,"context_line":"creating a temporary snapshot and backing up the temporary snapshot."},{"line_number":23,"context_line":"So we can leverage the existing techniques to backup a snapshot"},{"line_number":24,"context_line":"directly."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Use Cases"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_7c3e6429","line":24,"updated":"2015-11-11 14:37:38.000000000","message":"I don\u0027t agree that the above is identifying a problem.  The problem is that you (and maybe others) want to backup snapshots.  The fact that a lot of the work is already in place is kind of irrelevant in the problem statement IMO.","commit_id":"38c13573a2565d1f938ae269fb1707ceee28e22d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"86ae7a64d58385dae55cdaf9d2ef4bacff702202","unresolved":false,"context_lines":[{"line_number":21,"context_line":"snapshot. The process of backing up an in-use volume may involve"},{"line_number":22,"context_line":"creating a temporary snapshot and backing up the temporary snapshot."},{"line_number":23,"context_line":"So we can leverage the existing techniques to backup a snapshot"},{"line_number":24,"context_line":"directly."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Use Cases"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_4a06201e","line":24,"in_reply_to":"da85f559_7c3e6429","updated":"2015-11-11 18:57:43.000000000","message":"I agree the fact that we are using a temp snapshot to backup an in-use volume is not a reason to support backing up snapshot directly.  I\u0027ll remove that from Problem Statement.","commit_id":"38c13573a2565d1f938ae269fb1707ceee28e22d"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"ad65d7109999a46b28e1551cd7415901c2792f89","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"There are customers who have taken many snapshots and would like a"},{"line_number":30,"context_line":"way to protect those snapshots. This proposal to backup snapshots"},{"line_number":31,"context_line":"provides another layer of data protection."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_3c8e9cd0","line":31,"updated":"2015-11-11 14:37:38.000000000","message":"How far do we go with all of this?  At this point I think we\u0027re better off focusing some effort on the Smaug project instead and moving most of this backup work out of Cinder altogether.","commit_id":"38c13573a2565d1f938ae269fb1707ceee28e22d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"86ae7a64d58385dae55cdaf9d2ef4bacff702202","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"There are customers who have taken many snapshots and would like a"},{"line_number":30,"context_line":"way to protect those snapshots. This proposal to backup snapshots"},{"line_number":31,"context_line":"provides another layer of data protection."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_ca953087","line":31,"in_reply_to":"da85f559_3c8e9cd0","updated":"2015-11-11 18:57:43.000000000","message":"I took a quick look of the Smaug project but it doesn\u0027t look like we should remove backup completely from Cinder.  We can provide backup APIs in Cinder and Smaug can be a consumer.  I\u0027ll keep watching Smaug.","commit_id":"38c13573a2565d1f938ae269fb1707ceee28e22d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5ab61cc8eea7a293858b35f679d50b2fa269acfb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"* Detach the temporary volume"},{"line_number":42,"context_line":"* Cleanup temporary volume"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"If the driver has implemented the attach_snapshot interface,"},{"line_number":45,"context_line":"backing up a snapshot can be done as follows:"},{"line_number":46,"context_line":"* Attach the snapshot"},{"line_number":47,"context_line":"* Do backup from the snapshot"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_bf435e12","line":44,"updated":"2015-11-11 14:36:34.000000000","message":"Below it states the only driver API change is backup_snapshot. Does this leverage the non-disruptive API calls listed under the Developer Impact section? Or should detach_snapshot actually be attach_snapshot and detach_snapshot?","commit_id":"38c13573a2565d1f938ae269fb1707ceee28e22d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ef8a24dd7d51a591fded0e37be3dcd8c7f18229c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"* Detach the temporary volume"},{"line_number":42,"context_line":"* Cleanup temporary volume"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"If the driver has implemented the attach_snapshot interface,"},{"line_number":45,"context_line":"backing up a snapshot can be done as follows:"},{"line_number":46,"context_line":"* Attach the snapshot"},{"line_number":47,"context_line":"* Do backup from the snapshot"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_0701dc37","line":44,"in_reply_to":"da85f559_2a2e3c43","updated":"2015-11-12 05:15:08.000000000","message":"I didn\u0027t remove this section.  I added some explanation and hopefully it is clear now:).","commit_id":"38c13573a2565d1f938ae269fb1707ceee28e22d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"86ae7a64d58385dae55cdaf9d2ef4bacff702202","unresolved":false,"context_lines":[{"line_number":41,"context_line":"* Detach the temporary volume"},{"line_number":42,"context_line":"* Cleanup temporary volume"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"If the driver has implemented the attach_snapshot interface,"},{"line_number":45,"context_line":"backing up a snapshot can be done as follows:"},{"line_number":46,"context_line":"* Attach the snapshot"},{"line_number":47,"context_line":"* Do backup from the snapshot"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_2a2e3c43","line":44,"in_reply_to":"da85f559_bf435e12","updated":"2015-11-11 18:57:43.000000000","message":"I think I should remove this section.  I\u0027m not adding this part.  This was already in Liberty.  Yes, this is already listed under Developer Impact section, but it is not new for Mitaka.  Maybe I should reference non-disruptive backup spec instead.","commit_id":"38c13573a2565d1f938ae269fb1707ceee28e22d"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"ad65d7109999a46b28e1551cd7415901c2792f89","unresolved":false,"context_lines":[{"line_number":42,"context_line":"* Cleanup temporary volume"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"If the driver has implemented the attach_snapshot interface,"},{"line_number":45,"context_line":"backing up a snapshot can be done as follows:"},{"line_number":46,"context_line":"* Attach the snapshot"},{"line_number":47,"context_line":"* Do backup from the snapshot"},{"line_number":48,"context_line":"* Detach the snapshot"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_3ca53c46","line":45,"updated":"2015-11-11 14:37:38.000000000","message":"I hate that we introduce yet another API call that only works for \u0027some\u0027 devices :(","commit_id":"38c13573a2565d1f938ae269fb1707ceee28e22d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"86ae7a64d58385dae55cdaf9d2ef4bacff702202","unresolved":false,"context_lines":[{"line_number":42,"context_line":"* Cleanup temporary volume"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"If the driver has implemented the attach_snapshot interface,"},{"line_number":45,"context_line":"backing up a snapshot can be done as follows:"},{"line_number":46,"context_line":"* Attach the snapshot"},{"line_number":47,"context_line":"* Do backup from the snapshot"},{"line_number":48,"context_line":"* Detach the snapshot"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_2a071ccb","line":45,"in_reply_to":"da85f559_3ca53c46","updated":"2015-11-11 18:57:43.000000000","message":"We don\u0027t need to introduce another driver API in Mitaka.  This was already there as part of non-disruptive backup support.  I listed it here to address previous review comments, but it seems that it didn\u0027t help:).","commit_id":"38c13573a2565d1f938ae269fb1707ceee28e22d"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"ad65d7109999a46b28e1551cd7415901c2792f89","unresolved":false,"context_lines":[{"line_number":64,"context_line":"Here is a manual alternative:"},{"line_number":65,"context_line":"* Create a volume from the snapshot."},{"line_number":66,"context_line":"* Backup the volume."},{"line_number":67,"context_line":"* Delete the volume."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Data model impact"},{"line_number":70,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_ff532615","line":67,"updated":"2015-11-11 14:37:38.000000000","message":"yeah, that seems lame when you put it that way.  Like I said the backup snaps probably made more sense than the online backup API call.","commit_id":"38c13573a2565d1f938ae269fb1707ceee28e22d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ef8a24dd7d51a591fded0e37be3dcd8c7f18229c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"Here is a manual alternative:"},{"line_number":65,"context_line":"* Create a volume from the snapshot."},{"line_number":66,"context_line":"* Backup the volume."},{"line_number":67,"context_line":"* Delete the volume."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Data model impact"},{"line_number":70,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_07af9c2a","line":67,"in_reply_to":"da85f559_ff532615","updated":"2015-11-12 05:15:08.000000000","message":"Maybe there will be more people using backup snapshot over time.  We\u0027ll have to see.  I still think backup volume online is a useful feature as it is one step.","commit_id":"38c13573a2565d1f938ae269fb1707ceee28e22d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ef8a24dd7d51a591fded0e37be3dcd8c7f18229c","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The following driver API will be added to support backup snapshot."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"* def backup_snapshot(self, context, backup, backup_service)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_671b0882","line":111,"updated":"2015-11-12 05:15:08.000000000","message":"We don\u0027t need to add this.  backup_volume will be changed to handle snapshot_id.  Sorry for the confusion.","commit_id":"38c13573a2565d1f938ae269fb1707ceee28e22d"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"e3c41962337fbf631733a249bebf579b0ed6f51d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"could be a backup from a previous snapshot or a backup from the volume,"},{"line_number":81,"context_line":"depending on the timestamps when the previous snapshot was taken vs"},{"line_number":82,"context_line":"when the volume backup was taken. The backup with the latest timestamp"},{"line_number":83,"context_line":"will be chosen as the parent."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Alternatives"},{"line_number":86,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_9c8f5b74","line":83,"updated":"2015-11-12 08:26:05.000000000","message":"So no mater how many backups are created from a snapshot, the timestmaps of the backups are same. Correct?\n\nDo we allow to create multiple backups created from a snap in a backup driver?","commit_id":"5e75ced961ae6a09da49349f77e1658beabc65c7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c5512e478f290de169aade9ef274eaee48899df9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"could be a backup from a previous snapshot or a backup from the volume,"},{"line_number":81,"context_line":"depending on the timestamps when the previous snapshot was taken vs"},{"line_number":82,"context_line":"when the volume backup was taken. The backup with the latest timestamp"},{"line_number":83,"context_line":"will be chosen as the parent."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Alternatives"},{"line_number":86,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba8a016a_7118ce75","line":83,"in_reply_to":"ba8a016a_7c73574e","updated":"2015-11-18 21:54:51.000000000","message":"Good idea.  It will be much easier to figure out which backup should be the parent with this new column.","commit_id":"5e75ced961ae6a09da49349f77e1658beabc65c7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6e3460cf67a94e990a9ac6fd015e51bca283ea20","unresolved":false,"context_lines":[{"line_number":80,"context_line":"could be a backup from a previous snapshot or a backup from the volume,"},{"line_number":81,"context_line":"depending on the timestamps when the previous snapshot was taken vs"},{"line_number":82,"context_line":"when the volume backup was taken. The backup with the latest timestamp"},{"line_number":83,"context_line":"will be chosen as the parent."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Alternatives"},{"line_number":86,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_f4a6ad0d","line":83,"in_reply_to":"da85f559_9c8f5b74","updated":"2015-11-12 13:42:29.000000000","message":"Each backup will have its own \u0027created_at\u0027 timestamp, whether it is from volume or snapshot.  So timestamps of the backups will change.\n\nWhat will not change is the timestamp of \u0027created_at\u0027 on the same snapshot itself.\n\nYes, you can create multiple backups from a snapshot.","commit_id":"5e75ced961ae6a09da49349f77e1658beabc65c7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6ec5d7a04c52a1b286308f4bffc1d392036c18c0","unresolved":false,"context_lines":[{"line_number":80,"context_line":"could be a backup from a previous snapshot or a backup from the volume,"},{"line_number":81,"context_line":"depending on the timestamps when the previous snapshot was taken vs"},{"line_number":82,"context_line":"when the volume backup was taken. The backup with the latest timestamp"},{"line_number":83,"context_line":"will be chosen as the parent."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Alternatives"},{"line_number":86,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba8a016a_7c73574e","line":83,"in_reply_to":"da85f559_f4a6ad0d","updated":"2015-11-16 15:58:43.000000000","message":"I think we should add a field to the backup with the timestamp of the data, that way not only will we be able to easily tell which one should be the parent, but we should also remove the problems of not having a timestamp if the source snapshot of a backup has been removed.","commit_id":"5e75ced961ae6a09da49349f77e1658beabc65c7"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"109ff710fe3fb8f435173ec24959d0f8a246045b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"depending on the timestamps when the previous snapshot was taken vs"},{"line_number":82,"context_line":"when the volume backup was taken. The backup with the latest timestamp"},{"line_number":83,"context_line":"will be chosen as the parent."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Alternatives"},{"line_number":86,"context_line":"------------"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_3c466f7b","line":84,"updated":"2015-11-12 08:32:40.000000000","message":"Especially for incremental backup from snapshot?","commit_id":"5e75ced961ae6a09da49349f77e1658beabc65c7"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"530d51a96b4b27e5b7413d9823399c08935e773d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"depending on the timestamps when the previous snapshot was taken vs"},{"line_number":82,"context_line":"when the volume backup was taken. The backup with the latest timestamp"},{"line_number":83,"context_line":"will be chosen as the parent."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Alternatives"},{"line_number":86,"context_line":"------------"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_2b0d393e","line":84,"in_reply_to":"da85f559_0f1aef6e","updated":"2015-11-16 07:32:43.000000000","message":"Thank you for the explanation.\nSo created_at changes for backups from snapshot. Just when sorting the backups, the timestamp of snapshots are used if the backups are created from snapshots.\n\nYeah, I am considering the sort of the backups on timestamp as it needs to find the latest parent in incremental backups.\n\nI noticed that before this bp, to create an incremental backup, you just needs to find out the latest parent, or full copy. But now you have to check the timestamp, as the timestamp of the snapshot may be easier than  the latest parent/backup.","commit_id":"5e75ced961ae6a09da49349f77e1658beabc65c7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"3f0ab0dbbe7db840f4f750446cd24223ed262752","unresolved":false,"context_lines":[{"line_number":81,"context_line":"depending on the timestamps when the previous snapshot was taken vs"},{"line_number":82,"context_line":"when the volume backup was taken. The backup with the latest timestamp"},{"line_number":83,"context_line":"will be chosen as the parent."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Alternatives"},{"line_number":86,"context_line":"------------"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_0f1aef6e","line":84,"in_reply_to":"da85f559_22cfeeb4","updated":"2015-11-13 17:47:02.000000000","message":"\u003e\u003e\"When a backup is created from a snapshot, its \u0027created_at\u0027 will be set as the timestamp of the snapshot.\"\n\nThis is not what I meant.  When a backup is created from a snapshot, its \"created_at\" will be set as the time when the backup is created.\n\n\u003e\u003e\"Could you please explain why needs to create multiple incremental backups for a snapshot? I understand both the data and the timestamp of a snapshot are not changed.\"\n\nIt\u0027s not needed, but I don\u0027t think we should restrict user from doing that either if they want to have multiple backups of the same data.\n\nAre you building a solution using this API and want to sort the backups based on timestamps?","commit_id":"5e75ced961ae6a09da49349f77e1658beabc65c7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6e3460cf67a94e990a9ac6fd015e51bca283ea20","unresolved":false,"context_lines":[{"line_number":81,"context_line":"depending on the timestamps when the previous snapshot was taken vs"},{"line_number":82,"context_line":"when the volume backup was taken. The backup with the latest timestamp"},{"line_number":83,"context_line":"will be chosen as the parent."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Alternatives"},{"line_number":86,"context_line":"------------"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_94c72195","line":84,"in_reply_to":"da85f559_3c466f7b","updated":"2015-11-12 13:42:29.000000000","message":"Not sure what you mean here.  It is possible to create multiple incremental backups from a snapshot, as long as there is already a full backup from it.  The parent will be a full backup of the snapshot.","commit_id":"5e75ced961ae6a09da49349f77e1658beabc65c7"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"d3d24869f5f129ac59e4cd98db56b71aefba2148","unresolved":false,"context_lines":[{"line_number":81,"context_line":"depending on the timestamps when the previous snapshot was taken vs"},{"line_number":82,"context_line":"when the volume backup was taken. The backup with the latest timestamp"},{"line_number":83,"context_line":"will be chosen as the parent."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Alternatives"},{"line_number":86,"context_line":"------------"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_22cfeeb4","line":84,"in_reply_to":"da85f559_94c72195","updated":"2015-11-13 03:14:04.000000000","message":"When a backup is created from a snapshot,  its \u0027created_at\u0027 will be set as the timestamp of the snapshot.\n\nCould you please explain why needs to create multiple incremental backups for a snapshot? I understand both the data and the timestamp of a snapshot are not changed.","commit_id":"5e75ced961ae6a09da49349f77e1658beabc65c7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5651459580deb51858c4f135ba0d1627913d2ef6","unresolved":false,"context_lines":[{"line_number":82,"context_line":"when the volume backup was taken. The backup with the latest timestamp"},{"line_number":83,"context_line":"will be chosen as the parent. A new column will be created to record"},{"line_number":84,"context_line":"the timestamp of the data in the backups table. For a backup from"},{"line_number":85,"context_line":"volume, the data timestamp field will be the same as the created_at"},{"line_number":86,"context_line":"field in the backups table. For a backup from snapshot, the data"},{"line_number":87,"context_line":"timestamp field will be the same as the created_at field of the"},{"line_number":88,"context_line":"snapshot."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba8a016a_ac2ec3f8","line":85,"updated":"2015-11-19 12:16:33.000000000","message":"?: Wouldn\u0027t it be a little better if we use the current time for available volumes?","commit_id":"ceedf202a762d9d1906b3565a4a9a211289b8bd5"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"206f41c93295fb866002981db26e8a631eae8a48","unresolved":false,"context_lines":[{"line_number":82,"context_line":"when the volume backup was taken. The backup with the latest timestamp"},{"line_number":83,"context_line":"will be chosen as the parent. A new column will be created to record"},{"line_number":84,"context_line":"the timestamp of the data in the backups table. For a backup from"},{"line_number":85,"context_line":"volume, the data timestamp field will be the same as the created_at"},{"line_number":86,"context_line":"field in the backups table. For a backup from snapshot, the data"},{"line_number":87,"context_line":"timestamp field will be the same as the created_at field of the"},{"line_number":88,"context_line":"snapshot."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba8a016a_a31a30c4","line":85,"in_reply_to":"ba8a016a_25240fc3","updated":"2015-11-19 21:11:38.000000000","message":"When we create a backup from a volume, whether it is available or in-use, the current time will be the \"created_at\" and automatically created in the db.  That is the timestamp we will be using for data_timestamp.  Are you suggesting that we make a separate call to timeutils.utcnow() and use that in data_timestamp instead?  There will be a small difference, but I don\u0027t see why it is better?","commit_id":"ceedf202a762d9d1906b3565a4a9a211289b8bd5"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a04eaa6baef20d80866492418afb2e80a9f8eed1","unresolved":false,"context_lines":[{"line_number":82,"context_line":"when the volume backup was taken. The backup with the latest timestamp"},{"line_number":83,"context_line":"will be chosen as the parent. A new column will be created to record"},{"line_number":84,"context_line":"the timestamp of the data in the backups table. For a backup from"},{"line_number":85,"context_line":"volume, the data timestamp field will be the same as the created_at"},{"line_number":86,"context_line":"field in the backups table. For a backup from snapshot, the data"},{"line_number":87,"context_line":"timestamp field will be the same as the created_at field of the"},{"line_number":88,"context_line":"snapshot."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_ec4af082","line":85,"in_reply_to":"ba8a016a_68be0001","updated":"2015-11-25 17:59:16.000000000","message":"No problem.  Thanks for reviewing!","commit_id":"ceedf202a762d9d1906b3565a4a9a211289b8bd5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"20b1dc593d851ccd7e839fc46c661f3dfafab5bd","unresolved":false,"context_lines":[{"line_number":82,"context_line":"when the volume backup was taken. The backup with the latest timestamp"},{"line_number":83,"context_line":"will be chosen as the parent. A new column will be created to record"},{"line_number":84,"context_line":"the timestamp of the data in the backups table. For a backup from"},{"line_number":85,"context_line":"volume, the data timestamp field will be the same as the created_at"},{"line_number":86,"context_line":"field in the backups table. For a backup from snapshot, the data"},{"line_number":87,"context_line":"timestamp field will be the same as the created_at field of the"},{"line_number":88,"context_line":"snapshot."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba8a016a_68be0001","line":85,"in_reply_to":"ba8a016a_a31a30c4","updated":"2015-11-23 11:04:23.000000000","message":"I\u0027m really sorry, I misunderstood (although it is clearly explained in your spec) I thought it was referring to the volume\u0027s created_at field.","commit_id":"ceedf202a762d9d1906b3565a4a9a211289b8bd5"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2c57778e084e8897ec2f841495c04533020fe934","unresolved":false,"context_lines":[{"line_number":82,"context_line":"when the volume backup was taken. The backup with the latest timestamp"},{"line_number":83,"context_line":"will be chosen as the parent. A new column will be created to record"},{"line_number":84,"context_line":"the timestamp of the data in the backups table. For a backup from"},{"line_number":85,"context_line":"volume, the data timestamp field will be the same as the created_at"},{"line_number":86,"context_line":"field in the backups table. For a backup from snapshot, the data"},{"line_number":87,"context_line":"timestamp field will be the same as the created_at field of the"},{"line_number":88,"context_line":"snapshot."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba8a016a_c429938b","line":85,"in_reply_to":"ba8a016a_ac2ec3f8","updated":"2015-11-19 17:19:19.000000000","message":"You mean the \u0027updated_at\u0027 field of a volume?  I don\u0027t know if that is necessarily more accurate.  If a volume was attached earlier and someone wrote to it, we won\u0027t have the timestamp of that data change.  Also we have been using the \u0027created_at\u0027 timestamp of a volume backup previously, so probably should not change it now.","commit_id":"ceedf202a762d9d1906b3565a4a9a211289b8bd5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"26bf0b5c1bcfcdbb1d21d2bb88cc93e5de6459bb","unresolved":false,"context_lines":[{"line_number":82,"context_line":"when the volume backup was taken. The backup with the latest timestamp"},{"line_number":83,"context_line":"will be chosen as the parent. A new column will be created to record"},{"line_number":84,"context_line":"the timestamp of the data in the backups table. For a backup from"},{"line_number":85,"context_line":"volume, the data timestamp field will be the same as the created_at"},{"line_number":86,"context_line":"field in the backups table. For a backup from snapshot, the data"},{"line_number":87,"context_line":"timestamp field will be the same as the created_at field of the"},{"line_number":88,"context_line":"snapshot."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba8a016a_25240fc3","line":85,"in_reply_to":"ba8a016a_c429938b","updated":"2015-11-19 18:06:45.000000000","message":"I mean current time as in timeutils.utcnow() since this is a new field trying to capture at which point in time the data is really from.","commit_id":"ceedf202a762d9d1906b3565a4a9a211289b8bd5"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"25b0295bf3b3a4dcaf8f510bb4874f33eaf8951d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"field in the backups table. For a backup from snapshot, the data"},{"line_number":87,"context_line":"timestamp field will be the same as the created_at field of the"},{"line_number":88,"context_line":"snapshot."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Alternatives"},{"line_number":91,"context_line":"------------"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba8a016a_ce979146","line":89,"updated":"2015-11-23 09:27:17.000000000","message":"Oh, yes, the field is needed. As a snapshot may be deleted. Good point!","commit_id":"ceedf202a762d9d1906b3565a4a9a211289b8bd5"}]}
