)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"07c2118488881d2582f3a6ada9037fea9c8c594d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This is one of the aspects that are needed to support Active/Active in"},{"line_number":14,"context_line":"cinder."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint cinder-volume-active-active-support"},{"line_number":17,"context_line":"Change-Id: I3b94d3bce4c61a344cac073f5f0eafc5a70d233f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da85f559_e38e4878","line":16,"updated":"2015-11-11 04:41:17.000000000","message":"Partial-Implements","commit_id":"04cef5787173e99ad6ae84adceb71e1f0f6ca452"}],"specs/mitaka/ha-aa-drivers_locks.rst":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fcf20a5092a516b263636f2fa1b60b1953ba2810","unresolved":false,"context_lines":[{"line_number":34,"context_line":"- Locks local to the current node that don\u0027t need sharing between different"},{"line_number":35,"context_line":"  nodes.  As is the case of the LIO target helper lock."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- Locks local to the current node that need to be shared between among nodes."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The only locks that we have to worry about on an Active/Active cloud"},{"line_number":40,"context_line":"configuration are these last ones, because as they are now they will not work."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_ef788cc6","line":37,"updated":"2015-10-20 19:28:36.000000000","message":"between or among?","commit_id":"6a6ba33ddf39e88de648efa3e3d67926f1e2cfd3"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"32c836045b3fa64521f1e6aa36a659235b395da6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"- Locks local to the current node that don\u0027t need sharing between different"},{"line_number":35,"context_line":"  nodes.  As is the case of the LIO target helper lock."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- Locks local to the current node that need to be shared between among nodes."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The only locks that we have to worry about on an Active/Active cloud"},{"line_number":40,"context_line":"configuration are these last ones, because as they are now they will not work."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_4a3955f1","line":37,"in_reply_to":"3a29b11f_ef788cc6","updated":"2015-10-21 09:59:37.000000000","message":"It\u0027s among  :-)","commit_id":"6a6ba33ddf39e88de648efa3e3d67926f1e2cfd3"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fcf20a5092a516b263636f2fa1b60b1953ba2810","unresolved":false,"context_lines":[{"line_number":63,"context_line":"cloud operational at all times or have higher throughput requirements will want"},{"line_number":64,"context_line":"to have the possibility to configure their deployments with an Active/Active"},{"line_number":65,"context_line":"configuration without a considerable amount of configuration work and adding as"},{"line_number":66,"context_line":"little applications as possible to their systems."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_af829492","line":66,"updated":"2015-10-20 19:28:36.000000000","message":"Better word would be probably software instead of applications.","commit_id":"6a6ba33ddf39e88de648efa3e3d67926f1e2cfd3"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"32c836045b3fa64521f1e6aa36a659235b395da6","unresolved":false,"context_lines":[{"line_number":63,"context_line":"cloud operational at all times or have higher throughput requirements will want"},{"line_number":64,"context_line":"to have the possibility to configure their deployments with an Active/Active"},{"line_number":65,"context_line":"configuration without a considerable amount of configuration work and adding as"},{"line_number":66,"context_line":"little applications as possible to their systems."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_650c823b","line":66,"in_reply_to":"3a29b11f_af829492","updated":"2015-10-21 09:59:37.000000000","message":"Done","commit_id":"6a6ba33ddf39e88de648efa3e3d67926f1e2cfd3"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fcf20a5092a516b263636f2fa1b60b1953ba2810","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Proposed change"},{"line_number":70,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"We will be base Cinder\u0027s general locking mechanism on proposed change from the"},{"line_number":73,"context_line":"`Removal of the Manager Locks`_ and expand on it to allow a generic locking"},{"line_number":74,"context_line":"mechanism that is flexible enough to accommodate all drivers\u0027 needs."},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_cf7d90b2","line":72,"updated":"2015-10-20 19:28:36.000000000","message":"We will base","commit_id":"6a6ba33ddf39e88de648efa3e3d67926f1e2cfd3"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"32c836045b3fa64521f1e6aa36a659235b395da6","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Proposed change"},{"line_number":70,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"We will be base Cinder\u0027s general locking mechanism on proposed change from the"},{"line_number":73,"context_line":"`Removal of the Manager Locks`_ and expand on it to allow a generic locking"},{"line_number":74,"context_line":"mechanism that is flexible enough to accommodate all drivers\u0027 needs."},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_2513ea5c","line":72,"in_reply_to":"3a29b11f_cf7d90b2","updated":"2015-10-21 09:59:37.000000000","message":"Done","commit_id":"6a6ba33ddf39e88de648efa3e3d67926f1e2cfd3"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fcf20a5092a516b263636f2fa1b60b1953ba2810","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Condition for the exist clause of the conditional insert will be generated from"},{"line_number":101,"context_line":"the arguments of the decorator.  Assuming all arguments are provided it will"},{"line_number":102,"context_line":"add the row if it doesn\u0027t exist a row in the same cluster, with a specific UUID"},{"line_number":103,"context_line":"and resource type and with with the same ``lock_name``."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"With these arguments we will be able to lock on:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_8f4eb894","line":102,"updated":"2015-10-20 19:28:36.000000000","message":"I think \"a row\" is a leftover.","commit_id":"6a6ba33ddf39e88de648efa3e3d67926f1e2cfd3"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"32c836045b3fa64521f1e6aa36a659235b395da6","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Condition for the exist clause of the conditional insert will be generated from"},{"line_number":101,"context_line":"the arguments of the decorator.  Assuming all arguments are provided it will"},{"line_number":102,"context_line":"add the row if it doesn\u0027t exist a row in the same cluster, with a specific UUID"},{"line_number":103,"context_line":"and resource type and with with the same ``lock_name``."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"With these arguments we will be able to lock on:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_c53236f2","line":102,"in_reply_to":"3a29b11f_8f4eb894","updated":"2015-10-21 09:59:37.000000000","message":"No it\u0027s just poor writing on my part.  But anyway, since I have changed the manager lock specification this one will also require heavy changes.","commit_id":"6a6ba33ddf39e88de648efa3e3d67926f1e2cfd3"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fcf20a5092a516b263636f2fa1b60b1953ba2810","unresolved":false,"context_lines":[{"line_number":171,"context_line":"----------------"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Driver developers will have to use the new decorator for locking purposes"},{"line_number":174,"context_line":"instead of Oslo or Cinder\u0027s ``syncrhonize`` method when using external\u003dTrue."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Implementation"},{"line_number":177,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_2f45246f","line":174,"updated":"2015-10-20 19:28:36.000000000","message":"s/syncrhonize/synchronize","commit_id":"6a6ba33ddf39e88de648efa3e3d67926f1e2cfd3"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"32c836045b3fa64521f1e6aa36a659235b395da6","unresolved":false,"context_lines":[{"line_number":171,"context_line":"----------------"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Driver developers will have to use the new decorator for locking purposes"},{"line_number":174,"context_line":"instead of Oslo or Cinder\u0027s ``syncrhonize`` method when using external\u003dTrue."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Implementation"},{"line_number":177,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_e55df215","line":174,"in_reply_to":"3a29b11f_2f45246f","updated":"2015-10-21 09:59:37.000000000","message":"Done","commit_id":"6a6ba33ddf39e88de648efa3e3d67926f1e2cfd3"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1b413a323bfef5f0e4fb888e78b595576e90fa43","unresolved":false,"context_lines":[{"line_number":34,"context_line":"- Locks local to the current node that don\u0027t need sharing between different"},{"line_number":35,"context_line":"  nodes.  As is the case of the LIO target helper lock."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- Locks local to the current node that need to be shared between among nodes."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The only locks that we have to worry about on an Active/Active cloud"},{"line_number":40,"context_line":"configuration are these last ones, because as they are now they will not work."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_d06af280","line":37,"updated":"2015-10-21 10:24:11.000000000","message":"You\u0027ve missed removing \"between\".","commit_id":"dd6600f4c4f3297ae84a1822caba5db928e477e8"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b2fef502df1362ecc623680794a1291ed2d0b5bb","unresolved":false,"context_lines":[{"line_number":34,"context_line":"- Locks local to the current node that don\u0027t need sharing between different"},{"line_number":35,"context_line":"  nodes.  As is the case of the LIO target helper lock."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- Locks local to the current node that need to be shared between among nodes."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The only locks that we have to worry about on an Active/Active cloud"},{"line_number":40,"context_line":"configuration are these last ones, because as they are now they will not work."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_6b8693dc","line":37,"in_reply_to":"3a29b11f_d06af280","updated":"2015-10-21 10:48:57.000000000","message":"Done","commit_id":"dd6600f4c4f3297ae84a1822caba5db928e477e8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"07c2118488881d2582f3a6ada9037fea9c8c594d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  to get the uuid from (string or Versioned Object parameter)."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"- Resource Type: Type of resource to limit the locking to.  If UUID argument is"},{"line_number":95,"context_line":"  provided, it is a Versioned Object and no Resource type is provided it will"},{"line_number":96,"context_line":"  be inferred from the Versioned Object class."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Condition for the exist clause of the conditional insert will be generated from"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_835bbcf5","line":95,"updated":"2015-11-11 04:41:17.000000000","message":"I think you missed \"if\" between \"and\" and \"no Resource type\".  It\u0027s a little hard to read without it.","commit_id":"04cef5787173e99ad6ae84adceb71e1f0f6ca452"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"07c2118488881d2582f3a6ada9037fea9c8c594d","unresolved":false,"context_lines":[{"line_number":159,"context_line":"------------------"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Small, but necessary, performance impact from changing local file locks to DB"},{"line_number":162,"context_line":"calls."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Other deployer impact"},{"line_number":165,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_0316ecf0","line":162,"updated":"2015-11-11 04:41:17.000000000","message":"I wonder what the performance impact will be for long running operations such as attach volume.  Does it mean we will get rpc_response_timeout more often?","commit_id":"04cef5787173e99ad6ae84adceb71e1f0f6ca452"}]}