)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"edeb1c1337cef4742fd0b4501a9f1ea6f433635d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improvement to query consistency group detail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This feature allows users or cloud manage system"},{"line_number":10,"context_line":"to get the volume id list which\u0027re existed in"},{"line_number":11,"context_line":"consistency group by querying this CG detail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a740942_f97579ca","line":10,"updated":"2015-12-12 19:35:11.000000000","message":"Text should be clearer:\n... allows users to get the list of volume ids that exist in the consistency group, ...","commit_id":"bf46e88a7a857d53cb370b300aab743362307d77"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"5819884d64b4ccb4c9dafcea8d50fd98ea9648e4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improvement to query consistency group detail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This feature allows users or cloud manage system"},{"line_number":10,"context_line":"to get the volume id list which\u0027re existed in"},{"line_number":11,"context_line":"consistency group by querying this CG detail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a710552_a7ee83ea","line":10,"in_reply_to":"7a740942_f97579ca","updated":"2015-12-15 03:34:14.000000000","message":"Done","commit_id":"bf46e88a7a857d53cb370b300aab743362307d77"}],"specs/mitaka/improvement-to-query-consistency-group-detail.rst":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7a55b38a54bb8688299ae700e5fc0728c27e780c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"if they\u0027re existed in this CG, end users don\u0027t know how many and which volumes"},{"line_number":20,"context_line":"have been added into the CG. They must query the volume detail one by one to"},{"line_number":21,"context_line":"get the CG\u0027s id and then form the volume list which are in a consistency group."},{"line_number":22,"context_line":"It\u0027s very inconvenience to user experience."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da85f559_8f8476b1","line":22,"updated":"2015-11-16 03:04:15.000000000","message":"s/inconvenience/inconvenient","commit_id":"2e823b7d0816bbd363a44818299fc0dcc56d8419"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"1f8385148884f462281497994db9d770d556264c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"if they\u0027re existed in this CG, end users don\u0027t know how many and which volumes"},{"line_number":20,"context_line":"have been added into the CG. They must query the volume detail one by one to"},{"line_number":21,"context_line":"get the CG\u0027s id and then form the volume list which are in a consistency group."},{"line_number":22,"context_line":"It\u0027s very inconvenience to user experience."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da85f559_ee6c1f9e","line":22,"in_reply_to":"da85f559_8f8476b1","updated":"2015-11-16 07:48:37.000000000","message":"Done","commit_id":"2e823b7d0816bbd363a44818299fc0dcc56d8419"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7a55b38a54bb8688299ae700e5fc0728c27e780c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Alternatives"},{"line_number":42,"context_line":"------------"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"None"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Data model impact"},{"line_number":47,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da85f559_af6cda08","line":44,"updated":"2015-11-16 03:04:15.000000000","message":"Alternative is to do a volume show one by one to get the CG\u0027s id and find out all the volumes.  As you mentioned on line 20-22, it is not convenient, but it is an alternative.","commit_id":"2e823b7d0816bbd363a44818299fc0dcc56d8419"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"1f8385148884f462281497994db9d770d556264c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Alternatives"},{"line_number":42,"context_line":"------------"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"None"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Data model impact"},{"line_number":47,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da85f559_2efa27be","line":44,"in_reply_to":"da85f559_af6cda08","updated":"2015-11-16 07:48:37.000000000","message":"Yes, it\u0027s true.","commit_id":"2e823b7d0816bbd363a44818299fc0dcc56d8419"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4071f43fb335dbc7e90fa3e5c515034704ac4d7e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                                     ...,"},{"line_number":60,"context_line":"                                     \"volume_list\":[\u0027volume_id1\u0027,"},{"line_number":61,"context_line":"                                                    ...,"},{"line_number":62,"context_line":"                                                    \u0027volume_idn\u0027]"},{"line_number":63,"context_line":"                                    }"},{"line_number":64,"context_line":"                }"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba8a016a_b1f70c58","line":62,"updated":"2015-11-19 04:23:09.000000000","message":"I can see some value of having this volume list in CG details, however, the user would still need to query on the volume uuid to find out info about it.\n\nIt seems to me \"cinder list --consisgroup-id \u003cuuid of CG\u003e\" on line 45 is more useful.","commit_id":"863e2f3c160c18d7c60c14d0589a9ed90debb7a4"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"a9924da0418f060e7610c9b06a64f1ddacf49aa2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                                     ...,"},{"line_number":60,"context_line":"                                     \"volume_list\":[\u0027volume_id1\u0027,"},{"line_number":61,"context_line":"                                                    ...,"},{"line_number":62,"context_line":"                                                    \u0027volume_idn\u0027]"},{"line_number":63,"context_line":"                                    }"},{"line_number":64,"context_line":"                }"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba8a016a_5bbeb9ae","line":62,"in_reply_to":"ba8a016a_b1f70c58","updated":"2015-11-20 06:18:54.000000000","message":"Yes, as Alex and I discussed, for my view, it\u0027s better to support both, for example, first uses get CG\u0027s info with volumes id list, and then if they want to see volumes detail info, they can use volume list filter. But I feel good to change this to alternative if you also think we shouldn\u0027t make different response body between detail and show operation.","commit_id":"863e2f3c160c18d7c60c14d0589a9ed90debb7a4"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"edeb1c1337cef4742fd0b4501a9f1ea6f433635d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"if they\u0027re existed in this CG, end users don\u0027t know how many and which volumes"},{"line_number":20,"context_line":"have been added into the CG. They must query the volume detail one by one to"},{"line_number":21,"context_line":"get the CG\u0027s id and then form the volume list which are in a consistency group."},{"line_number":22,"context_line":"It\u0027s very inconvenient to user experience."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a740942_ffef991a","line":22,"updated":"2015-12-12 19:35:11.000000000","message":"Same comment as in commit message","commit_id":"bf46e88a7a857d53cb370b300aab743362307d77"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"5819884d64b4ccb4c9dafcea8d50fd98ea9648e4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"if they\u0027re existed in this CG, end users don\u0027t know how many and which volumes"},{"line_number":20,"context_line":"have been added into the CG. They must query the volume detail one by one to"},{"line_number":21,"context_line":"get the CG\u0027s id and then form the volume list which are in a consistency group."},{"line_number":22,"context_line":"It\u0027s very inconvenient to user experience."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a710552_478f9f23","line":22,"in_reply_to":"7a740942_ffef991a","updated":"2015-12-15 03:34:14.000000000","message":"Done","commit_id":"bf46e88a7a857d53cb370b300aab743362307d77"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"edeb1c1337cef4742fd0b4501a9f1ea6f433635d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"added into this CG befor they decide to make CG snapshot, according this"},{"line_number":31,"context_line":"feature, they can get this information easily by querying consistency group"},{"line_number":32,"context_line":"detail, and help uses or system to make further adjustment, like adding more"},{"line_number":33,"context_line":"volumes, or remove some volumes from this consistency group."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Proposed change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a740942_3fea0110","line":33,"updated":"2015-12-12 19:35:11.000000000","message":"Needs rephrasing (e.g.):\nAfter adding volumes to a consistency group, end users want to know how many and which volumes are in a CG before they decide to make CG snapshot. According to this feature, they can get this information easily by querying consistency group detail, and make further adjustments, like adding more volumes, or remove some volumes from this consistency group.","commit_id":"bf46e88a7a857d53cb370b300aab743362307d77"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"5819884d64b4ccb4c9dafcea8d50fd98ea9648e4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"added into this CG befor they decide to make CG snapshot, according this"},{"line_number":31,"context_line":"feature, they can get this information easily by querying consistency group"},{"line_number":32,"context_line":"detail, and help uses or system to make further adjustment, like adding more"},{"line_number":33,"context_line":"volumes, or remove some volumes from this consistency group."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Proposed change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a710552_e73c8b31","line":33,"in_reply_to":"7a740942_3fea0110","updated":"2015-12-15 03:34:14.000000000","message":"Done","commit_id":"bf46e88a7a857d53cb370b300aab743362307d77"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"edeb1c1337cef4742fd0b4501a9f1ea6f433635d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"------------"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Add consistency_group_id query filter to /volumes to get a list of volumes"},{"line_number":45,"context_line":"in a CG. For example \"cinder list --consisgroup-id \u003cuuid of CG\u003e\"."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Data model impact"},{"line_number":48,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a740942_9fb8d512","line":45,"updated":"2015-12-12 19:35:11.000000000","message":"There is no contradiction between these options.","commit_id":"bf46e88a7a857d53cb370b300aab743362307d77"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"5819884d64b4ccb4c9dafcea8d50fd98ea9648e4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"------------"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Add consistency_group_id query filter to /volumes to get a list of volumes"},{"line_number":45,"context_line":"in a CG. For example \"cinder list --consisgroup-id \u003cuuid of CG\u003e\"."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Data model impact"},{"line_number":48,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a710552_a7e2039e","line":45,"in_reply_to":"7a740942_9fb8d512","updated":"2015-12-15 03:34:14.000000000","message":"Agree with you, but this alternative will bring less changes and seems some reviewers like this more.","commit_id":"bf46e88a7a857d53cb370b300aab743362307d77"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"edeb1c1337cef4742fd0b4501a9f1ea6f433635d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"It just need to add a additional DB query to get all volume ids which have same"},{"line_number":85,"context_line":"CG id. So the performance impact should be small. If considering large scale"},{"line_number":86,"context_line":"volumes, we can add index to consistencygroup_id column of volume table to"},{"line_number":87,"context_line":"reduce performance impact."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Other deployer impact"},{"line_number":90,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a740942_3f38c19f","line":87,"updated":"2015-12-12 19:35:11.000000000","message":"In case of adding an index, there will be a Data impact, right?","commit_id":"bf46e88a7a857d53cb370b300aab743362307d77"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"5819884d64b4ccb4c9dafcea8d50fd98ea9648e4","unresolved":false,"context_lines":[{"line_number":84,"context_line":"It just need to add a additional DB query to get all volume ids which have same"},{"line_number":85,"context_line":"CG id. So the performance impact should be small. If considering large scale"},{"line_number":86,"context_line":"volumes, we can add index to consistencygroup_id column of volume table to"},{"line_number":87,"context_line":"reduce performance impact."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Other deployer impact"},{"line_number":90,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a710552_e7232b04","line":87,"in_reply_to":"7a740942_3f38c19f","updated":"2015-12-15 03:34:14.000000000","message":"Yes","commit_id":"bf46e88a7a857d53cb370b300aab743362307d77"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"bac808eeaede495f5a7ef8b35a9439df59b6e8ab","unresolved":false,"context_lines":[{"line_number":19,"context_line":"if they\u0027re existed in this CG, end users don\u0027t know how many and which volumes"},{"line_number":20,"context_line":"have been added into the CG. They must query the volume detail one by one to"},{"line_number":21,"context_line":"get the CG\u0027s id and then form the list of volume ids that exist in a"},{"line_number":22,"context_line":"consistency group. It\u0027s very inconvenient to user experience."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a710552_8ee27c9e","line":22,"updated":"2015-12-15 06:28:31.000000000","message":"Still needs rephrasing","commit_id":"1e60c10be03310a216dada6fcc6e13420d15ab5d"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"1a1fb55227aafbac575caccc5d0f56d3fd949fe9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"if they\u0027re existed in this CG, end users don\u0027t know how many and which volumes"},{"line_number":20,"context_line":"have been added into the CG. They must query the volume detail one by one to"},{"line_number":21,"context_line":"get the CG\u0027s id and then form the list of volume ids that exist in a"},{"line_number":22,"context_line":"consistency group. It\u0027s very inconvenient to user experience."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a710552_00e894e1","line":22,"in_reply_to":"5a710552_8ee27c9e","updated":"2015-12-15 09:05:51.000000000","message":"Done","commit_id":"1e60c10be03310a216dada6fcc6e13420d15ab5d"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"bac808eeaede495f5a7ef8b35a9439df59b6e8ab","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"After adding volumes to a consistency group, end users want to know how many"},{"line_number":29,"context_line":"and which volumes are in a CG befor they decide to make CG snapshot."},{"line_number":30,"context_line":"According to this feature, they can get this information easily by querying"},{"line_number":31,"context_line":"consistency group detail, and make further adjustment, like adding more"},{"line_number":32,"context_line":"volumes, or remove some volumes from this consistency group."}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a710552_2e602835","line":29,"updated":"2015-12-15 06:28:31.000000000","message":"befor \u003d\u003e before","commit_id":"1e60c10be03310a216dada6fcc6e13420d15ab5d"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"1a1fb55227aafbac575caccc5d0f56d3fd949fe9","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"After adding volumes to a consistency group, end users want to know how many"},{"line_number":29,"context_line":"and which volumes are in a CG befor they decide to make CG snapshot."},{"line_number":30,"context_line":"According to this feature, they can get this information easily by querying"},{"line_number":31,"context_line":"consistency group detail, and make further adjustment, like adding more"},{"line_number":32,"context_line":"volumes, or remove some volumes from this consistency group."}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a710552_600e3836","line":29,"in_reply_to":"5a710552_2e602835","updated":"2015-12-15 09:05:51.000000000","message":"Done","commit_id":"1e60c10be03310a216dada6fcc6e13420d15ab5d"}],"specs/newton/improvement-to-query-consistency-group-detail.rst":[{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"3fbe77a5bdbbe56e74c01392ffed0c2dada58c8c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Alternatives"},{"line_number":40,"context_line":"------------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Add consistency_group_id query filter to /volumes to get a list of volumes"},{"line_number":43,"context_line":"in a CG. For example \"cinder list --consisgroup-id \u003cuuid of CG\u003e\"."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Data model impact"},{"line_number":46,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_017c0471","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":65},"updated":"2016-04-23 01:40:40.000000000","message":"I actually think this might be more useful, although if we can get both that would be nice :D","commit_id":"d7f127ff2c116250fe770059da2055b0896c81eb"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"8885951691005fc4ca56e3425d0b222ead481b19","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Alternatives"},{"line_number":40,"context_line":"------------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Add consistency_group_id query filter to /volumes to get a list of volumes"},{"line_number":43,"context_line":"in a CG. For example \"cinder list --consisgroup-id \u003cuuid of CG\u003e\"."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Data model impact"},{"line_number":46,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_bced7390","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":65},"in_reply_to":"1a122d0e_017c0471","updated":"2016-04-23 04:12:28.000000000","message":"Yes, you\u0027re right, I\u0027d like we have both too.","commit_id":"d7f127ff2c116250fe770059da2055b0896c81eb"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"3fbe77a5bdbbe56e74c01392ffed0c2dada58c8c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"REST API impact"},{"line_number":52,"context_line":"---------------"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Add volume id list into response body of querying a CG detail:"},{"line_number":55,"context_line":"  * GET /v2/{project_id}/consistencygroups/{consistency_group_id}"},{"line_number":56,"context_line":"    RESP BODY: {\"consistencygroup\": {\"status\": \"XXX\","},{"line_number":57,"context_line":"                                     \"description\": \"XXX\","}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_e1f588ed","line":54,"updated":"2016-04-23 01:40:40.000000000","message":"Since it could potentially be a lot of volumes should we have a way to specify if we want the list of volumes or not?","commit_id":"d7f127ff2c116250fe770059da2055b0896c81eb"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"8885951691005fc4ca56e3425d0b222ead481b19","unresolved":false,"context_lines":[{"line_number":51,"context_line":"REST API impact"},{"line_number":52,"context_line":"---------------"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Add volume id list into response body of querying a CG detail:"},{"line_number":55,"context_line":"  * GET /v2/{project_id}/consistencygroups/{consistency_group_id}"},{"line_number":56,"context_line":"    RESP BODY: {\"consistencygroup\": {\"status\": \"XXX\","},{"line_number":57,"context_line":"                                     \"description\": \"XXX\","}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_9cf07768","line":54,"in_reply_to":"1a122d0e_e1f588ed","updated":"2016-04-23 04:12:28.000000000","message":"Good suggestion, it will be more flexible.","commit_id":"d7f127ff2c116250fe770059da2055b0896c81eb"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"a74d7579ae83fd89171730ab40e35bf086f90e45","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Use Cases"},{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"After adding volumes to a consistency group, end users want to know how many"},{"line_number":28,"context_line":"and which volumes are in a CG before they decide to make CG snapshot."},{"line_number":29,"context_line":"According to this feature, they can get this information easily by querying"},{"line_number":30,"context_line":"consistency group detail, and make further adjustment, like adding more"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a122d0e_afdb721a","line":27,"range":{"start_line":27,"start_character":49,"end_line":27,"end_character":59},"updated":"2016-04-23 16:58:13.000000000","message":"user wants","commit_id":"b06b0ebb02261eba6012721241bbfb70b830b928"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"d64dd817aa56eaa509802b892547b017e77c0d68","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Use Cases"},{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"After adding volumes to a consistency group, end users want to know how many"},{"line_number":28,"context_line":"and which volumes are in a CG before they decide to make CG snapshot."},{"line_number":29,"context_line":"According to this feature, they can get this information easily by querying"},{"line_number":30,"context_line":"consistency group detail, and make further adjustment, like adding more"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a122d0e_b4ee1a89","line":27,"range":{"start_line":27,"start_character":49,"end_line":27,"end_character":59},"in_reply_to":"1a122d0e_afdb721a","updated":"2016-04-25 00:46:09.000000000","message":"Done","commit_id":"b06b0ebb02261eba6012721241bbfb70b830b928"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"a74d7579ae83fd89171730ab40e35bf086f90e45","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Add volume id list into response body of querying a consistency group detail"},{"line_number":37,"context_line":"if users want those volumes\u0027 information."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* Add consistency_group_id query filter to /volumes to get a list of volumes"},{"line_number":40,"context_line":"in a CG. For example \"cinder list --consisgroup-id \u003cuuid of CG\u003e\"."}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a122d0e_0fea66ac","line":37,"range":{"start_line":37,"start_character":3,"end_line":37,"end_character":28},"updated":"2016-04-23 16:58:13.000000000","message":"user wants those volume\u0027s","commit_id":"b06b0ebb02261eba6012721241bbfb70b830b928"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"d64dd817aa56eaa509802b892547b017e77c0d68","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Add volume id list into response body of querying a consistency group detail"},{"line_number":37,"context_line":"if users want those volumes\u0027 information."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* Add consistency_group_id query filter to /volumes to get a list of volumes"},{"line_number":40,"context_line":"in a CG. For example \"cinder list --consisgroup-id \u003cuuid of CG\u003e\"."}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a122d0e_d4ebd676","line":37,"range":{"start_line":37,"start_character":3,"end_line":37,"end_character":28},"in_reply_to":"1a122d0e_0fea66ac","updated":"2016-04-25 00:46:09.000000000","message":"Done","commit_id":"b06b0ebb02261eba6012721241bbfb70b830b928"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"a74d7579ae83fd89171730ab40e35bf086f90e45","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Data model impact"},{"line_number":49,"context_line":"-----------------"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"For performance impact, if we want add index to consistencygroup_id column,"},{"line_number":52,"context_line":"there is data model impact."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a122d0e_8fd676ef","line":51,"range":{"start_line":51,"start_character":30,"end_line":51,"end_character":38},"updated":"2016-04-23 16:58:13.000000000","message":"want to add","commit_id":"b06b0ebb02261eba6012721241bbfb70b830b928"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"d64dd817aa56eaa509802b892547b017e77c0d68","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Data model impact"},{"line_number":49,"context_line":"-----------------"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"For performance impact, if we want add index to consistencygroup_id column,"},{"line_number":52,"context_line":"there is data model impact."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a122d0e_14feee37","line":51,"range":{"start_line":51,"start_character":30,"end_line":51,"end_character":38},"in_reply_to":"1a122d0e_8fd676ef","updated":"2016-04-25 00:46:09.000000000","message":"Done","commit_id":"b06b0ebb02261eba6012721241bbfb70b830b928"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"a74d7579ae83fd89171730ab40e35bf086f90e45","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Performance Impact"},{"line_number":88,"context_line":"------------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"It just need to add a additional DB query to get all volume ids which have"},{"line_number":91,"context_line":"same CG id. So the performance impact should be small. If considering large"},{"line_number":92,"context_line":"scale volumes, we can add index to consistencygroup_id column of volume table"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a122d0e_0ab7f4f5","line":89,"updated":"2016-04-23 16:58:13.000000000","message":"I dont think there is any performance issue in current functionality.\nIf user wants volume list in output of conisgroup-show, user needs to specify one extra argument in query \"\u0027list_volume\u003dTrue\u0027\".\nSo, this itself is new functionality.\n\nAs far as i could understand from this spec, if current consisgroup-show is executed(without extra argument \"list_volume\u003dTrue in API\"), it will not have any performance impact.\n\nOr will there be any impact in current functionality also?","commit_id":"b06b0ebb02261eba6012721241bbfb70b830b928"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"bd9918f8b7ebff080a6b738c830af92ca835a76c","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Performance Impact"},{"line_number":88,"context_line":"------------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"It just need to add a additional DB query to get all volume ids which have"},{"line_number":91,"context_line":"same CG id. So the performance impact should be small. If considering large"},{"line_number":92,"context_line":"scale volumes, we can add index to consistencygroup_id column of volume table"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a122d0e_e5046bc7","line":89,"in_reply_to":"1a122d0e_0ab7f4f5","updated":"2016-04-23 19:12:33.000000000","message":"Hi Sheel,\nThere may be an issue in performance if the CG has many volumes and it takes time to retrieve the information from the database and to pass it on to the user.","commit_id":"b06b0ebb02261eba6012721241bbfb70b830b928"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"988fe0b85d928e384eae54ecd1032d86a51c651f","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Performance Impact"},{"line_number":88,"context_line":"------------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"It just need to add a additional DB query to get all volume ids which have"},{"line_number":91,"context_line":"same CG id. So the performance impact should be small. If considering large"},{"line_number":92,"context_line":"scale volumes, we can add index to consistencygroup_id column of volume table"}],"source_content_type":"text/x-rst","patch_set":12,"id":"dab17558_a15fcf3f","line":89,"in_reply_to":"1a122d0e_14ac2e34","updated":"2016-05-10 05:17:01.000000000","message":"Dear Alon and Wanghao,\n\nI am ok if you want it to write here :)\nBut it is not desired to write performance impact for new addions in case old operations does not have any impact in their perfomance.\nIn case there had been any impact in quering CG without new argument \u0027list_volume\u003dTrue\u0027, then it would have been desired to mention here else this is not required.\n\nThis is creating confusion as such because it depicts that there is performancd impact even if user is not using list_volume\u003dTrue(new addition to existing functionality).\n\nPlease let me know in case i am missing something.\nThank you!!","commit_id":"b06b0ebb02261eba6012721241bbfb70b830b928"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"d64dd817aa56eaa509802b892547b017e77c0d68","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Performance Impact"},{"line_number":88,"context_line":"------------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"It just need to add a additional DB query to get all volume ids which have"},{"line_number":91,"context_line":"same CG id. So the performance impact should be small. If considering large"},{"line_number":92,"context_line":"scale volumes, we can add index to consistencygroup_id column of volume table"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a122d0e_14ac2e34","line":89,"in_reply_to":"1a122d0e_e5046bc7","updated":"2016-04-25 00:46:09.000000000","message":"@Sheel, Alon is right, for this new functionality, there may be some performance impact if querying CG with \"list_volume\u003dTrue\". But I think it\u0027s small, so write it here to let guys know it.","commit_id":"b06b0ebb02261eba6012721241bbfb70b830b928"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"a9e3b8f1f7838e8f3a686b473d2b5256dde7dd8c","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Performance Impact"},{"line_number":88,"context_line":"------------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"It just need to add a additional DB query to get all volume ids which have"},{"line_number":91,"context_line":"same CG id. So the performance impact should be small. If considering large"},{"line_number":92,"context_line":"scale volumes, we can add index to consistencygroup_id column of volume table"}],"source_content_type":"text/x-rst","patch_set":12,"id":"dab17558_e3d99f58","line":89,"in_reply_to":"dab17558_a15fcf3f","updated":"2016-05-11 01:46:23.000000000","message":"@Sheel, Currently description is little fuzzy, yes, if user is not using list_volume\u003dTrue, it\u0027s no performance impact here. I\u0027d like to update this to make it more clearly. Thanks again.","commit_id":"b06b0ebb02261eba6012721241bbfb70b830b928"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9e63f0174e0994be3d66c4edc81896b9e7625dde","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/cinder/+spec/improvement-to-query-consistency-group-detail"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Return the volume id list if they\u0027re existed in CG when querying CG detail."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1a122d0e_f80260b3","line":13,"updated":"2016-05-03 20:01:43.000000000","message":"s/they\u0027re existed/they exist","commit_id":"c9760c6836cb1c30d29313249a5b6dc8978db27a"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9e63f0174e0994be3d66c4edc81896b9e7625dde","unresolved":false,"context_lines":[{"line_number":37,"context_line":"if user wants those volume\u0027s information."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* Add consistency_group_id query filter to /volumes to get a list of volumes"},{"line_number":40,"context_line":"in a CG. For example \"cinder list --consisgroup-id \u003cuuid of CG\u003e\"."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1a122d0e_f333a3f4","line":40,"updated":"2016-05-03 20:01:43.000000000","message":"We discussed about the Generic Volume Group at the summit:\n\nhttps://review.openstack.org/#/c/303893/\n\nEventually we will be using Generic Group for group level actions and CG will be migrated to Generic Groups.\n\nSo I suggest that you work on \"Add CG id query filter to /volumes to get a list of volumes in a CG\" first in this spec.  Also I suggest changing \"consisgroup-id\" to \"group-id\" in the CLI so that transition to Generic Group will be easier.\n\nFurther changes to CG API should be done on the Generic Group so we don\u0027t have to migrate later.  This means \"Add volume id list into response body of querying CG detail\" should be dependent on the Generic Group spec.","commit_id":"c9760c6836cb1c30d29313249a5b6dc8978db27a"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"c75fe4ed3b0de51d6873f0ac260aceb5426dc09c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"if user wants those volume\u0027s information."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* Add consistency_group_id query filter to /volumes to get a list of volumes"},{"line_number":40,"context_line":"in a CG. For example \"cinder list --consisgroup-id \u003cuuid of CG\u003e\"."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":13,"id":"dab17558_e1f3c99c","line":40,"in_reply_to":"1a122d0e_f333a3f4","updated":"2016-05-09 01:32:33.000000000","message":"Sure, I have noticed the Generic Volume Group, so I will implement the \u0027filter\u0027 way first as you suggested. Thanks.","commit_id":"c9760c6836cb1c30d29313249a5b6dc8978db27a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"23e4a8ae6f59d500e76ea4224824bc3fa937ed79","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Add volume id list into response body of querying a CG detail if specifying"},{"line_number":62,"context_line":"the argument \u0027list_volume\u003dTrue\u0027, this will be dependent on the Generic Group"},{"line_number":63,"context_line":"spec now, so just leave a example here:"},{"line_number":64,"context_line":"GET /v3/{project_id}/consistencygroups/{consistency_group_id}?list_volume\u003dTrue"},{"line_number":65,"context_line":"RESP BODY: {\"consistencygroup\": {\"status\": \"XXX\","},{"line_number":66,"context_line":"                                 \"description\": \"XXX\","}],"source_content_type":"text/x-rst","patch_set":14,"id":"dab17558_87ceff2b","line":63,"updated":"2016-05-10 13:50:34.000000000","message":"Need a blank line after here, and I think a double \"::\" so that the next block gets interpreted as a code block.","commit_id":"efeed6bf635ef013e6d65c3b0d2b357adc622453"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"e3e6e01f9c1bd939351c990a5a425dc35032639a","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Add volume id list into response body of querying a CG detail if specifying"},{"line_number":62,"context_line":"the argument \u0027list_volume\u003dTrue\u0027, this will be dependent on the Generic Group"},{"line_number":63,"context_line":"spec now, so just leave a example here:"},{"line_number":64,"context_line":"GET /v3/{project_id}/consistencygroups/{consistency_group_id}?list_volume\u003dTrue"},{"line_number":65,"context_line":"RESP BODY: {\"consistencygroup\": {\"status\": \"XXX\","},{"line_number":66,"context_line":"                                 \"description\": \"XXX\","}],"source_content_type":"text/x-rst","patch_set":14,"id":"dab17558_a3ecb7f3","line":63,"in_reply_to":"dab17558_87ceff2b","updated":"2016-05-11 01:44:24.000000000","message":"Sure","commit_id":"efeed6bf635ef013e6d65c3b0d2b357adc622453"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"23e4a8ae6f59d500e76ea4224824bc3fa937ed79","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                                }"},{"line_number":72,"context_line":"            }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* Add a filter \"\u0003\u003dxxx\" in URL of querying volume list/detail:"},{"line_number":75,"context_line":"GET /v3/{project_id}/volumes?group_id\u003dXXX"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dab17558_879c3f10","line":74,"updated":"2016-05-10 13:50:34.000000000","message":"Same.","commit_id":"efeed6bf635ef013e6d65c3b0d2b357adc622453"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"e3e6e01f9c1bd939351c990a5a425dc35032639a","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                                }"},{"line_number":72,"context_line":"            }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* Add a filter \"\u0003\u003dxxx\" in URL of querying volume list/detail:"},{"line_number":75,"context_line":"GET /v3/{project_id}/volumes?group_id\u003dXXX"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dab17558_83d09320","line":74,"in_reply_to":"dab17558_879c3f10","updated":"2016-05-11 01:44:24.000000000","message":"Done","commit_id":"efeed6bf635ef013e6d65c3b0d2b357adc622453"}]}