)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1933ed82b4ffae9defeb64d03452e48fb158e8ec","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Integrate Castellan for Key Management"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds blueprint for integrating Castellan for key management."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Castellan is a key manager interface library that is intended to be"},{"line_number":12,"context_line":"usable with multiple back ends, including Barbican. The Castellan code"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a8ffd7b_baf1b1cf","line":9,"updated":"2015-11-24 21:12:07.000000000","message":"This is a spec, not a blueprint. Is there a bp filed for this that should be linked to in the commit?","commit_id":"76e5b6caf26d63cfc93dd330d9499de714eb26ec"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"f08c894bffab1966e63c8bb9d733e8a0fb60d969","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Integrate Castellan for Key Management"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds blueprint for integrating Castellan for key management."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Castellan is a key manager interface library that is intended to be"},{"line_number":12,"context_line":"usable with multiple back ends, including Barbican. The Castellan code"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a8ffd7b_25d926f4","line":9,"in_reply_to":"9a8ffd7b_baf1b1cf","updated":"2015-11-24 21:40:29.000000000","message":"Thanks, I misused the word.  Yes, there\u0027s a blueprint.  I will update the commit message to include it.","commit_id":"76e5b6caf26d63cfc93dd330d9499de714eb26ec"}],"specs/mitaka/use-castellan-key-manager.rst":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"4191993e02f3e4047115254b2825a30cb0084d68","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Castellan behaves very similarly to the current Cinder key manager. One major"},{"line_number":73,"context_line":"change to note is that the default key manager back end in Cinder returns a"},{"line_number":74,"context_line":"fixed key. Castellan\u0027s default back end is Barbican, so it actually provides"},{"line_number":75,"context_line":"more security by default."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Notifications impact"},{"line_number":78,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a8ffd7b_e229eb38","line":75,"updated":"2015-11-30 16:19:49.000000000","message":"Should it be noted that castellan doesn\u0027t include this \"fixed key\" option (aka ConfKeyManager -- https://github.com/openstack/cinder/blob/master/cinder/keymgr/__init__.py#L21) at all?  It\u0027s more than just changing the default -- the original (very insecure) default has been removed as an option.","commit_id":"63a8badb841b808b2a41238c0331b11baf704773"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"21f95d693f82e9469ef4383c63145cf571132188","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Castellan behaves very similarly to the current Cinder key manager. One major"},{"line_number":73,"context_line":"change to note is that the default key manager back end in Cinder returns a"},{"line_number":74,"context_line":"fixed key. Castellan\u0027s default back end is Barbican, so it actually provides"},{"line_number":75,"context_line":"more security by default."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Notifications impact"},{"line_number":78,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a8ffd7b_3f0e13e6","line":75,"in_reply_to":"9a8ffd7b_2264d347","updated":"2015-12-01 01:48:54.000000000","message":"Please list the key managers which can be used if the list is changed, either for production or testing.","commit_id":"63a8badb841b808b2a41238c0331b11baf704773"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"7ecb602a8f8652b0eadb23ef9bc052a89d1a84a9","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Castellan behaves very similarly to the current Cinder key manager. One major"},{"line_number":73,"context_line":"change to note is that the default key manager back end in Cinder returns a"},{"line_number":74,"context_line":"fixed key. Castellan\u0027s default back end is Barbican, so it actually provides"},{"line_number":75,"context_line":"more security by default."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Notifications impact"},{"line_number":78,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a8ffd7b_c4b22096","line":75,"in_reply_to":"9a8ffd7b_3f0e13e6","updated":"2015-12-02 20:25:24.000000000","message":"Lisa, the key managers that currently can be used are the BarbicanKeyManager, NotImplementedKeyManager, ConfKeyManager (fixed key).\n\nCastellan currently has BarbicanKeyManager, NotImplementedKeyManager, MockKeyManager (in-memory key manager, should only be used for testing)","commit_id":"63a8badb841b808b2a41238c0331b11baf704773"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"9edfc1a8364ef260e0ca0da2989a82fbeb410e6c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Castellan behaves very similarly to the current Cinder key manager. One major"},{"line_number":73,"context_line":"change to note is that the default key manager back end in Cinder returns a"},{"line_number":74,"context_line":"fixed key. Castellan\u0027s default back end is Barbican, so it actually provides"},{"line_number":75,"context_line":"more security by default."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Notifications impact"},{"line_number":78,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a8ffd7b_2264d347","line":75,"in_reply_to":"9a8ffd7b_e229eb38","updated":"2015-11-30 16:25:25.000000000","message":"Brianna, thanks for pointing that out.  That is true, and I can clarify that point in another patch if another patch is required for this change to be merged.","commit_id":"63a8badb841b808b2a41238c0331b11baf704773"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"5ab9fc24de52a7f6255a150ce11788cfee521cab","unresolved":false,"context_lines":[{"line_number":95,"context_line":"The deployer should be made aware of a change in the default key manager back"},{"line_number":96,"context_line":"end. The current default back end in Cinder is a fixed key, but Castellan uses"},{"line_number":97,"context_line":"Barbican as the default. This means that the deployer should ensure Barbican is"},{"line_number":98,"context_line":"running."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Developer impact"},{"line_number":101,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a8ffd7b_bb9f854f","line":98,"updated":"2015-11-30 18:56:05.000000000","message":"So, this basically makes Cinder dependent on a running Barbican service if they want encryption support?\n\nWhy can\u0027t the default be the same fixed key that we have no, so that deployments don\u0027t require a running Barbican service.","commit_id":"63a8badb841b808b2a41238c0331b11baf704773"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"21f95d693f82e9469ef4383c63145cf571132188","unresolved":false,"context_lines":[{"line_number":95,"context_line":"The deployer should be made aware of a change in the default key manager back"},{"line_number":96,"context_line":"end. The current default back end in Cinder is a fixed key, but Castellan uses"},{"line_number":97,"context_line":"Barbican as the default. This means that the deployer should ensure Barbican is"},{"line_number":98,"context_line":"running."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Developer impact"},{"line_number":101,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a8ffd7b_bf5443ca","line":98,"in_reply_to":"9a8ffd7b_4a11e4ae","updated":"2015-12-01 01:48:54.000000000","message":"It seems that it needs some changes in devstack to default the in-memory key manager.","commit_id":"63a8badb841b808b2a41238c0331b11baf704773"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"002c6596e11ac97678a60b00ca9963658ff3bbfc","unresolved":false,"context_lines":[{"line_number":95,"context_line":"The deployer should be made aware of a change in the default key manager back"},{"line_number":96,"context_line":"end. The current default back end in Cinder is a fixed key, but Castellan uses"},{"line_number":97,"context_line":"Barbican as the default. This means that the deployer should ensure Barbican is"},{"line_number":98,"context_line":"running."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Developer impact"},{"line_number":101,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a8ffd7b_4a11e4ae","line":98,"in_reply_to":"9a8ffd7b_bb9f854f","updated":"2015-11-30 19:52:51.000000000","message":"Hi Walter,\n\nA fixed key implementation is very insecure.  The intent for the volume encryption feature was to have it deployed with a secure key manager, but the volume encryption feature was implemented during the Grizzly development cycle, when Barbican was first being proposed, so the feature used a fixed key as default until a better key manager such as Barbican came along.\n\nIf the deployer is really only concerned with testing the feature without wanting to deploy Barbican, Castellan does have an in-memory key manager back end that should only be used for testing.\n\nI hope that answered your question, please let me know if you still have concerns.","commit_id":"63a8badb841b808b2a41238c0331b11baf704773"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"7ecb602a8f8652b0eadb23ef9bc052a89d1a84a9","unresolved":false,"context_lines":[{"line_number":95,"context_line":"The deployer should be made aware of a change in the default key manager back"},{"line_number":96,"context_line":"end. The current default back end in Cinder is a fixed key, but Castellan uses"},{"line_number":97,"context_line":"Barbican as the default. This means that the deployer should ensure Barbican is"},{"line_number":98,"context_line":"running."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Developer impact"},{"line_number":101,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a8ffd7b_e46e44ff","line":98,"in_reply_to":"9a8ffd7b_bf5443ca","updated":"2015-12-02 20:25:24.000000000","message":"Lisa, yes that is true.","commit_id":"63a8badb841b808b2a41238c0331b11baf704773"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cc28383edae8121d1199f82e960ccc7da2d7dbe0","unresolved":false,"context_lines":[{"line_number":95,"context_line":"The deployer should be made aware of a change in the default key manager back"},{"line_number":96,"context_line":"end. The current default back end in Cinder is a fixed key, but Castellan uses"},{"line_number":97,"context_line":"Barbican as the default. This means that the deployer should ensure Barbican is"},{"line_number":98,"context_line":"running."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Developer impact"},{"line_number":101,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1af94dfe_2a6a7aee","line":98,"in_reply_to":"9a8ffd7b_e46e44ff","updated":"2016-03-17 14:18:55.000000000","message":"The default in Cinder should remain as it is today, we can\u0027t require access to Castellan and Barbican by default.\n\nWhat devstack sets up for testing etc. by default is a different discussion.\n\nIMO neither really need to be covered here, let\u0027s focus on getting support added.","commit_id":"63a8badb841b808b2a41238c0331b11baf704773"}],"specs/newton/use-castellan-key-manager.rst":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"55a337b3b63f4cbd6eabd83a2740fcc77ae866e2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Use Cases"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Castellan supports existing features such as volume encryption."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Proposed change"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da0c15f0_f8cb9b70","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":63},"updated":"2016-03-25 18:25:37.000000000","message":"Does Castellan support user defined keys for encryption?","commit_id":"cfa1276d72056570df640e9bddf527a353c27e59"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"776f0870b07f72a65ae4fc06ec75ce55881e1e2a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Use Cases"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Castellan supports existing features such as volume encryption."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Proposed change"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_8ee13001","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":63},"in_reply_to":"1a122d0e_c99c1760","updated":"2016-05-19 15:20:19.000000000","message":"A similar change was proposed and merged into Nova.  This change should not affect existing attached volumes, since it is not changing the back ends, it is moving the key manager interface code into a separate library.","commit_id":"cfa1276d72056570df640e9bddf527a353c27e59"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"89001b38b2c3419e1af76043e392464b4448350c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Use Cases"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Castellan supports existing features such as volume encryption."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Proposed change"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_c99c1760","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":63},"in_reply_to":"da0c15f0_18b12f90","updated":"2016-05-03 04:22:45.000000000","message":"Any encryption changes in Cinder need to ensure that there is no ill affect of existing attached volumes, as well as attaching new volumes in Nova.  How does this affect Nova?","commit_id":"cfa1276d72056570df640e9bddf527a353c27e59"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"bb414e4357c53da5b9fbdb318a79c57e6f8ec368","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Use Cases"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Castellan supports existing features such as volume encryption."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Proposed change"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da0c15f0_18b12f90","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":63},"in_reply_to":"da0c15f0_f8cb9b70","updated":"2016-03-25 18:42:56.000000000","message":"Jay, the Castellan back ends and Cinder\u0027s existing functionality will create keys on behalf of the user. The focus of this spec is to refactor existing functionality. There\u0027s ongoing discussion about Bring Your Own Key (BYOK), perhaps that will address what you mean by user-defined keys? That spec requires much more design work than what Castellan provides, and will hopefully be a discussion topic at the summit.\n\nBYOK spec: https://review.openstack.org/#/c/271517/\n\nAustin summit BYOK session: https://www.openstack.org/summit/austin-2016/summit-schedule/events/7229?goback\u003d1","commit_id":"cfa1276d72056570df640e9bddf527a353c27e59"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"8ad6bc7c451d960485e3deba15b90e1b48dc404d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"in the Cinder code where the key manager interface was called will be replaced"},{"line_number":50,"context_line":"by calls to Castellan instead. Castellan does not include ConfKeyManager, an"},{"line_number":51,"context_line":"insecure fixed-key key manager that reads the key from the configuration file."},{"line_number":52,"context_line":"The implementation for ConfKeyManager will remain in Cinder as the Cinder"},{"line_number":53,"context_line":"community agrees that it provides a valuable test fixture."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_72ff7b67","line":52,"range":{"start_line":52,"start_character":53,"end_line":52,"end_character":59},"updated":"2016-05-31 08:22:11.000000000","message":"If you change this to read \"The implementation for ConfKeyManager will remain in Cinder but made into a Castellan plugin to exercise the relevant Castellan code paths\" (which matches the patch) then I\u0027m happy enough. I\u0027ve finally found time to do a detailed review on the code, and the code does the right thing. Apologies for delaying this so long.","commit_id":"cfa1276d72056570df640e9bddf527a353c27e59"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"b400ffa47828671531f44964d9dd7c97b70ec1d7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"The old key manager interface code and back end implementations in"},{"line_number":48,"context_line":"cinder/keymgr and tests in cinder/tests/unit/keymgr can be removed. Any place"},{"line_number":49,"context_line":"in the Cinder code where the key manager interface was called will be replaced"},{"line_number":50,"context_line":"by calls to Castellan instead. Castellan does not include ConfKeyManager, an"},{"line_number":51,"context_line":"insecure fixed-key key manager that reads the key from the configuration file."},{"line_number":52,"context_line":"The implementation for ConfKeyManager will remain in Cinder as the Cinder"},{"line_number":53,"context_line":"community agrees that it provides a valuable test fixture."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Alternatives"},{"line_number":56,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa0719c6_9dc68a47","line":53,"range":{"start_line":50,"start_character":31,"end_line":53,"end_character":57},"updated":"2016-03-23 07:16:40.000000000","message":"I am confused. Do you mean ConfKeyManager will not be included in Castellan, but only left in Cinder component?\n\nThe problem is that when Cinder uses keymgr/api_class as ConfKeyManager, how Nova set this parameter in its config?","commit_id":"cfa1276d72056570df640e9bddf527a353c27e59"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"c6b8566cb3ba3d557b7d527e823d934be710f390","unresolved":false,"context_lines":[{"line_number":47,"context_line":"The old key manager interface code and back end implementations in"},{"line_number":48,"context_line":"cinder/keymgr and tests in cinder/tests/unit/keymgr can be removed. Any place"},{"line_number":49,"context_line":"in the Cinder code where the key manager interface was called will be replaced"},{"line_number":50,"context_line":"by calls to Castellan instead. Castellan does not include ConfKeyManager, an"},{"line_number":51,"context_line":"insecure fixed-key key manager that reads the key from the configuration file."},{"line_number":52,"context_line":"The implementation for ConfKeyManager will remain in Cinder as the Cinder"},{"line_number":53,"context_line":"community agrees that it provides a valuable test fixture."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Alternatives"},{"line_number":56,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa0719c6_b3a28149","line":53,"range":{"start_line":50,"start_character":31,"end_line":53,"end_character":57},"in_reply_to":"fa0719c6_18426cae","updated":"2016-03-23 14:21:39.000000000","message":"Lisa, Duncan, this change will be designed so that it does not break backwards compatibility. A fixed-key option can still be used. Most of the key manager functionality will be removed and Castellan used instead, with the main exception being ConfKeyManager.  ConfKeyManager will be updated so that it uses Castellan\u0027s key manager interface, and will remain in Cinder\u0027s codebase.","commit_id":"cfa1276d72056570df640e9bddf527a353c27e59"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"0edc447b38017956ff9d8279cc989ff227eeac25","unresolved":false,"context_lines":[{"line_number":47,"context_line":"The old key manager interface code and back end implementations in"},{"line_number":48,"context_line":"cinder/keymgr and tests in cinder/tests/unit/keymgr can be removed. Any place"},{"line_number":49,"context_line":"in the Cinder code where the key manager interface was called will be replaced"},{"line_number":50,"context_line":"by calls to Castellan instead. Castellan does not include ConfKeyManager, an"},{"line_number":51,"context_line":"insecure fixed-key key manager that reads the key from the configuration file."},{"line_number":52,"context_line":"The implementation for ConfKeyManager will remain in Cinder as the Cinder"},{"line_number":53,"context_line":"community agrees that it provides a valuable test fixture."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Alternatives"},{"line_number":56,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa0719c6_64893d75","line":53,"range":{"start_line":50,"start_character":31,"end_line":53,"end_character":57},"in_reply_to":"fa0719c6_89f0ec68","updated":"2016-03-23 14:53:25.000000000","message":"Yes, the corresponding Nova spec is here: https://review.openstack.org/#/c/247561/\n\nThe changes should be fairly independent, and merging in one service shouldn\u0027t break the other.","commit_id":"cfa1276d72056570df640e9bddf527a353c27e59"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"523137258876d52609e49c49ed37767baafc296b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"The old key manager interface code and back end implementations in"},{"line_number":48,"context_line":"cinder/keymgr and tests in cinder/tests/unit/keymgr can be removed. Any place"},{"line_number":49,"context_line":"in the Cinder code where the key manager interface was called will be replaced"},{"line_number":50,"context_line":"by calls to Castellan instead. Castellan does not include ConfKeyManager, an"},{"line_number":51,"context_line":"insecure fixed-key key manager that reads the key from the configuration file."},{"line_number":52,"context_line":"The implementation for ConfKeyManager will remain in Cinder as the Cinder"},{"line_number":53,"context_line":"community agrees that it provides a valuable test fixture."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Alternatives"},{"line_number":56,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa0719c6_18426cae","line":53,"range":{"start_line":50,"start_character":31,"end_line":53,"end_character":57},"in_reply_to":"fa0719c6_9dc68a47","updated":"2016-03-23 14:04:11.000000000","message":"The cloud operator must ensure that the same key manager classes are used by both Nova and Cinder, which is the same as the case today.\n\nThere is no plan to include the configuration-based key manager in Castellan because it should not be used outside of testing. Castellan is focused on providing production-quality key management.","commit_id":"cfa1276d72056570df640e9bddf527a353c27e59"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"fab731c65aa70f95affc772f3bec72c1ae62ea08","unresolved":false,"context_lines":[{"line_number":47,"context_line":"The old key manager interface code and back end implementations in"},{"line_number":48,"context_line":"cinder/keymgr and tests in cinder/tests/unit/keymgr can be removed. Any place"},{"line_number":49,"context_line":"in the Cinder code where the key manager interface was called will be replaced"},{"line_number":50,"context_line":"by calls to Castellan instead. Castellan does not include ConfKeyManager, an"},{"line_number":51,"context_line":"insecure fixed-key key manager that reads the key from the configuration file."},{"line_number":52,"context_line":"The implementation for ConfKeyManager will remain in Cinder as the Cinder"},{"line_number":53,"context_line":"community agrees that it provides a valuable test fixture."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Alternatives"},{"line_number":56,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa0719c6_89f0ec68","line":53,"range":{"start_line":50,"start_character":31,"end_line":53,"end_character":57},"in_reply_to":"fa0719c6_b3a28149","updated":"2016-03-23 14:49:03.000000000","message":"Kaitlin: Will the equivalent be done in the Nova code too? Otherwise you\u0027ve still broken things (somewhat outside the scope of this spec I guess, but worth spelling out before we agree to merge this support)","commit_id":"cfa1276d72056570df640e9bddf527a353c27e59"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f3a904f843b5cede808065006ca7b79b195a4e9a","unresolved":false,"context_lines":[{"line_number":162,"context_line":"References"},{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"[1] Castellan source code:"},{"line_number":166,"context_line":"  https://github.com/openstack/castellan"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"[2] Castellan in OpenStack\u0027s global requirements:"},{"line_number":169,"context_line":"  https://github.com/openstack/requirements/blob/master/global-requirements.txt"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"[3] Current Cinder key manager implementation"},{"line_number":172,"context_line":"  https://github.com/openstack/cinder/tree/master/cinder/keymgr"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"[4] Volume encryption configuration reference"},{"line_number":175,"context_line":"  http://docs.openstack.org/liberty/config-reference/content/section_volume-encryption.html"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_bf9d3f5b","line":175,"range":{"start_line":165,"start_character":0,"end_line":175,"end_character":91},"updated":"2016-06-07 09:22:51.000000000","message":"We could\u0027ve format this using rst [1], but that\u0027s not a blocker.\n\n[1] http://docutils.sourceforge.net/docs/user/rst/quickref.html#enumerated-lists","commit_id":"4fb99e0294ab0adc21618e120c2f84e00678bd46"}]}
